99366 2012-10-15 14:17:51 -0700 ResourceLoader::sendResourceLoadCallbacks() is backwards 2012-10-16 10:30:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 49246 1 japhet japhet abarth dbates webkit.review.bot oldest_to_newest 742428 0 japhet 2012-10-15 14:17:51 -0700 ...it does an implicit enum to bool conversion which returns the opposite value of what is intended. It isn't used currently, but will be used in a later patch for supporting main resources in the memory cache. 742444 1 168781 japhet 2012-10-15 14:23:25 -0700 Created attachment 168781 patch 742793 2 168781 dbates 2012-10-15 22:06:31 -0700 Comment on attachment 168781 patch This patch looks straightforward to me. 742798 3 168781 webkit.review.bot 2012-10-15 22:14:47 -0700 Comment on attachment 168781 patch Clearing flags on attachment: 168781 Committed r131411: <http://trac.webkit.org/changeset/131411> 742799 4 webkit.review.bot 2012-10-15 22:14:50 -0700 All reviewed patches have been landed. Closing bug. 743257 5 168781 ap 2012-10-16 10:29:18 -0700 Comment on attachment 168781 patch View in context: https://bugs.webkit.org/attachment.cgi?id=168781&action=review > Source/WebCore/ChangeLog:3 > + ResourceLoader::sendResourceLoadCallbacks() is backwards It's also badly misnamed. A function with this name should send callbacks when called, not just access a member variable. 743259 6 japhet 2012-10-16 10:30:44 -0700 (In reply to comment #5) > (From update of attachment 168781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168781&action=review > > > Source/WebCore/ChangeLog:3 > > + ResourceLoader::sendResourceLoadCallbacks() is backwards > > It's also badly misnamed. A function with this name should send callbacks when called, not just access a member variable. ...I never noticed that. Now it irritates me. Will fix :) 168781 2012-10-15 14:23:25 -0700 2012-10-16 10:29:18 -0700 patch srlc.txt text/plain 1407 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5oCShyZXZpc2lvbiAxMzEw ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuaAkod29ya2luZyBj b3B5KQpAQCAtMTM5LDcgKzEzOSw3IEBACiAKICAgICAgICAgY29uc3QgS1VSTCYgdXJsKCkgY29u c3QgeyByZXR1cm4gbV9yZXF1ZXN0LnVybCgpOyB9IAogICAgICAgICBSZXNvdXJjZUhhbmRsZSog aGFuZGxlKCkgY29uc3QgeyByZXR1cm4gbV9oYW5kbGUuZ2V0KCk7IH0KLSAgICAgICAgYm9vbCBz ZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCkgY29uc3QgeyByZXR1cm4gbV9vcHRpb25zLnNlbmRM b2FkQ2FsbGJhY2tzOyB9CisgICAgICAgIGJvb2wgc2VuZFJlc291cmNlTG9hZENhbGxiYWNrcygp IGNvbnN0IHsgcmV0dXJuIG1fb3B0aW9ucy5zZW5kTG9hZENhbGxiYWNrcyA9PSBTZW5kQ2FsbGJh Y2tzOyB9CiAKICAgICAgICAgYm9vbCByZWFjaGVkVGVybWluYWxTdGF0ZSgpIGNvbnN0IHsgcmV0 dXJuIG1fcmVhY2hlZFRlcm1pbmFsU3RhdGU7IH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24g MTMxMzU0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTItMTAtMTUgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXNvdXJjZUxvYWRlcjo6c2VuZFJlc291cmNlTG9hZENhbGxiYWNrcygp IGlzIGJhY2t3YXJkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTkzNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMsIHRoaXMgZnVuY3Rpb24gaXMgdW5jYWxsZWQgYnV0IHdpbGwgYmUg dXNlZAorICAgICAgICBpbiBhIGxhdGVyIHBhdGNoLgorCisgICAgICAgICogbG9hZGVyL1Jlc291 cmNlTG9hZGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWRlcjo6c2VuZFJlc291 cmNlTG9hZENhbGxiYWNrcyk6CisKIDIwMTItMTAtMTUgIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBDb25zb2xlIG1lc3NhZ2VzIGNvbnRhaW5pbmcgbG9uZyBVUkxz IHNob3VsZCBjdXQgYXQgc29tZSByZWFzb25hYmxlIGxlbmd0aC4K