98907 2012-10-10 08:01:49 -0700 Document calls createElement with the wrong parameters. 2012-10-10 21:56:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98050 1 mkwst mkwst ap jochen tkent webkit.review.bot oldest_to_newest 738953 0 mkwst 2012-10-10 08:01:49 -0700 Document calls createElement with the wrong parameters. 738955 1 167998 mkwst 2012-10-10 08:06:25 -0700 Created attachment 167998 Patch 738957 2 mkwst 2012-10-10 08:10:58 -0700 This isn't so trivial as the others I've seen today. Document::importNode calls Document::createElement with a QualifiedName and ExceptionCode. The Document::createElement that takes a QualifiedName doesn't generate an exception; the second argument is a bool, which the ExceptionCode autocasts into. There is, however, a Document::createElement that takes an AtomicString and an Exception code. I wonder if that was the original intent. CCing Kent Tamura, who looks like he wrote that code in the first place. Hi Kent! Would you mind taking a look at this? 738967 3 jochen 2012-10-10 08:21:23 -0700 (In reply to comment #2) > This isn't so trivial as the others I've seen today. > > Document::importNode calls Document::createElement with a QualifiedName and ExceptionCode. The Document::createElement that takes a QualifiedName doesn't generate an exception; the second argument is a bool, which the ExceptionCode autocasts into. > > There is, however, a Document::createElement that takes an AtomicString and an Exception code. I wonder if that was the original intent. CCing Kent Tamura, who looks like he wrote that code in the first place. > > Hi Kent! Would you mind taking a look at this? I could imagine that you'd need to invoke the version that actually takes a ec: if the document is an xml doc, a different type of element needs to be created. 738971 4 mkwst 2012-10-10 08:27:21 -0700 (In reply to comment #3) > (In reply to comment #2) > > This isn't so trivial as the others I've seen today. > > > > Document::importNode calls Document::createElement with a QualifiedName and ExceptionCode. The Document::createElement that takes a QualifiedName doesn't generate an exception; the second argument is a bool, which the ExceptionCode autocasts into. > > > > There is, however, a Document::createElement that takes an AtomicString and an Exception code. I wonder if that was the original intent. CCing Kent Tamura, who looks like he wrote that code in the first place. > > > > Hi Kent! Would you mind taking a look at this? > > I could imagine that you'd need to invoke the version that actually takes a ec: if the document is an xml doc, a different type of element needs to be created. So we likely need 'oldElement->localName()' instead of 'oldElement->tagQName()'? 739445 5 tkent 2012-10-10 17:55:32 -0700 The purpose of http://trac.webkit.org/changeset/104275 was to use createElement with QualifiedName argument. So the patch is correct. 739447 6 167998 tkent 2012-10-10 17:55:45 -0700 Comment on attachment 167998 Patch ok 739594 7 167998 mkwst 2012-10-10 21:38:26 -0700 Comment on attachment 167998 Patch Alright, thanks for taking a look! Throwing this into the queue. 739608 8 167998 webkit.review.bot 2012-10-10 21:56:52 -0700 Comment on attachment 167998 Patch Clearing flags on attachment: 167998 Committed r131015: <http://trac.webkit.org/changeset/131015> 739609 9 webkit.review.bot 2012-10-10 21:56:55 -0700 All reviewed patches have been landed. Closing bug. 167998 2012-10-10 08:06:25 -0700 2012-10-10 21:56:52 -0700 Patch bug-98907-20121010170524.patch text/plain 1741 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ2MjUyYTMyMmU0MjE1 MjU2NGYyYmEwYmNiNDJhMmZkZTdiZTYxZC4uODM5ZmUxOTc0YTI5N2RhYjMyY2FjMjEwZmZlNjhm OWU2ZjQzNmUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTEwICBNaWtl IFdlc3QgIDxta3dzdEBnb29nbGUuY29tPgorCisgICAgICAgIERvY3VtZW50IGNhbGxzIGNyZWF0 ZUVsZW1lbnQgd2l0aCB0aGUgd3JvbmcgcGFyYW1ldGVycy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4OTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9jdW1lbnQ6OmltcG9ydE5vZGUgY2FsbHMgRG9j dW1lbnQ6OmNyZWF0ZUVsZW1lbnQgd2l0aCBhIFF1YWxpZmllZE5hbWUKKyAgICAgICAgYW5kIEV4 Y2VwdGlvbkNvZGUuIFRoZSBEb2N1bWVudDo6Y3JlYXRlRWxlbWVudCB0aGF0IHRha2VzIGEKKyAg ICAgICAgUXVhbGlmaWVkTmFtZSBkb2Vzbid0IGdlbmVyYXRlIGFuIGV4Y2VwdGlvbjsgdGhlIHNl Y29uZCBhcmd1bWVudCBpcyBhCisgICAgICAgIGJvb2wsIHdoaWNoIHRoZSBFeGNlcHRpb25Db2Rl IGF1dG9jYXN0cyBpbnRvLgorCisgICAgICAgIENoYW5naW5nIHRoZSBhcmd1bWVudCB0byBhbiBl eHBsaWNpdCBib29sIHNob3VsZG4ndCBoYXZlIGFueSB2aXNpYmxlCisgICAgICAgIGVmZmVjdDsg bm8gbmV3IHRlc3RzIGFyZSByZXF1aXJlZC4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6aW1wb3J0Tm9kZSk6CisKIDIwMTItMTAtMDkg IFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzA3NDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRl eCBiMWU4Y2JlZGJkZGQ5NTExOWU4NTFjMGMwOTAxZTlhNzNkYWQ2NjNhLi4zZDc1MDEwZDRlYmI2 ZTA5MTY4NTgxMWU3MzhhMTc1ZDliYTI5MzllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAg LTk1MCw5ICs5NTAsNyBAQCBQYXNzUmVmUHRyPE5vZGU+IERvY3VtZW50OjppbXBvcnROb2RlKE5v ZGUqIGltcG9ydGVkTm9kZSwgYm9vbCBkZWVwLCBFeGNlcHRpb25DbwogICAgICAgICAgICAgZWMg PSBOQU1FU1BBQ0VfRVJSOwogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIH0KLSAgICAg ICAgUmVmUHRyPEVsZW1lbnQ+IG5ld0VsZW1lbnQgPSBjcmVhdGVFbGVtZW50KG9sZEVsZW1lbnQt PnRhZ1FOYW1lKCksIGVjKTsKLSAgICAgICAgaWYgKGVjKQotICAgICAgICAgICAgcmV0dXJuIDA7 CisgICAgICAgIFJlZlB0cjxFbGVtZW50PiBuZXdFbGVtZW50ID0gY3JlYXRlRWxlbWVudChvbGRF bGVtZW50LT50YWdRTmFtZSgpLCBmYWxzZSk7CiAKICAgICAgICAgbmV3RWxlbWVudC0+Y2xvbmVE YXRhRnJvbUVsZW1lbnQoKm9sZEVsZW1lbnQpOwogCg==