98892 2012-10-10 06:04:14 -0700 HTMLTextFormControlElement calls setInlineStyleProperty with the wrong parameters. 2012-10-10 06:56:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98050 1 mkwst mkwst mifenton tkent webkit.review.bot oldest_to_newest 738882 0 mkwst 2012-10-10 06:04:14 -0700 HTMLTextFormControlElement calls setInlineStyleProperty with the wrong parameters. 738884 1 167985 mkwst 2012-10-10 06:06:59 -0700 Created attachment 167985 Patch 738886 2 167985 jochen 2012-10-10 06:11:52 -0700 Comment on attachment 167985 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167985&action=review > Source/WebCore/html/HTMLTextFormControlElement.cpp:162 > + placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? "visible" : "hidden", false); "important" defaults to false so you could also just omit it 738889 3 mkwst 2012-10-10 06:15:12 -0700 (In reply to comment #2) > (From update of attachment 167985 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167985&action=review > > > Source/WebCore/html/HTMLTextFormControlElement.cpp:162 > > + placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? "visible" : "hidden", false); > > "important" defaults to false so you could also just omit it Even better. Thanks. :) 738903 4 167990 mkwst 2012-10-10 06:32:05 -0700 Created attachment 167990 Patch 738919 5 167990 webkit.review.bot 2012-10-10 06:56:10 -0700 Comment on attachment 167990 Patch Clearing flags on attachment: 167990 Committed r130897: <http://trac.webkit.org/changeset/130897> 738920 6 webkit.review.bot 2012-10-10 06:56:13 -0700 All reviewed patches have been landed. Closing bug. 167985 2012-10-10 06:06:59 -0700 2012-10-10 06:32:01 -0700 Patch bug-98892-20121010150558.patch text/plain 2061 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ2MjUyYTMyMmU0MjE1 MjU2NGYyYmEwYmNiNDJhMmZkZTdiZTYxZC4uODE3MzY3OTM1ZTZkNTA4NTY5ODQ5YTE4NGQ4Y2E1 NzQ2MWViNzg3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTEwICBNaWtl IFdlc3QgIDxta3dzdEBnb29nbGUuY29tPgorCisgICAgICAgIEhUTUxUZXh0Rm9ybUNvbnRyb2xF bGVtZW50IGNhbGxzIHNldElubGluZVN0eWxlUHJvcGVydHkgd2l0aCB0aGUgd3JvbmcgcGFyYW1l dGVycy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4 ODkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRN TFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnVwZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eSBjYWxs cworICAgICAgICBIVE1MRWxlbWVudDo6c2V0SW5saW5lU3R5bGVQcm9wZXJ0eSB3aXRoIGFuIEV4 Y2VwdGlvbkNvZGUgYXMgdGhlIGxhc3QKKyAgICAgICAgcGFyYW1ldGVyLiBUaGlzIG9ubHkgc3Vj Y2VlZHMgYmVjYXVzZSBpdCdzIGF1dG9tYWdpY2FsbHkgY2FzdCB0byBhIGJvb2wsCisgICAgICAg IHdoaWNoIGlzIHdoYXQgdGhlIG1ldGhvZCBhY3R1YWxseSBleHBlY3RzLgorCisgICAgICAgIEV4 cGxpY2l0bHkgcGFzc2luZyBpbiAnZmFsc2UnIHNob3VsZG4ndCBjaGFuZ2UgYW55IGZ1bmN0aW9u YWxpdHk7IHNvIG5vCisgICAgICAgIG5ldyB0ZXN0cyBhcmUgcmVxdWlyZWQuCisKKyAgICAgICAg KiBodG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50Ojp1cGRhdGVQbGFjZWhvbGRlclZpc2liaWxpdHkp OgorCiAyMDEyLTEwLTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTMwNzQ2LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAppbmRleCA3 MGMwNjE5MWVkNDU5NzJhMDQ0NTc4Y2RjMDM5ZWJlOWZmMTYxMzhlLi45MzA0N2Q4YzliZjRkYjM4 NWU5ZTgzN2UwNzkxZjc1MWJhZDAyMDM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcApAQCAtMTU5LDkgKzE1OSw3IEBAIHZvaWQg SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnVwZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eShi b29sIHBsYWNlaG9sZGVyVmFsCiAgICAgSFRNTEVsZW1lbnQqIHBsYWNlaG9sZGVyID0gcGxhY2Vo b2xkZXJFbGVtZW50KCk7CiAgICAgaWYgKCFwbGFjZWhvbGRlcikKICAgICAgICAgcmV0dXJuOwot ICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgIHBsYWNlaG9sZGVyLT5zZXRJbmxpbmVTdHls ZVByb3BlcnR5KENTU1Byb3BlcnR5VmlzaWJpbGl0eSwgcGxhY2Vob2xkZXJTaG91bGRCZVZpc2li bGUoKSA/ICJ2aXNpYmxlIiA6ICJoaWRkZW4iLCBlYyk7Ci0gICAgQVNTRVJUKCFlYyk7CisgICAg cGxhY2Vob2xkZXItPnNldElubGluZVN0eWxlUHJvcGVydHkoQ1NTUHJvcGVydHlWaXNpYmlsaXR5 LCBwbGFjZWhvbGRlclNob3VsZEJlVmlzaWJsZSgpID8gInZpc2libGUiIDogImhpZGRlbiIsIGZh bHNlKTsKIH0KIAogdm9pZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6Zml4UGxhY2Vob2xk ZXJSZW5kZXJlcihIVE1MRWxlbWVudCogcGxhY2Vob2xkZXIsIEhUTUxFbGVtZW50KiBzaWJsaW5n RWxlbWVudCkK 167990 2012-10-10 06:32:05 -0700 2012-10-10 06:56:10 -0700 Patch bug-98892-20121010153104.patch text/plain 2081 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ2MjUyYTMyMmU0MjE1 MjU2NGYyYmEwYmNiNDJhMmZkZTdiZTYxZC4uMmMzODdlZWU4YWU5ZDdiODE3NjcwZjgyNDhjOTcx ZWJlZjk2YjNmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTEwICBNaWtl IFdlc3QgIDxta3dzdEBnb29nbGUuY29tPgorCisgICAgICAgIEhUTUxUZXh0Rm9ybUNvbnRyb2xF bGVtZW50IGNhbGxzIHNldElubGluZVN0eWxlUHJvcGVydHkgd2l0aCB0aGUgd3JvbmcgcGFyYW1l dGVycy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4 ODkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9jaGVuIEVpc2luZ2VyLgorCisgICAgICAgIEhU TUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50Ojp1cGRhdGVQbGFjZWhvbGRlclZpc2liaWxpdHkgY2Fs bHMKKyAgICAgICAgSFRNTEVsZW1lbnQ6OnNldElubGluZVN0eWxlUHJvcGVydHkgd2l0aCBhbiBF eGNlcHRpb25Db2RlIGFzIHRoZSBsYXN0CisgICAgICAgIHBhcmFtZXRlci4gVGhpcyBvbmx5IHN1 Y2NlZWRzIGJlY2F1c2UgaXQncyBhdXRvbWFnaWNhbGx5IGNhc3QgdG8gYSBib29sLAorICAgICAg ICB3aGljaCBpcyB3aGF0IHRoZSBtZXRob2QgYWN0dWFsbHkgZXhwZWN0cy4KKworICAgICAgICBJ bXBsaWNpdGx5IHBhc3NpbmcgaW4gJ2ZhbHNlJyBieSBkcm9wcGluZyB0aGUgcGFyYW1ldGVyIHNo b3VsZG4ndCBjaGFuZ2UKKyAgICAgICAgYW55IGZ1bmN0aW9uYWxpdHk7IHNvIG5vIG5ldyB0ZXN0 cyBhcmUgcmVxdWlyZWQuCisKKyAgICAgICAgKiBodG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50Ojp1 cGRhdGVQbGFjZWhvbGRlclZpc2liaWxpdHkpOgorCiAyMDEyLTEwLTA5ICBTaGVyaWZmIEJvdCAg PHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMTMwNzQ2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4 dEZvcm1Db250cm9sRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9y bUNvbnRyb2xFbGVtZW50LmNwcAppbmRleCA3MGMwNjE5MWVkNDU5NzJhMDQ0NTc4Y2RjMDM5ZWJl OWZmMTYxMzhlLi5mY2RlMzVhZTYxZWIyNzg1YTE3NTVjMWY1OTBlNDk2YmMxM2M0YmYwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNw cApAQCAtMTU5LDkgKzE1OSw3IEBAIHZvaWQgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnVw ZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eShib29sIHBsYWNlaG9sZGVyVmFsCiAgICAgSFRNTEVs ZW1lbnQqIHBsYWNlaG9sZGVyID0gcGxhY2Vob2xkZXJFbGVtZW50KCk7CiAgICAgaWYgKCFwbGFj ZWhvbGRlcikKICAgICAgICAgcmV0dXJuOwotICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAg IHBsYWNlaG9sZGVyLT5zZXRJbmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5VmlzaWJpbGl0 eSwgcGxhY2Vob2xkZXJTaG91bGRCZVZpc2libGUoKSA/ICJ2aXNpYmxlIiA6ICJoaWRkZW4iLCBl Yyk7Ci0gICAgQVNTRVJUKCFlYyk7CisgICAgcGxhY2Vob2xkZXItPnNldElubGluZVN0eWxlUHJv cGVydHkoQ1NTUHJvcGVydHlWaXNpYmlsaXR5LCBwbGFjZWhvbGRlclNob3VsZEJlVmlzaWJsZSgp ID8gInZpc2libGUiIDogImhpZGRlbiIpOwogfQogCiB2b2lkIEhUTUxUZXh0Rm9ybUNvbnRyb2xF bGVtZW50OjpmaXhQbGFjZWhvbGRlclJlbmRlcmVyKEhUTUxFbGVtZW50KiBwbGFjZWhvbGRlciwg SFRNTEVsZW1lbnQqIHNpYmxpbmdFbGVtZW50KQo=