98703 2012-10-08 17:16:14 -0700 Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol.html 2012-10-09 11:20:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98798 1 eric eric eae jchaffraix leviw webkit.review.bot oldest_to_newest 737249 0 eric 2012-10-08 17:16:14 -0700 Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol.html 737251 1 167654 eric 2012-10-08 17:20:28 -0700 Created attachment 167654 Patch 737252 2 eric 2012-10-08 17:21:06 -0700 Oh subpixelers: I welcome your thoughts on how we might make this function even simpler. :) 737267 3 167654 eae 2012-10-08 17:40:50 -0700 Comment on attachment 167654 Patch I like it! We could definitely do better if we only use pixels, then again with the move to 1/64 the cost of translating between layout units and ints is quite low. 737318 4 167654 webkit.review.bot 2012-10-08 18:39:16 -0700 Comment on attachment 167654 Patch Clearing flags on attachment: 167654 Committed r130710: <http://trac.webkit.org/changeset/130710> 737319 5 webkit.review.bot 2012-10-08 18:39:20 -0700 All reviewed patches have been landed. Closing bug. 167654 2012-10-08 17:20:28 -0700 2012-10-08 18:39:16 -0700 Patch bug-98703-20121008171931.patch text/plain 4393 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRlYTExOTA2MGM1OWQy Y2M3Yzk2ZmVlZmYyOGMwMDZlZmI1MzZlMi4uOWVjM2M0MTUxMjk0MDZlMDc3OTRiODQ3NGIyMzQ5 ZTFlMzMxMjA3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTEwLTA4ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAorICAgICAgICBJbmxpbmUgbG9naWNhbEhlaWdo dEZvclJvd1NpemluZyB0byBzaGF2ZSBhbm90aGVyIDItMyUgb2ZmIHJvYm9ob3JuZXQncyByZXNp emVjb2wuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTg3MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGlzIHZlcnkgc21hbGwgcG90YXRvZXMuICBUaGVyZSBhcmUgbXVjaCBiaWdnZXIgd2lu cyBmb3IgdGFibGUgbGF5b3V0IHlldCwgYnV0CisgICAgICAgIHRoaXMgd2FzIGFuIGVhc3kgd2lu LgorCisgICAgICAgIFRoaXMgZnVuY3Rpb24gc2hvdWxkIHByb2JhYmx5IGJlIGNvbnZlcnRlZCB0 byB1c2UgaW50J3Mgb25seSwgYXMgdGFibGUgY2VsbHMgYXJlIHBpeGVsLXNpemVkCisgICAgICAg IGFjY29yZGluZyB0byBvdXIgc3VicGl4ZWwtZXhwZXJ0cy4KKworICAgICAgICBBbHNvLCBJIHN1 c3BlY3QgdGhlcmUgc2hvdWxkIGJlIHdheXMgdG8gZWFybHkgcmV0dXJuIHdpdGggbGVzcy1tYXRo IGluIHRoZSBjb21tb24gY2FzZXMsIGJ1dAorICAgICAgICBJJ3ZlIHNhdmVkIHN1Y2ggZm9yIGEg bGF0ZXIgcGF0Y2guCisKKyAgICAgICAgTm90ZSB0aGF0IEkgY2hhbmdlZCBmcm9tIHVzaW5nIHBh ZGRpbmdCZWZvcmUvcGFkZGluZ0FmdGVyICh3aGljaCBpbmNsdWRlIHRoZSBpbnN0cmluc2ljIHBh ZGRpbmcpCisgICAgICAgIHRvIGNhbGxpbmcgY29tcHV0ZWRDU1NQYWRkaW5nQmVmb3JlL2NvbXB1 dGVkQ1NTUGFkZGluZ0FmdGVyIGRpcmVjdGx5IGFzIHdlbGwuCisKKyAgICAgICAgVGhpcyBzaW5n bGUgZnVuY3Rpb24gaXMgYWJvdXQgMTElIG9mIHRvdGFsIHRpbWUgZm9yIHJvYm9ob3JuZXQncyBy ZXNpemVjb2wuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcDoKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmg6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUYWJsZUNlbGw6OmxvZ2ljYWxIZWlnaHRGb3JSb3dTaXppbmcpOgorCisyMDEyLTEwLTA4 ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBNYWtlIG5vLWNvbHVt biB0YWJsZS1sYXlvdXQgY2FzZXMgYSBsaXR0bGUgZmFzdGVyIHdpdGggaW5saW5pbmcKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NTY2CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAKaW5kZXggOWVmN2YzZGY0 MTEzNDBiZDMyOTY5NTllMmI2OWJiMDhkNzIxZWViNi4uNTliYmE3OTEwOTM1MWUxYzM3ZmI5MTQ0 Mzk4MDY1Yzk3Y2U0NDdlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRhYmxlQ2VsbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRh YmxlQ2VsbC5jcHAKQEAgLTEyNSwyNSArMTI1LDYgQEAgdm9pZCBSZW5kZXJUYWJsZUNlbGw6OmNv bFNwYW5PclJvd1NwYW5DaGFuZ2VkKCkKICAgICAgICAgc2VjdGlvbigpLT5zZXROZWVkc0NlbGxS ZWNhbGMoKTsKIH0KIAotTGF5b3V0VW5pdCBSZW5kZXJUYWJsZUNlbGw6OmxvZ2ljYWxIZWlnaHRG b3JSb3dTaXppbmcoKSBjb25zdAotewotICAgIExheW91dFVuaXQgYWRqdXN0ZWRMb2dpY2FsSGVp Z2h0ID0gbG9naWNhbEhlaWdodCgpIC0gKGludHJpbnNpY1BhZGRpbmdCZWZvcmUoKSArIGludHJp bnNpY1BhZGRpbmdBZnRlcigpKTsKLQotICAgIExheW91dFVuaXQgc3R5bGVMb2dpY2FsSGVpZ2h0 ID0gdmFsdWVGb3JMZW5ndGgoc3R5bGUoKS0+bG9naWNhbEhlaWdodCgpLCAwLCB2aWV3KCkpOwot ICAgIGlmIChkb2N1bWVudCgpLT5pblF1aXJrc01vZGUoKSB8fCBzdHlsZSgpLT5ib3hTaXppbmco KSA9PSBCT1JERVJfQk9YKSB7Ci0gICAgICAgIC8vIEV4cGxpY2l0IGhlaWdodHMgdXNlIHRoZSBi b3JkZXIgYm94IGluIHF1aXJrcyBtb2RlLgotICAgICAgICAvLyBEb24ndCBhZGp1c3QgaGVpZ2h0 LgotICAgIH0gZWxzZSB7Ci0gICAgICAgIC8vIEluIHN0cmljdCBtb2RlLCBib3gtc2l6aW5nOiBj b250ZW50LWJveCBkbyB0aGUgcmlnaHQKLSAgICAgICAgLy8gdGhpbmcgYW5kIGFjdHVhbGx5IGFk ZCBpbiB0aGUgYm9yZGVyIGFuZCBwYWRkaW5nLgotICAgICAgICBMYXlvdXRVbml0IGFkanVzdGVk UGFkZGluZ0JlZm9yZSA9IHBhZGRpbmdCZWZvcmUoKSAtIGludHJpbnNpY1BhZGRpbmdCZWZvcmUo KTsKLSAgICAgICAgTGF5b3V0VW5pdCBhZGp1c3RlZFBhZGRpbmdBZnRlciA9IHBhZGRpbmdBZnRl cigpIC0gaW50cmluc2ljUGFkZGluZ0FmdGVyKCk7Ci0gICAgICAgIHN0eWxlTG9naWNhbEhlaWdo dCArPSBhZGp1c3RlZFBhZGRpbmdCZWZvcmUgKyBhZGp1c3RlZFBhZGRpbmdBZnRlciArIGJvcmRl ckJlZm9yZSgpICsgYm9yZGVyQWZ0ZXIoKTsKLSAgICB9Ci0KLSAgICByZXR1cm4gbWF4KHN0eWxl TG9naWNhbEhlaWdodCwgYWRqdXN0ZWRMb2dpY2FsSGVpZ2h0KTsKLX0KLQogTGVuZ3RoIFJlbmRl clRhYmxlQ2VsbDo6bG9naWNhbFdpZHRoRnJvbUNvbHVtbnMoUmVuZGVyVGFibGVDb2wqIGZpcnN0 Q29sRm9yVGhpc0NlbGwsIExlbmd0aCB3aWR0aEZyb21TdHlsZSkgY29uc3QKIHsKICAgICBBU1NF UlQoZmlyc3RDb2xGb3JUaGlzQ2VsbCAmJiBmaXJzdENvbEZvclRoaXNDZWxsID09IHRhYmxlKCkt PmNvbEVsZW1lbnQoY29sKCkpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUYWJsZUNlbGwuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJs ZUNlbGwuaAppbmRleCA0NWM3YWU1MzFjMDZiMzE4OTU1MGI2NzExNjZmZDg4ZTYxZDAwMWYyLi5h ODczYTUxOTdlMmJhMDhlZDg1NjcyMjZiM2JhZjc3NzdjMGMzODNhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5oCkBAIC05MCw3ICs5MCwxNyBAQCBwdWJsaWM6 CiAgICAgICAgIHJldHVybiBzdHlsZVdpZHRoOwogICAgIH0KIAotICAgIExheW91dFVuaXQgbG9n aWNhbEhlaWdodEZvclJvd1NpemluZygpIGNvbnN0OworICAgIExheW91dFVuaXQgbG9naWNhbEhl aWdodEZvclJvd1NpemluZygpIGNvbnN0CisgICAgeworICAgICAgICAvLyBGSVhNRTogVGhpcyBm dW5jdGlvbiBkb2VzIHRvbyBtdWNoIHdvcmssIGFuZCBpcyB2ZXJ5IGhvdCBkdXJpbmcgdGFibGUg bGF5b3V0IQorICAgICAgICBMYXlvdXRVbml0IGFkanVzdGVkTG9naWNhbEhlaWdodCA9IGxvZ2lj YWxIZWlnaHQoKSAtIChpbnRyaW5zaWNQYWRkaW5nQmVmb3JlKCkgKyBpbnRyaW5zaWNQYWRkaW5n QWZ0ZXIoKSk7CisgICAgICAgIExheW91dFVuaXQgc3R5bGVMb2dpY2FsSGVpZ2h0ID0gdmFsdWVG b3JMZW5ndGgoc3R5bGUoKS0+bG9naWNhbEhlaWdodCgpLCAwLCB2aWV3KCkpOworICAgICAgICAv LyBJbiBzdHJpY3QgbW9kZSwgYm94LXNpemluZzogY29udGVudC1ib3ggZG8gdGhlIHJpZ2h0IHRo aW5nIGFuZCBhY3R1YWxseSBhZGQgaW4gdGhlIGJvcmRlciBhbmQgcGFkZGluZy4KKyAgICAgICAg Ly8gQ2FsbCBjb21wdXRlZENTU1BhZGRpbmcqIGRpcmVjdGx5IHRvIGF2b2lkIGluY2x1ZGluZyBp bXBsaWNpdFBhZGRpbmcuCisgICAgICAgIGlmICghZG9jdW1lbnQoKS0+aW5RdWlya3NNb2RlKCkg JiYgc3R5bGUoKS0+Ym94U2l6aW5nKCkgIT0gQk9SREVSX0JPWCkKKyAgICAgICAgICAgIHN0eWxl TG9naWNhbEhlaWdodCArPSBjb21wdXRlZENTU1BhZGRpbmdCZWZvcmUoKSArIGNvbXB1dGVkQ1NT UGFkZGluZ0FmdGVyKCkgKyBib3JkZXJCZWZvcmUoKSArIGJvcmRlckFmdGVyKCk7CisgICAgICAg IHJldHVybiBtYXgoc3R5bGVMb2dpY2FsSGVpZ2h0LCBhZGp1c3RlZExvZ2ljYWxIZWlnaHQpOwor ICAgIH0KIAogICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocygp OwogCg==