98550 2012-10-05 13:21:38 -0700 Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster 2012-10-09 11:20:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98798 1 eric eric abarth jchaffraix kling koivisto webkit.review.bot oldest_to_newest 735911 0 eric 2012-10-05 13:21:38 -0700 Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster 735913 1 167373 eric 2012-10-05 13:24:29 -0700 Created attachment 167373 Patch 735949 2 167373 eric 2012-10-05 14:15:17 -0700 Comment on attachment 167373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167373&action=review > Source/WebCore/rendering/AutoTableLayout.cpp:52 > + for (RenderObject* child = m_table->children()->firstChild(); child; child = child->nextSibling()) { For the uninitiated: firstChild() calls virtualChildren()->firstChild(), and is defined on RenderObject. The pointer in question already has a non-virtual children() method which is faster. :) 735980 3 167373 kling 2012-10-05 14:47:45 -0700 Comment on attachment 167373 Patch Nifty! r=me 736015 4 167373 webkit.review.bot 2012-10-05 15:08:58 -0700 Comment on attachment 167373 Patch Clearing flags on attachment: 167373 Committed r130560: <http://trac.webkit.org/changeset/130560> 736016 5 webkit.review.bot 2012-10-05 15:09:02 -0700 All reviewed patches have been landed. Closing bug. 167373 2012-10-05 13:24:29 -0700 2012-10-05 15:08:58 -0700 Patch bug-98550-20121005132340.patch text/plain 5189 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNmOWI0OWI4M2UwYzg1 NTAyMWEzYzM3MTk0ZGQ0MmYyZWU1Y2QxOS4uNmUzMmRjOTQ5NjZlYWEyYjNkOWU5NjVhMmQ1Yjk2 YjhmZGE5YTcxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTEwLTA1ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZW1vdmUgbmVlZGxlc3Mgdmly dHVhbCBjYWxscyBhbmQgaW5saW5lIFJlbmRlclN0eWxlOjpsb2dpY2FsKiB0byBtYWtlIHRhYmxl IGxheW91dCBmYXN0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk4NTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBzaGF2ZWQgYW5vdGhlciA1JSAoMTAwbXMpIG9mZiBvZiB0aGUgcnVudGltZSBv ZiByZXNpemVjb2wuaHRtbCBtaWNyb2JlbmNobWFyazoKKyAgICAgICAgaHR0cDovL3d3dy5yb2Jv aG9ybmV0Lm9yZy90ZXN0cy9yZXNpemVjb2wuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL0F1 dG9UYWJsZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdXRvVGFibGVMYXlvdXQ6OnJl Y2FsY0NvbHVtbik6CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcDoK KyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaDoKKworMjAxMi0xMC0wNSAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAgICAgTWFrZSB0YWJsZXMgd2hp Y2ggZG9uJ3QgdXNlIGNvbC9yb3cgc3BhbiBtdWNoIGZhc3RlciB0byBsYXlvdXQKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MjIxCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5jcHAKaW5kZXggMzZiYTE2NGRjZDU4 ODBmYTBmZWY3OGU5YjA4MGQ3MGMwMWEyNmY4MC4uZGFlNWExNWVhZTljZDlhODNjYzAxMjliOWU5 MTJlMDk3MmMzMjU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9U YWJsZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxh eW91dC5jcHAKQEAgLTQ5LDcgKzQ5LDcgQEAgdm9pZCBBdXRvVGFibGVMYXlvdXQ6OnJlY2FsY0Nv bHVtbih1bnNpZ25lZCBlZmZDb2wpCiAgICAgUmVuZGVyVGFibGVDZWxsKiBmaXhlZENvbnRyaWJ1 dG9yID0gMDsKICAgICBSZW5kZXJUYWJsZUNlbGwqIG1heENvbnRyaWJ1dG9yID0gMDsKIAotICAg IGZvciAoUmVuZGVyT2JqZWN0KiBjaGlsZCA9IG1fdGFibGUtPmZpcnN0Q2hpbGQoKTsgY2hpbGQ7 IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCkpIHsKKyAgICBmb3IgKFJlbmRlck9iamVjdCog Y2hpbGQgPSBtX3RhYmxlLT5jaGlsZHJlbigpLT5maXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9 IGNoaWxkLT5uZXh0U2libGluZygpKSB7CiAgICAgICAgIGlmIChjaGlsZC0+aXNSZW5kZXJUYWJs ZUNvbCgpKQogICAgICAgICAgICAgdG9SZW5kZXJUYWJsZUNvbChjaGlsZCktPmNvbXB1dGVQcmVm ZXJyZWRMb2dpY2FsV2lkdGhzKCk7CiAgICAgICAgIGVsc2UgaWYgKGNoaWxkLT5pc1RhYmxlU2Vj dGlvbigpKSB7CkBAIC02Miw3ICs2Miw3IEBAIHZvaWQgQXV0b1RhYmxlTGF5b3V0OjpyZWNhbGND b2x1bW4odW5zaWduZWQgZWZmQ29sKQogICAgICAgICAgICAgICAgIGlmIChjdXJyZW50LmluQ29s U3BhbiB8fCAhY2VsbCkKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAg ICAgICAgICBib29sIGNlbGxIYXNDb250ZW50ID0gY2VsbC0+Zmlyc3RDaGlsZCgpIHx8IGNlbGwt PnN0eWxlKCktPmhhc0JvcmRlcigpIHx8IGNlbGwtPnN0eWxlKCktPmhhc1BhZGRpbmcoKTsKKyAg ICAgICAgICAgICAgICBib29sIGNlbGxIYXNDb250ZW50ID0gY2VsbC0+Y2hpbGRyZW4oKS0+Zmly c3RDaGlsZCgpIHx8IGNlbGwtPnN0eWxlKCktPmhhc0JvcmRlcigpIHx8IGNlbGwtPnN0eWxlKCkt Pmhhc1BhZGRpbmcoKTsKICAgICAgICAgICAgICAgICBpZiAoY2VsbEhhc0NvbnRlbnQpCiAgICAg ICAgICAgICAgICAgICAgIGNvbHVtbkxheW91dC5lbXB0eUNlbGxzT25seSA9IGZhbHNlOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAppbmRleCA1 MmQ2NWFiMTlhMDJjMzk1Mzk1NTliNzM2YWNkODdiNzJiNDIxYzA0Li4zMzg3ODgxMjQ4N2M3YTVj OGU5ZGMyN2UxYzJlNWU2MGRkODgzMTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKQEAgLTE0MzIsNDggKzE0MzIsNiBAQCBDb2xvciBSZW5k ZXJTdHlsZTo6dmlzaXRlZERlcGVuZGVudENvbG9yKGludCBjb2xvclByb3BlcnR5KSBjb25zdAog ICAgIHJldHVybiBDb2xvcih2aXNpdGVkQ29sb3IucmVkKCksIHZpc2l0ZWRDb2xvci5ncmVlbigp LCB2aXNpdGVkQ29sb3IuYmx1ZSgpLCB1bnZpc2l0ZWRDb2xvci5hbHBoYSgpKTsKIH0KIAotTGVu Z3RoIFJlbmRlclN0eWxlOjpsb2dpY2FsV2lkdGgoKSBjb25zdAotewotICAgIGlmIChpc0hvcml6 b250YWxXcml0aW5nTW9kZSgpKQotICAgICAgICByZXR1cm4gd2lkdGgoKTsKLSAgICByZXR1cm4g aGVpZ2h0KCk7Ci19Ci0KLUxlbmd0aCBSZW5kZXJTdHlsZTo6bG9naWNhbEhlaWdodCgpIGNvbnN0 Ci17Ci0gICAgaWYgKGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpCi0gICAgICAgIHJldHVybiBo ZWlnaHQoKTsKLSAgICByZXR1cm4gd2lkdGgoKTsKLX0KLQotTGVuZ3RoIFJlbmRlclN0eWxlOjps b2dpY2FsTWluV2lkdGgoKSBjb25zdAotewotICAgIGlmIChpc0hvcml6b250YWxXcml0aW5nTW9k ZSgpKQotICAgICAgICByZXR1cm4gbWluV2lkdGgoKTsKLSAgICByZXR1cm4gbWluSGVpZ2h0KCk7 Ci19Ci0KLUxlbmd0aCBSZW5kZXJTdHlsZTo6bG9naWNhbE1heFdpZHRoKCkgY29uc3QKLXsKLSAg ICBpZiAoaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSkKLSAgICAgICAgcmV0dXJuIG1heFdpZHRo KCk7Ci0gICAgcmV0dXJuIG1heEhlaWdodCgpOwotfQotCi1MZW5ndGggUmVuZGVyU3R5bGU6Omxv Z2ljYWxNaW5IZWlnaHQoKSBjb25zdAotewotICAgIGlmIChpc0hvcml6b250YWxXcml0aW5nTW9k ZSgpKQotICAgICAgICByZXR1cm4gbWluSGVpZ2h0KCk7Ci0gICAgcmV0dXJuIG1pbldpZHRoKCk7 Ci19Ci0KLUxlbmd0aCBSZW5kZXJTdHlsZTo6bG9naWNhbE1heEhlaWdodCgpIGNvbnN0Ci17Ci0g ICAgaWYgKGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpCi0gICAgICAgIHJldHVybiBtYXhIZWln aHQoKTsKLSAgICByZXR1cm4gbWF4V2lkdGgoKTsKLX0KLQogY29uc3QgQm9yZGVyVmFsdWUmIFJl bmRlclN0eWxlOjpib3JkZXJCZWZvcmUoKSBjb25zdAogewogICAgIHN3aXRjaCAod3JpdGluZ01v ZGUoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRl clN0eWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaApp bmRleCBmYjk5NGEzMDdjNWNiY2NmNWZhMWQxY2FhODAxYWY2YjkwZjY4ZDIzLi5hYzcyNzM5NDAw MWEwMzgyYmYxM2U1ZjVhYWZmMmJiYTBkYTcxZDQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaApAQCAtNTIzLDEyICs1MjMsMTIgQEAgcHVibGljOgog ICAgIExlbmd0aCBtaW5IZWlnaHQoKSBjb25zdCB7IHJldHVybiBtX2JveC0+bWluSGVpZ2h0KCk7 IH0KICAgICBMZW5ndGggbWF4SGVpZ2h0KCkgY29uc3QgeyByZXR1cm4gbV9ib3gtPm1heEhlaWdo dCgpOyB9CiAgICAgCi0gICAgTGVuZ3RoIGxvZ2ljYWxXaWR0aCgpIGNvbnN0OwotICAgIExlbmd0 aCBsb2dpY2FsSGVpZ2h0KCkgY29uc3Q7Ci0gICAgTGVuZ3RoIGxvZ2ljYWxNaW5XaWR0aCgpIGNv bnN0OwotICAgIExlbmd0aCBsb2dpY2FsTWF4V2lkdGgoKSBjb25zdDsKLSAgICBMZW5ndGggbG9n aWNhbE1pbkhlaWdodCgpIGNvbnN0OwotICAgIExlbmd0aCBsb2dpY2FsTWF4SGVpZ2h0KCkgY29u c3Q7CisgICAgTGVuZ3RoIGxvZ2ljYWxXaWR0aCgpIGNvbnN0IHsgcmV0dXJuIGlzSG9yaXpvbnRh bFdyaXRpbmdNb2RlKCkgPyB3aWR0aCgpIDogaGVpZ2h0KCk7IH0KKyAgICBMZW5ndGggbG9naWNh bEhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkgPyBoZWln aHQoKSA6IHdpZHRoKCk7IH0KKyAgICBMZW5ndGggbG9naWNhbE1pbldpZHRoKCkgY29uc3QgeyBy ZXR1cm4gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSA/IG1pbldpZHRoKCkgOiBtaW5IZWlnaHQo KTsgfQorICAgIExlbmd0aCBsb2dpY2FsTWF4V2lkdGgoKSBjb25zdCB7IHJldHVybiBpc0hvcml6 b250YWxXcml0aW5nTW9kZSgpID8gbWF4V2lkdGgoKSA6IG1heEhlaWdodCgpOyB9CisgICAgTGVu Z3RoIGxvZ2ljYWxNaW5IZWlnaHQoKSBjb25zdCB7IHJldHVybiBpc0hvcml6b250YWxXcml0aW5n TW9kZSgpID8gbWluSGVpZ2h0KCkgOiBtaW5XaWR0aCgpOyB9CisgICAgTGVuZ3RoIGxvZ2ljYWxN YXhIZWlnaHQoKSBjb25zdCB7IHJldHVybiBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gbWF4 SGVpZ2h0KCkgOiBtYXhXaWR0aCgpOyB9CiAKICAgICBjb25zdCBCb3JkZXJEYXRhJiBib3JkZXIo KSBjb25zdCB7IHJldHVybiBzdXJyb3VuZC0+Ym9yZGVyOyB9CiAgICAgY29uc3QgQm9yZGVyVmFs dWUmIGJvcmRlckxlZnQoKSBjb25zdCB7IHJldHVybiBzdXJyb3VuZC0+Ym9yZGVyLmxlZnQoKTsg fQo=