98478 2012-10-04 21:46:46 -0700 Fix font for date/time input types. 2012-10-04 23:24:51 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98226 1 tkent tkent cmarcelo haraken macpherson menard morrita webkit.review.bot yutak oldest_to_newest 735318 0 tkent 2012-10-04 21:46:46 -0700 * input[type=date] should use monospace font * input[type=datetime/datetime-local/time/week/month] should not use monospace font if the type is disabled. 735330 1 167245 tkent 2012-10-04 22:01:27 -0700 Created attachment 167245 Patch 735332 2 167246 tkent 2012-10-04 22:05:52 -0700 Created attachment 167246 Patch 2 Update ChangeLog 735333 3 167246 haraken 2012-10-04 22:07:41 -0700 Comment on attachment 167246 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=167246&action=review > Source/WebCore/ChangeLog:17 > + The input[type=date] change is covered by > + fast/forms/date/calendar-picker-appearance.html, > + platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html Why isn't there any change in these test results although you're changing fonts in this patch? Such a minor change is not detected? 735334 4 167246 tkent 2012-10-04 22:10:02 -0700 Comment on attachment 167246 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=167246&action=review >> Source/WebCore/ChangeLog:17 >> + platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html > > Why isn't there any change in these test results although you're changing fonts in this patch? Such a minor change is not detected? Fortunately these tests are suppressed in TestExpectations for now because they need rebaseline by prior changes. 735336 5 167246 haraken 2012-10-04 22:10:49 -0700 Comment on attachment 167246 Patch 2 OK. Please just confirm the appearance manually. 735390 6 167246 webkit.review.bot 2012-10-04 23:24:48 -0700 Comment on attachment 167246 Patch 2 Clearing flags on attachment: 167246 Committed r130467: <http://trac.webkit.org/changeset/130467> 735391 7 webkit.review.bot 2012-10-04 23:24:51 -0700 All reviewed patches have been landed. Closing bug. 167245 2012-10-04 22:01:27 -0700 2012-10-04 22:05:47 -0700 Patch bug-98478-20121005140036.patch text/plain 2534 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM2ZWIzZDM3ZjY4Yzgy NTEzMzJhNDdjZmVjN2Y5MDFjOGYyZWM1Yy4uODM2MWQ3NjYxNGUwZjE0ZDFjZjFiNzcxYTFjMjk5 MWQ1NThkOGY0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTEwLTA0ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggZm9udCBmb3IgZGF0 ZS90aW1lIGlucHV0IHR5cGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTg0NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBpbnB1dFt0eXBlPWRhdGVdIHNob3VsZCB1c2UgbW9ub3NwYWNlIGZvbnQgaWYK KyAgICAgICAgRU5BQkxFX0lOUFVUX01VTFRJUExFX0ZJRUxEU19VSSAmJiBFTkFCTEVfSU5QVVRf VFlQRV9EQVRFLgorCisgICAgICAgIEZvciBvdGhlciBkYXRlL3RpbWUgdHlwZXMsIHRoZXkgc2hv dWxkIHVzZSBtb25vc3BhY2UgZm9udCBvbmx5CisgICAgICAgIGlmIHRoZWlyIHR5cGVzIGFyZSBl bmFibGVkLiBpbnB1dFt0eXBlPSJmb28iXSBtYXRjaGVzIGlucHV0CisgICAgICAgIGVsZW1lbnQg d2l0aCB0eXBlPSJmb28iIGV2ZW4gaWYgdGhlIGZvbyB0eXBlIGlzIG5vdCBzdXBwb3J0ZWQuCisK KyAgICAgICAgV2UnbGwgYWRkIHRlc3RzIGZvciBpbnB1dFt0eXBlPWRhdGVdIGluIEJ1ZyA5ODQ3 OS4KKworICAgICAgICAqIGNzcy9odG1sLmNzczoKKyAgICAgICAgKGlucHV0W3R5cGU9ImRhdGUi XSk6CisgICAgICAgIChpbnB1dFt0eXBlPSJkYXRldGltZSJdKToKKyAgICAgICAgKGlucHV0W3R5 cGU9ImRhdGV0aW1lLWxvY2FsIl0pOgorICAgICAgICAoaW5wdXRbdHlwZT0ibW9udGgiXSk6Cisg ICAgICAgIChpbnB1dFt0eXBlPSJ0aW1lIl0pOgorCiAyMDEyLTEwLTA0ICBKdWxpZW4gQ2hhZmZy YWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFNwbGl0IHRoZSBpbnRyaW5z aWMgcGFkZGluZyB1cGRhdGUgY29kZSBvdXQgb2YgUmVuZGVyVGFibGVTZWN0aW9uOjpsYXlvdXRS b3dzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5jc3MgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvaHRtbC5jc3MKaW5kZXggNmQ2M2MyMjIwYTE3ZDBhNjM0ODA4YWI5NmMyOTZkMGQy YjY1ZTFkNy4uMWY0NTVkOGJiMjc1ZGM5ZWJhMTE3N2RiMmQ2NDk0MjYwOWMwNWExZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9odG1sLmNzcwpAQCAtNDc3LDEzICs0NzcsMzYgQEAgZGF0YWxpc3QgewogI2VuZGlmCiAKICNp ZiBkZWZpbmVkKEVOQUJMRV9JTlBVVF9NVUxUSVBMRV9GSUVMRFNfVUkpICYmIEVOQUJMRV9JTlBV VF9NVUxUSVBMRV9GSUVMRFNfVUkKLWlucHV0W3R5cGU9ImRhdGV0aW1lIl0sCi1pbnB1dFt0eXBl PSJkYXRldGltZS1sb2NhbCJdLAotaW5wdXRbdHlwZT0ibW9udGgiXSwKLWlucHV0W3R5cGU9InRp bWUiXSwKKyNpZiBkZWZpbmVkKEVOQUJMRV9JTlBVVF9UWVBFX0RBVEUpICYmIEVOQUJMRV9JTlBV VF9UWVBFX0RBVEUKK2lucHV0W3R5cGU9ImRhdGUiXSB7CisgICAgZm9udC1mYW1pbHk6IG1vbm9z cGFjZTsKK30KKyNlbmRpZgorI2lmIGRlZmluZWQoRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUUp ICYmIEVOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1FCitpbnB1dFt0eXBlPSJkYXRldGltZSJdIHsK KyAgICBmb250LWZhbWlseTogbW9ub3NwYWNlOworfQorI2VuZGlmCisjaWYgZGVmaW5lZChFTkFC TEVfSU5QVVRfVFlQRV9EQVRFVElNRUxPQ0FMKSAmJiBFTkFCTEVfSU5QVVRfVFlQRV9EQVRFVElN RUxPQ0FMCitpbnB1dFt0eXBlPSJkYXRldGltZS1sb2NhbCJdIHsKKyAgICBmb250LWZhbWlseTog bW9ub3NwYWNlOworfQorI2VuZGlmCisjaWYgZGVmaW5lZChFTkFCTEVfSU5QVVRfVFlQRV9NT05U SCkgJiYgRU5BQkxFX0lOUFVUX1RZUEVfTU9OVEgKK2lucHV0W3R5cGU9Im1vbnRoIl0geworICAg IGZvbnQtZmFtaWx5OiBtb25vc3BhY2U7Cit9CisjZW5kaWYKKyNpZiBkZWZpbmVkKEVOQUJMRV9J TlBVVF9UWVBFX1RJTUUpICYmIEVOQUJMRV9JTlBVVF9UWVBFX1RJTUUKK2lucHV0W3R5cGU9InRp bWUiXSB7CisgICAgZm9udC1mYW1pbHk6IG1vbm9zcGFjZTsKK30KKyNlbmRpZgorI2lmIGRlZmlu ZWQoRU5BQkxFX0lOUFVUX1RZUEVfV0VFSykgJiYgRU5BQkxFX0lOUFVUX1RZUEVfV0VFSwogaW5w dXRbdHlwZT0id2VlayJdIHsKICAgICBmb250LWZhbWlseTogbW9ub3NwYWNlOwogfQorI2VuZGlm CiAKIGlucHV0Ojotd2Via2l0LWRhdGV0aW1lLWVkaXQgewogICAgIC13ZWJraXQtdXNlci1tb2Rp Znk6IHJlYWQtb25seSAhaW1wb3J0YW50Owo= 167246 2012-10-04 22:05:52 -0700 2012-10-04 23:24:48 -0700 Patch 2 bug-98478-20121005140500.patch text/plain 2666 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM2ZWIzZDM3ZjY4Yzgy NTEzMzJhNDdjZmVjN2Y5MDFjOGYyZWM1Yy4uMTM5ZmNiZGU1MjAwZjI4Mjc0NjhlYzdiMjk2Mzdl NTE0NjVjODg1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTEwLTA0ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggZm9udCBmb3IgZGF0 ZS90aW1lIGlucHV0IHR5cGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTg0NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBpbnB1dFt0eXBlPWRhdGVdIHNob3VsZCB1c2UgbW9ub3NwYWNlIGZvbnQgaWYK KyAgICAgICAgRU5BQkxFX0lOUFVUX01VTFRJUExFX0ZJRUxEU19VSSAmJiBFTkFCTEVfSU5QVVRf VFlQRV9EQVRFLgorCisgICAgICAgIEZvciBvdGhlciBkYXRlL3RpbWUgdHlwZXMsIHRoZXkgc2hv dWxkIHVzZSBtb25vc3BhY2UgZm9udCBvbmx5CisgICAgICAgIGlmIHRoZWlyIHR5cGVzIGFyZSBl bmFibGVkLiBpbnB1dFt0eXBlPSJmb28iXSBtYXRjaGVzIGlucHV0CisgICAgICAgIGVsZW1lbnQg d2l0aCB0eXBlPSJmb28iIGV2ZW4gaWYgdGhlIGZvbyB0eXBlIGlzIG5vdCBzdXBwb3J0ZWQuCisK KyAgICAgICAgVGhlIGlucHV0W3R5cGU9ZGF0ZV0gY2hhbmdlIGlzIGNvdmVyZWQgYnkKKyAgICAg ICAgZmFzdC9mb3Jtcy9kYXRlL2NhbGVuZGFyLXBpY2tlci1hcHBlYXJhbmNlLmh0bWwsCisgICAg ICAgIHBsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZm9ybXMvZGF0ZS9kYXRlLXN1Z2dlc3Rpb24tcGlj a2VyLWFwcGVhcmFuY2UqLmh0bWwKKworICAgICAgICAqIGNzcy9odG1sLmNzczoKKyAgICAgICAg KGlucHV0W3R5cGU9ImRhdGUiXSk6CisgICAgICAgIChpbnB1dFt0eXBlPSJkYXRldGltZSJdKToK KyAgICAgICAgKGlucHV0W3R5cGU9ImRhdGV0aW1lLWxvY2FsIl0pOgorICAgICAgICAoaW5wdXRb dHlwZT0ibW9udGgiXSk6CisgICAgICAgIChpbnB1dFt0eXBlPSJ0aW1lIl0pOgorCiAyMDEyLTEw LTA0ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAg IFNwbGl0IHRoZSBpbnRyaW5zaWMgcGFkZGluZyB1cGRhdGUgY29kZSBvdXQgb2YgUmVuZGVyVGFi bGVTZWN0aW9uOjpsYXlvdXRSb3dzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRt bC5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5jc3MKaW5kZXggNmQ2M2MyMjIwYTE3ZDBh NjM0ODA4YWI5NmMyOTZkMGQyYjY1ZTFkNy4uMWY0NTVkOGJiMjc1ZGM5ZWJhMTE3N2RiMmQ2NDk0 MjYwOWMwNWExZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9odG1sLmNzcwpAQCAtNDc3LDEzICs0NzcsMzYgQEAgZGF0YWxp c3QgewogI2VuZGlmCiAKICNpZiBkZWZpbmVkKEVOQUJMRV9JTlBVVF9NVUxUSVBMRV9GSUVMRFNf VUkpICYmIEVOQUJMRV9JTlBVVF9NVUxUSVBMRV9GSUVMRFNfVUkKLWlucHV0W3R5cGU9ImRhdGV0 aW1lIl0sCi1pbnB1dFt0eXBlPSJkYXRldGltZS1sb2NhbCJdLAotaW5wdXRbdHlwZT0ibW9udGgi XSwKLWlucHV0W3R5cGU9InRpbWUiXSwKKyNpZiBkZWZpbmVkKEVOQUJMRV9JTlBVVF9UWVBFX0RB VEUpICYmIEVOQUJMRV9JTlBVVF9UWVBFX0RBVEUKK2lucHV0W3R5cGU9ImRhdGUiXSB7CisgICAg Zm9udC1mYW1pbHk6IG1vbm9zcGFjZTsKK30KKyNlbmRpZgorI2lmIGRlZmluZWQoRU5BQkxFX0lO UFVUX1RZUEVfREFURVRJTUUpICYmIEVOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1FCitpbnB1dFt0 eXBlPSJkYXRldGltZSJdIHsKKyAgICBmb250LWZhbWlseTogbW9ub3NwYWNlOworfQorI2VuZGlm CisjaWYgZGVmaW5lZChFTkFCTEVfSU5QVVRfVFlQRV9EQVRFVElNRUxPQ0FMKSAmJiBFTkFCTEVf SU5QVVRfVFlQRV9EQVRFVElNRUxPQ0FMCitpbnB1dFt0eXBlPSJkYXRldGltZS1sb2NhbCJdIHsK KyAgICBmb250LWZhbWlseTogbW9ub3NwYWNlOworfQorI2VuZGlmCisjaWYgZGVmaW5lZChFTkFC TEVfSU5QVVRfVFlQRV9NT05USCkgJiYgRU5BQkxFX0lOUFVUX1RZUEVfTU9OVEgKK2lucHV0W3R5 cGU9Im1vbnRoIl0geworICAgIGZvbnQtZmFtaWx5OiBtb25vc3BhY2U7Cit9CisjZW5kaWYKKyNp ZiBkZWZpbmVkKEVOQUJMRV9JTlBVVF9UWVBFX1RJTUUpICYmIEVOQUJMRV9JTlBVVF9UWVBFX1RJ TUUKK2lucHV0W3R5cGU9InRpbWUiXSB7CisgICAgZm9udC1mYW1pbHk6IG1vbm9zcGFjZTsKK30K KyNlbmRpZgorI2lmIGRlZmluZWQoRU5BQkxFX0lOUFVUX1RZUEVfV0VFSykgJiYgRU5BQkxFX0lO UFVUX1RZUEVfV0VFSwogaW5wdXRbdHlwZT0id2VlayJdIHsKICAgICBmb250LWZhbWlseTogbW9u b3NwYWNlOwogfQorI2VuZGlmCiAKIGlucHV0Ojotd2Via2l0LWRhdGV0aW1lLWVkaXQgewogICAg IC13ZWJraXQtdXNlci1tb2RpZnk6IHJlYWQtb25seSAhaW1wb3J0YW50Owo=