98379 2012-10-04 00:46:30 -0700 [GTK] accessibility/textarea-selected-text-range.html is failing 2013-11-01 04:46:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 112016 Gtk, LayoutTestFailure P2 Normal --- 98347 1 zan webkit-unassigned apinheiro cfleizach dmazzoni jdiggs mario pnormand webkit.review.bot oldest_to_newest 734466 0 zan 2012-10-04 00:46:30 -0700 accessibility/textarea-selected-text-range.html is failing on all GTK platforms. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=accessibility%2Ftextarea-selected-text-range.html 743327 1 jdiggs 2012-10-16 11:12:16 -0700 This one is failing because we need to implement our DRT's AccessibilityUIElement::selectedTextRange() Putting this one on Piñeiro's plate. 787157 2 apinheiro 2012-12-10 03:27:30 -0800 (In reply to comment #1) > This one is failing because we need to implement our DRT's AccessibilityUIElement::selectedTextRange() After a quick look, this test is also using AccessibilityUIElement::setSelectedTextRange(), so I will implement both. > > Putting this one on Piñeiro's plate. Using WebkitGTK hackfest to catch it. 789748 3 179091 apinheiro 2012-12-12 11:36:47 -0800 Created attachment 179091 Fixes the bug In the end it was not only implement those DRT methods. Some of the ATK implementation methods were failing for the case of text areas (so making remove this test from the failure list more important). So in a short this bug: * Fixes ATK implementation case for text area * Update the atk unit test, in order to include text areas * Implement the DRT methods pointed by Joanie at comment 1 * Remove the test from the failure list at TestExpectations 789936 4 179091 buildbot 2012-12-12 14:43:06 -0800 Comment on attachment 179091 Fixes the bug Attachment 179091 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15304147 New failing tests: fast/frames/sandboxed-iframe-attribute-parsing.html 790443 5 apinheiro 2012-12-13 02:43:27 -0800 (In reply to comment #4) > (From update of attachment 179091 [details]) > Attachment 179091 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/15304147 > > New failing tests: > fast/frames/sandboxed-iframe-attribute-parsing.html This is strange, because on my patch I didn't change anything related to WebCore accessibility. All my changes were related to the gtk port, and in the same way, the test failing is not related at all with selection. Chris what do you think about this? Can be a false positive? Meanwhile I will set the commit-queue again to '?'. Btw, Chris if you finally come here to give your opinion, could you review the patch? Thanks 874901 6 pnormand 2013-04-12 12:28:53 -0700 Chris, would you have time to review this patch? 874906 7 179091 cfleizach 2013-04-12 12:38:57 -0700 Comment on attachment 179091 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=179091&action=review > LayoutTests/ChangeLog:8 > + * platform/gtk/TestExpectations: Removed textare-selected-text-range.html failure expectation. missing "a" at the end of text area in "textare-selected" > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:510 > + // siblings (e.g. multiline text) or text markers (e.g. list item's bullet) I would rewrite this as "The text content for TextAreas is already flattened so the startOffset is the same as the selectionStart. Other elements must handle other sibling nodes and text markers." > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:806 > + // WebKit atk implementation only supports one selection use a period at the end of comments. ATK should probably be capitalized does anything support more than one selection? maybe the comment is not necessary > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:821 > + atk_text_set_selection(ATK_TEXT(m_element), 0, location, location+length); space before and after + 877395 8 cfleizach 2013-04-17 11:19:30 -0700 (In reply to comment #7) > (From update of attachment 179091 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179091&action=review > > > LayoutTests/ChangeLog:8 > > + * platform/gtk/TestExpectations: Removed textare-selected-text-range.html failure expectation. > > missing "a" at the end of text area in > "textare-selected" > > > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:510 > > + // siblings (e.g. multiline text) or text markers (e.g. list item's bullet) > > I would rewrite this as > > "The text content for TextAreas is already flattened so the startOffset is the same as the selectionStart. > Other elements must handle other sibling nodes and text markers." > > > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:806 > > + // WebKit atk implementation only supports one selection > > use a period at the end of comments. > ATK should probably be capitalized > > does anything support more than one selection? maybe the comment is not necessary > > > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:821 > > + atk_text_set_selection(ATK_TEXT(m_element), 0, location, location+length); > > space before and after + otherwise things seem ok 941764 9 179091 mario 2013-10-21 02:03:53 -0700 Comment on attachment 179091 Fixes the bug Clearing r? so it does not appear in webkit.org/pending-review. API, do you want to give it another try? If that's the case, bear in mind that getSelectionOffsetsForObject() has changed recently, so this original patch won't apply cleanly. 941796 10 apinheiro 2013-10-21 03:46:14 -0700 (In reply to comment #9) > (From update of attachment 179091 [details]) > Clearing r? so it does not appear in webkit.org/pending-review. > > API, do you want to give it another try? If that's the case, bear in mind that getSelectionOffsetsForObject() has changed recently, so this original patch won't apply cleanly. Well, I also need to update the patch due Chris's review. In any case thanks for the update. FWIW, probably I would not be able to work on this until next webkitgtk hackfest, and seems a good bug to start with. 945889 11 mario 2013-11-01 04:46:46 -0700 (In reply to comment #10) > (In reply to comment #9) > > (From update of attachment 179091 [details] [details]) > > Clearing r? so it does not appear in webkit.org/pending-review. > > > > API, do you want to give it another try? If that's the case, bear in mind that getSelectionOffsetsForObject() has changed recently, so this original patch won't apply cleanly. > > Well, I also need to update the patch due Chris's review. In any case thanks > for the update. FWIW, probably I would not be able to work on this until next > webkitgtk hackfest, and seems a good bug to start with. It seems that in the end all we needed to fix this at this point was to provide the implementation for DRT and WKTR, which has been done as part of bug 112016. So resolving. *** This bug has been marked as a duplicate of bug 112016 *** 179091 2012-12-12 11:36:47 -0800 2013-10-21 02:03:53 -0700 Fixes the bug 0001-Bug-98379.patch text/plain 12163 apinheiro RnJvbSAyYzYyYTA3YmJhMDMzNDdiZjA5Yjg0MDhhOWE2N2Q2YjM3NWZlNjVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QWxlamFuZHJvPTIwUGk9QzM9QjFlaXJvPz0g PGFwaW5oZWlyb0BpZ2FsaWEuY29tPgpEYXRlOiBUdWUsIDExIERlYyAyMDEyIDEyOjM1OjMwICsw MTAwClN1YmplY3Q6IFtQQVRDSF0gQnVnIDk4Mzc5CgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgOSArKysrKysrCiBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyAgICAgICAgICB8ICAgIDEgLQogU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsrKysr KysrCiAuLi4vYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VUZXh0LmNwcCAgICAgICAgICB8 ICAgMjggKysrKysrKysrKysrKy0tLS0tLS0KIFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKwogU291cmNlL1dlYktpdC9ndGsv dGVzdHMvdGVzdGF0ay5jICAgICAgICAgICAgICAgICAgfCAgIDIyICsrKysrKysrKysrKysrLQog VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEz ICsrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCAgICAgICAg ICAgICAgfCAgIDIzICsrKysrKysrKysrKystLS0KIDggZmlsZXMgY2hhbmdlZCwgMTAzIGluc2Vy dGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkM2VlOGNhLi4zZDRiNDVkIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMTItMTIgIEFsZWphbmRybyBQacOxZWlybyAgPGFwaW5o ZWlyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGFjY2Vzc2liaWxpdHkvdGV4dGFyZWEt c2VsZWN0ZWQtdGV4dC1yYW5nZS5odG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4Mzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u czogUmVtb3ZlZCB0ZXh0YXJlLXNlbGVjdGVkLXRleHQtcmFuZ2UuaHRtbCBmYWlsdXJlIGV4cGVj dGF0aW9uLgorCiAyMDEyLTEyLTEyICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIE1hcmtlZCBpbnNwZWN0b3ItcHJvdG9jb2wvdGFr ZS1oZWFwLXNuYXBzaG90Lmh0bWwgYXMgQ1JBU0ggb25seSBpbiBEZWJ1ZyBtb2RlLCBpdCBwYXNz ZXMgaW4gUmVsZWFzZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0 RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMK aW5kZXggY2JiNGM4OS4uMGQwNzE3MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnMKQEAgLTc3Myw3ICs3NzMsNiBAQCB3ZWJraXQub3JnL2IvOTgzNzYgYWNjZXNz aWJpbGl0eS9zZWxlY3Rpb24tc3RhdGVzLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8x MDExODUgYWNjZXNzaWJpbGl0eS9zdmctcmVtb3RlLWVsZW1lbnQuaHRtbCBbIEZhaWx1cmUgXQog d2Via2l0Lm9yZy9iLzk4Mzc3IGFjY2Vzc2liaWxpdHkvdGV4dGFyZWEtaW5zZXJ0aW9uLXBvaW50 LWxpbmUtbnVtYmVyLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi85ODM3OCBhY2Nlc3Np YmlsaXR5L3RleHRhcmVhLWxpbmUtZm9yLWluZGV4Lmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5v cmcvYi85ODM3OSBhY2Nlc3NpYmlsaXR5L3RleHRhcmVhLXNlbGVjdGVkLXRleHQtcmFuZ2UuaHRt bCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk4MzgwIGFjY2Vzc2liaWxpdHkvdGgtYXMtdGl0 bGUtdWkuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk4MzgxIGFjY2Vzc2liaWxpdHkv dHJhbnNmb3JtZWQtZWxlbWVudC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvOTgzODIg YWNjZXNzaWJpbGl0eS92aXNpYmxlLWVsZW1lbnRzLmh0bWwgWyBGYWlsdXJlIF0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCA4YTRhYmVhLi4yYzY2ZmNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTIt MTItMTIgIEFsZWphbmRybyBQacOxZWlybyAgPGFwaW5oZWlyb0BpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIGFjY2Vzc2liaWxpdHkvdGV4dGFyZWEtc2VsZWN0ZWQtdGV4dC1yYW5nZS5odG1s IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk4Mzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dC5jcHA6 CisgICAgICAgIChnZXRTZWxlY3Rpb25PZmZzZXRzRm9yT2JqZWN0KTogVXBkYXRlZCB0byB0YWtl IGludG8gYWNjb3VudCB0aGUKKyAgICAgICAgY2FzZSBvZiBhIHRleHQgYXJlYS4KKwogMjAxMi0x Mi0xMiAgQWxleGVpIEZpbGlwcG92ICA8YWxwaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogYWRkIG1lbW9yeSB1c2VkIGJ5IG1lbW9yeSBhbGxvY2F0b3IgaXRzZWxmIHRv IE5NSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0 QWNjZXNzaWJsZUludGVyZmFjZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVRleHQuY3BwCmluZGV4IGI3MDIyNDcuLjhj ZmNlZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktp dEFjY2Vzc2libGVJbnRlcmZhY2VUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dC5jcHAKQEAgLTUwNCwxOCAr NTA0LDI2IEBAIHN0YXRpYyB2b2lkIGdldFNlbGVjdGlvbk9mZnNldHNGb3JPYmplY3QoQWNjZXNz aWJpbGl0eU9iamVjdCogY29yZU9iamVjdCwgVmlzaWJsCiAgICAgZWxzZQogICAgICAgICBub2Rl UmFuZ2VFbmQgPSBzZWxSYW5nZS0+ZW5kUG9zaXRpb24oKTsKIAotICAgIC8vIENhbGN1bGF0ZSBw b3NpdGlvbiBvZiB0aGUgc2VsZWN0ZWQgcmFuZ2UgaW5zaWRlIHRoZSBvYmplY3QuCi0gICAgUG9z aXRpb24gcGFyZW50Rmlyc3RQb3NpdGlvbiA9IGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShu b2RlKTsKLSAgICBSZWZQdHI8UmFuZ2U+IHJhbmdlSW5QYXJlbnQgPSBSYW5nZTo6Y3JlYXRlKG5v ZGUtPmRvY3VtZW50KCksIHBhcmVudEZpcnN0UG9zaXRpb24sIG5vZGVSYW5nZVN0YXJ0KTsKKyAg ICAvLyBJZiBpdCBpcyBhIFRleHRBcmVhIHdlIGFyZSBnZXR0aW5nIHRoZSB0ZXh0IGNvbnRlbnQg YWxyZWFkeSBmbGF0dGVuZWQKKyAgICAvLyBzbyB3ZSBqdXN0IG5lZWQgdG8gdXNlIHRoZSBzdGFy dCBvZiB0aGUgc2VsZWN0aW9uLiBJbiBvdGhlciBjYXNlcyB3ZQorICAgIC8vIG1pZ2h0IG5lZWQg dG8gZG8gbW9yZSB3b3JrLCB0YWtpbmcgaW50byBhY2NvdW50IHRoaW5ncyBzdWNoIGFzCisgICAg Ly8gc2libGluZ3MgKGUuZy4gbXVsdGlsaW5lIHRleHQpIG9yIHRleHQgbWFya2VycyAoZS5nLiBs aXN0IGl0ZW0ncyBidWxsZXQpCisgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IGNvcmVPYmpl Y3QtPnJlbmRlcmVyKCk7CisgICAgaWYgKHJlbmRlcmVyICYmIHJlbmRlcmVyLT5pc1RleHRBcmVh KCkpCisgICAgICAgIHN0YXJ0T2Zmc2V0ID0gY29yZU9iamVjdC0+c2VsZWN0aW9uU3RhcnQoKTsK KyAgICBlbHNlIHsKKyAgICAgICAgLy8gQ2FsY3VsYXRlIHBvc2l0aW9uIG9mIHRoZSBzZWxlY3Rl ZCByYW5nZSBpbnNpZGUgdGhlIG9iamVjdC4KKyAgICAgICAgUG9zaXRpb24gcGFyZW50Rmlyc3RQ b3NpdGlvbiA9IGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShub2RlKTsKKyAgICAgICAgUmVm UHRyPFJhbmdlPiByYW5nZUluUGFyZW50ID0gUmFuZ2U6OmNyZWF0ZShub2RlLT5kb2N1bWVudCgp LCBwYXJlbnRGaXJzdFBvc2l0aW9uLCBub2RlUmFuZ2VTdGFydCk7CiAKLSAgICAvLyBTZXQgdmFs dWVzIGZvciBzdGFydCBhbmQgZW5kIG9mZnNldHMuCi0gICAgc3RhcnRPZmZzZXQgPSBUZXh0SXRl cmF0b3I6OnJhbmdlTGVuZ3RoKHJhbmdlSW5QYXJlbnQuZ2V0KCksIHRydWUpOworICAgICAgICAv LyBTZXQgdmFsdWVzIGZvciBzdGFydCBhbmQgZW5kIG9mZnNldHMuCisgICAgICAgIHN0YXJ0T2Zm c2V0ID0gVGV4dEl0ZXJhdG9yOjpyYW5nZUxlbmd0aChyYW5nZUluUGFyZW50LmdldCgpLCB0cnVl KTsKIAotICAgIC8vIFdlIG5lZWQgdG8gYWRqdXN0IHRoZSBvZmZzZXRzIGZvciB0aGUgbGlzdCBp dGVtIG1hcmtlci4KLSAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gY29yZU9iamVjdC0+cmVu ZGVyZXIoKTsKLSAgICBpZiAocmVuZGVyZXIgJiYgcmVuZGVyZXItPmlzTGlzdEl0ZW0oKSkgewot ICAgICAgICBTdHJpbmcgbWFya2VyVGV4dCA9IHRvUmVuZGVyTGlzdEl0ZW0ocmVuZGVyZXIpLT5t YXJrZXJUZXh0V2l0aFN1ZmZpeCgpOwotICAgICAgICBzdGFydE9mZnNldCArPSBtYXJrZXJUZXh0 Lmxlbmd0aCgpOworICAgICAgICAvLyBXZSBuZWVkIHRvIGFkanVzdCB0aGUgb2Zmc2V0cyBmb3Ig dGhlIGxpc3QgaXRlbSBtYXJrZXIuCisgICAgICAgIGlmIChyZW5kZXJlciAmJiByZW5kZXJlci0+ aXNMaXN0SXRlbSgpKSB7CisgICAgICAgICAgICBTdHJpbmcgbWFya2VyVGV4dCA9IHRvUmVuZGVy TGlzdEl0ZW0ocmVuZGVyZXIpLT5tYXJrZXJUZXh0V2l0aFN1ZmZpeCgpOworICAgICAgICAgICAg c3RhcnRPZmZzZXQgKz0gbWFya2VyVGV4dC5sZW5ndGgoKTsKKyAgICAgICAgfQogICAgIH0KIAog ICAgIFJlZlB0cjxSYW5nZT4gbm9kZVJhbmdlID0gUmFuZ2U6OmNyZWF0ZShub2RlLT5kb2N1bWVu dCgpLCBub2RlUmFuZ2VTdGFydCwgbm9kZVJhbmdlRW5kKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCAz ODJmMmQ5Li5jODRjNDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTIt MTItMTIgIEFsZWphbmRybyBQacOxZWlybyAgPGFwaW5oZWlyb0BpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIGFjY2Vzc2liaWxpdHkvdGV4dGFyZWEtc2VsZWN0ZWQtdGV4dC1yYW5nZS5odG1s IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk4Mzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB0ZXN0cy90ZXN0YXRrLmM6CisgICAgICAgICh0ZXN0V2Via2l0QXRrVGV4dFNlbGVjdGlv bnMpOiBBZGQgYSB0ZXh0IGFyZWEgYXQgdGhlIGV4YW1wbGUgdXNlZAorICAgICAgICB3aGlsZSB0 ZXN0aW5nIEFUSyB0ZXh0IHNlbGVjdGlvbiBtZXRob2RzLgorCiAyMDEyLTEyLTEyICBKb29uZSBI dXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgogCiAgICAgICAgIFtHVEtdW0FDXSBHcmFwaGljc0xh eWVycyBhcmUgbm90IHNob3duIG9uIHRoZSB2aWV3cG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ndGsvdGVzdHMvdGVzdGF0ay5jIGIvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0 ay5jCmluZGV4IGNjOTBkOTQuLjI4NzFlZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3Rr L3Rlc3RzL3Rlc3RhdGsuYworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMK QEAgLTY3LDcgKzY3LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIqIGxpc3RzT2ZJdGVtcyA9ICI8aHRt bD48Ym9keT48dWw+PGxpPnRleHQgb25seTwvbGk+PGxpPjxhIGhyZWYKIAogc3RhdGljIGNvbnN0 IGNoYXIqIHRleHRGb3JDYXJldEJyb3dzaW5nID0gIjxodG1sPjxib2R5PjxoMT5BIHRleHQgaGVh ZGVyPC9oMT48cD5BIHBhcmFncmFwaCA8YSBocmVmPSdodHRwOi8vZm9vLmJhci5iYXovJz53aXRo IGEgbGluazwvYT4gaW4gdGhlIG1pZGRsZTwvcD48b2w+PGxpPkEgbGlzdCBpdGVtPC9saT48bGk+ PHNwYW4gc3R5bGU9J2Rpc3BsYXk6YmxvY2s7Jz5CbG9jayBzcGFuIGluIGEgbGlzdCBpdGVtPC9z cGFuPjxzcGFuPklubGluZSBzcGFuIGluIGEgbGlzdCBpdGVtPC9zcGFuPjwvbGk+PGxpPjxhIGhy ZWY9J2Zvbyc+PHNwYW4gc3R5bGU9J2Rpc3BsYXk6YmxvY2s7Jz5CbG9jayBzcGFuIGluIGEgbGlu ayBpbiBhIGxpc3QgaXRlbTwvc3Bhbj48c3Bhbj5JbmxpbmUgc3BhbiBpbiBhIGxpbmsgaW4gYSBs aXN0IGl0ZW08L3NwYW4+PC9hPjwvbGk+PC9vbD48c2VsZWN0PjxvcHRpb24gc2VsZWN0ZWQgdmFs dWU9J2Zvbyc+QW4gb3B0aW9uIGluIGEgY29tYm8gYm94PC9vcHRpb24+PC9zZWxlY3Q+PGlucHV0 IHR5cGU9J3RleHQnIG5hbWU9J2ZvbycgdmFsdWU9J2ZvbyBiYXIgYmF6JyAvPjx0YWJsZT48dHI+ PHRkPmEgdGFibGUgY2VsbDwvdGQ+PHRkPjwvdGQ+PHRkPjxhIGhyZWY9J2Zvbyc+PHNwYW4gc3R5 bGU9J2Rpc3BsYXk6YmxvY2s7Jz5CbG9jayBzcGFuIGluIGEgbGluayBpbiBhIHRhYmxlIGNlbGw8 L3NwYW4+PHNwYW4+SW5saW5lIHNwYW4gaW4gYSBsaW5rIGluIGEgdGFibGUgY2VsbDwvc3Bhbj48 L2E+PC90ZD48dGQ+PHNwYW4gc3R5bGU9J2Rpc3BsYXk6YmxvY2s7Jz5CbG9jayBzcGFuIGluIGEg dGFibGUgY2VsbDwvc3Bhbj48c3Bhbj5JbmxpbmUgc3BhbiBpbiBhIHRhYmxlIGNlbGw8L3NwYW4+ PC90ZD48L3RyPjwvdGFibGU+PGg0PjxhIGhyZWY9J2Zvbyc+PHNwYW4gc3R5bGU9J2Rpc3BsYXk6 YmxvY2s7Jz5CbG9jayBzcGFuIGluIGEgbGluayBpbiBhIGhlYWRpbmc8L3NwYW4+PHNwYW4+SW5s aW5lIHNwYW4gaW4gYSBsaW5rIGluIGEgaGVhZGluZzwvc3Bhbj48L2g0PjxoND48c3BhbiBzdHls ZT0nZGlzcGxheTpibG9jazsnPkJsb2NrIHNwYW4gaW4gYSBoZWFkaW5nPC9zcGFuPjxzcGFuPklu bGluZSBzcGFuIGluIGEgaGVhZGluZzwvc3Bhbj48L2g0PjwvYm9keT48L2h0bWw+IjsKIAotc3Rh dGljIGNvbnN0IGNoYXIqIHRleHRGb3JTZWxlY3Rpb25zID0gIjxodG1sPjxib2R5PjxwPkEgcGFy YWdyYXBoIHdpdGggcGxhaW4gdGV4dDwvcD48cD5BIHBhcmFncmFwaCB3aXRoIDxhIGhyZWY9J2h0 dHA6Ly93ZWJraXQub3JnJz5hIGxpbms8L2E+IGluIHRoZSBtaWRkbGU8L3A+PG9sPjxsaT5BIGxp c3QgaXRlbTwvbGk+PC9vbD48c2VsZWN0PjwvYm9keT48L2h0bWw+IjsKK3N0YXRpYyBjb25zdCBj aGFyKiB0ZXh0Rm9yU2VsZWN0aW9ucyA9ICI8aHRtbD48Ym9keT48cD5BIHBhcmFncmFwaCB3aXRo IHBsYWluIHRleHQ8L3A+PHA+QSBwYXJhZ3JhcGggd2l0aCA8YSBocmVmPSdodHRwOi8vd2Via2l0 Lm9yZyc+YSBsaW5rPC9hPiBpbiB0aGUgbWlkZGxlPC9wPjxvbD48bGk+QSBsaXN0IGl0ZW08L2xp Pjwvb2w+PHA+PHRleHRhcmVhPlxubGluZSAxXG5saW5lIDJcbmxpbmUgM1xuICAgIDwvdGV4dGFy ZWE+PC9wPjwvYm9keT48L2h0bWw+IjsKIAogc3RhdGljIGNvbnN0IGNoYXIqIHRleHRXaXRoQXR0 cmlidXRlcyA9ICI8aHRtbD48aGVhZD48c3R5bGU+LnN0MSB7Zm9udC1mYW1pbHk6IG1vbm9zcGFj ZTsgY29sb3I6cmdiKDEyMCwxMjEsMTIyKTt9IC5zdDIge3RleHQtZGVjb3JhdGlvbjp1bmRlcmxp bmU7IGJhY2tncm91bmQtY29sb3I6cmdiKDgwLDgxLDgyKTt9PC9zdHlsZT48L2hlYWQ+PGJvZHk+ PHAgc3R5bGU9XCJmb250LXNpemU6MTQ7IHRleHQtYWxpZ246cmlnaHQ7XCI+VGhpcyBpcyB0aGUg PGk+Zmlyc3Q8L2k+PGI+IHNlbnRlbmNlIG9mIHRoaXMgdGV4dC48L2I+PC9wPjxwIGNsYXNzPVwi c3QxXCI+VGhpcyBzZW50ZW5jZSBzaG91bGQgaGF2ZSBhbiBzdHlsZSBhcHBsaWVkIDxzcGFuIGNs YXNzPVwic3QyXCI+YW5kIHRoaXMgcGFydCBzaG91bGQgaGF2ZSBhbm90aGVyIG9uZTwvc3Bhbj4u PC9wPjxwPng8c3ViPjE8L3N1Yj48c3VwPjI8L3N1cD49eDxzdWI+Mjwvc3ViPjxzdXA+Mzwvc3Vw PjwvcD48cCBzdHlsZT1cInRleHQtYWxpZ246Y2VudGVyO1wiPlRoaXMgc2VudGVuY2UgaXMgdGhl IDxzdHJpa2U+bGFzdDwvc3RyaWtlPiBvbmUuPC9wPjwvYm9keT48L2h0bWw+IjsKIApAQCAtMTMw Niw2ICsxMzA2LDEyIEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJraXRBdGtUZXh0U2VsZWN0aW9ucygp CiAgICAgQXRrVGV4dCogbGlzdEl0ZW0gPSBBVEtfVEVYVChhdGtfb2JqZWN0X3JlZl9hY2Nlc3Np YmxlX2NoaWxkKGxpc3QsIDApKTsKICAgICBnX2Fzc2VydChBVEtfSVNfVEVYVChsaXN0SXRlbSkp OwogCisgICAgQXRrT2JqZWN0KiBwYXJhZ3JhcGgzID0gYXRrX29iamVjdF9yZWZfYWNjZXNzaWJs ZV9jaGlsZChvYmplY3QsIDMpOworICAgIGdfYXNzZXJ0KEFUS19PQkpFQ1QocGFyYWdyYXBoMykp OworCisgICAgQXRrVGV4dCogdGV4dEFyZWEgPSBBVEtfVEVYVChhdGtfb2JqZWN0X3JlZl9hY2Nl c3NpYmxlX2NoaWxkKHBhcmFncmFwaDMsIDApKTsKKyAgICBnX2Fzc2VydChBVEtfSVNfVEVYVChw YXJhZ3JhcGgzKSk7CisKICAgICAvKiBGaXJzdCBwYXJhZ3JhcGggKHNpbXBsZSB0ZXh0KS4gKi8K IAogICAgIC8qIEJhc2ljIGluaXRpYWwgY2hlY2tzLiAqLwpAQCAtMTQzMiwxMCArMTQzOCwyNCBA QCBzdGF0aWMgdm9pZCB0ZXN0V2Via2l0QXRrVGV4dFNlbGVjdGlvbnMoKQogCiAgICAgZ19mcmVl KHRleHRTZWxlY3Rpb25DaGFuZ2VkUmVzdWx0KTsKIAorICAgIC8qIFRoaXJkIHBhcmFncmFwaCwg YSB0ZXh0IGFyZWEgKi8KKworICAgIC8qIE1ha2UgYSBzZWxlY3Rpb24gYW5kIHRlc3QgaXQuICov CisgICAgcmVzdWx0ID0gYXRrX3RleHRfc2V0X3NlbGVjdGlvbih0ZXh0QXJlYSwgMCwgOCwgMTEp OworICAgIGdfYXNzZXJ0KHJlc3VsdCk7CisgICAgZ19hc3NlcnRfY21waW50KGF0a190ZXh0X2dl dF9uX3NlbGVjdGlvbnModGV4dEFyZWEpLCA9PSwgMSk7CisgICAgc2VsZWN0ZWRUZXh0ID0gYXRr X3RleHRfZ2V0X3NlbGVjdGlvbih0ZXh0QXJlYSwgMCwgJnN0YXJ0T2Zmc2V0LCAmZW5kT2Zmc2V0 KTsKKyAgICBnX2Fzc2VydF9jbXBpbnQoc3RhcnRPZmZzZXQsID09LCA4KTsKKyAgICBnX2Fzc2Vy dF9jbXBpbnQoZW5kT2Zmc2V0LCA9PSwgMTEpOworICAgIGdfYXNzZXJ0X2NtcHN0cihzZWxlY3Rl ZFRleHQsID09LCAiaW5lIik7CisgICAgZ19mcmVlIChzZWxlY3RlZFRleHQpOworCiAgICAgZ19v YmplY3RfdW5yZWYocGFyYWdyYXBoMSk7CiAgICAgZ19vYmplY3RfdW5yZWYocGFyYWdyYXBoMik7 CisgICAgZ19vYmplY3RfdW5yZWYocGFyYWdyYXBoMyk7CiAgICAgZ19vYmplY3RfdW5yZWYobGlz dCk7CiAgICAgZ19vYmplY3RfdW5yZWYobGlzdEl0ZW0pOworICAgIGdfb2JqZWN0X3VucmVmKHRl eHRBcmVhKTsKICAgICBnX29iamVjdF91bnJlZih3ZWJWaWV3KTsKIH0KIApkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGRmY2RkNzIuLjI3Yzc1MjIg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0xMi0xMiAgQWxlamFuZHJvIFBpw7FlaXJvICA8YXBpbmhlaXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gYWNjZXNzaWJpbGl0eS90ZXh0YXJlYS1zZWxlY3Rl ZC10ZXh0LXJhbmdlLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgzNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlF bGVtZW50R3RrLmNwcDoKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnNlbGVjdGVk VGV4dFJhbmdlKTogSW1wbGVtZW50IHRoaXMgYnkKKyAgICAgICAgdXNpbmcgdGhlIHByb3BlciBB dGtUZXh0IG1ldGhvZHMuCisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpzZXRTZWxl Y3RlZFRleHRSYW5nZSk6IEltcGxlbWVudCB0aGlzIGJ5CisgICAgICAgIHVzaW5nIHRoZSBwcm9w ZXIgQXRrVGV4dCBtZXRob2RzLgorCiAyMDEyLTEyLTEyICBaYW4gRG9iZXJzZWsgIDx6YW5kb2Jl cnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgW0dUS10gUmVtb3ZlIHRoZSBsYXN0IG9mIHVubmVj ZXNzYXJ5IGNvbmZpZ3VyYXRpb24gb3B0aW9ucyBpbiBjb25maWd1cmUuYWMKZGlmZiAtLWdpdCBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcApp bmRleCA1YzE4ODMyLi4wNzI3YTcyIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9n dGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCkBAIC03OTUsMTMgKzc5NSwzMCBA QCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmNlbGxGb3JD b2x1bW5BbmRSb3codW5zaWduZWQgY29sdQogCiBKU1N0cmluZ1JlZiBBY2Nlc3NpYmlsaXR5VUlF bGVtZW50OjpzZWxlY3RlZFRleHRSYW5nZSgpCiB7Ci0gICAgLy8gRklYTUU6IGltcGxlbWVudAot ICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKDAsIDApOworICAgIGlmICgh bV9lbGVtZW50KQorICAgICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVycygw LCAwKTsKKworICAgIEFTU0VSVChBVEtfSVNfVEVYVChtX2VsZW1lbnQpKTsKKworICAgIGdpbnQg c3RhcnRfb2Zmc2V0OworICAgIGdpbnQgZW5kX29mZnNldDsKKworICAgIC8vIFdlYktpdCBhdGsg aW1wbGVtZW50YXRpb24gb25seSBzdXBwb3J0cyBvbmUgc2VsZWN0aW9uCisgICAgR093blB0cjxn Y2hhcj4gc2VsZWN0ZWRfdGV4dChhdGtfdGV4dF9nZXRfc2VsZWN0aW9uKEFUS19URVhUKG1fZWxl bWVudCksIDAsICZzdGFydF9vZmZzZXQsICZlbmRfb2Zmc2V0KSk7CisgICAgR093blB0cjxnY2hh cj4gdGV4dFJhbmdlKGdfc3RyZHVwX3ByaW50ZiAoInslaSwgJWl9Iiwgc3RhcnRfb2Zmc2V0LCBl bmRfb2Zmc2V0IC0gc3RhcnRfb2Zmc2V0KSk7CisKKyAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVX aXRoVVRGOENTdHJpbmcodGV4dFJhbmdlLmdldCgpKTsKIH0KIAogdm9pZCBBY2Nlc3NpYmlsaXR5 VUlFbGVtZW50OjpzZXRTZWxlY3RlZFRleHRSYW5nZSh1bnNpZ25lZCBsb2NhdGlvbiwgdW5zaWdu ZWQgbGVuZ3RoKQogewotICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKKyAgICBpZiAoIW1fZWxlbWVu dCkKKyAgICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKEFUS19JU19URVhUKG1fZWxlbWVudCkp OworCisgICAgLy8gV2Via2l0IGF0ayBpbXBsZW1lbnRhdGlvbiBvbmx5IHN1cHBvcnQgb25lIHRl eHQgc2VsZWN0aW9uCisgICAgYXRrX3RleHRfc2V0X3NlbGVjdGlvbihBVEtfVEVYVChtX2VsZW1l bnQpLCAwLCBsb2NhdGlvbiwgbG9jYXRpb24rbGVuZ3RoKTsKIH0KIAogSlNTdHJpbmdSZWYgQWNj ZXNzaWJpbGl0eVVJRWxlbWVudDo6c3RyaW5nQXR0cmlidXRlVmFsdWUoSlNTdHJpbmdSZWYgYXR0 cmlidXRlKQotLSAKMS43LjEwLjQKCg==