98373 2012-10-04 00:43:24 -0700 [GTK] accessibility/placeholder.html is failing 2012-12-09 17:10:35 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 98347 1 zan jdiggs apinheiro cfleizach dmazzoni jdiggs webkit.review.bot oldest_to_newest 734460 0 zan 2012-10-04 00:43:24 -0700 accessibility/placeholder.html is failing on all GTK platforms. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=accessibility%2Fplaceholder.html 743443 1 jdiggs 2012-10-16 12:51:26 -0700 On the surface, this is failing due to the need to implement AccessibilityUIElement::stringAttributeValue() Having said that, I'm not seeing the placeholder text exposed to us when viewing the test case in Accerciser. So this looks like something that never got implemented in the first place. I'll take this one. 786849 2 178434 jdiggs 2012-12-09 12:21:50 -0800 Created attachment 178434 Patch 786851 3 178434 mrobinson 2012-12-09 12:30:53 -0800 Comment on attachment 178434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178434&action=review Looks good, but I have a few very small quibbles. > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:40 > +static inline String coreAttributeToAtkAttribute(JSStringRef attribute) It's probably okay to skip the "inline" here. The compiler typically works it out and it's not imperative for performance. > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:47 > + if (attrString == "AXPlaceholderValue") attrString -> attributeString (see below). > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:783 > + String atkAttributeName = coreAttributeToAtkAttribute(attribute); Maybe an early return here if String.isEmpty()? > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:786 > + for (GSList* attrs = atk_object_get_attributes(ATK_OBJECT(m_element)); attrs; attrs = attrs->next) { > + AtkAttribute* attr = static_cast<AtkAttribute*>(attrs->data); Small nit: Variable names are not typically abbreviated in WebKit apart from the most obvious (such as i or it for iterator), so these should be 'attributes' and 'attribute' respectively. 786853 4 178435 jdiggs 2012-12-09 12:43:22 -0800 Created attachment 178435 Patch 786854 5 jdiggs 2012-12-09 12:45:27 -0800 (In reply to comment #3) > (From update of attachment 178434 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178434&action=review > > Looks good, but I have a few very small quibbles. > > > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:40 > > +static inline String coreAttributeToAtkAttribute(JSStringRef attribute) > > It's probably okay to skip the "inline" here. The compiler typically works it out and it's not imperative for performance. Done. > > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:47 > > + if (attrString == "AXPlaceholderValue") > > attrString -> attributeString (see below). Done. > > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:783 > > + String atkAttributeName = coreAttributeToAtkAttribute(attribute); > > Maybe an early return here if String.isEmpty()? Done. > > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:786 > > + for (GSList* attrs = atk_object_get_attributes(ATK_OBJECT(m_element)); attrs; attrs = attrs->next) { > > + AtkAttribute* attr = static_cast<AtkAttribute*>(attrs->data); > > Small nit: Variable names are not typically abbreviated in WebKit apart from the most obvious (such as i or it for iterator), so these should be 'attributes' and 'attribute' respectively. Done with a small alteration ('attribute' is the argument, so I went with 'atkAttributes' and 'atkAttribute' respectively). Thanks for the review! 786855 6 178435 mrobinson 2012-12-09 12:47:46 -0800 Comment on attachment 178435 Patch Great! 786914 7 178435 webkit.review.bot 2012-12-09 17:10:31 -0800 Comment on attachment 178435 Patch Clearing flags on attachment: 178435 Committed r137099: <http://trac.webkit.org/changeset/137099> 786915 8 webkit.review.bot 2012-12-09 17:10:35 -0800 All reviewed patches have been landed. Closing bug. 178434 2012-12-09 12:21:50 -0800 2012-12-09 12:43:17 -0800 Patch bug-98373-20121209211912.patch text/plain 6245 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjYwMjgzMWMzMjk1MDdj NmYxNzYyNzIxNzk5ZGM1OTdmODlmZGY0MC4uZjVlYjkwNTc2NTI5YWVlOTc5MzEzNTUwZjBlNzM0 MTE0Y2I1MzZlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTA5ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBhY2Nlc3Np YmlsaXR5L3BsYWNlaG9sZGVyLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgzNzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCB3YXMgZmFpbGluZyBiZWNhdXNlIHRo ZSBwbGFjZWhvbGRlciB0ZXh0IHdhcyBub3Qgc3VwcG9ydGVkIGFuZAorICAgICAgICBBY2Nlc3Np YmlsaXR5VUlFbGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1ZSgpIHdhcyBub3QgaW1wbGVtZW50 ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyBpbnN0ZWFkIHRoZSBmYWlsaW5nIHRlc3Qgd2Fz IHVuc2tpcHBlZC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2li bGVXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKHdlYmtpdEFjY2Vzc2libGVHZXRBdHRyaWJ1dGVz KTogQWRkIHRoZSBwbGFjZWhvbGRlciB0ZXh0IGFzIGFuIEF0a0F0dHJpYnV0ZQorICAgICAgICBv ZiB0aGUgQXRrT2JqZWN0LCBhcyBpcyBkb25lIGluIEd0aysgMy4KKwogMjAxMi0xMi0wOSAgTGVv IFlhbmcgIDxsZW95YW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkYXB0IHRv IG5hbWUgY2hhbmdlIG9mIGNyZWF0ZU5ldHdvcmtCdWZmZXJCeUNvcHlpbmdEYXRhKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVX cmFwcGVyQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFj Y2Vzc2libGVXcmFwcGVyQXRrLmNwcAppbmRleCBkZWZkOWM1OWM1NWRlM2NiMmQ4OTJmMGFhNmJi MDIxYTgzYjM3YWYwLi42MTNhOWEyZDExMzY4NDFlZjYzNzdlNTdhYTNkMjg3MzY5MjU2NGNkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3Np YmxlV3JhcHBlckF0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsv V2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCkBAIC00NTUsNiArNDU1LDEwIEBAIHN0YXRp YyBBdGtBdHRyaWJ1dGVTZXQqIHdlYmtpdEFjY2Vzc2libGVHZXRBdHRyaWJ1dGVzKEF0a09iamVj dCogb2JqZWN0KQogICAgIGlmIChjb3JlT2JqZWN0LT5pc0FjY2Vzc2liaWxpdHlUYWJsZSgpICYm ICFjb3JlT2JqZWN0LT5pc0RhdGFUYWJsZSgpKQogICAgICAgICBhdHRyaWJ1dGVTZXQgPSBhZGRU b0F0a0F0dHJpYnV0ZVNldChhdHRyaWJ1dGVTZXQsICJsYXlvdXQtZ3Vlc3MiLCAidHJ1ZSIpOwog CisgICAgU3RyaW5nIHBsYWNlaG9sZGVyID0gY29yZU9iamVjdC0+cGxhY2Vob2xkZXJWYWx1ZSgp OworICAgIGlmICghcGxhY2Vob2xkZXIuaXNFbXB0eSgpKQorICAgICAgICBhdHRyaWJ1dGVTZXQg PSBhZGRUb0F0a0F0dHJpYnV0ZVNldChhdHRyaWJ1dGVTZXQsICJwbGFjZWhvbGRlci10ZXh0Iiwg cGxhY2Vob2xkZXIudXRmOCgpLmRhdGEoKSk7CisKICAgICByZXR1cm4gYXR0cmlidXRlU2V0Owog fQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg YWQzM2E5Yzc2NTE2ODBjZTcxYjE4OWIxMjBiYTgzMTM4MGM5YjM1My4uMjQ2NWI0YWZmOGI4NWZh Nzg1NDg4NTc4MzdlYjdiMzQ1MWE5ZWUzMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisr KyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTEyLTA5ICBKb2FubWFy aWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBhY2Nlc3NpYmls aXR5L3BsYWNlaG9sZGVyLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgzNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCB3YXMgZmFpbGluZyBiZWNhdXNlIHRoZSBw bGFjZWhvbGRlciB0ZXh0IHdhcyBub3Qgc3VwcG9ydGVkIGFuZAorICAgICAgICBBY2Nlc3NpYmls aXR5VUlFbGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1ZSgpIHdhcyBub3QgaW1wbGVtZW50ZWQu CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0 ay5jcHA6CisgICAgICAgIChjb3JlQXR0cmlidXRlVG9BdGtBdHRyaWJ1dGUpOiBOZXcgY29udmVu aWVuY2UgbWV0aG9kIHRvIGNvbnZlcnQgV2ViQ29yZSBhdHRyaWJ1dGUKKyAgICAgICAgbmFtZXMg aW50byBBdGtPYmplY3QgYXR0cmlidXRlIG5hbWVzCisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlF bGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1ZSk6IGltcGxlbWVudGVkCisKKzIwMTItMTItMDkg IEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIGFj Y2Vzc2liaWxpdHkvbGFiZWwtZm9yLWNvbnRyb2wtaGl0dGVzdC5odG1sIGlzIGZhaWxpbmcKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MzY4CiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 R3RrLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 R3RrLmNwcAppbmRleCBmYThkMzViOWJkNDdkZTI3NGZkZDk1YWY3MmE2MWFmYzVhM2MxNzVkLi5m NWI3OWI4Yzc0YTk0YmFiNWM5ZGFhMDUzNTQzMzQ3ZmViMGUxODA5IDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAKKysrIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCkBA IC0zNyw2ICszNywxOSBAQAogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogI2luY2x1 ZGUgPHd0Zi91bmljb2RlL0NoYXJhY3Rlck5hbWVzLmg+CiAKK3N0YXRpYyBpbmxpbmUgU3RyaW5n IGNvcmVBdHRyaWJ1dGVUb0F0a0F0dHJpYnV0ZShKU1N0cmluZ1JlZiBhdHRyaWJ1dGUpCit7Cisg ICAgc2l6ZV90IGJ1ZmZlclNpemUgPSBKU1N0cmluZ0dldE1heGltdW1VVEY4Q1N0cmluZ1NpemUo YXR0cmlidXRlKTsKKyAgICBHT3duUHRyPGdjaGFyPiBidWZmZXIoc3RhdGljX2Nhc3Q8Z2NoYXIq PihnX21hbGxvYyhidWZmZXJTaXplKSkpOworICAgIEpTU3RyaW5nR2V0VVRGOENTdHJpbmcoYXR0 cmlidXRlLCBidWZmZXIuZ2V0KCksIGJ1ZmZlclNpemUpOworCisgICAgU3RyaW5nIGF0dHJTdHJp bmcgPSBTdHJpbmc6OmZyb21VVEY4KGJ1ZmZlci5nZXQoKSk7CisgICAgaWYgKGF0dHJTdHJpbmcg PT0gIkFYUGxhY2Vob2xkZXJWYWx1ZSIpCisgICAgICAgIHJldHVybiAicGxhY2Vob2xkZXItdGV4 dCI7CisKKyAgICByZXR1cm4gIiI7Cit9CisKIHN0YXRpYyBpbmxpbmUgU3RyaW5nIHJvbGVUb1N0 cmluZyhBdGtSb2xlIHJvbGUpCiB7CiAgICAgc3dpdGNoIChyb2xlKSB7CkBAIC03NjQsNyArNzc3 LDE3IEBAIHZvaWQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c2V0U2VsZWN0ZWRUZXh0UmFuZ2Uo dW5zaWduZWQgbG9jYXRpb24sIHVuc2lnbmVkIGxlCiAKIEpTU3RyaW5nUmVmIEFjY2Vzc2liaWxp dHlVSUVsZW1lbnQ6OnN0cmluZ0F0dHJpYnV0ZVZhbHVlKEpTU3RyaW5nUmVmIGF0dHJpYnV0ZSkK IHsKLSAgICAvLyBGSVhNRTogaW1wbGVtZW50CisgICAgaWYgKCFtX2VsZW1lbnQpCisgICAgICAg IHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKDAsIDApOworCisgICAgU3RyaW5n IGF0a0F0dHJpYnV0ZU5hbWUgPSBjb3JlQXR0cmlidXRlVG9BdGtBdHRyaWJ1dGUoYXR0cmlidXRl KTsKKworICAgIGZvciAoR1NMaXN0KiBhdHRycyA9IGF0a19vYmplY3RfZ2V0X2F0dHJpYnV0ZXMo QVRLX09CSkVDVChtX2VsZW1lbnQpKTsgYXR0cnM7IGF0dHJzID0gYXR0cnMtPm5leHQpIHsKKyAg ICAgICAgQXRrQXR0cmlidXRlKiBhdHRyID0gc3RhdGljX2Nhc3Q8QXRrQXR0cmlidXRlKj4oYXR0 cnMtPmRhdGEpOworICAgICAgICBpZiAoIXN0cmNtcChhdHRyLT5uYW1lLCBhdGtBdHRyaWJ1dGVO YW1lLnV0ZjgoKS5kYXRhKCkpKQorICAgICAgICAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0 aFVURjhDU3RyaW5nKGF0dHItPnZhbHVlKTsKKyAgICB9CisKICAgICByZXR1cm4gSlNTdHJpbmdD cmVhdGVXaXRoQ2hhcmFjdGVycygwLCAwKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI1NzUwYTViZDQwOWNhNDYz OTdiNGJmOWNhNDMwMWYwZjBlNzcwNDMuLjY5NzEwM2NjZGUzMTVjZjA0NWZhZTQwMDE5OTVhZDNm MjNmNzExOWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMi0wOSAgSm9hbm1hcmllIERp Z2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gYWNjZXNzaWJpbGl0eS9w bGFjZWhvbGRlci5odG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk4MzczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIHRlc3Qgd2FzIGZhaWxpbmcgYmVjYXVzZSB0aGUgcGxhY2Vo b2xkZXIgdGV4dCB3YXMgbm90IHN1cHBvcnRlZCBhbmQKKyAgICAgICAgQWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6c3RyaW5nQXR0cmlidXRlVmFsdWUoKSB3YXMgbm90IGltcGxlbWVudGVkLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcCB0aGUgZmFpbGlu ZyB0ZXN0CisKIDIwMTItMTItMDkgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2VkIGdhcmRlbmluZy4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOTc5MDkxYWQ3MWM5MDIx Yzk2Mjg3MGYzMjhjODYyYjlmZmJhYmZjYi4uMzJiMDQ5ZDA5NWNmZjNhOTA3MzZiMmQwZWNiODFl OWRhMmIxZTBhMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTc1MSw3ICs3NTEsNiBAQCB3ZWJraXQub3JnL2IvOTgzNjkgYWNjZXNzaWJpbGl0eS9sYW5n dWFnZS1hdHRyaWJ1dGUuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk4MzcwIGFjY2Vz c2liaWxpdHkvbG9hZGluZy1pZnJhbWUtc2VuZHMtbm90aWZpY2F0aW9uLmh0bWwgWyBGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi85ODM3MSBhY2Nlc3NpYmlsaXR5L2xvYWRpbmctaWZyYW1lLXVwZGF0 ZXMtYXh0cmVlLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi85ODM3MiBhY2Nlc3NpYmls aXR5L29uY2xpY2staGFuZGxlcnMuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzk4Mzcz IGFjY2Vzc2liaWxpdHkvcGxhY2Vob2xkZXIuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9i Lzk4Mzc1IGFjY2Vzc2liaWxpdHkvc2VjdXJlLXRleHRmaWVsZC10aXRsZS11aS5odG1sIFsgRmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvOTgzNzYgYWNjZXNzaWJpbGl0eS9zZWxlY3Rpb24tc3RhdGVz Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMDExODUgYWNjZXNzaWJpbGl0eS9zdmct cmVtb3RlLWVsZW1lbnQuaHRtbCBbIEZhaWx1cmUgXQo= 178435 2012-12-09 12:43:22 -0800 2012-12-09 17:10:31 -0800 Patch bug-98373-20121209214044.patch text/plain 6401 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjYwMjgzMWMzMjk1MDdj NmYxNzYyNzIxNzk5ZGM1OTdmODlmZGY0MC4uZjVlYjkwNTc2NTI5YWVlOTc5MzEzNTUwZjBlNzM0 MTE0Y2I1MzZlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTA5ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBhY2Nlc3Np YmlsaXR5L3BsYWNlaG9sZGVyLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgzNzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCB3YXMgZmFpbGluZyBiZWNhdXNlIHRo ZSBwbGFjZWhvbGRlciB0ZXh0IHdhcyBub3Qgc3VwcG9ydGVkIGFuZAorICAgICAgICBBY2Nlc3Np YmlsaXR5VUlFbGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1ZSgpIHdhcyBub3QgaW1wbGVtZW50 ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyBpbnN0ZWFkIHRoZSBmYWlsaW5nIHRlc3Qgd2Fz IHVuc2tpcHBlZC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2li bGVXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKHdlYmtpdEFjY2Vzc2libGVHZXRBdHRyaWJ1dGVz KTogQWRkIHRoZSBwbGFjZWhvbGRlciB0ZXh0IGFzIGFuIEF0a0F0dHJpYnV0ZQorICAgICAgICBv ZiB0aGUgQXRrT2JqZWN0LCBhcyBpcyBkb25lIGluIEd0aysgMy4KKwogMjAxMi0xMi0wOSAgTGVv IFlhbmcgIDxsZW95YW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkYXB0IHRv IG5hbWUgY2hhbmdlIG9mIGNyZWF0ZU5ldHdvcmtCdWZmZXJCeUNvcHlpbmdEYXRhKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVX cmFwcGVyQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFj Y2Vzc2libGVXcmFwcGVyQXRrLmNwcAppbmRleCBkZWZkOWM1OWM1NWRlM2NiMmQ4OTJmMGFhNmJi MDIxYTgzYjM3YWYwLi42MTNhOWEyZDExMzY4NDFlZjYzNzdlNTdhYTNkMjg3MzY5MjU2NGNkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3Np YmxlV3JhcHBlckF0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsv V2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCkBAIC00NTUsNiArNDU1LDEwIEBAIHN0YXRp YyBBdGtBdHRyaWJ1dGVTZXQqIHdlYmtpdEFjY2Vzc2libGVHZXRBdHRyaWJ1dGVzKEF0a09iamVj dCogb2JqZWN0KQogICAgIGlmIChjb3JlT2JqZWN0LT5pc0FjY2Vzc2liaWxpdHlUYWJsZSgpICYm ICFjb3JlT2JqZWN0LT5pc0RhdGFUYWJsZSgpKQogICAgICAgICBhdHRyaWJ1dGVTZXQgPSBhZGRU b0F0a0F0dHJpYnV0ZVNldChhdHRyaWJ1dGVTZXQsICJsYXlvdXQtZ3Vlc3MiLCAidHJ1ZSIpOwog CisgICAgU3RyaW5nIHBsYWNlaG9sZGVyID0gY29yZU9iamVjdC0+cGxhY2Vob2xkZXJWYWx1ZSgp OworICAgIGlmICghcGxhY2Vob2xkZXIuaXNFbXB0eSgpKQorICAgICAgICBhdHRyaWJ1dGVTZXQg PSBhZGRUb0F0a0F0dHJpYnV0ZVNldChhdHRyaWJ1dGVTZXQsICJwbGFjZWhvbGRlci10ZXh0Iiwg cGxhY2Vob2xkZXIudXRmOCgpLmRhdGEoKSk7CisKICAgICByZXR1cm4gYXR0cmlidXRlU2V0Owog fQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg YWQzM2E5Yzc2NTE2ODBjZTcxYjE4OWIxMjBiYTgzMTM4MGM5YjM1My4uMjQ2NWI0YWZmOGI4NWZh Nzg1NDg4NTc4MzdlYjdiMzQ1MWE5ZWUzMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisr KyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTEyLTA5ICBKb2FubWFy aWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBhY2Nlc3NpYmls aXR5L3BsYWNlaG9sZGVyLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgzNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCB3YXMgZmFpbGluZyBiZWNhdXNlIHRoZSBw bGFjZWhvbGRlciB0ZXh0IHdhcyBub3Qgc3VwcG9ydGVkIGFuZAorICAgICAgICBBY2Nlc3NpYmls aXR5VUlFbGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1ZSgpIHdhcyBub3QgaW1wbGVtZW50ZWQu CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0 ay5jcHA6CisgICAgICAgIChjb3JlQXR0cmlidXRlVG9BdGtBdHRyaWJ1dGUpOiBOZXcgY29udmVu aWVuY2UgbWV0aG9kIHRvIGNvbnZlcnQgV2ViQ29yZSBhdHRyaWJ1dGUKKyAgICAgICAgbmFtZXMg aW50byBBdGtPYmplY3QgYXR0cmlidXRlIG5hbWVzCisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlF bGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1ZSk6IGltcGxlbWVudGVkCisKKzIwMTItMTItMDkg IEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIGFj Y2Vzc2liaWxpdHkvbGFiZWwtZm9yLWNvbnRyb2wtaGl0dGVzdC5odG1sIGlzIGZhaWxpbmcKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MzY4CiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 R3RrLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 R3RrLmNwcAppbmRleCBmYThkMzViOWJkNDdkZTI3NGZkZDk1YWY3MmE2MWFmYzVhM2MxNzVkLi4w N2I1N2Q4NGRkOGM0MzNjZjMxZGRiZTBjN2UyNTk5YWExMGZjNTU4IDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAKKysrIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCkBA IC0zNyw2ICszNywxOSBAQAogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogI2luY2x1 ZGUgPHd0Zi91bmljb2RlL0NoYXJhY3Rlck5hbWVzLmg+CiAKK3N0YXRpYyBTdHJpbmcgY29yZUF0 dHJpYnV0ZVRvQXRrQXR0cmlidXRlKEpTU3RyaW5nUmVmIGF0dHJpYnV0ZSkKK3sKKyAgICBzaXpl X3QgYnVmZmVyU2l6ZSA9IEpTU3RyaW5nR2V0TWF4aW11bVVURjhDU3RyaW5nU2l6ZShhdHRyaWJ1 dGUpOworICAgIEdPd25QdHI8Z2NoYXI+IGJ1ZmZlcihzdGF0aWNfY2FzdDxnY2hhcio+KGdfbWFs bG9jKGJ1ZmZlclNpemUpKSk7CisgICAgSlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhhdHRyaWJ1dGUs IGJ1ZmZlci5nZXQoKSwgYnVmZmVyU2l6ZSk7CisKKyAgICBTdHJpbmcgYXR0cmlidXRlU3RyaW5n ID0gU3RyaW5nOjpmcm9tVVRGOChidWZmZXIuZ2V0KCkpOworICAgIGlmIChhdHRyaWJ1dGVTdHJp bmcgPT0gIkFYUGxhY2Vob2xkZXJWYWx1ZSIpCisgICAgICAgIHJldHVybiAicGxhY2Vob2xkZXIt dGV4dCI7CisKKyAgICByZXR1cm4gIiI7Cit9CisKIHN0YXRpYyBpbmxpbmUgU3RyaW5nIHJvbGVU b1N0cmluZyhBdGtSb2xlIHJvbGUpCiB7CiAgICAgc3dpdGNoIChyb2xlKSB7CkBAIC03NjQsNyAr Nzc3LDE5IEBAIHZvaWQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c2V0U2VsZWN0ZWRUZXh0UmFu Z2UodW5zaWduZWQgbG9jYXRpb24sIHVuc2lnbmVkIGxlCiAKIEpTU3RyaW5nUmVmIEFjY2Vzc2li aWxpdHlVSUVsZW1lbnQ6OnN0cmluZ0F0dHJpYnV0ZVZhbHVlKEpTU3RyaW5nUmVmIGF0dHJpYnV0 ZSkKIHsKLSAgICAvLyBGSVhNRTogaW1wbGVtZW50CisgICAgaWYgKCFtX2VsZW1lbnQpCisgICAg ICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKDAsIDApOworCisgICAgU3Ry aW5nIGF0a0F0dHJpYnV0ZU5hbWUgPSBjb3JlQXR0cmlidXRlVG9BdGtBdHRyaWJ1dGUoYXR0cmli dXRlKTsKKyAgICBpZiAoYXRrQXR0cmlidXRlTmFtZS5pc0VtcHR5KCkpCisgICAgICAgIHJldHVy biBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKDAsIDApOworCisgICAgZm9yIChHU0xpc3Qq IGF0a0F0dHJpYnV0ZXMgPSBhdGtfb2JqZWN0X2dldF9hdHRyaWJ1dGVzKEFUS19PQkpFQ1QobV9l bGVtZW50KSk7IGF0a0F0dHJpYnV0ZXM7IGF0a0F0dHJpYnV0ZXMgPSBhdGtBdHRyaWJ1dGVzLT5u ZXh0KSB7CisgICAgICAgIEF0a0F0dHJpYnV0ZSogYXRrQXR0cmlidXRlID0gc3RhdGljX2Nhc3Q8 QXRrQXR0cmlidXRlKj4oYXRrQXR0cmlidXRlcy0+ZGF0YSk7CisgICAgICAgIGlmICghc3RyY21w KGF0a0F0dHJpYnV0ZS0+bmFtZSwgYXRrQXR0cmlidXRlTmFtZS51dGY4KCkuZGF0YSgpKSkKKyAg ICAgICAgICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhhdGtBdHRyaWJ1 dGUtPnZhbHVlKTsKKyAgICB9CisKICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFj dGVycygwLCAwKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI1NzUwYTViZDQwOWNhNDYzOTdiNGJmOWNhNDMwMWYw ZjBlNzcwNDMuLjY5NzEwM2NjZGUzMTVjZjA0NWZhZTQwMDE5OTVhZDNmMjNmNzExOWUgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMi0wOSAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gYWNjZXNzaWJpbGl0eS9wbGFjZWhvbGRlci5odG1s IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk4MzczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIHRlc3Qgd2FzIGZhaWxpbmcgYmVjYXVzZSB0aGUgcGxhY2Vob2xkZXIgdGV4dCB3YXMg bm90IHN1cHBvcnRlZCBhbmQKKyAgICAgICAgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c3RyaW5n QXR0cmlidXRlVmFsdWUoKSB3YXMgbm90IGltcGxlbWVudGVkLgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcCB0aGUgZmFpbGluZyB0ZXN0CisKIDIwMTIt MTItMDkgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW0Nocm9taXVtXSBVbnJldmlld2VkIGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOTc5MDkxYWQ3MWM5MDIxYzk2Mjg3MGYzMjhjODYy YjlmZmJhYmZjYi4uMzJiMDQ5ZDA5NWNmZjNhOTA3MzZiMmQwZWNiODFlOWRhMmIxZTBhMyAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTc1MSw3ICs3NTEs NiBAQCB3ZWJraXQub3JnL2IvOTgzNjkgYWNjZXNzaWJpbGl0eS9sYW5ndWFnZS1hdHRyaWJ1dGUu aHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk4MzcwIGFjY2Vzc2liaWxpdHkvbG9hZGlu Zy1pZnJhbWUtc2VuZHMtbm90aWZpY2F0aW9uLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcv Yi85ODM3MSBhY2Nlc3NpYmlsaXR5L2xvYWRpbmctaWZyYW1lLXVwZGF0ZXMtYXh0cmVlLmh0bWwg WyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi85ODM3MiBhY2Nlc3NpYmlsaXR5L29uY2xpY2staGFu ZGxlcnMuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzk4MzczIGFjY2Vzc2liaWxpdHkv cGxhY2Vob2xkZXIuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk4Mzc1IGFjY2Vzc2li aWxpdHkvc2VjdXJlLXRleHRmaWVsZC10aXRsZS11aS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvOTgzNzYgYWNjZXNzaWJpbGl0eS9zZWxlY3Rpb24tc3RhdGVzLmh0bWwgWyBGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi8xMDExODUgYWNjZXNzaWJpbGl0eS9zdmctcmVtb3RlLWVsZW1lbnQu aHRtbCBbIEZhaWx1cmUgXQo=