98287 2012-10-03 11:51:53 -0700 Crash when calling document.open during unload 2018-06-28 21:10:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=98345 P2 Normal --- 98345 1 abarth abarth eric fujii japhet ossy simonjam webkit.review.bot oldest_to_newest 733891 0 abarth 2012-10-03 11:51:53 -0700 Crash when calling document.open during unload 733893 1 166931 abarth 2012-10-03 11:53:53 -0700 Created attachment 166931 Patch 733897 2 166931 japhet 2012-10-03 11:56:44 -0700 Comment on attachment 166931 Patch Will this crash the current test or the next one without the patch? 733900 3 abarth 2012-10-03 12:06:59 -0700 > Will this crash the current test or the next one without the patch? The current one. 733902 4 166931 japhet 2012-10-03 12:08:55 -0700 Comment on attachment 166931 Patch Ok. I just get worried about unload events causing their failures too late. 733937 5 166931 webkit.review.bot 2012-10-03 12:34:21 -0700 Comment on attachment 166931 Patch Clearing flags on attachment: 166931 Committed r130313: <http://trac.webkit.org/changeset/130313> 733938 6 webkit.review.bot 2012-10-03 12:34:24 -0700 All reviewed patches have been landed. Closing bug. 734412 7 ossy 2012-10-04 00:07:06 -0700 (In reply to comment #5) > (From update of attachment 166931 [details]) > Clearing flags on attachment: 166931 > > Committed r130313: <http://trac.webkit.org/changeset/130313> It caused a crash on the Qt WK2 bot - https://bugs.webkit.org/show_bug.cgi?id=98345 Could you check it, please? 734442 8 abarth 2012-10-04 00:36:41 -0700 Sounds like this test uncovered an existing crash in WebKit2. There's no way this patch introduced the crash. (The patch is just a null check.) 166931 2012-10-03 11:53:53 -0700 2012-10-03 12:34:21 -0700 Patch bug-98287-20121003115304.patch text/plain 3390 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdhZDg2YjYxMjNjYWQz OGJjZDg5YTBmODBhOTVlNjc5ZDQxM2NiYi4uZmYzMDUwNTVjNWNhM2NiMmQ4YjdlOTQxOTc3NWMx ZjFjOTM0NTA0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTAzICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ3Jhc2ggd2hlbiBjYWxsaW5n IGRvY3VtZW50Lm9wZW4gZHVyaW5nIHVubG9hZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgyODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDYWxsaW5nIGRvY3VtZW50Lm9wZW4gcmVzdWx0cyBpbiB1cyBu dWxsaW5nIG91dCBtX2RvY3VtZW50TG9hZGVyLiBUaGlzCisgICAgICAgIGNvZGUgZG9lc24ndCBw cm9wZXJseSBoYW5kbGUgdGhhdCBjYXNlIGFuZCBjcmFzaGVzLgorCisgICAgICAgIFRlc3Q6IGZh c3QvcGFyc2VyL2RvY3VtZW50LW9wZW4taW4tdW5sb2FkLmh0bWwKKworICAgICAgICAqIGxvYWRl ci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y29tbWl0 UHJvdmlzaW9uYWxMb2FkKToKKwogMjAxMi0xMC0wMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSBtb3N0IEdyYXBoaWNzTGF5ZXI6OmNyZWF0 ZSBjYWxscyB0byB1c2UgdGhlIHZlcnNpb24gdGhhdCB0YWtlcyBhIEdyYXBoaWNzTGF5ZXJGYWN0 b3J5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCBkYjM5YjIxZjJkZGYz MGRjYWEzMDZmMzEyZDVhNWZiZmRhNmVlY2U2Li4xZDQ4NDA1ZTdjZjJjNmU5ODc2NGRiNDNiY2I0 NzdkOTEzMWI1OTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKQEAgLTE3 MTUsNyArMTcxNSw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNvbW1pdFByb3Zpc2lvbmFsTG9hZCgp CiAKICAgICB0cmFuc2l0aW9uVG9Db21taXR0ZWQoY2FjaGVkUGFnZSk7CiAKLSAgICBpZiAocGRs KSB7CisgICAgaWYgKHBkbCAmJiBtX2RvY3VtZW50TG9hZGVyKSB7CiAgICAgICAgIC8vIENoZWNr IGlmIHRoZSBkZXN0aW5hdGlvbiBwYWdlIGlzIGFsbG93ZWQgdG8gYWNjZXNzIHRoZSBwcmV2aW91 cyBwYWdlJ3MgdGltaW5nIGluZm9ybWF0aW9uLgogICAgICAgICBSZWZQdHI8U2VjdXJpdHlPcmln aW4+IHNlY3VyaXR5T3JpZ2luID0gU2VjdXJpdHlPcmlnaW46OmNyZWF0ZShwZGwtPnJlcXVlc3Qo KS51cmwoKSk7CiAgICAgICAgIG1fZG9jdW1lbnRMb2FkZXItPnRpbWluZygpLT5zZXRIYXNTYW1l T3JpZ2luQXNQcmV2aW91c0RvY3VtZW50KHNlY3VyaXR5T3JpZ2luLT5jYW5SZXF1ZXN0KG1fcHJl dmlvdXNVcmwpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA3NWFmZDUxM2EzOTM1ODc4YjQ0N2M0YjcwNDhiYjE2NzBlOGUz MWFjLi5lZmUwZWIwYWMzYzE0MTNlMWEyYmY0ZmQzZWYwNTBmNzNmNDcwMmJiIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTItMTAtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K KworICAgICAgICBDcmFzaCB3aGVuIGNhbGxpbmcgZG9jdW1lbnQub3BlbiBkdXJpbmcgdW5sb2Fk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODI4Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgdGhh dCB3ZSBkb24ndCBjcmFzaCB3aGVuIGNhbGxpbmcgZG9jdW1lbnQub3BlbiBkdXJpbmcgdGhlIHVu bG9hZCBldmVudC4KKworICAgICAgICAqIGZhc3QvcGFyc2VyL2RvY3VtZW50LW9wZW4taW4tdW5s b2FkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9wYXJzZXIvZG9jdW1lbnQt b3Blbi1pbi11bmxvYWQuaHRtbDogQWRkZWQuCisKIDIwMTItMTAtMDMgIFJhcGhhZWwgS3VibyBk YSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAgICAgW0VG TF0gUGl4ZWwgdGVzdCByZWJhc2VsaW5lcyB0byBlbmFibGUgcGl4ZWwgdGVzdGluZyBvbiB0aGUg Ym90cywgcGFydCAzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvZG9jdW1l bnQtb3Blbi1pbi11bmxvYWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIv ZG9jdW1lbnQtb3Blbi1pbi11bmxvYWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIzYjJiNDY2 NGJhMmFhYTYxN2EyOTczMjFmM2VhNDE1NDYyN2I5MjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L3BhcnNlci9kb2N1bWVudC1vcGVuLWluLXVubG9hZC1leHBlY3RlZC50eHQK QEAgLTAsMCArMSBAQAorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoLiAKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2RvY3VtZW50LW9wZW4taW4tdW5sb2Fk Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9kb2N1bWVudC1vcGVuLWluLXVubG9hZC5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjQ3MWYxNjMxNTVlZDkzNDNiYjQ1ODk4MTkzYjdlNDYxYjFlOTFjNTgK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9kb2N1bWVudC1vcGVu LWluLXVubG9hZC5odG1sCkBAIC0wLDAgKzEsMTAgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgaXQg ZG9lc24ndCBjcmFzaC4KKzxpZnJhbWUgc3JjPSJkYXRhOnRleHQvcGxhaW4sSGkiPjwvaWZyYW1l PgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBB c1RleHQoKTsKKworZnJhbWVzWzBdLm9udW5sb2FkID0gZnVuY3Rpb24gKCkgeworICAgIGRvY3Vt ZW50Lm9wZW4oKTsKK307Cis8L3NjcmlwdD4K