98236 2012-10-03 00:17:58 -0700 Array.splice should be fast when it is used to remove elements other than the very first 2012-10-03 13:03:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 97288 1 fpizlo fpizlo barraclough fpizlo ggaren mark.lam mhahnenberg msaboff oliver oldest_to_newest 733402 0 fpizlo 2012-10-03 00:17:58 -0700 Patch forthcoming. 733403 1 166817 fpizlo 2012-10-03 00:25:38 -0700 Created attachment 166817 the patch 733959 2 fpizlo 2012-10-03 13:03:30 -0700 Landed in http://trac.webkit.org/changeset/130315 166817 2012-10-03 00:25:38 -0700 2012-10-03 08:25:46 -0700 the patch splice.patch text/plain 4631 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwMjU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSArMSwxOSBAQAor MjAxMi0xMC0wMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAgIEFy cmF5LnNwbGljZSBzaG91bGQgYmUgZmFzdCB3aGVuIGl0IGlzIHVzZWQgdG8gcmVtb3ZlIGVsZW1l bnRzIG90aGVyIHRoYW4gdGhlIHZlcnkgZmlyc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQXBwbGllZCB0aGUgc2FtZSB0ZWNobmlxdWUgdGhhdCB3YXMg dXNlZCB0byBvcHRpbWl6ZSB0aGUgdW5zaGlmdCBjYXNlIG9mIHNwbGljZSBpbgorICAgICAgICBo dHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMjk2NzYuICBUaGlzIGlzIGEgPjIweCBz cGVlZC11cCBvbiBwcm9ncmFtcyB0aGF0CisgICAgICAgIHVzZSBzcGxpY2UgZm9yIGVsZW1lbnQg cmVtb3ZhbC4KKworICAgICAgICAqIHJ1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwOgorICAgICAg ICAoSlNDOjpzaGlmdCk6CisgICAgICAgICogcnVudGltZS9KU0FycmF5LmNwcDoKKyAgICAgICAg KEpTQzo6SlNBcnJheTo6c2hpZnRDb3VudCk6CisgICAgICAgICogcnVudGltZS9KU0FycmF5Lmg6 CisgICAgICAgIChKU0FycmF5KToKKwogPT0gUm9sbGVkIG92ZXIgdG8gQ2hhbmdlTG9nLTIwMTIt MTAtMDIgPT0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90 eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJh eVByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDEzMDEyNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAyLDkgKzIw Miw5IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBzaGlmdChFeGVjU3RhdGUqIGV4ZWMKICAgICBBU1NF UlQoaGVhZGVyIDw9IGxlbmd0aCk7CiAgICAgQVNTRVJUKGN1cnJlbnRDb3VudCA8PSAobGVuZ3Ro IC0gaGVhZGVyKSk7CiAKLSAgICBpZiAoIWhlYWRlciAmJiBpc0pTQXJyYXkodGhpc09iaikpIHsK KyAgICBpZiAoaXNKU0FycmF5KHRoaXNPYmopKSB7CiAgICAgICAgIEpTQXJyYXkqIGFycmF5ID0g YXNBcnJheSh0aGlzT2JqKTsKLSAgICAgICAgaWYgKGFycmF5LT5sZW5ndGgoKSA9PSBsZW5ndGgg JiYgYXNBcnJheSh0aGlzT2JqKS0+c2hpZnRDb3VudChleGVjLCBjb3VudCkpCisgICAgICAgIGlm IChhcnJheS0+bGVuZ3RoKCkgPT0gbGVuZ3RoICYmIGFzQXJyYXkodGhpc09iaiktPnNoaWZ0Q291 bnQoZXhlYywgaGVhZGVyLCBjb3VudCkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgfQogCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkocmV2aXNpb24g MTMwMTI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTUwNSw3ICs1MDUsNyBAQCB2b2lkIEpTQXJyYXk6OnB1c2goRXhlY1N0 YXRlKiBleGVjLCBKU1ZhCiAgICAgfQogfQogCi1ib29sIEpTQXJyYXk6OnNoaWZ0Q291bnQoRXhl Y1N0YXRlKiBleGVjLCB1bnNpZ25lZCBjb3VudCkKK2Jvb2wgSlNBcnJheTo6c2hpZnRDb3VudChF eGVjU3RhdGUqIGV4ZWMsIHVuc2lnbmVkIHN0YXJ0SW5kZXgsIHVuc2lnbmVkIGNvdW50KQogewog ICAgIEFTU0VSVChjb3VudCA+IDApOwogICAgIApAQCAtNTIyLDIwICs1MjIsNDQgQEAgYm9vbCBK U0FycmF5OjpzaGlmdENvdW50KEV4ZWNTdGF0ZSogZXhlYwogICAgIGlmICghb2xkTGVuZ3RoKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAKKyAgICB1bnNpZ25lZCBsZW5ndGggPSBvbGRMZW5n dGggLSBjb3VudDsKKyAgICAKICAgICBzdG9yYWdlLT5tX251bVZhbHVlc0luVmVjdG9yIC09IGNv dW50OwotICAgIHN0b3JhZ2UtPnNldExlbmd0aChvbGRMZW5ndGggLSBjb3VudCk7CisgICAgc3Rv cmFnZS0+c2V0TGVuZ3RoKGxlbmd0aCk7CiAgICAgCiAgICAgdW5zaWduZWQgdmVjdG9yTGVuZ3Ro ID0gc3RvcmFnZS0+dmVjdG9yTGVuZ3RoKCk7CisgICAgaWYgKCF2ZWN0b3JMZW5ndGgpCisgICAg ICAgIHJldHVybiB0cnVlOworICAgIAorICAgIGlmIChzdGFydEluZGV4ID49IHZlY3Rvckxlbmd0 aCkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgCisgICAgaWYgKHN0YXJ0SW5kZXggKyBjb3Vu dCA+IHZlY3Rvckxlbmd0aCkKKyAgICAgICAgY291bnQgPSB2ZWN0b3JMZW5ndGggLSBzdGFydElu ZGV4OworICAgIAorICAgIHVuc2lnbmVkIHVzZWRWZWN0b3JMZW5ndGggPSBtaW4odmVjdG9yTGVu Z3RoLCBvbGRMZW5ndGgpOworICAgIAorICAgIHZlY3Rvckxlbmd0aCAtPSBjb3VudDsKKyAgICBz dG9yYWdlLT5zZXRWZWN0b3JMZW5ndGgodmVjdG9yTGVuZ3RoKTsKKyAgICAKICAgICBpZiAodmVj dG9yTGVuZ3RoKSB7Ci0gICAgICAgIGNvdW50ID0gbWluKHZlY3Rvckxlbmd0aCwgKHVuc2lnbmVk KWNvdW50KTsKLSAgICAgICAgCi0gICAgICAgIHZlY3Rvckxlbmd0aCAtPSBjb3VudDsKLSAgICAg ICAgc3RvcmFnZS0+c2V0VmVjdG9yTGVuZ3RoKHZlY3Rvckxlbmd0aCk7Ci0gICAgICAgIAotICAg ICAgICBpZiAodmVjdG9yTGVuZ3RoKSB7CisgICAgICAgIGlmIChzdGFydEluZGV4IDwgdXNlZFZl Y3Rvckxlbmd0aCAtIChzdGFydEluZGV4ICsgY291bnQpKSB7CisgICAgICAgICAgICBpZiAoc3Rh cnRJbmRleCkgeworICAgICAgICAgICAgICAgIG1lbW1vdmUoCisgICAgICAgICAgICAgICAgICAg IHN0b3JhZ2UtPm1fdmVjdG9yICsgY291bnQsCisgICAgICAgICAgICAgICAgICAgIHN0b3JhZ2Ut Pm1fdmVjdG9yLAorICAgICAgICAgICAgICAgICAgICBzaXplb2YoSlNWYWx1ZSkgKiBzdGFydElu ZGV4KTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIG1fYnV0dGVyZmx5ID0gbV9idXR0ZXJm bHktPnNoaWZ0KHN0cnVjdHVyZSgpLCBjb3VudCk7CiAgICAgICAgICAgICBzdG9yYWdlID0gbV9i dXR0ZXJmbHktPmFycmF5U3RvcmFnZSgpOwogICAgICAgICAgICAgc3RvcmFnZS0+bV9pbmRleEJp YXMgKz0gY291bnQ7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBtZW1tb3ZlKAorICAg ICAgICAgICAgICAgIHN0b3JhZ2UtPm1fdmVjdG9yICsgc3RhcnRJbmRleCwKKyAgICAgICAgICAg ICAgICBzdG9yYWdlLT5tX3ZlY3RvciArIHN0YXJ0SW5kZXggKyBjb3VudCwKKyAgICAgICAgICAg ICAgICBzaXplb2YoSlNWYWx1ZSkgKiAodXNlZFZlY3Rvckxlbmd0aCAtIChzdGFydEluZGV4ICsg Y291bnQpKSk7CisgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSB1c2VkVmVjdG9yTGVuZ3Ro IC0gY291bnQ7IGkgPCB1c2VkVmVjdG9yTGVuZ3RoOyArK2kpCisgICAgICAgICAgICAgICAgc3Rv cmFnZS0+bV92ZWN0b3JbaV0uY2xlYXIoKTsKICAgICAgICAgfQogICAgIH0KICAgICByZXR1cm4g dHJ1ZTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgJKHJldmlz aW9uIDEzMDEyNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuaAko d29ya2luZyBjb3B5KQpAQCAtNzEsOCArNzEsOCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAg dm9pZCBwdXNoKEV4ZWNTdGF0ZSosIEpTVmFsdWUpOwogICAgICAgICBKU1ZhbHVlIHBvcChFeGVj U3RhdGUqKTsKIAotICAgICAgICBib29sIHNoaWZ0Q291bnQoRXhlY1N0YXRlKiwgdW5zaWduZWQg Y291bnQpOwotICAgICAgICBib29sIHVuc2hpZnRDb3VudChFeGVjU3RhdGUqLCB1bnNpZ25lZCwg dW5zaWduZWQpOworICAgICAgICBib29sIHNoaWZ0Q291bnQoRXhlY1N0YXRlKiwgdW5zaWduZWQg c3RhcnRJbmRleCwgdW5zaWduZWQgY291bnQpOworICAgICAgICBib29sIHVuc2hpZnRDb3VudChF eGVjU3RhdGUqLCB1bnNpZ25lZCBzdGFydEluZGV4LCB1bnNpZ25lZCBjb3VudCk7CiAKICAgICAg ICAgdm9pZCBmaWxsQXJnTGlzdChFeGVjU3RhdGUqLCBNYXJrZWRBcmd1bWVudEJ1ZmZlciYpOwog ICAgICAgICB2b2lkIGNvcHlUb0FyZ3VtZW50cyhFeGVjU3RhdGUqLCBDYWxsRnJhbWUqLCB1aW50 MzJfdCBsZW5ndGgpOwo=