<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98234</bug_id>
          
          <creation_ts>2012-10-02 23:14:54 -0700</creation_ts>
          <short_desc>HTMLFormElement::m_elementAliases might cause a leak</short_desc>
          <delta_ts>2017-06-16 19:12:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="WebKit Review Bot">webkit.review.bot</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>abarth</cc>
    
    <cc>deepak.deepakmittal</cc>
    
    <cc>joepeck</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>733378</commentid>
    <comment_count>0</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-02 23:14:54 -0700</bug_when>
    <thetext>HTMLFormElement::m_elementAliases might cause a leak
Requested by abarth on #webkit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733381</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-10-02 23:16:50 -0700</bug_when>
    <thetext>From inspecting the code, it looks like the following will cause HTMLFormElement::m_elementAliases to hold a RefPtr to a parent of the form element.

1) Get a form element by name (so that the form element is stored in m_elementAliases).
2) Reparent the &lt;form&gt; under that element

Note: I haven&apos;t actually tested this issue.

It likely can be fixed by clearing m_elementAliases when HTMLFormElement is moved.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733382</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-10-02 23:19:56 -0700</bug_when>
    <thetext>11:15 PM &lt;othermaciej&gt; There&apos;s also I think an attribute to explicitly make a form association, rather than implicitly; not sure if that could also cause the problem
11:15 PM &lt;othermaciej&gt; the form=&quot;&quot; attribute
11:16 PM &lt;othermaciej&gt; it looks like &lt;object&gt; will respect the form=&quot;&quot; attribute in our implementation, which may be a bug
11:17 PM &lt;othermaciej&gt; nope, correct per spec
11:17 PM &lt;othermaciej&gt; an &lt;object&gt;, &lt;textarea&gt; or &lt;select&gt; could be the ancestor of its associated form just in markup, w/o reparenting</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733383</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-10-02 23:20:45 -0700</bug_when>
    <thetext>11:19 PM &lt;othermaciej&gt; oh, I guess &lt;object&gt; is not an HTMLFormConrolElement so can&apos;t be in the alias map</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>974913</commentid>
    <comment_count>4</comment_count>
    <who name="Deepak Mittal">deepak.deepakmittal</who>
    <bug_when>2014-02-02 21:04:56 -0800</bug_when>
    <thetext>I am not able to find m_elementAliases in HTMLFormElement.cpp/h files, I think the code has been changed the issue has been filed..

please check the issue on the latest code..so that we can work on this or close this issue..

Deepak Mittal</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1320296</commentid>
    <comment_count>5</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2017-06-16 19:12:03 -0700</bug_when>
    <thetext>Yep, this member no longer exists. Closing.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>