<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98228</bug_id>
          
          <creation_ts>2012-10-02 20:51:12 -0700</creation_ts>
          <short_desc>Refactoring: DateTimeEditBuilder had better hold LayoutParameters</short_desc>
          <delta_ts>2012-10-02 21:30:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Forms</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>98227</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kent Tamura">tkent</reporter>
          <assigned_to name="Kent Tamura">tkent</assigned_to>
          <cc>haraken</cc>
    
    <cc>yutak</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>733338</commentid>
    <comment_count>0</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-10-02 20:51:12 -0700</bug_when>
    <thetext>Refactoring: DateTimeEditBuilder had better hold LayoutParameters</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733340</commentid>
    <comment_count>1</comment_count>
      <attachid>166803</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-10-02 21:05:28 -0700</bug_when>
    <thetext>Created attachment 166803
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733342</commentid>
    <comment_count>2</comment_count>
      <attachid>166803</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-02 21:11:31 -0700</bug_when>
    <thetext>Comment on attachment 166803
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166803&amp;action=review

Looks OK.

&gt; Source/WebCore/ChangeLog:9
&gt; +        constructor. This change improves code size and runtime cost.

This change increases the size of a DateTimeEditBuilder object. I don&apos;t think this is a big deal, but please just keep it in mind:

Before:
const StepRange m_stepRange;
Localizer&amp; m_localizer;
const String m_placeholderForDay;
const String m_placeholderForMonth;
const String m_placeholderForYear;

After:
String dateTimeFormat;
String fallbackDateTimeFormat;
Localizer&amp; localizer;
const StepRange stepRange;
String placeholderForMonth;
String placeholderForYear;

&gt; Source/WebCore/ChangeLog:19
&gt; +        Add m_parmaeters.

Typo: m_parmaeters</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733344</commentid>
    <comment_count>3</comment_count>
      <attachid>166803</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-10-02 21:18:13 -0700</bug_when>
    <thetext>Comment on attachment 166803
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166803&amp;action=review

&gt;&gt; Source/WebCore/ChangeLog:9
&gt;&gt; +        constructor. This change improves code size and runtime cost.
&gt; 
&gt; This change increases the size of a DateTimeEditBuilder object. I don&apos;t think this is a big deal, but please just keep it in mind:
&gt; 
&gt; Before:
&gt; const StepRange m_stepRange;
&gt; Localizer&amp; m_localizer;
&gt; const String m_placeholderForDay;
&gt; const String m_placeholderForMonth;
&gt; const String m_placeholderForYear;
&gt; 
&gt; After:
&gt; String dateTimeFormat;
&gt; String fallbackDateTimeFormat;
&gt; Localizer&amp; localizer;
&gt; const StepRange stepRange;
&gt; String placeholderForMonth;
&gt; String placeholderForYear;

No. m_parameters is a const reference, which is equivalent to one pointer internally.

&gt;&gt; Source/WebCore/ChangeLog:19
&gt;&gt; +        Add m_parmaeters.
&gt; 
&gt; Typo: m_parmaeters

oops. will fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733345</commentid>
    <comment_count>4</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-02 21:19:27 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 166803 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=166803&amp;action=review
&gt; 
&gt; No. m_parameters is a const reference, which is equivalent to one pointer internally.

Ah, got it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733348</commentid>
    <comment_count>5</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-10-02 21:30:24 -0700</bug_when>
    <thetext>Committed r130246: &lt;http://trac.webkit.org/changeset/130246&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166803</attachid>
            <date>2012-10-02 21:05:28 -0700</date>
            <delta_ts>2012-10-02 21:18:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-98228-20121003130440.patch</filename>
            <type>text/plain</type>
            <size>7463</size>
            <attacher name="Kent Tamura">tkent</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU0ZmE5NjQ4ZTFiYTYx
NjRhYmM1YTgxMDdkNzlmMTVkMzExODU5Zi4uNmU0NTgzMThkZjA4OWQ0ODhlODU1ODQ0MThjNjI2
M2Q2NWYyN2NiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEyLTEwLTAzICBLZW50
IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWZhY3RvcmluZzogRGF0
ZVRpbWVFZGl0QnVpbGRlciBoYWQgYmV0dGVyIGhvbGQgTGF5b3V0UGFyYW1ldGVycworICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgyMjgKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdG9wIGNvcHlpbmcgbXVs
dGlwbGUgbWVtYmVycyBvZiBMYXlvdXRQYXJhbWV0ZXJzIGluIERhdGVUaW1lRWRpdEJ1aWxkZXIK
KyAgICAgICAgY29uc3RydWN0b3IuIFRoaXMgY2hhbmdlIGltcHJvdmVzIGNvZGUgc2l6ZSBhbmQg
cnVudGltZSBjb3N0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBkb2Vzbid0IGNoYW5n
ZSB1c2VyLXZpc2libGUgYmVoYXZpb3IuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9EYXRlVGlt
ZUVkaXRFbGVtZW50LmNwcDoKKyAgICAgICAgKERhdGVUaW1lRWRpdEJ1aWxkZXIpOiBBZGQgYSBj
b21tZW50IGFib3V0IGxpZmV0aW1lIG9mIG9iamVjdHMuCisgICAgICAgIChXZWJDb3JlOjpEYXRl
VGltZUVkaXRCdWlsZGVyOjpzdGVwUmFuZ2UpOgorICAgICAgICBBZGRlZC4gQSBoZWxwZXIgdG8g
YWNjZXNzIG1fcGFyYW1ldGVycy5zdGVwUmFuZ2UuCisgICAgICAgIChXZWJDb3JlOjpEYXRlVGlt
ZUVkaXRCdWlsZGVyOjpEYXRlVGltZUVkaXRCdWlsZGVyKToKKyAgICAgICAgUmVtb3ZlIG1fc3Rl
cFJhbmdlLCBtX2xvY2FsaXplciwgbV9wbGFjZWhvbGRlckZvciogbWVtYmVycy4KKyAgICAgICAg
QWRkIG1fcGFybWFldGVycy4KKyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1lRWRpdEJ1aWxkZXI6
Om5lZWRNaWxsaXNlY29uZEZpZWxkKToKKyAgICAgICAgVXNlIHN0ZXBSYW5nZSgpIGluc3RlYWQg
b2YgbV9zdGVwUmFuZ2UuCisgICAgICAgIChXZWJDb3JlOjpEYXRlVGltZUVkaXRCdWlsZGVyOjp2
aXNpdEZpZWxkKToKKyAgICAgICAgVXNlIG1fcGFyYW1ldGVycy5wbGFjZWhvbGRlckZvciouCisg
ICAgICAgIChXZWJDb3JlOjpEYXRlVGltZUVkaXRCdWlsZGVyOjpzaG91bGRNaWxsaXNlY29uZEZp
ZWxkUmVhZE9ubHkpOgorICAgICAgICBVc2Ugc3RlcFJhbmdlKCkgaW5zdGVhZCBvZiBtX3N0ZXBS
YW5nZS4KKyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1lRWRpdEJ1aWxkZXI6OnNob3VsZE1pbnV0
ZUZpZWxkUmVhZE9ubHkpOiBkaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1lRWRpdEJ1
aWxkZXI6OnNob3VsZFNlY29uZEZpZWxkUmVhZE9ubHkpOiBkaXR0by4KKwogMjAxMi0xMC0wMiAg
S2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IExv
Y2FsZUlDVTo6ZGF0ZUZvcm1hdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFk
b3cvRGF0ZVRpbWVFZGl0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9E
YXRlVGltZUVkaXRFbGVtZW50LmNwcAppbmRleCBhZTdhYTJjNjY1MTg2NTVmOTBiOGY2ZWRjZTUz
Yzc3NDViYzRlMzlmLi5jNDYyZTI2ZTQ3MGU3NWE0ZDNlNTgxMzcwODNhYzc3ZTQ3NmZiOGUyIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZUVkaXRFbGVtZW50
LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZUVkaXRFbGVtZW50
LmNwcApAQCAtNDksNiArNDksNyBAQCBjbGFzcyBEYXRlVGltZUVkaXRCdWlsZGVyIDogcHJpdmF0
ZSBEYXRlVGltZUZvcm1hdDo6VG9rZW5IYW5kbGVyIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJM
RShEYXRlVGltZUVkaXRCdWlsZGVyKTsKIAogcHVibGljOgorICAgIC8vIFRoZSBhcmd1bWVudCBv
YmplY3RzIG11c3QgYmUgYWxpdmUgdW50aWwgdGhpcyBvYmplY3QgZGllcy4KICAgICBEYXRlVGlt
ZUVkaXRCdWlsZGVyKERhdGVUaW1lRWRpdEVsZW1lbnQmLCBjb25zdCBEYXRlVGltZUVkaXRFbGVt
ZW50OjpMYXlvdXRQYXJhbWV0ZXJzJiwgY29uc3QgRGF0ZUNvbXBvbmVudHMmKTsKIAogICAgIGJv
b2wgYnVpbGQoY29uc3QgU3RyaW5nJik7CkBAIC01OCw2ICs1OSw3IEBAIHByaXZhdGU6CiAgICAg
Ym9vbCBzaG91bGRNaWxsaXNlY29uZEZpZWxkUmVhZE9ubHkoKSBjb25zdDsKICAgICBib29sIHNo
b3VsZE1pbnV0ZUZpZWxkUmVhZE9ubHkoKSBjb25zdDsKICAgICBib29sIHNob3VsZFNlY29uZEZp
ZWxkUmVhZE9ubHkoKSBjb25zdDsKKyAgICBpbmxpbmUgY29uc3QgU3RlcFJhbmdlJiBzdGVwUmFu
Z2UoKSBjb25zdCB7IHJldHVybiBtX3BhcmFtZXRlcnMuc3RlcFJhbmdlOyB9CiAKICAgICAvLyBE
YXRlVGltZUZvcm1hdDo6VG9rZW5IYW5kbGVyIGZ1bmN0aW9ucy4KICAgICB2aXJ0dWFsIHZvaWQg
dmlzaXRGaWVsZChEYXRlVGltZUZvcm1hdDo6RmllbGRUeXBlLCBpbnQpIE9WRVJSSURFIEZJTkFM
OwpAQCAtNjUsMjEgKzY3LDEzIEBAIHByaXZhdGU6CiAKICAgICBEYXRlVGltZUVkaXRFbGVtZW50
JiBtX2VkaXRFbGVtZW50OwogICAgIGNvbnN0IERhdGVDb21wb25lbnRzIG1fZGF0ZVZhbHVlOwot
ICAgIGNvbnN0IFN0ZXBSYW5nZSBtX3N0ZXBSYW5nZTsKLSAgICBMb2NhbGl6ZXImIG1fbG9jYWxp
emVyOwotICAgIGNvbnN0IFN0cmluZyBtX3BsYWNlaG9sZGVyRm9yRGF5OwotICAgIGNvbnN0IFN0
cmluZyBtX3BsYWNlaG9sZGVyRm9yTW9udGg7Ci0gICAgY29uc3QgU3RyaW5nIG1fcGxhY2Vob2xk
ZXJGb3JZZWFyOworICAgIGNvbnN0IERhdGVUaW1lRWRpdEVsZW1lbnQ6OkxheW91dFBhcmFtZXRl
cnMmIG1fcGFyYW1ldGVyczsKIH07CiAKIERhdGVUaW1lRWRpdEJ1aWxkZXI6OkRhdGVUaW1lRWRp
dEJ1aWxkZXIoRGF0ZVRpbWVFZGl0RWxlbWVudCYgZWxlbW50LCBjb25zdCBEYXRlVGltZUVkaXRF
bGVtZW50OjpMYXlvdXRQYXJhbWV0ZXJzJiBsYXlvdXRQYXJhbWV0ZXJzLCBjb25zdCBEYXRlQ29t
cG9uZW50cyYgZGF0ZVZhbHVlKQogICAgIDogbV9lZGl0RWxlbWVudChlbGVtbnQpCiAgICAgLCBt
X2RhdGVWYWx1ZShkYXRlVmFsdWUpCi0gICAgLCBtX3N0ZXBSYW5nZShsYXlvdXRQYXJhbWV0ZXJz
LnN0ZXBSYW5nZSkKLSAgICAsIG1fbG9jYWxpemVyKGxheW91dFBhcmFtZXRlcnMubG9jYWxpemVy
KQotICAgICwgbV9wbGFjZWhvbGRlckZvckRheShsYXlvdXRQYXJhbWV0ZXJzLnBsYWNlaG9sZGVy
Rm9yRGF5KQotICAgICwgbV9wbGFjZWhvbGRlckZvck1vbnRoKGxheW91dFBhcmFtZXRlcnMucGxh
Y2Vob2xkZXJGb3JNb250aCkKLSAgICAsIG1fcGxhY2Vob2xkZXJGb3JZZWFyKGxheW91dFBhcmFt
ZXRlcnMucGxhY2Vob2xkZXJGb3JZZWFyKQorICAgICwgbV9wYXJhbWV0ZXJzKGxheW91dFBhcmFt
ZXRlcnMpCiB7CiB9CiAKQEAgLTkyLDggKzg2LDggQEAgYm9vbCBEYXRlVGltZUVkaXRCdWlsZGVy
OjpidWlsZChjb25zdCBTdHJpbmcmIGZvcm1hdFN0cmluZykKIGJvb2wgRGF0ZVRpbWVFZGl0QnVp
bGRlcjo6bmVlZE1pbGxpc2Vjb25kRmllbGQoKSBjb25zdAogewogICAgIHJldHVybiBtX2RhdGVW
YWx1ZS5taWxsaXNlY29uZCgpCi0gICAgICAgIHx8ICFtX3N0ZXBSYW5nZS5taW5pbXVtKCkucmVt
YWluZGVyKHN0YXRpY19jYXN0PGludD4obXNQZXJTZWNvbmQpKS5pc1plcm8oKQotICAgICAgICB8
fCAhbV9zdGVwUmFuZ2Uuc3RlcCgpLnJlbWFpbmRlcihzdGF0aWNfY2FzdDxpbnQ+KG1zUGVyU2Vj
b25kKSkuaXNaZXJvKCk7CisgICAgICAgIHx8ICFzdGVwUmFuZ2UoKS5taW5pbXVtKCkucmVtYWlu
ZGVyKHN0YXRpY19jYXN0PGludD4obXNQZXJTZWNvbmQpKS5pc1plcm8oKQorICAgICAgICB8fCAh
c3RlcFJhbmdlKCkuc3RlcCgpLnJlbWFpbmRlcihzdGF0aWNfY2FzdDxpbnQ+KG1zUGVyU2Vjb25k
KSkuaXNaZXJvKCk7CiB9CiAKIHZvaWQgRGF0ZVRpbWVFZGl0QnVpbGRlcjo6dmlzaXRGaWVsZChE
YXRlVGltZUZvcm1hdDo6RmllbGRUeXBlIGZpZWxkVHlwZSwgaW50KQpAQCAtMTAyLDcgKzk2LDcg
QEAgdm9pZCBEYXRlVGltZUVkaXRCdWlsZGVyOjp2aXNpdEZpZWxkKERhdGVUaW1lRm9ybWF0OjpG
aWVsZFR5cGUgZmllbGRUeXBlLCBpbnQpCiAKICAgICBzd2l0Y2ggKGZpZWxkVHlwZSkgewogICAg
IGNhc2UgRGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZURheU9mTW9udGg6Ci0gICAgICAgIG1fZWRp
dEVsZW1lbnQuYWRkRmllbGQoRGF0ZVRpbWVEYXlGaWVsZEVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVu
dCwgbV9lZGl0RWxlbWVudCwgbV9wbGFjZWhvbGRlckZvckRheSkpOworICAgICAgICBtX2VkaXRF
bGVtZW50LmFkZEZpZWxkKERhdGVUaW1lRGF5RmllbGRFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQs
IG1fZWRpdEVsZW1lbnQsIG1fcGFyYW1ldGVycy5wbGFjZWhvbGRlckZvckRheSkpOwogICAgICAg
ICByZXR1cm47CiAKICAgICBjYXNlIERhdGVUaW1lRm9ybWF0OjpGaWVsZFR5cGVIb3VyMTE6CkBA
IC0xMzEsMTEgKzEyNSwxMSBAQCB2b2lkIERhdGVUaW1lRWRpdEJ1aWxkZXI6OnZpc2l0RmllbGQo
RGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZSBmaWVsZFR5cGUsIGludCkKIAogICAgIGNhc2UgRGF0
ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZU1vbnRoOgogICAgICAgICAvLyBXZSBhbHdheXMgdXNlICJN
TSIsIHR3byBkaWdpdHMgbW9udGgsIGV2ZW4gaWYgIk0iLCAiTU1NIiwgIk1NTU0iLCBvciAiTU1N
TU0iLgotICAgICAgICBtX2VkaXRFbGVtZW50LmFkZEZpZWxkKERhdGVUaW1lTW9udGhGaWVsZEVs
ZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCwgbV9lZGl0RWxlbWVudCwgbV9wbGFjZWhvbGRlckZvck1v
bnRoKSk7CisgICAgICAgIG1fZWRpdEVsZW1lbnQuYWRkRmllbGQoRGF0ZVRpbWVNb250aEZpZWxk
RWxlbWVudDo6Y3JlYXRlKGRvY3VtZW50LCBtX2VkaXRFbGVtZW50LCBtX3BhcmFtZXRlcnMucGxh
Y2Vob2xkZXJGb3JNb250aCkpOwogICAgICAgICByZXR1cm47CiAKICAgICBjYXNlIERhdGVUaW1l
Rm9ybWF0OjpGaWVsZFR5cGVQZXJpb2Q6Ci0gICAgICAgIG1fZWRpdEVsZW1lbnQuYWRkRmllbGQo
RGF0ZVRpbWVBTVBNRmllbGRFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQsIG1fZWRpdEVsZW1lbnQs
IG1fbG9jYWxpemVyLnRpbWVBTVBNTGFiZWxzKCkpKTsKKyAgICAgICAgbV9lZGl0RWxlbWVudC5h
ZGRGaWVsZChEYXRlVGltZUFNUE1GaWVsZEVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCwgbV9lZGl0
RWxlbWVudCwgbV9wYXJhbWV0ZXJzLmxvY2FsaXplci50aW1lQU1QTUxhYmVscygpKSk7CiAgICAg
ICAgIHJldHVybjsKIAogICAgIGNhc2UgRGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZVNlY29uZDog
ewpAQCAtMTQ1LDcgKzEzOSw3IEBAIHZvaWQgRGF0ZVRpbWVFZGl0QnVpbGRlcjo6dmlzaXRGaWVs
ZChEYXRlVGltZUZvcm1hdDo6RmllbGRUeXBlIGZpZWxkVHlwZSwgaW50KQogICAgICAgICAgICAg
ZmllbGQtPnNldFJlYWRPbmx5KCk7CiAKICAgICAgICAgaWYgKG5lZWRNaWxsaXNlY29uZEZpZWxk
KCkpIHsKLSAgICAgICAgICAgIHZpc2l0TGl0ZXJhbChtX2xvY2FsaXplci5sb2NhbGl6ZWREZWNp
bWFsU2VwYXJhdG9yKCkpOworICAgICAgICAgICAgdmlzaXRMaXRlcmFsKG1fcGFyYW1ldGVycy5s
b2NhbGl6ZXIubG9jYWxpemVkRGVjaW1hbFNlcGFyYXRvcigpKTsKICAgICAgICAgICAgIHZpc2l0
RmllbGQoRGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZUZyYWN0aW9uYWxTZWNvbmQsIDMpOwogICAg
ICAgICB9CiAgICAgICAgIHJldHVybjsKQEAgLTE2NCw3ICsxNTgsNyBAQCB2b2lkIERhdGVUaW1l
RWRpdEJ1aWxkZXI6OnZpc2l0RmllbGQoRGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZSBmaWVsZFR5
cGUsIGludCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgY2FzZSBEYXRlVGltZUZvcm1hdDo6Rmll
bGRUeXBlWWVhcjoKLSAgICAgICAgbV9lZGl0RWxlbWVudC5hZGRGaWVsZChEYXRlVGltZVllYXJG
aWVsZEVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCwgbV9lZGl0RWxlbWVudCwgbV9wbGFjZWhvbGRl
ckZvclllYXIpKTsKKyAgICAgICAgbV9lZGl0RWxlbWVudC5hZGRGaWVsZChEYXRlVGltZVllYXJG
aWVsZEVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCwgbV9lZGl0RWxlbWVudCwgbV9wYXJhbWV0ZXJz
LnBsYWNlaG9sZGVyRm9yWWVhcikpOwogICAgICAgICByZXR1cm47CiAKICAgICBkZWZhdWx0OgpA
QCAtMTc0LDE3ICsxNjgsMTcgQEAgdm9pZCBEYXRlVGltZUVkaXRCdWlsZGVyOjp2aXNpdEZpZWxk
KERhdGVUaW1lRm9ybWF0OjpGaWVsZFR5cGUgZmllbGRUeXBlLCBpbnQpCiAKIGJvb2wgRGF0ZVRp
bWVFZGl0QnVpbGRlcjo6c2hvdWxkTWlsbGlzZWNvbmRGaWVsZFJlYWRPbmx5KCkgY29uc3QKIHsK
LSAgICByZXR1cm4gIW1fZGF0ZVZhbHVlLm1pbGxpc2Vjb25kKCkgJiYgbV9zdGVwUmFuZ2Uuc3Rl
cCgpLnJlbWFpbmRlcihzdGF0aWNfY2FzdDxpbnQ+KG1zUGVyU2Vjb25kKSkuaXNaZXJvKCk7Cisg
ICAgcmV0dXJuICFtX2RhdGVWYWx1ZS5taWxsaXNlY29uZCgpICYmIHN0ZXBSYW5nZSgpLnN0ZXAo
KS5yZW1haW5kZXIoc3RhdGljX2Nhc3Q8aW50Pihtc1BlclNlY29uZCkpLmlzWmVybygpOwogfQog
CiBib29sIERhdGVUaW1lRWRpdEJ1aWxkZXI6OnNob3VsZE1pbnV0ZUZpZWxkUmVhZE9ubHkoKSBj
b25zdAogewotICAgIHJldHVybiAhbV9kYXRlVmFsdWUubWludXRlKCkgJiYgbV9zdGVwUmFuZ2Uu
c3RlcCgpLnJlbWFpbmRlcihzdGF0aWNfY2FzdDxpbnQ+KG1zUGVySG91cikpLmlzWmVybygpOwor
ICAgIHJldHVybiAhbV9kYXRlVmFsdWUubWludXRlKCkgJiYgc3RlcFJhbmdlKCkuc3RlcCgpLnJl
bWFpbmRlcihzdGF0aWNfY2FzdDxpbnQ+KG1zUGVySG91cikpLmlzWmVybygpOwogfQogCiBib29s
IERhdGVUaW1lRWRpdEJ1aWxkZXI6OnNob3VsZFNlY29uZEZpZWxkUmVhZE9ubHkoKSBjb25zdAog
ewotICAgIHJldHVybiAhbV9kYXRlVmFsdWUuc2Vjb25kKCkgJiYgbV9zdGVwUmFuZ2Uuc3RlcCgp
LnJlbWFpbmRlcihzdGF0aWNfY2FzdDxpbnQ+KG1zUGVyTWludXRlKSkuaXNaZXJvKCk7CisgICAg
cmV0dXJuICFtX2RhdGVWYWx1ZS5zZWNvbmQoKSAmJiBzdGVwUmFuZ2UoKS5zdGVwKCkucmVtYWlu
ZGVyKHN0YXRpY19jYXN0PGludD4obXNQZXJNaW51dGUpKS5pc1plcm8oKTsKIH0KIAogdm9pZCBE
YXRlVGltZUVkaXRCdWlsZGVyOjp2aXNpdExpdGVyYWwoY29uc3QgU3RyaW5nJiB0ZXh0KQo=
</data>
<flag name="review"
          id="179263"
          type_id="1"
          status="+"
          setter="haraken"
    />
          </attachment>
      

    </bug>

</bugzilla>