98162 2012-10-02 08:16:38 -0700 [EFL] Use XvfbDriver for layout tests 2012-10-02 22:38:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88414 98231 1 cdumez cdumez abarth dpranke d-r gyuyoung.kim kenneth laszlo.gombos ojan ossy webkit.review.bot oldest_to_newest 732660 0 cdumez 2012-10-02 08:16:38 -0700 We should use XvfbDriver for layout tests so that tests that requires a running X server can be unskipped on the build bots. 732673 1 166692 cdumez 2012-10-02 08:43:00 -0700 Created attachment 166692 Patch 732689 2 cdumez 2012-10-02 09:07:39 -0700 xvfb is now installed on both Intel build bots. I added xvfb dependency to: https://trac.webkit.org/wiki/WebKitEFLLayoutTest 732719 3 laszlo.gombos 2012-10-02 09:33:47 -0700 (In reply to comment #2) > xvfb is now installed on both Intel build bots. Is there an expectation on the xvfb version ? Predictability and consistent environment for LayoutTests are very important (and using xvfb should help with that). IMHO we should recommend the xvfb version that runs on the buildbot. Would that be v2.1.11+ ? 732722 4 cdumez 2012-10-02 09:36:01 -0700 (In reply to comment #3) > (In reply to comment #2) > > xvfb is now installed on both Intel build bots. > > Is there an expectation on the xvfb version ? Predictability and consistent environment for LayoutTests are very important (and using xvfb should help with that). > > IMHO we should recommend the xvfb version that runs on the buildbot. Would that be v2.1.11+ ? The build bots are running Ubuntu 12.04 so they have xfvb v1.11.4, yes. 732817 5 166692 webkit.review.bot 2012-10-02 10:53:25 -0700 Comment on attachment 166692 Patch Clearing flags on attachment: 166692 Committed r130186: <http://trac.webkit.org/changeset/130186> 732818 6 webkit.review.bot 2012-10-02 10:53:30 -0700 All reviewed patches have been landed. Closing bug. 166692 2012-10-02 08:43:00 -0700 2012-10-02 10:53:25 -0700 Patch 98162_xvfbdriver.patch text/plain 2823 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhODAz ZDY1Li41MmEzYzdhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMDIgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBVc2UgWHZmYkRyaXZl ciBmb3IgbGF5b3V0IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05ODE2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVzZSBYdmZiRHJpdmVyIGZvciBsYXlvdXQgdGVzdHMgb24gRUZMIHBvcnQuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weToKKyAg ICAgICAgKEVmbFBvcnQuX2RyaXZlcl9jbGFzcyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC94dmZiZHJpdmVyLnB5OgorICAgICAgICAoWHZmYkRyaXZlci5f c3RhcnQpOiBTZXQgRFVNUFJFTkRFUlRSRUVfVEVNUCBhbmQgTE9DQUxfUkVTT1VSQ0VfUk9PVAor ICAgICAgICBlbnZpcm9ubWVudCB2YXJpYWJsZXMgaW4gWHZmYkRyaXZlciBhcyB0aG9zZSBhcmUg bmVlZGVkIGZvcgorICAgICAgICBUZXN0UnVubmVyOjpwYXRoVG9Mb2NhbFJlc291cmNlKCkuCisK IDIwMTItMTAtMDIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAg ICAgICBbV0syXSBSRUdSRVNTSU9OKHIxMjg2MjMpOiBJdCBtYWRlIGxheW91dCB0ZXN0cyBleHRy ZW1lbHkgc2xvdwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9lZmwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2VmbC5weQppbmRleCAxNWFmNDYwLi5hNGYxYjk2IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weQpAQCAtMzIsNyArMzIsNyBAQCBpbXBvcnQg b3MKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLm1vZGVscy50ZXN0X2NvbmZpZ3VyYXRpb24g aW1wb3J0IFRlc3RDb25maWd1cmF0aW9uCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0 LmJhc2UgaW1wb3J0IFBvcnQKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQucHVsc2Vh dWRpb19zYW5pdGl6ZXIgaW1wb3J0IFB1bHNlQXVkaW9TYW5pdGl6ZXIKLQorZnJvbSB3ZWJraXRw eS5sYXlvdXRfdGVzdHMucG9ydC54dmZiZHJpdmVyIGltcG9ydCBYdmZiRHJpdmVyCiAKIGNsYXNz IEVmbFBvcnQoUG9ydCwgUHVsc2VBdWRpb1Nhbml0aXplcik6CiAgICAgcG9ydF9uYW1lID0gJ2Vm bCcKQEAgLTgwLDYgKzgwLDkgQEAgY2xhc3MgRWZsUG9ydChQb3J0LCBQdWxzZUF1ZGlvU2FuaXRp emVyKToKICAgICBkZWYgX2dlbmVyYXRlX2FsbF90ZXN0X2NvbmZpZ3VyYXRpb25zKHNlbGYpOgog ICAgICAgICByZXR1cm4gW1Rlc3RDb25maWd1cmF0aW9uKHZlcnNpb249c2VsZi5fdmVyc2lvbiwg YXJjaGl0ZWN0dXJlPSd4ODYnLCBidWlsZF90eXBlPWJ1aWxkX3R5cGUpIGZvciBidWlsZF90eXBl IGluIHNlbGYuQUxMX0JVSUxEX1RZUEVTXQogCisgICAgZGVmIF9kcml2ZXJfY2xhc3Moc2VsZik6 CisgICAgICAgIHJldHVybiBYdmZiRHJpdmVyCisKICAgICBkZWYgX3BhdGhfdG9fZHJpdmVyKHNl bGYpOgogICAgICAgICByZXR1cm4gc2VsZi5fYnVpbGRfcGF0aCgnYmluJywgc2VsZi5kcml2ZXJf bmFtZSgpKQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3h2ZmJkcml2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3h2ZmJkcml2ZXIucHkKaW5kZXggM2U0MjhjMS4uMDY2YjZjMiAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC94dmZiZHJpdmVyLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQveHZmYmRyaXZlci5w eQpAQCAtNzMsNiArNzMsOSBAQCBjbGFzcyBYdmZiRHJpdmVyKERyaXZlcik6CiAgICAgICAgIGVu dmlyb25tZW50WydESVNQTEFZJ10gPSAiOiVkIiAlIGRpc3BsYXlfaWQKICAgICAgICAgIyBEcml2 ZXJzIHNob3VsZCB1c2Ugc2VwYXJhdGUgYXBwbGljYXRpb24gY2FjaGUgbG9jYXRpb25zCiAgICAg ICAgIGVudmlyb25tZW50WydYREdfQ0FDSEVfSE9NRSddID0gc2VsZi5fcG9ydC5ob3N0LmZpbGVz eXN0ZW0uam9pbihzZWxmLl9wb3J0LnJlc3VsdHNfZGlyZWN0b3J5KCksICclcy1hcHBjYWNoZS0l ZCcgJSAoc2VydmVyX25hbWUsIHNlbGYuX3dvcmtlcl9udW1iZXIpKQorICAgICAgICBzZWxmLl9k cml2ZXJfdGVtcGRpciA9IHNlbGYuX3BvcnQuX2ZpbGVzeXN0ZW0ubWtkdGVtcChwcmVmaXg9JyVz LScgJSBzZWxmLl9wb3J0LmRyaXZlcl9uYW1lKCkpCisgICAgICAgIGVudmlyb25tZW50WydEVU1Q UkVOREVSVFJFRV9URU1QJ10gPSBzdHIoc2VsZi5fZHJpdmVyX3RlbXBkaXIpCisgICAgICAgIGVu dmlyb25tZW50WydMT0NBTF9SRVNPVVJDRV9ST09UJ10gPSBzZWxmLl9wb3J0LmxheW91dF90ZXN0 c19kaXIoKQogCiAgICAgICAgIHNlbGYuX2NyYXNoZWRfcHJvY2Vzc19uYW1lID0gTm9uZQogICAg ICAgICBzZWxmLl9jcmFzaGVkX3BpZCA9IE5vbmUK