98118 2012-10-01 22:54:32 -0700 Implement LocaleICU::dateFormat 2012-10-02 18:38:16 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98109 97997 1 tkent tkent morrita webkit.review.bot oldest_to_newest 732288 0 tkent 2012-10-01 22:54:32 -0700 Implement LocaleICU::dateFormat 732359 1 166625 tkent 2012-10-02 00:11:46 -0700 Created attachment 166625 Patch 732373 2 166625 tkent 2012-10-02 00:32:02 -0700 Comment on attachment 166625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166625&action=review > Source/WebCore/platform/text/LocaleICU.cpp:419 > + return ASCIILiteral("dd/mm/yyyyy"); Oops, mm -> MM 732432 3 166645 tkent 2012-10-02 01:58:17 -0700 Created attachment 166645 Patch 2 mm -> MM. yyyyy -> yyyy 733307 4 166645 webkit.review.bot 2012-10-02 18:38:13 -0700 Comment on attachment 166645 Patch 2 Clearing flags on attachment: 166645 Committed r130244: <http://trac.webkit.org/changeset/130244> 733308 5 webkit.review.bot 2012-10-02 18:38:16 -0700 All reviewed patches have been landed. Closing bug. 166625 2012-10-02 00:11:46 -0700 2012-10-02 01:58:14 -0700 Patch bug-98118-20121002161058.patch text/plain 2478 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDJkYjAzYWYzZmFjNGVk MDIyYWQ0YWU4NGExYzNlNjA5MjY4OWVhNS4uNjZiMWIxMDAwNjliNmE0NzRiY2ViNDQyMDg4ZDhm YThiNjMwYzJmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTAyICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1lbnQgTG9jYWxl SUNVOjpkYXRlRm9ybWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05ODExOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMDEyNyBpbnRyb2R1Y2Vk CisgICAgICAgIExvY2FsaXplcjo6ZGF0ZUZvcm1hdCwgYW5kIHRoaXMgaXMgaXRzIGltcGxlbWVu dGF0aW9uIGZvciBMb2NhbGVJQ1UKKyAgICAgICAgY2xhc3NzLiBUaGUgY29kZSBpcyBnb2luZyB0 byBiZSB1c2VkIHdoZW4KKyAgICAgICAgRU5BQkxFX0lOUFVUX01VTFRJUExFX0ZJRUxEU19VSSBp cyBlbmFibGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhlIGZ1bmN0aW9uIGlzIG5vdCB1 c2VkIHlldC4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxvY2FsZUlDVTo6ZGF0ZUZvcm1hdCk6CisgICAgICAgIEltcGxlbWVudGVk LiBOb3RlIHRoYXQgbV9zaG9ydERhdGVGb3JtYXQgaXMgYSBVRGF0ZUZvcm1hdCBvYmplY3QsIHdo aWNoCisgICAgICAgIGtub3dzIHZhcmlvdXMgZm9ybWF0IGluZm9ybWF0aW9uLgorICAgICAgICAq IHBsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmg6CisgICAgICAgIChMb2NhbGVJQ1UpOiBBZGQgbV9k YXRlRm9ybWF0IHRvIGNhY2hlIHRoZSBmb3JtYXQgc3RyaW5nLgorCiAyMDEyLTEwLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkaW5nIExvY2Fs aXplcjo6ZGF0ZUZvcm1hdCgpIGZvciBtdWx0aXBsZSBmaWVsZHMgZGF0ZS9kYXRldGltZSBpbnB1 dCBVSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuY3BwCmluZGV4IGUw ZWQxNmViMjQ4NzA2MTdjMzYyYmFmZmYyMmY4ZjhjYjU4NmRiNWQuLjI2NDI2OWU2Zjc4N2VmZjBk Nzg5ZjA1YWRmNGYzY2ZjMTY4MDliMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvTG9jYWxlSUNVLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L0xvY2FsZUlDVS5jcHAKQEAgLTQxMyw4ICs0MTMsMTIgQEAgdm9pZCBMb2NhbGVJQ1U6OmluaXRp YWxpemVEYXRlVGltZUZvcm1hdCgpCiAKIFN0cmluZyBMb2NhbGVJQ1U6OmRhdGVGb3JtYXQoKQog ewotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgaGF2ZSByZWFsIGltcGxlbWVudGF0aW9uIG9mIExv Y2FsZUlDVTo6ZGF0ZUZvcm1hdCgpLgotICAgIHJldHVybiBlbXB0eVN0cmluZygpOworICAgIGlm ICghbV9kYXRlRm9ybWF0LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIG1fZGF0ZUZvcm1hdDsK KyAgICBpZiAoIWluaXRpYWxpemVTaG9ydERhdGVGb3JtYXQoKSkKKyAgICAgICAgcmV0dXJuIEFT Q0lJTGl0ZXJhbCgiZGQvbW0veXl5eXkiKTsKKyAgICBtX2RhdGVGb3JtYXQgPSBnZXREYXRlRm9y bWF0UGF0dGVybihtX3Nob3J0RGF0ZUZvcm1hdCk7CisgICAgcmV0dXJuIG1fZGF0ZUZvcm1hdDsK IH0KIAogU3RyaW5nIExvY2FsZUlDVTo6dGltZUZvcm1hdCgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9Mb2NhbGVJQ1UuaAppbmRleCAyNTY1NDhjYmE3ZGQxZGZlMjE5NzdjNjE3Mzg3MjY0 N2U2N2U5Zjg3Li42OWYzZDY1MmVhYTcxZjFhOWZiZDkzMGFkYzRhMmU0MWYwNWJjOWVmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmgKQEAgLTEwOCw2ICsxMDgsNyBA QCBwcml2YXRlOgogI2VuZGlmCiAKICNpZiBFTkFCTEUoSU5QVVRfTVVMVElQTEVfRklFTERTX1VJ KQorICAgIFN0cmluZyBtX2RhdGVGb3JtYXQ7CiAgICAgVURhdGVGb3JtYXQqIG1fbWVkaXVtVGlt ZUZvcm1hdDsKICAgICBVRGF0ZUZvcm1hdCogbV9zaG9ydFRpbWVGb3JtYXQ7CiAgICAgVmVjdG9y PFN0cmluZz4gbV90aW1lQU1QTUxhYmVsczsK 166645 2012-10-02 01:58:17 -0700 2012-10-02 18:38:13 -0700 Patch 2 bug-98118-20121002175730.patch text/plain 2477 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDJkYjAzYWYzZmFjNGVk MDIyYWQ0YWU4NGExYzNlNjA5MjY4OWVhNS4uNjZiMWIxMDAwNjliNmE0NzRiY2ViNDQyMDg4ZDhm YThiNjMwYzJmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTAyICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1lbnQgTG9jYWxl SUNVOjpkYXRlRm9ybWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05ODExOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMDEyNyBpbnRyb2R1Y2Vk CisgICAgICAgIExvY2FsaXplcjo6ZGF0ZUZvcm1hdCwgYW5kIHRoaXMgaXMgaXRzIGltcGxlbWVu dGF0aW9uIGZvciBMb2NhbGVJQ1UKKyAgICAgICAgY2xhc3NzLiBUaGUgY29kZSBpcyBnb2luZyB0 byBiZSB1c2VkIHdoZW4KKyAgICAgICAgRU5BQkxFX0lOUFVUX01VTFRJUExFX0ZJRUxEU19VSSBp cyBlbmFibGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhlIGZ1bmN0aW9uIGlzIG5vdCB1 c2VkIHlldC4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxvY2FsZUlDVTo6ZGF0ZUZvcm1hdCk6CisgICAgICAgIEltcGxlbWVudGVk LiBOb3RlIHRoYXQgbV9zaG9ydERhdGVGb3JtYXQgaXMgYSBVRGF0ZUZvcm1hdCBvYmplY3QsIHdo aWNoCisgICAgICAgIGtub3dzIHZhcmlvdXMgZm9ybWF0IGluZm9ybWF0aW9uLgorICAgICAgICAq IHBsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmg6CisgICAgICAgIChMb2NhbGVJQ1UpOiBBZGQgbV9k YXRlRm9ybWF0IHRvIGNhY2hlIHRoZSBmb3JtYXQgc3RyaW5nLgorCiAyMDEyLTEwLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkaW5nIExvY2Fs aXplcjo6ZGF0ZUZvcm1hdCgpIGZvciBtdWx0aXBsZSBmaWVsZHMgZGF0ZS9kYXRldGltZSBpbnB1 dCBVSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuY3BwCmluZGV4IGUw ZWQxNmViMjQ4NzA2MTdjMzYyYmFmZmYyMmY4ZjhjYjU4NmRiNWQuLjQ4ZmMxNTMwN2Y3NjYyZjVh ZGEwMGI0Yzk1YjY2ODY0OGNmY2MwOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvTG9jYWxlSUNVLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L0xvY2FsZUlDVS5jcHAKQEAgLTQxMyw4ICs0MTMsMTIgQEAgdm9pZCBMb2NhbGVJQ1U6OmluaXRp YWxpemVEYXRlVGltZUZvcm1hdCgpCiAKIFN0cmluZyBMb2NhbGVJQ1U6OmRhdGVGb3JtYXQoKQog ewotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgaGF2ZSByZWFsIGltcGxlbWVudGF0aW9uIG9mIExv Y2FsZUlDVTo6ZGF0ZUZvcm1hdCgpLgotICAgIHJldHVybiBlbXB0eVN0cmluZygpOworICAgIGlm ICghbV9kYXRlRm9ybWF0LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIG1fZGF0ZUZvcm1hdDsK KyAgICBpZiAoIWluaXRpYWxpemVTaG9ydERhdGVGb3JtYXQoKSkKKyAgICAgICAgcmV0dXJuIEFT Q0lJTGl0ZXJhbCgiZGQvTU0veXl5eSIpOworICAgIG1fZGF0ZUZvcm1hdCA9IGdldERhdGVGb3Jt YXRQYXR0ZXJuKG1fc2hvcnREYXRlRm9ybWF0KTsKKyAgICByZXR1cm4gbV9kYXRlRm9ybWF0Owog fQogCiBTdHJpbmcgTG9jYWxlSUNVOjp0aW1lRm9ybWF0KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS90ZXh0L0xvY2FsZUlDVS5oCmluZGV4IDI1NjU0OGNiYTdkZDFkZmUyMTk3N2M2MTczODcyNjQ3 ZTY3ZTlmODcuLjY5ZjNkNjUyZWFhNzFmMWE5ZmJkOTMwYWRjNGEyZTQxZjA1YmM5ZWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuaApAQCAtMTA4LDYgKzEwOCw3IEBA IHByaXZhdGU6CiAjZW5kaWYKIAogI2lmIEVOQUJMRShJTlBVVF9NVUxUSVBMRV9GSUVMRFNfVUkp CisgICAgU3RyaW5nIG1fZGF0ZUZvcm1hdDsKICAgICBVRGF0ZUZvcm1hdCogbV9tZWRpdW1UaW1l Rm9ybWF0OwogICAgIFVEYXRlRm9ybWF0KiBtX3Nob3J0VGltZUZvcm1hdDsKICAgICBWZWN0b3I8 U3RyaW5nPiBtX3RpbWVBTVBNTGFiZWxzOwo=