98104 2012-10-01 19:01:43 -0700 Week specifiers defined in DateTimeFormat class are wrong. 2012-10-02 19:03:23 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97877 98120 1 yosin yosin caseq mifenton ojan tkent webkit.review.bot oldest_to_newest 732213 0 yosin 2012-10-01 19:01:43 -0700 Week of year and week of month must be: week of year = 'w' (lower case'w') week of month = 'W' (upper case 'W') 732218 1 166591 yosin 2012-10-01 19:29:51 -0700 Created attachment 166591 Patch 1 732219 2 166591 yosin 2012-10-01 19:30:40 -0700 Comment on attachment 166591 Patch 1 Could you review this patch? Thanks in advance. 732230 3 166591 tkent 2012-10-01 20:21:46 -0700 Comment on attachment 166591 Patch 1 ok 732246 4 166591 yosin 2012-10-01 21:22:38 -0700 Comment on attachment 166591 Patch 1 Clearing flags on attachment: 166591 Committed r130116: <http://trac.webkit.org/changeset/130116> 732247 5 yosin 2012-10-01 21:22:42 -0700 All reviewed patches have been landed. Closing bug. 732305 6 ojan 2012-10-01 23:16:30 -0700 This caused two webkit_unit_test failures. Maybe the tests need updating? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=DateTimeFormatTest.SingleUpperCaseCharacter%2CDateTimeFormatTest.SingleLowerCaseCharacter 732310 7 yosin 2012-10-01 23:20:01 -0700 (In reply to comment #6) > This caused two webkit_unit_test failures. Maybe the tests need updating? > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=DateTimeFormatTest.SingleUpperCaseCharacter%2CDateTimeFormatTest.SingleLowerCaseCharacter Yes, I field a bug 98120, for updating tests. 732711 8 166591 darin 2012-10-02 09:22:40 -0700 Comment on attachment 166591 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=166591&action=review > Source/WebCore/ChangeLog:12 > + No new tests. Following existing tests cover this change: Why no new tests? Is this really not a testable change? 733318 9 yosin 2012-10-02 19:03:23 -0700 (In reply to comment #8) > (From update of attachment 166591 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166591&action=review > > > Source/WebCore/ChangeLog:12 > > + No new tests. Following existing tests cover this change: > > Why no new tests? Is this really not a testable change? This is testable change. There are layoyut tests listed in ChangeLog and webkit_unit_tests, sorry I forgot to include this in this patch, in bug 98120. 166591 2012-10-01 19:29:51 -0700 2012-10-02 09:22:40 -0700 Patch 1 bug-98104-20121002112904.patch text/plain 4241 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQ5NDI1ZTY4OWY2N2Yw ZTdlNDVhYWU0ZWFlNzFkYzYxMWQyNGFlZC4uNTM4ZmI5ODdjMjFkMGQ3Y2JlYTdkNjQ4OTUzZjUx NWMwNzNjM2YwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEwLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2VlayBzcGVjaWZp ZXJzIGRlZmluZWQgaW4gRGF0ZVRpbWVGb3JtYXQgY2xhc3MgYXJlIHdyb25nLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgxMDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMg d2VlayBvZiB5ZWFyIGFuZCB3ZWVrIG9mIG1vbnRoIGZvcm1hdCBzcGVjaWZpZXJzCisgICAgICAg IGRlZmluZWQgaW4gRGF0ZVRpbWVGb3JtYXQgY2xhc3MgdG8gbWF0Y2ggd2l0aCBVbmljb2RlIHRl Y2huaWNhbAorICAgICAgICBzdGFuZGFyZCAzNSwgTERNTCwgTG9jYWxlIERhdGEgTWFya3VwIExh bmd1YWdlLCAoaHR0cDovL3d3dy51bmljb2RlLm9yZy9yZXBvcnRzL3RyMzUvKS4KKworICAgICAg ICBObyBuZXcgdGVzdHMuIEZvbGxvd2luZyBleGlzdGluZyB0ZXN0cyBjb3ZlciB0aGlzIGNoYW5n ZToKKyAgICAgICAgICAtIGZhc3QvZm9ybXMvbW9udGgtbXVsdGlwbGUtZmllbGRzL21vbnRoLW11 bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLWJhc2ljLmh0bWwKKyAgICAgICAgICAtIGZhc3QvZm9y bXMvbW9udGgtbXVsdGlwbGUtZmllbGRzL21vbnRoLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNl LXBzZXVkby1jbGFzc2VzLmh0bWwKKyAgICAgICAgICAtIGZhc3QvZm9ybXMvbW9udGgtbXVsdGlw bGUtZmllbGRzL21vbnRoLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLXBzZXVkby1lbGVtZW50 cy5odG1sCisgICAgICAgICAgLSBmYXN0L2Zvcm1zL21vbnRoLW11bHRpcGxlLWZpZWxkcy9tb250 aC1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS1zdHlsZS5odG1sCisKKyAgICAgICAgKiBodG1s L1dlZWtJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2Vla0lucHV0VHlwZTo6c2V0 dXBMYXlvdXRQYXJhbWV0ZXJzKTogQ2hhbmdlZCB0byB1c2UgJ3cnIGluc3RlYWQgb2YgJ1cnLgor ICAgICAgICAqIHBsYXRmb3JtL3RleHQvRGF0ZVRpbWVGb3JtYXQuY3BwOiBDaGFuZ2VkIGVsZW1l bnRzIGluIGxvd2VyQ2FzZVRvRmllbGRUeXBlTWFwIGFuZCB1cHBlckNhc2VUb0ZpZWxkVHlwZU1h cC4KKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L0RhdGVUaW1lRm9ybWF0Lmg6IENoYW5nZWQgRmll bGRUeXBlV2Vla09mTW9udGggdG8gJ1cnIGFuZCBGaWVsZFR5cGVXZWVrT2ZZZWFyIHRvICd3Jy4K KwogMjAxMi0xMC0wMSAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IGZsZXhib3ggZG9lcyB3cm9uZyBiYXNlbGluZSBpdGVtIGFsaWdubWVudCBpbiBjb2x1bW5zCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1dlZWtJbnB1dFR5cGUuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9XZWVrSW5wdXRUeXBlLmNwcAppbmRleCBlNGZlYWQwNmU4MWJlNDc5NWNk NTIwMmU4NzIwNDAwY2MwOTRhNTJiLi42Y2FlODdmNGMwNjlhYmIzZjlkNzM4ZDBkOTk5ZDkxMjEw ZTJhYTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1dlZWtJbnB1dFR5cGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvV2Vla0lucHV0VHlwZS5jcHAKQEAgLTEwOSw3ICsx MDksNyBAQCBTdHJpbmcgV2Vla0lucHV0VHlwZTo6Zm9ybWF0RGF0ZVRpbWVGaWVsZHNTdGF0ZShj b25zdCBEYXRlVGltZUZpZWxkc1N0YXRlJiBkYXRlVAogdm9pZCBXZWVrSW5wdXRUeXBlOjpzZXR1 cExheW91dFBhcmFtZXRlcnMoRGF0ZVRpbWVFZGl0RWxlbWVudDo6TGF5b3V0UGFyYW1ldGVycyYg bGF5b3V0UGFyYW1ldGVycywgY29uc3QgRGF0ZUNvbXBvbmVudHMmKSBjb25zdAogewogICAgIGxh eW91dFBhcmFtZXRlcnMuZGF0ZVRpbWVGb3JtYXQgPSB3ZWVrRm9ybWF0SW5MRE1MKCk7Ci0gICAg bGF5b3V0UGFyYW1ldGVycy5mYWxsYmFja0RhdGVUaW1lRm9ybWF0ID0gIidXZWVrJyBXVy15eXl5 IjsKKyAgICBsYXlvdXRQYXJhbWV0ZXJzLmZhbGxiYWNrRGF0ZVRpbWVGb3JtYXQgPSAiJ1dlZWsn IHd3LXl5eXkiOwogICAgIGxheW91dFBhcmFtZXRlcnMucGxhY2Vob2xkZXJGb3JZZWFyID0gIi0t LS0iOwogfQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L0RhdGVUaW1lRm9ybWF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvRGF0ZVRp bWVGb3JtYXQuY3BwCmluZGV4IGQ0ZTUwMzVjM2FhYjFkOGRiZTQwYzg5YWVlZTI3NmIwMTlkMWE4 ZTYuLjJiMWMyOGM2OGE5MjJhZTZmYTliNjQxMjc4Y2VkOTM5OTQ3YmFhYzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvRGF0ZVRpbWVGb3JtYXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvRGF0ZVRpbWVGb3JtYXQuY3BwCkBAIC01NSw3ICs1 NSw3IEBAIHN0YXRpYyBjb25zdCBEYXRlVGltZUZvcm1hdDo6RmllbGRUeXBlIGxvd2VyQ2FzZVRv RmllbGRUeXBlTWFwWzI2XSA9IHsKICAgICBEYXRlVGltZUZvcm1hdDo6RmllbGRUeXBlSW52YWxp ZCwgLy8gdAogICAgIERhdGVUaW1lRm9ybWF0OjpGaWVsZFR5cGVFeHRlbmRlZFllYXIsIC8vIHUK ICAgICBEYXRlVGltZUZvcm1hdDo6RmllbGRUeXBlTm9uTG9jYXRpb25ab25lLCAvLyB2Ci0gICAg RGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZVdlZWtPZk1vbnRoLCAvLyB3CisgICAgRGF0ZVRpbWVG b3JtYXQ6OkZpZWxkVHlwZVdlZWtPZlllYXIsIC8vIHcKICAgICBEYXRlVGltZUZvcm1hdDo6Rmll bGRUeXBlSW52YWxpZCwgLy8geAogICAgIERhdGVUaW1lRm9ybWF0OjpGaWVsZFR5cGVZZWFyLCAv LyB5CiAgICAgRGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZVpvbmUsIC8vIHoKQEAgLTg0LDcgKzg0 LDcgQEAgc3RhdGljIGNvbnN0IERhdGVUaW1lRm9ybWF0OjpGaWVsZFR5cGUgdXBwZXJDYXNlVG9G aWVsZFR5cGVNYXBbMjZdID0gewogICAgIERhdGVUaW1lRm9ybWF0OjpGaWVsZFR5cGVJbnZhbGlk LCAvLyBUCiAgICAgRGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZUludmFsaWQsIC8vIFUKICAgICBE YXRlVGltZUZvcm1hdDo6RmllbGRUeXBlSW52YWxpZCwgLy8gVgotICAgIERhdGVUaW1lRm9ybWF0 OjpGaWVsZFR5cGVXZWVrT2ZZZWFyLCAvLyBXCisgICAgRGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlw ZVdlZWtPZk1vbnRoLCAvLyBXCiAgICAgRGF0ZVRpbWVGb3JtYXQ6OkZpZWxkVHlwZUludmFsaWQs IC8vIFgKICAgICBEYXRlVGltZUZvcm1hdDo6RmllbGRUeXBlWWVhck9mV2Vla09mWWVhciwgLy8g WQogICAgIERhdGVUaW1lRm9ybWF0OjpGaWVsZFR5cGVSRkM4MjJab25lLCAvLyBaCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0RhdGVUaW1lRm9ybWF0LmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0RhdGVUaW1lRm9ybWF0LmgKaW5kZXggZWM5MGM2ZTRm NDliM2RlYzdiM2RiYjg0ZjMxMTIxNTI2MDA4N2JhMC4uZjVmZjAwMzhmNzM1NDIxYjBmMmQ2NWFl YWRmNjRhMjlhMGYzNjU4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC9EYXRlVGltZUZvcm1hdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvRGF0 ZVRpbWVGb3JtYXQuaApAQCAtNTcsOCArNTcsOCBAQCBwdWJsaWM6CiAgICAgICAgIEZpZWxkVHlw ZU1vbnRoU3RhbmRBbG9uZSA9ICdMJywKIAogICAgICAgICAvLyBXZWVrOiA0MgotICAgICAgICBG aWVsZFR5cGVXZWVrT2ZZZWFyID0gJ1cnLAotICAgICAgICBGaWVsZFR5cGVXZWVrT2ZNb250aCA9 ICd3JywKKyAgICAgICAgRmllbGRUeXBlV2Vla09mWWVhciA9ICd3JywKKyAgICAgICAgRmllbGRU eXBlV2Vla09mTW9udGggPSAnVycsCiAKICAgICAgICAgLy8gRGF5OiAxMgogICAgICAgICBGaWVs ZFR5cGVEYXlPZk1vbnRoID0gJ2QnLAo=