98014 2012-10-01 04:22:40 -0700 Make wait-for-SVN-server.py accept empty string as revision 2012-11-07 23:29:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85887 1 ossy ossy dpranke galpeter hausmann ossy vestbo oldest_to_newest 731568 0 ossy 2012-10-01 04:22:40 -0700 Force build on build.webkit.org passes empty string as revision to wait-for-SVN-server.py, but it accepts only int revision numbers. 731570 1 ossy 2012-10-01 04:24:56 -0700 Of course it is possible to make buildmaster not to pass '-r ""' if revision property is empty string ... I'll check this way too. (but it needs fix in master.cfg and buildmaster restart) 759667 2 172584 ossy 2012-11-06 07:34:47 -0800 Created attachment 172584 Patch 759673 3 galpeter 2012-11-06 07:38:27 -0800 lgtm. still, is this a valid usecase? 759675 4 galpeter 2012-11-06 07:38:55 -0800 (In reply to comment #3) > lgtm. still, is this a valid usecase? ahh sorry. missed the previous comments. 761377 5 172584 ossy 2012-11-07 23:29:34 -0800 Comment on attachment 172584 Patch Clearing flags on attachment: 172584 Committed r133854: <http://trac.webkit.org/changeset/133854> 761378 6 ossy 2012-11-07 23:29:39 -0800 All reviewed patches have been landed. Closing bug. 172584 2012-11-06 07:34:47 -0800 2012-11-07 23:29:33 -0800 Patch bug-98014-20121106073259.patch text/plain 2165 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzRlMjA5ZmJjYWE1YTgzODkzYTE2MDBlOTA4ZTJhZTc4 M2UxNTBiOS4uYTA5OTZkYjZjMDA2MzE5MTY5ZDk2NWI2ZmQ1ZTE0YjRkYjdiNmY0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTExLTA2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgTWFrZSB3YWl0LWZvci1TVk4tc2VydmVyLnB5IGFjY2VwdCBlbXB0eSBzdHJpbmcg YXMgcmV2aXNpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk4MDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC93YWl0LWZvci1TVk4tc2VydmVyLnB5OgorICAgICAgICAo d2FpdEZvclNWTlJldmlzaW9uKToKKwogMjAxMi0xMS0wNiAgUmFwaGFlbCBLdWJvIGRhIENvc3Rh ICA8cmFwaGFlbC5rdWJvLmRhLmNvc3RhQGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXVFJd IEV2ZW50U2VuZGVyOiBHZXQgcmlkIG9mIHRoZSBXVFJNb3VzZUJ1dHRvbiBlbnVtLgpkaWZmIC0t Z2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvd2FpdC1mb3ItU1ZOLXNlcnZlci5weSBiL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L3dhaXQtZm9yLVNWTi1zZXJ2ZXIucHkKaW5kZXggZGE5MGFi MmRmNWFlMjBlODc3NDU3ZTUxMmIzNTZlMTE2ZDI3ZTNlYi4uZjA5MzAyNGExMDg4NmYxNDhjYTE2 MzFjMDA0MWY3ZWNiOTg1ODQyYyAxMDA3NTUKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv d2FpdC1mb3ItU1ZOLXNlcnZlci5weQorKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC93YWl0 LWZvci1TVk4tc2VydmVyLnB5CkBAIC00NCwxMSArNDQsMTIgQEAgZGVmIGdldExhdGVzdFNWTlJl dmlzaW9uKFNWTlNlcnZlcik6CiAKIAogZGVmIHdhaXRGb3JTVk5SZXZpc2lvbihTVk5TZXJ2ZXIs IHJldmlzaW9uKToKLSAgICBpZiBub3QgcmV2aXNpb246CisgICAgaWYgbm90IHJldmlzaW9uIG9y IG5vdCByZXZpc2lvbi5pc2RpZ2l0KCk6CiAgICAgICAgIGxhdGVzdFJldmlzaW9uID0gaW50KGdl dExhdGVzdFNWTlJldmlzaW9uKFNWTlNlcnZlcikpCi0gICAgICAgIHByaW50ICJMYXRlc3QgU1ZO IHJldmlzaW9uIG9uICVzIGlzIHIlZC4gRG9uJ3Qgd2FpdCwgYmVjYXVzZSByZXZpc2lvbiBhcmd1 bWVudCBpcyBlbXB0eS4iICUgKFNWTlNlcnZlciwgbGF0ZXN0UmV2aXNpb24pCisgICAgICAgIHBy aW50ICJMYXRlc3QgU1ZOIHJldmlzaW9uIG9uICVzIGlzIHIlZC4gRG9uJ3Qgd2FpdCwgYmVjYXVz ZSByZXZpc2lvbiBhcmd1bWVudCBpc24ndCBhIHZhbGlkIFNWTiByZXZpc2lvbi4iICUgKFNWTlNl cnZlciwgbGF0ZXN0UmV2aXNpb24pCiAgICAgICAgIHJldHVybgogCisgICAgcmV2aXNpb24gPSBp bnQocmV2aXNpb24pCiAgICAgd2hpbGUgVHJ1ZToKICAgICAgICAgbGF0ZXN0UmV2aXNpb24gPSBp bnQoZ2V0TGF0ZXN0U1ZOUmV2aXNpb24oU1ZOU2VydmVyKSkKICAgICAgICAgaWYgbGF0ZXN0UmV2 aXNpb24gPCByZXZpc2lvbjoKQEAgLTYxLDcgKzYyLDcgQEAgZGVmIHdhaXRGb3JTVk5SZXZpc2lv bihTVk5TZXJ2ZXIsIHJldmlzaW9uKToKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAg ICBwYXJzZXIgPSBPcHRpb25QYXJzZXIoKQotICAgIHBhcnNlci5hZGRfb3B0aW9uKCItciIsICIt LXJldmlzaW9uIiwgZGVzdD0icmV2aXNpb24iLCB0eXBlPSJpbnQiLCBoZWxwPSJTVk4gcmV2aXNp b24gbnVtYmVyIikKKyAgICBwYXJzZXIuYWRkX29wdGlvbigiLXIiLCAiLS1yZXZpc2lvbiIsIGRl c3Q9InJldmlzaW9uIiwgaGVscD0iU1ZOIHJldmlzaW9uIG51bWJlciIpCiAgICAgcGFyc2VyLmFk ZF9vcHRpb24oIi1zIiwgIi0tc3ZuLXNlcnZlciIsIGRlc3Q9IlNWTlNlcnZlciIsIGhlbHA9IlNW TiBzZXJ2ZXIiKQogICAgIG9wdGlvbnMsIGFyZ3MgPSBwYXJzZXIucGFyc2VfYXJncygpCiAgICAg d2FpdEZvclNWTlJldmlzaW9uKG9wdGlvbnMuU1ZOU2VydmVyLCBvcHRpb25zLnJldmlzaW9uKQo=