97998 2012-10-01 00:33:58 -0700 [Forms] Adding DateTimeDayFieldElement for multiple fields "date", "datetime", "datetime-local" input UI 2012-10-02 01:09:56 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97997 1 yosin yosin tkent oldest_to_newest 731431 0 yosin 2012-10-01 00:33:58 -0700 To implement multiple fields "date", "datetime", "datetime-local" input UI, we would like to have DateTimeDayFieldElement. 732384 1 166632 yosin 2012-10-02 00:59:57 -0700 Created attachment 166632 Patch 1 732386 2 166632 yosin 2012-10-02 01:00:42 -0700 Comment on attachment 166632 Patch 1 Could you review this patch? Thanks in advance. Bug 97992 added DateTimeWeekFieldElement. It is similar to this patch. 732393 3 tkent 2012-10-02 01:04:16 -0700 (In reply to comment #2) > (From update of attachment 166632 [details]) > Could you review this patch? You should set r? flag. 732394 4 166632 yosin 2012-10-02 01:05:40 -0700 Comment on attachment 166632 Patch 1 Could you review this patch? Thanks in advance. 732398 5 166632 tkent 2012-10-02 01:08:45 -0700 Comment on attachment 166632 Patch 1 ok 732400 6 166632 yosin 2012-10-02 01:09:52 -0700 Comment on attachment 166632 Patch 1 Clearing flags on attachment: 166632 Committed r130134: <http://trac.webkit.org/changeset/130134> 732401 7 yosin 2012-10-02 01:09:56 -0700 All reviewed patches have been landed. Closing bug. 166632 2012-10-02 00:59:57 -0700 2012-10-02 01:09:52 -0700 Patch 1 bug-97998-20121002165909.patch text/plain 4918 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDJkYjAzYWYzZmFjNGVk MDIyYWQ0YWU4NGExYzNlNjA5MjY4OWVhNS4uZTE5N2QyZTM3MjU1OWQyOWU4M2Q2ODNmYWQyNzg2 MTFkMjFiN2MyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTAyICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBBZGRp bmcgRGF0ZVRpbWVEYXlGaWVsZEVsZW1lbnQgZm9yIG11bHRpcGxlIGZpZWxkcyAiZGF0ZSIsICJk YXRldGltZSIsICJkYXRldGltZS1sb2NhbCIgaW5wdXQgVUkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3OTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIERhdGVUaW1l RGF5RmllbGRFbGVtZW50IGNsYXNzIGZvciBpbXBsZW1lbnRpbmcKKyAgICAgICAgbXVsdGlwbGUg ZmllbGRzICJkYXRlIiwgImRhdGV0aW1lIiwgYW5kICJkYXRldGltZS1sb2NhbCIgaW5wdXQgVUku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIGRvZXNuJ3QgY2hhbmdlIGJlaGF2 aW9yLgorCisgICAgICAgICogaHRtbC9zaGFkb3cvRGF0ZVRpbWVGaWVsZEVsZW1lbnRzLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1lRGF5RmllbGRFbGVtZW50OjpEYXRlVGltZURheUZp ZWxkRWxlbWVudCk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6RGF0ZVRpbWVEYXlGaWVsZEVs ZW1lbnQ6OmNyZWF0ZSk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6RGF0ZVRpbWVEYXlGaWVs ZEVsZW1lbnQ6OnBvcHVsYXRlRGF0ZVRpbWVGaWVsZHNTdGF0ZSk6IEFkZGVkLgorICAgICAgICAo V2ViQ29yZTo6RGF0ZVRpbWVEYXlGaWVsZEVsZW1lbnQ6OnNldFZhbHVlQXNEYXRlKTogQWRkZWQu CisgICAgICAgIChXZWJDb3JlOjpEYXRlVGltZURheUZpZWxkRWxlbWVudDo6c2V0VmFsdWVBc0Rh dGVUaW1lRmllbGRzU3RhdGUpOiBBZGRlZC4KKyAgICAgICAgKiBodG1sL3NoYWRvdy9EYXRlVGlt ZUZpZWxkRWxlbWVudHMuaDoKKyAgICAgICAgKERhdGVUaW1lRGF5RmllbGRFbGVtZW50KTogQWRk ZWQuCisKIDIwMTItMTAtMDEgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4K IAogICAgICAgICBBZGRpbmcgTG9jYWxpemVyOjpkYXRlRm9ybWF0KCkgZm9yIG11bHRpcGxlIGZp ZWxkcyBkYXRlL2RhdGV0aW1lIGlucHV0IFVJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL3NoYWRvdy9EYXRlVGltZUZpZWxkRWxlbWVudHMuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvRGF0ZVRpbWVGaWVsZEVsZW1lbnRzLmNwcAppbmRleCAzYzYyNTA5MjRmNWI3ZDI0 Y2JmYmNlNTY3NjQ5YjQyNzM1NjVjZWM3Li5iNzdkYjkxNWFmNTdiY2NlNmE2YzBkNTNiMDFiYTkx Y2RmZTgyZDdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGlt ZUZpZWxkRWxlbWVudHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0RhdGVU aW1lRmllbGRFbGVtZW50cy5jcHAKQEAgLTcxLDYgKzcxLDQ3IEBAIHZvaWQgRGF0ZVRpbWVBTVBN RmllbGRFbGVtZW50OjpzZXRWYWx1ZUFzRGF0ZVRpbWVGaWVsZHNTdGF0ZShjb25zdCBEYXRlVGlt ZUZpZWxkCiAKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAorRGF0ZVRpbWVEYXlG aWVsZEVsZW1lbnQ6OkRhdGVUaW1lRGF5RmllbGRFbGVtZW50KERvY3VtZW50KiBkb2N1bWVudCwg RmllbGRPd25lciYgZmllbGRPd25lciwgY29uc3QgU3RyaW5nJiBwbGFjZWhvbGRlcikKKyAgICA6 IERhdGVUaW1lTnVtZXJpY0ZpZWxkRWxlbWVudChkb2N1bWVudCwgZmllbGRPd25lciwgMSwgMzEs IHBsYWNlaG9sZGVyKQoreworfQorCitQYXNzUmVmUHRyPERhdGVUaW1lRGF5RmllbGRFbGVtZW50 PiBEYXRlVGltZURheUZpZWxkRWxlbWVudDo6Y3JlYXRlKERvY3VtZW50KiBkb2N1bWVudCwgRmll bGRPd25lciYgZmllbGRPd25lciwgY29uc3QgU3RyaW5nJiBwbGFjZWhvbGRlcikKK3sKKyAgICBE RUZJTkVfU1RBVElDX0xPQ0FMKEF0b21pY1N0cmluZywgZGF5UHN1ZWRvSWQsICgiLXdlYmtpdC1k YXRldGltZS1lZGl0LWRheS1maWVsZCIpKTsKKyAgICBSZWZQdHI8RGF0ZVRpbWVEYXlGaWVsZEVs ZW1lbnQ+IGZpZWxkID0gYWRvcHRSZWYobmV3IERhdGVUaW1lRGF5RmllbGRFbGVtZW50KGRvY3Vt ZW50LCBmaWVsZE93bmVyLCBwbGFjZWhvbGRlcikpOworICAgIGZpZWxkLT5pbml0aWFsaXplKGRh eVBzdWVkb0lkLCBBWERheU9mTW9udGhGaWVsZFRleHQoKSk7CisgICAgcmV0dXJuIGZpZWxkLnJl bGVhc2UoKTsKK30KKwordm9pZCBEYXRlVGltZURheUZpZWxkRWxlbWVudDo6cG9wdWxhdGVEYXRl VGltZUZpZWxkc1N0YXRlKERhdGVUaW1lRmllbGRzU3RhdGUmIGRhdGVUaW1lRmllbGRzU3RhdGUp Cit7CisgICAgZGF0ZVRpbWVGaWVsZHNTdGF0ZS5zZXREYXlPZk1vbnRoKGhhc1ZhbHVlKCkgPyB2 YWx1ZUFzSW50ZWdlcigpIDogRGF0ZVRpbWVGaWVsZHNTdGF0ZTo6ZW1wdHlWYWx1ZSk7Cit9CisK K3ZvaWQgRGF0ZVRpbWVEYXlGaWVsZEVsZW1lbnQ6OnNldFZhbHVlQXNEYXRlKGNvbnN0IERhdGVD b21wb25lbnRzJiBkYXRlKQoreworICAgIHNldFZhbHVlQXNJbnRlZ2VyKGRhdGUubW9udGhEYXko KSk7Cit9CisKK3ZvaWQgRGF0ZVRpbWVEYXlGaWVsZEVsZW1lbnQ6OnNldFZhbHVlQXNEYXRlVGlt ZUZpZWxkc1N0YXRlKGNvbnN0IERhdGVUaW1lRmllbGRzU3RhdGUmIGRhdGVUaW1lRmllbGRzU3Rh dGUsIGNvbnN0IERhdGVDb21wb25lbnRzJiBkYXRlRm9yUmVhZE9ubHlGaWVsZCkKK3sKKyAgICBp ZiAoIWRhdGVUaW1lRmllbGRzU3RhdGUuaGFzRGF5T2ZNb250aCgpKSB7CisgICAgICAgIHNldEVt cHR5VmFsdWUoZGF0ZUZvclJlYWRPbmx5RmllbGQpOworICAgICAgICByZXR1cm47CisgICAgfQor CisgICAgY29uc3QgdW5zaWduZWQgdmFsdWUgPSBkYXRlVGltZUZpZWxkc1N0YXRlLmRheU9mTW9u dGgoKTsKKyAgICBpZiAocmFuZ2UoKS5pc0luUmFuZ2Uoc3RhdGljX2Nhc3Q8aW50Pih2YWx1ZSkp KSB7CisgICAgICAgIHNldFZhbHVlQXNJbnRlZ2VyKHZhbHVlKTsKKyAgICAgICAgcmV0dXJuOwor ICAgIH0KKworICAgIHNldEVtcHR5VmFsdWUoZGF0ZUZvclJlYWRPbmx5RmllbGQpOworfQorCisv LyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisKIERhdGVUaW1lSG91ckZpZWxkRWxlbWVu dDo6RGF0ZVRpbWVIb3VyRmllbGRFbGVtZW50KERvY3VtZW50KiBkb2N1bWVudCwgRmllbGRPd25l ciYgZmllbGRPd25lciwgaW50IG1pbmltdW0sIGludCBtYXhpbXVtKQogICAgIDogRGF0ZVRpbWVO dW1lcmljRmllbGRFbGVtZW50KGRvY3VtZW50LCBmaWVsZE93bmVyLCBtaW5pbXVtLCBtYXhpbXVt LCAiLS0iKQogICAgICwgbV9hbGlnbm1lbnQobWF4aW11bSArIG1heGltdW0gJSAyKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvRGF0ZVRpbWVGaWVsZEVsZW1lbnRzLmgg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZUZpZWxkRWxlbWVudHMuaAppbmRl eCAxZGUzNzE0ODlhYmU1MzRkNDU3ZjRmOGY3NzZmNzMxOTJhYWVkM2JlLi4xOTg0ZWZiNTNmNmUw YTlkM2M3ZjcyZmFiYTE3ZDQxNzZiMjEzMTg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL3NoYWRvdy9EYXRlVGltZUZpZWxkRWxlbWVudHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL3NoYWRvdy9EYXRlVGltZUZpZWxkRWxlbWVudHMuaApAQCAtNDcsNiArNDcsMjAgQEAgcHJp dmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgc2V0VmFsdWVBc0RhdGVUaW1lRmllbGRzU3RhdGUoY29u c3QgRGF0ZVRpbWVGaWVsZHNTdGF0ZSYsIGNvbnN0IERhdGVDb21wb25lbnRzJiBkYXRlRm9yUmVh ZE9ubHlGaWVsZCkgT1ZFUlJJREUgRklOQUw7CiB9OwogCitjbGFzcyBEYXRlVGltZURheUZpZWxk RWxlbWVudCA6IHB1YmxpYyBEYXRlVGltZU51bWVyaWNGaWVsZEVsZW1lbnQgeworICAgIFdURl9N QUtFX05PTkNPUFlBQkxFKERhdGVUaW1lRGF5RmllbGRFbGVtZW50KTsKKworcHVibGljOgorICAg IHN0YXRpYyBQYXNzUmVmUHRyPERhdGVUaW1lRGF5RmllbGRFbGVtZW50PiBjcmVhdGUoRG9jdW1l bnQqLCBGaWVsZE93bmVyJiwgY29uc3QgU3RyaW5nJiBwbGFjZWhvbGRlcik7CisKK3ByaXZhdGU6 CisgICAgRGF0ZVRpbWVEYXlGaWVsZEVsZW1lbnQoRG9jdW1lbnQqLCBGaWVsZE93bmVyJiwgY29u c3QgU3RyaW5nJiBwbGFjZWhvbGRlcik7CisKKyAgICAvLyBEYXRlVGltZUZpZWxkRWxlbWVudCBm dW5jdGlvbnMuCisgICAgdmlydHVhbCB2b2lkIHBvcHVsYXRlRGF0ZVRpbWVGaWVsZHNTdGF0ZShE YXRlVGltZUZpZWxkc1N0YXRlJikgT1ZFUlJJREUgRklOQUw7CisgICAgdmlydHVhbCB2b2lkIHNl dFZhbHVlQXNEYXRlKGNvbnN0IERhdGVDb21wb25lbnRzJikgT1ZFUlJJREUgRklOQUw7CisgICAg dmlydHVhbCB2b2lkIHNldFZhbHVlQXNEYXRlVGltZUZpZWxkc1N0YXRlKGNvbnN0IERhdGVUaW1l RmllbGRzU3RhdGUmLCBjb25zdCBEYXRlQ29tcG9uZW50cyYgZGF0ZUZvclJlYWRPbmx5RmllbGQp IE9WRVJSSURFIEZJTkFMOworfTsKIAogLy8gRGF0ZVRpbWVIb3VyRmllbGRFbGVtZW50IGlzIHVz ZWQgZm9yIGhvdXIgZmllbGQgb2YgZGF0ZSB0aW1lIGZvcm1hdAogLy8gc3VwcG9ydGluZyBmb2xs b3dpbmcgcGF0dGVybnM6Cg==