97907 2012-09-28 06:36:07 -0700 [Qt] QRawWebView tests are broken after r129545 2012-09-28 06:55:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70236 1 kbalazs kbalazs abecsi cmarcelo menard noam ossy webkit.review.bot zoltan oldest_to_newest 730596 0 kbalazs 2012-09-28 06:36:07 -0700 The issue here was that we were setting the page loader client before initialized the page. This is not correct, the API expects that the page is initialized, i.e. we have a living page at the web process side. Without that most of the API calls will be implicitly ignored. This has been revealed by http://trac.webkit.org/changeset/129545 because it changed the initializing of the loader client so that it requires sending a message. 730608 1 166242 kbalazs 2012-09-28 06:46:56 -0700 Created attachment 166242 Patch 730616 2 166242 kbalazs 2012-09-28 06:55:34 -0700 Comment on attachment 166242 Patch Clearing flags on attachment: 166242 Committed r129890: <http://trac.webkit.org/changeset/129890> 730617 3 kbalazs 2012-09-28 06:55:39 -0700 All reviewed patches have been landed. Closing bug. 166242 2012-09-28 06:46:56 -0700 2012-09-28 06:55:34 -0700 Patch bug-97907-20120928154608.patch text/plain 3373 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzQ3MDA2NGVkMTJjMGRi ODA0YzdlOGI4YTZlYTFjNDg0MzU0N2NmOS4uZmQyMDliN2FkOTIwNmI3OWQ0ZDg5YmNiMGU1ZmNh ZDgzMjUxODlhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI4ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFFSYXdXZWJW aWV3IHRlc3RzIGFyZSBicm9rZSBhZnRlciByMTI5NTQ1CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpc3N1ZSBoZXJlIGlzIHRoYXQgd2Ugc2V0IHVw IHRoZSBwYWdlIGxvYWRlciBjbGllbnQgYmVmb3JlIGluaXRpYWxpemluZyB0aGUgcGFnZQorICAg ICAgICBzbyB0aGUgbWVzc2FnZSB3ZSBzZW5kIGluIFdlYlBhZ2VQcm94eTo6aW5pdGlhbGl6ZUxv YWRlckNsaWVudCB3aWxsIGJlIGxvc3Qgc2luY2UgdGhlCisgICAgICAgIHBhZ2UgZG9lcyBub3Qg ZXhpc3RzIGF0IHRoZSB3ZWIgcHJvY2VzcyBzaWRlIHlldC4gVGhlIHRyaXZpYWwgZml4IHdvdWxk IGJlIHRvIHJlb3JkZXIKKyAgICAgICAgaW5pdGlhbGl6YXRpb24uIEluIHRoaXMgcGF0Y2ggSSBh bHNvIG1vdmVkIHRvIHRoZSBuZXcgbW9kZWwgb2Ygb2JzZXJ2aW5nIGxheW91dCBjaGFuZ2VzCisg ICAgICAgIHZpYSBXS1BhZ2VEaWRMYXlvdXRDYWxsYmFjayBzaW5jZSB0aGUgb2xkIG9uZSB3aWxs IGJlIGRlcHJlY2F0ZWQgYXQgc29tZSB0aW1lLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9x dC90ZXN0cy9xcmF3d2Vidmlldy90c3RfcXJhd3dlYnZpZXcuY3BwOgorICAgICAgICAoV2ViVmll dzo6V2ViVmlldyk6CisgICAgICAgIChXZWJWaWV3OjpkaWRMYXlvdXQpOgorCiAyMDEyLTA5LTI4 ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyOTg2My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXJhd3dlYnZpZXcvdHN0X3FyYXd3ZWJ2aWV3LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXJhd3dlYnZpZXcvdHN0X3Fy YXd3ZWJ2aWV3LmNwcAppbmRleCAyNzE0MmU2Y2Y1ZjdlYTIxMmRmOTBhYTJmYTAwYTFjMzJlNjIx YTVjLi4yMDgyODhkMWU2ZDBlY2U1YmU3ZmZlZDNhMWVmZTEyZWRjNWMwMmQ4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FyYXd3ZWJ2aWV3L3RzdF9x cmF3d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy9xcmF3d2Vidmlldy90c3RfcXJhd3dlYnZpZXcuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAKICNp bmNsdWRlIDxXZWJLaXQyL1dLQ29udGV4dC5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tQYWdlR3Jv dXAuaD4KKyNpbmNsdWRlIDxXZWJLaXQyL1dLUGFnZUxvYWRUeXBlcy5oPgogI2luY2x1ZGUgPFdl YktpdDIvV0tQcmVmZXJlbmNlcy5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tQcmVmZXJlbmNlc1By aXZhdGUuaD4KICNpbmNsdWRlIDxXZWJLaXQyL1dLU3RyaW5nUXQuaD4KQEAgLTYwLDE1ICs2MSwx OCBAQCBjbGFzcyBXZWJWaWV3IDogcHVibGljIFFPYmplY3QsIHB1YmxpYyBRUmF3V2ViVmlld0Ns aWVudCB7CiBwdWJsaWM6CiAgICAgV2ViVmlldyhjb25zdCBRU2l6ZSYgc2l6ZSwgYm9vbCB0cmFu c3BhcmVudCA9IGZhbHNlKQogICAgIHsKKyAgICAgICAgbV93ZWJWaWV3ID0gbmV3IFFSYXdXZWJW aWV3KHdlYkNvbnRleHQoKSwgd2ViUGFnZUdyb3VwKFFTdHJpbmcoKSksIHRoaXMpOworICAgICAg ICBtX3dlYlZpZXctPnNldFRyYW5zcGFyZW50QmFja2dyb3VuZCh0cmFuc3BhcmVudCk7CisgICAg ICAgIG1fd2ViVmlldy0+Y3JlYXRlKCk7CisKICAgICAgICAgV0tQYWdlTG9hZGVyQ2xpZW50IGxv YWRlckNsaWVudDsKICAgICAgICAgbWVtc2V0KCZsb2FkZXJDbGllbnQsIDAsIHNpemVvZihXS1Bh Z2VMb2FkZXJDbGllbnQpKTsKKyAgICAgICAgbG9hZGVyQ2xpZW50LnZlcnNpb24gPSBrV0tQYWdl TG9hZGVyQ2xpZW50Q3VycmVudFZlcnNpb247CiAgICAgICAgIGxvYWRlckNsaWVudC5jbGllbnRJ bmZvID0gdGhpczsKLSAgICAgICAgbG9hZGVyQ2xpZW50LmRpZEZpcnN0VmlzdWFsbHlOb25FbXB0 eUxheW91dEZvckZyYW1lID0gV2ViVmlldzo6ZmluaXNoRmlyc3RMYXlvdXRGb3JGcmFtZTsKKyAg ICAgICAgbG9hZGVyQ2xpZW50LmRpZExheW91dCA9IFdlYlZpZXc6OmRpZExheW91dDsKIAotICAg ICAgICBtX3dlYlZpZXcgPSBuZXcgUVJhd1dlYlZpZXcod2ViQ29udGV4dCgpLCB3ZWJQYWdlR3Jv dXAoUVN0cmluZygpKSwgdGhpcyk7CiAgICAgICAgIFdLUGFnZVNldFBhZ2VMb2FkZXJDbGllbnQo bV93ZWJWaWV3LT5wYWdlUmVmKCksICZsb2FkZXJDbGllbnQpOwotICAgICAgICBtX3dlYlZpZXct PnNldFRyYW5zcGFyZW50QmFja2dyb3VuZCh0cmFuc3BhcmVudCk7Ci0gICAgICAgIG1fd2ViVmll dy0+Y3JlYXRlKCk7CisgICAgICAgIFdLUGFnZUxpc3RlbkZvckxheW91dE1pbGVzdG9uZXMobV93 ZWJWaWV3LT5wYWdlUmVmKCksIGtXS0RpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dCk7CiAg ICAgICAgIFdLUGFnZVNldFVzZUZpeGVkTGF5b3V0KG1fd2ViVmlldy0+cGFnZVJlZigpLCB0cnVl KTsKIAogICAgICAgICBtX3dlYlZpZXctPnNldFNpemUoc2l6ZSk7CkBAIC0xMTgsNyArMTIyLDcg QEAgcHVibGljOgogICAgICAgICBzdGF0aWNfY2FzdDxXZWJWaWV3Kj4oY29udGV4dCktPm9uUmVw YWludERvbmUoKTsKICAgICB9CiAKLSAgICBzdGF0aWMgdm9pZCBmaW5pc2hGaXJzdExheW91dEZv ckZyYW1lKFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1R5cGVSZWYgdXNlckRh dGEsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pCisgICAgc3RhdGljIHZvaWQgZGlkTGF5b3V0KFdL UGFnZVJlZiBwYWdlLCBXS0xheW91dE1pbGVzdG9uZXMgbWlsZXN0b25lcywgV0tUeXBlUmVmIHVz ZXJEYXRhLCBjb25zdCB2b2lkICpjbGllbnRJbmZvKQogICAgIHsKICAgICAgICAgc3RhdGljX2Nh c3Q8V2ViVmlldyo+KGNvbnN0X2Nhc3Q8dm9pZCo+KGNsaWVudEluZm8pKS0+ZnJhbWVMb2FkZWQo KTsKICAgICB9Cg==