97872 2012-09-28 00:06:43 -0700 [Refactoring] DOMSelection should not use shadowAncestorNode 2012-10-01 23:22:23 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91821 1 shinyak shinyak dglazkov morrita rniwa webkit.review.bot oldest_to_newest 730305 0 shinyak 2012-09-28 00:06:43 -0700 in selectionShadowAncestor, we're using node->shadowAncestorNode(), but it's deprecated. We should use TreeScope::ancestorInThisScope here. 730306 1 166159 shinyak 2012-09-28 00:12:25 -0700 Created attachment 166159 Patch 732019 2 dglazkov 2012-10-01 14:53:52 -0700 +1 732313 3 166159 webkit.review.bot 2012-10-01 23:22:20 -0700 Comment on attachment 166159 Patch Clearing flags on attachment: 166159 Committed r130124: <http://trac.webkit.org/changeset/130124> 732314 4 webkit.review.bot 2012-10-01 23:22:23 -0700 All reviewed patches have been landed. Closing bug. 166159 2012-09-28 00:12:25 -0700 2012-10-01 23:22:20 -0700 Patch bug-97872-20120928161142.patch text/plain 1579 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZmODc5NjI4YmQyMTky NGU3ZDNjZWVkYWFhNGNhMGI3MjU3OTA3Yy4uZGFjMDQ5YzI1ODk5NWRjMWY2OTcwNmE4NGNhODc4 MzcxNTY5MjZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTI4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIERPTVNlbGVjdGlvbiBzaG91bGQgbm90IHVzZSBzaGFkb3dBbmNlc3Rvck5vZGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3ODcyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgTm9kZTo6c2hh ZG93QW5jZXN0b3JOb2RlIGlzIGRlcHJlY2F0ZWQsIGl0IHNob3VsZCBub3QgYmUgdXNlZC4KKyAg ICAgICAgSGVyZSwgd2Ugc2hvdWxkIHVzZSBUcmVlU2NvcGU6OmFuY2VzdG9ySW5UaGlzU2NvcGUg aW5zdGVhZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVz dC4KKworICAgICAgICAqIHBhZ2UvRE9NU2VsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnNlbGVjdGlvblNoYWRvd0FuY2VzdG9yKToKKwogMjAxMi0wOS0yNyAgS2VudCBUYW11cmEgIDx0 a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWFrZSBzdXJlIExvY2FsaXplciBjbGFzcyBp cyBub3QgY29weWFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0 aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmNwcAppbmRleCBjM2Fk NDI4MDdlOTI1Y2ZmNTJhMzEwNjFhMjMwM2ZkMmVlMDhjOWFiLi4wNjI0NDNhYzQ0NzlmYzgxMTAy YjFiYmQ5MmY3OGQ2NmJkNjMzMDgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RP TVNlbGVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01TZWxlY3Rpb24uY3Bw CkBAIC01MywxMCArNTMsNyBAQCBzdGF0aWMgTm9kZSogc2VsZWN0aW9uU2hhZG93QW5jZXN0b3Io RnJhbWUqIGZyYW1lKQogICAgIGlmICghbm9kZS0+aXNJblNoYWRvd1RyZWUoKSkKICAgICAgICAg cmV0dXJuIDA7CiAKLSAgICBOb2RlKiBzaGFkb3dBbmNlc3RvciA9IG5vZGUtPnNoYWRvd0FuY2Vz dG9yTm9kZSgpOwotICAgIHdoaWxlIChzaGFkb3dBbmNlc3Rvci0+aXNJblNoYWRvd1RyZWUoKSkK LSAgICAgICAgc2hhZG93QW5jZXN0b3IgPSBzaGFkb3dBbmNlc3Rvci0+c2hhZG93QW5jZXN0b3JO b2RlKCk7Ci0gICAgcmV0dXJuIHNoYWRvd0FuY2VzdG9yOworICAgIHJldHVybiBmcmFtZS0+ZG9j dW1lbnQoKS0+YW5jZXN0b3JJblRoaXNTY29wZShub2RlKTsKIH0KIAogRE9NU2VsZWN0aW9uOjpE T01TZWxlY3Rpb24oY29uc3QgVHJlZVNjb3BlKiB0cmVlU2NvcGUpCg==