97871 2012-09-27 23:58:24 -0700 RenderImage should not use shadowAncestorNode 2013-01-06 22:04:41 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91821 1 shinyak shinyak dglazkov eric webkit.review.bot oldest_to_newest 730297 0 shinyak 2012-09-27 23:58:24 -0700 Since node()->shadowAncestorNode() does not return NULL, this if statement will never fail. This should be shadowHost(). 730299 1 166158 shinyak 2012-09-28 00:01:26 -0700 Created attachment 166158 Patch 730714 2 eric 2012-09-28 09:01:40 -0700 I'm confused. How is this covered by existing tests? Is it a behavior change? 730727 3 dglazkov 2012-09-28 09:15:43 -0700 (In reply to comment #2) > I'm confused. How is this covered by existing tests? Is it a behavior change? It's not, it's a fix in the logic. shadowAncestorNode is a weird cousin of shadowRoot. We're trying to get rid of this weird cousin and in this particular case shadowRoot and shadowAncestorNode can be used interchangeably. So, the ChangeLog should say: No change in logic, refactoring. 730728 4 166158 dglazkov 2012-09-28 09:16:00 -0700 Comment on attachment 166158 Patch Please fix the ChangeLog before landing. 737398 5 167687 shinyak 2012-10-08 21:42:08 -0700 Created attachment 167687 Patch for landing 737421 6 167687 webkit.review.bot 2012-10-08 22:13:56 -0700 Comment on attachment 167687 Patch for landing Rejecting attachment 167687 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14214605 801149 7 181472 shinyak 2013-01-06 21:06:47 -0800 Created attachment 181472 Patch for landing 801150 8 shinyak 2013-01-06 21:07:48 -0800 I didn't notice this patch was not committed yet. rebase on ToT, and cq+. 801165 9 181472 webkit.review.bot 2013-01-06 22:04:37 -0800 Comment on attachment 181472 Patch for landing Clearing flags on attachment: 181472 Committed r138922: <http://trac.webkit.org/changeset/138922> 801166 10 webkit.review.bot 2013-01-06 22:04:41 -0800 All reviewed patches have been landed. Closing bug. 166158 2012-09-28 00:01:26 -0700 2012-10-08 21:42:04 -0700 Patch bug-97871-20120928160043.patch text/plain 1544 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZmODc5NjI4YmQyMTky NGU3ZDNjZWVkYWFhNGNhMGI3MjU3OTA3Yy4uNGIzN2JhZDc2NGJlMmUwMGNhOTZjNjdiZDg1NmVi OTU4MmE5MTFkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTI3ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5kZXJJbWFn ZSBzaG91bGQgbm90IHVzZSBzaGFkb3dBbmNlc3Rvck5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3ODcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2Ugc2hhZG93QW5jZXN0b3JOb2RlKCkgZG9l cyBub3QgcmV0dXJuIDAsIHRoaXMgaWYtY29uZGl0aW9uIHdpbGwgbmV2ZXIgaG9sZC4KKyAgICAg ICAgc2hhZG93SG9zdCgpIHNob3VsZCBiZSB1c2VkIGluc3RlYWQuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckltYWdlOjpob3N0SW1h Z2VFbGVtZW50KToKKwogMjAxMi0wOS0yNyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgTWFrZSBzdXJlIExvY2FsaXplciBjbGFzcyBpcyBub3QgY29weWFibGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCmluZGV4IGRhODdhNTIwZjdj OTMyNTE3MjU1MDFhNTliYjMzOTI2Y2Y1Njg0NDguLjgwYTAwZWEyNWY2MDEyMmUzN2RjYzU3YTRh OWVhMzExNWI0MzFiZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNw cApAQCAtNTczLDcgKzU3Myw3IEBAIEhUTUxJbWFnZUVsZW1lbnQqIFJlbmRlckltYWdlOjpob3N0 SW1hZ2VFbGVtZW50KCkgY29uc3QKICAgICAgICAgcmV0dXJuIHRvSFRNTEltYWdlRWxlbWVudChu b2RlKCkpOwogCiAgICAgaWYgKG5vZGUoKS0+aGFzVGFnTmFtZSh3ZWJraXRJbm5lckltYWdlVGFn KSkgewotICAgICAgICBpZiAoTm9kZSogYW5jZXN0b3IgPSBub2RlKCktPnNoYWRvd0FuY2VzdG9y Tm9kZSgpKSB7CisgICAgICAgIGlmIChOb2RlKiBhbmNlc3RvciA9IG5vZGUoKS0+c2hhZG93SG9z dCgpKSB7CiAgICAgICAgICAgICBpZiAoYW5jZXN0b3ItPmhhc1RhZ05hbWUoaW1nVGFnKSkKICAg ICAgICAgICAgICAgICByZXR1cm4gdG9IVE1MSW1hZ2VFbGVtZW50KGFuY2VzdG9yKTsKICAgICAg ICAgfQo= 167687 2012-10-08 21:42:08 -0700 2013-01-06 21:06:44 -0800 Patch for landing bug-97871-20121009134109.patch text/plain 1578 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVjODg2OTkyMTc2YWMx NzUzYTQ1ODM2OGE4OGM2M2JhZDFkNjhiOC4uOTlkMmEwYzBjNmIxZTYwMzc4MDY0MDc1NzY4MjIz MjUyMTg1M2NmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTA4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5kZXJJbWFn ZSBzaG91bGQgbm90IHVzZSBzaGFkb3dBbmNlc3Rvck5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3ODcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2Ugc2hhZG93QW5jZXN0b3JOb2RlKCkgZG9l cyBub3QgcmV0dXJuIDAsIHRoaXMgaWYtY29uZGl0aW9uIHdpbGwgbmV2ZXIgaG9sZC4KKyAgICAg ICAgc2hhZG93SG9zdCgpIHNob3VsZCBiZSB1c2VkIGluc3RlYWQuCisKKyAgICAgICAgTm8gY2hh bmdlIGluIGxvZ2ljLCByZWZhY3RvcmluZy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJ bWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJbWFnZTo6aG9zdEltYWdlRWxlbWVu dCk6CisKIDIwMTItMTAtMDggIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5nLmNvbT4K IAogICAgICAgICBbQ0FJUk9dIEFkanVzdCB0aGUgc291cmNlIHJlY3Qgc2l6ZSB3aGVuIElNQUdF X0RFQ09ERVJfRE9XTl9TQU1QTElORyBpcyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckltYWdlLmNwcAppbmRleCBkYTg3YTUyMGY3YzkzMjUxNzI1NTAxYTU5YmIzMzkyNmNm NTY4NDQ4Li44MGEwMGVhMjVmNjAxMjJlMzdkY2M1N2E0YTllYTMxMTViNDMxYmUxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKQEAgLTU3Myw3ICs1NzMsNyBAQCBI VE1MSW1hZ2VFbGVtZW50KiBSZW5kZXJJbWFnZTo6aG9zdEltYWdlRWxlbWVudCgpIGNvbnN0CiAg ICAgICAgIHJldHVybiB0b0hUTUxJbWFnZUVsZW1lbnQobm9kZSgpKTsKIAogICAgIGlmIChub2Rl KCktPmhhc1RhZ05hbWUod2Via2l0SW5uZXJJbWFnZVRhZykpIHsKLSAgICAgICAgaWYgKE5vZGUq IGFuY2VzdG9yID0gbm9kZSgpLT5zaGFkb3dBbmNlc3Rvck5vZGUoKSkgeworICAgICAgICBpZiAo Tm9kZSogYW5jZXN0b3IgPSBub2RlKCktPnNoYWRvd0hvc3QoKSkgewogICAgICAgICAgICAgaWYg KGFuY2VzdG9yLT5oYXNUYWdOYW1lKGltZ1RhZykpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRv SFRNTEltYWdlRWxlbWVudChhbmNlc3Rvcik7CiAgICAgICAgIH0K 181472 2013-01-06 21:06:47 -0800 2013-01-06 22:04:37 -0800 Patch for landing bug-97871-20130107140352.patch text/plain 1598 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRlYzNjMDlhZDYyNGZi ZWE3ZWIyMGEyMjQ1NDlmOTc0YWJmMDNiNi4uMWM0M2VmNGUyYjM5MGViMzc5ODhiNWJiZDI2NDA5 OGZiNWNiZThiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTA4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5kZXJJbWFn ZSBzaG91bGQgbm90IHVzZSBzaGFkb3dBbmNlc3Rvck5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3ODcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RGltaXRyaSBHbGF6a292LgorCisgICAgICAgIFNpbmNlIHNoYWRvd0FuY2VzdG9yTm9kZSgpIGRv ZXMgbm90IHJldHVybiAwLCB0aGlzIGlmLWNvbmRpdGlvbiB3aWxsIG5ldmVyIGhvbGQuCisgICAg ICAgIHNoYWRvd0hvc3QoKSBzaG91bGQgYmUgdXNlZCBpbnN0ZWFkLgorCisgICAgICAgIE5vIGNo YW5nZSBpbiBsb2dpYywgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy SW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW1hZ2U6Omhvc3RJbWFnZUVsZW1l bnQpOgorCiAyMDEzLTAxLTA2ICBTZWJhc3RpYW4gRHLDtmdlICA8c2ViYXN0aWFuLmRyb2VnZUBj b2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgQnVnwqAxMDYxNzcgLSBbR1N0cmVhbWVyXSBEb24n dCBjYWxsIGdzdF92aWRlb19pbmZvX2Zyb21fY2FwcygpIHdpdGggbm9uLWZpeGVkIGNhcHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCmluZGV4IDAwZDNmODBjYjY0NDNl MGY1NTEyMzUxZjA5N2M5Nzc2NGQ2MTIxMDYuLjJjY2EyMTQ3MTQzMjQzMTA1YWU0YWE5NDdkNWZk NGE1Zjc1YmFiMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJ bWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcApA QCAtNTg2LDcgKzU4Niw3IEBAIEhUTUxJbWFnZUVsZW1lbnQqIFJlbmRlckltYWdlOjpob3N0SW1h Z2VFbGVtZW50KCkgY29uc3QKICAgICAgICAgcmV0dXJuIHRvSFRNTEltYWdlRWxlbWVudChub2Rl KCkpOwogCiAgICAgaWYgKG5vZGUoKS0+aGFzVGFnTmFtZSh3ZWJraXRJbm5lckltYWdlVGFnKSkg ewotICAgICAgICBpZiAoTm9kZSogYW5jZXN0b3IgPSBub2RlKCktPnNoYWRvd0FuY2VzdG9yTm9k ZSgpKSB7CisgICAgICAgIGlmIChOb2RlKiBhbmNlc3RvciA9IG5vZGUoKS0+c2hhZG93SG9zdCgp KSB7CiAgICAgICAgICAgICBpZiAoYW5jZXN0b3ItPmhhc1RhZ05hbWUoaW1nVGFnKSkKICAgICAg ICAgICAgICAgICByZXR1cm4gdG9IVE1MSW1hZ2VFbGVtZW50KGFuY2VzdG9yKTsKICAgICAgICAg fQo=