97827 2012-09-27 16:00:58 -0700 RenderFlexibleBox::preferredMainAxisContentExtentForChild can return a negative value 2012-10-19 18:49:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62048 1 ojan tony eric tony webkit.review.bot oldest_to_newest 729964 0 ojan 2012-09-27 16:00:58 -0700 LayoutUnit RenderFlexibleBox::preferredMainAxisContentExtentForChild(RenderBox* child) { Length flexBasis = flexBasisForChild(child); if (flexBasis.isAuto()) { LayoutUnit mainAxisExtent = hasOrthogonalFlow(child) ? child->logicalHeight() : child->maxPreferredLogicalWidth(); return mainAxisExtent - mainAxisBorderAndPaddingExtentForChild(child); } return std::max(LayoutUnit(0), computeMainAxisExtentForChild(child, MainOrPreferredSize, flexBasis)); } In the first return statement we need to clamp to 0 the same way we do in the second one. If mainAxisExtent < mainAxisBorderAndPaddingExtentForChild, then we are incorrectly returning a negative value. 746766 1 169722 tony 2012-10-19 16:47:36 -0700 Created attachment 169722 Patch 746835 2 169722 webkit.review.bot 2012-10-19 18:49:17 -0700 Comment on attachment 169722 Patch Clearing flags on attachment: 169722 Committed r131972: <http://trac.webkit.org/changeset/131972> 746836 3 webkit.review.bot 2012-10-19 18:49:21 -0700 All reviewed patches have been landed. Closing bug. 169722 2012-10-19 16:47:36 -0700 2012-10-19 18:49:17 -0700 Patch bug-97827-20121019164619.patch text/plain 1845 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGYxOGM4YWNmZGRjNDE0 YmNkM2U3NjQzYTI1M2RjMmRjMGY3YjdiNi4uOTdkMjBhMmE3YzkzYzQ4ZGMzYTM1MjY5MTg5NjI4 MGY5Mjc2OTVkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTE5ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVuZGVyRmxleGlibGVCb3g6 OnByZWZlcnJlZE1haW5BeGlzQ29udGVudEV4dGVudEZvckNoaWxkIGNhbiByZXR1cm4gYSBuZWdh dGl2ZSB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTc4MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJJ20gcHJldHR5IHN1cmUgdGhpcyBpc24ndCBwb3NzaWJsZSAobG9naWNhbEhlaWdodCBhbmQg bWF4UHJlZmVycmVkTG9naWNhbFdpZHRoIHNob3VsZCBhbHdheXMgaW5jbHVkZQorICAgICAgICBi b3JkZXIgYW5kIHBhZGRpbmcpLCBzbyBqdXN0IGFkZCBhbiBhc3NlcnQuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCB0aGUgYXNzZXJ0IGlzIGZvciBjb2RlIGNsYXJpdHkuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy RmxleGlibGVCb3g6OnByZWZlcnJlZE1haW5BeGlzQ29udGVudEV4dGVudEZvckNoaWxkKToKKwog MjAxMi0xMC0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzE5MTUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAppbmRleCBiYWY3NzQ3Yjk2NTZmODgyMDhl ODg3ODI2OWQ3NzAyMTdmNmYzZmRlLi44NmU2NTVlODkxZDBjNWY4YTUxOTFiZWU0NWY4NWM5OWQ2 ZThkOWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGli bGVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJv eC5jcHAKQEAgLTY2NCw2ICs2NjQsNyBAQCBMYXlvdXRVbml0IFJlbmRlckZsZXhpYmxlQm94Ojpw cmVmZXJyZWRNYWluQXhpc0NvbnRlbnRFeHRlbnRGb3JDaGlsZChSZW5kZXJCb3gqCiAgICAgTGVu Z3RoIGZsZXhCYXNpcyA9IGZsZXhCYXNpc0ZvckNoaWxkKGNoaWxkKTsKICAgICBpZiAoZmxleEJh c2lzLmlzQXV0bygpKSB7CiAgICAgICAgIExheW91dFVuaXQgbWFpbkF4aXNFeHRlbnQgPSBoYXNP cnRob2dvbmFsRmxvdyhjaGlsZCkgPyBjaGlsZC0+bG9naWNhbEhlaWdodCgpIDogY2hpbGQtPm1h eFByZWZlcnJlZExvZ2ljYWxXaWR0aCgpOworICAgICAgICBBU1NFUlQobWFpbkF4aXNFeHRlbnQg LSBtYWluQXhpc0JvcmRlckFuZFBhZGRpbmdFeHRlbnRGb3JDaGlsZChjaGlsZCkgPj0gMCk7CiAg ICAgICAgIHJldHVybiBtYWluQXhpc0V4dGVudCAtIG1haW5BeGlzQm9yZGVyQW5kUGFkZGluZ0V4 dGVudEZvckNoaWxkKGNoaWxkKTsKICAgICB9CiAgICAgcmV0dXJuIHN0ZDo6bWF4KExheW91dFVu aXQoMCksIGNvbXB1dGVNYWluQXhpc0V4dGVudEZvckNoaWxkKGNoaWxkLCBNYWluT3JQcmVmZXJy ZWRTaXplLCBmbGV4QmFzaXMpKTsK