97804 2012-09-27 11:22:00 -0700 [CSS Exclusions] ExclusionShape class should provide a lineOverlapsShapeBounds() method 2013-04-11 13:19:26 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96811 1 giles_joplin giles_joplin donggwan.kim zoltan oldest_to_newest 729721 0 giles_joplin 2012-09-27 11:22:00 -0700 It would be more efficient if the ExclusionShape class provided a lineOverlapsShapeBounds() method, than the current approach where ExclusionShapeInsideInfo computes the result by getting the shape's bounding box: inline bool ExclusionShapeInsideInfo::lineOverlapsShapeBounds() const { ASSERT(m_shape); FloatRect shapeBounds = m_shape->shapeLogicalBoundingBox(); return m_lineTop <= shapeBounds.maxY() && m_lineBottom >= shapeBounds.y(); } By calling an ExclusionShape() method directly we could avoid allocating a FloatRect and doing the extra internal to logical conversions. 874095 1 zoltan 2013-04-11 13:19:26 -0700 It has been fixed earlier. Current function: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/ExclusionShapeInfo.h?rev=147384#L99 bool lineOverlapsShapeBounds() const { return logicalLineTop() < shapeLogicalBottom() && logicalLineBottom() >= shapeLogicalTop(); }