97747 2012-09-26 18:08:08 -0700 width on a flexitem should not affect the min-width: auto constraint 2013-03-07 16:25:22 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 111790 P2 Normal --- 106143 62048 1 dholbert webkit-unassigned kennyluck ojan tony oldest_to_newest 729111 0 dholbert 2012-09-26 18:08:08 -0700 Midori 0.4.3 Chrome Version 23.0.1271.6 dev 729112 1 dholbert 2012-09-26 18:11:31 -0700 (sorry, accidentally bumped "enter" key while typing bug summary & filed bug prematurely) The flexbox spec says that "min-width:auto" on a flex item is supposed to resolve to the min-content width. However, when there's a "width" property-value specified on the item, webkit appears to be clamping to that width, instead of to the min-content width. Testcases coming up. 729115 2 165909 dholbert 2012-09-26 18:19:03 -0700 Created attachment 165909 testcase 1 This testcase has a block with: flex: 1 1 0px; width: 1000px; inside of a 50px-wide flexbox. (with -webkit and -moz prefixes on flex properties) I believe the "width: 1000px" there should have no effect. It's not used as the flex-base, clearly, because we have "0px" in the flex specification. It's also not part of the block's min-content width, unless I'm misunderstanding what the spec authors had in mind with "min-content width". 729122 3 165910 dholbert 2012-09-26 18:29:30 -0700 Created attachment 165910 reference case 1 Here's a reference case, with the "width: 1000px" removed. I'd expect the testcase to render just like this reference case -- the 1000px shouldn't impact the minimum size that we clamp shrinkage at. Relevant spec text: # auto # When used as the value of a flex item's min main size property, # this keyword indicates a minimum of the min-content size, to help # ensure that the item is large enough to fit its contents. # # It is intended that this will compute to the ‘min-content’ keyword # when the specification defining it (Writing Modes Appendix D) is # sufficiently mature. So "min-width: auto" is supposed to effectively compute to "min-width: min-content". And when we resolve "min-width: min-content", I believe we're supposed to only use the contents of the block -- the computed value of "width" shouldn't affect the calculation. (If it did, then "width: min-content" would have a circular dependency.) 729182 4 ojan 2012-09-26 21:15:20 -0700 Thanks for filing the bug! I think we just didn't test cases of setting both the flex-basis and the width to fixed values 729195 5 ojan 2012-09-26 21:37:48 -0700 I take it back. You're totally right. We're using the width value for min-width:auto. Same as testcase 1, but with min-width:0 on the flex items: http://plexode.com/u/#N!(-webkit-Qj!dotted!b2_div2Z%3C2X%3EYW)height659)EVwidth62U(!!2R%0AIPH61!1!92O%3BrM4%22HboxKU4%22ELhould!EK%22XQJ)display66HflexEGaaaaaaE90pxOb8Z%2F_X66%3A!n4Z_!class%3DA)U!!I(R!!!!2!%20~http://plexode.com/eval3/#ht=!!ZstyleXU_.Hbox!%7BWV59R)border62pxjlackORJ-moz-HOJ!(HOJHOU%7DU_.a!%7B)-moz-P)!(P)PR)V1009!%2F*!SLhave!no!effect!*%2F)min-V0OWbackground6tealOU%7D(Z%2FstyleX(This!sLbe!a!50px-by-50px!teal!square.!ZbrX(No!teal!sLbe!outside!thejorder.(MaKaaa8(8R(This!_!sLonly!be!as!wide!as!the!text!it!contains.(MaKGGGGGG8(8R 818190 6 dholbert 2013-01-28 15:34:53 -0800 It's been ~4 months since the last comment here -- any updates / ETA for this? Just want to make sure this doesn't fall off the radar, since I think this could lead to interop issues & developer confusion. (I just received an email today regarding a testcase that rendered differently in Gecko vs. WebKit, and it ended up being due to this bug.) Per comment 5, it seems like this should at least be upgraded from UNCONFIRMED to NEW or something. :) 818194 7 tony 2013-01-28 15:38:32 -0800 Ojan is working on this, he got side tracked by mathml :) 818227 8 ojan 2013-01-28 16:06:48 -0800 Yup. I'm finally getting back to this. FWIW, I have been working on this and committing related patches. It's just that the fix requires rewriting a bunch of code. The final patch will be the one that fixes this as a one-liner. :) I'll try to get this done ASAP. 850599 9 ojan 2013-03-07 16:25:22 -0800 The spec has changed and this will be fixed with bug 111790. *** This bug has been marked as a duplicate of bug 111790 *** 165909 2012-09-26 18:19:03 -0700 2012-09-26 18:19:03 -0700 testcase 1 flexbox-minsize-bug.html text/html 958 dholbert PGh0bWw+CjwhLS0KICAgICBUaGlzIHRlc3QgY2hlY2tzIHRoYXQgYSBibG9jaydzIHJlc29sdmVk ICJtaW4td2lkdGg6IGF1dG8iIHZhbHVlCiAgICAgaXMgaGFuZGxlZCBjb3JyZWN0bHkgKGkuZS4g aXNuJ3QgaW5mbHVlbmNlZCBieSB0aGUgIndpZHRoIiBwcm9wZXJ0eSkuCi0tPgogIDxoZWFkPgog ICAgPHN0eWxlPgogICAgICBkaXYuZmxleGJveCB7CiAgICAgICAgaGVpZ2h0OiA1MHB4OwogICAg ICAgIHdpZHRoOiA1MHB4OwoKICAgICAgICBib3JkZXI6IDJweCBkb3R0ZWQgYmxhY2s7CgogICAg ICAgIGRpc3BsYXk6IC1tb3otZmxleDsKICAgICAgICBkaXNwbGF5OiAtd2Via2l0LWZsZXg7CiAg ICAgICAgZGlzcGxheTogZmxleDsKICAgICAgfQogICAgICBkaXYuYSB7CiAgICAgICAgLW1vei1m bGV4OiAxIDEgMHB4OwogICAgICAgIC13ZWJraXQtZmxleDogMSAxIDBweDsKICAgICAgICBmbGV4 OiAxIDEgMHB4OwoKICAgICAgICB3aWR0aDogMTAwMHB4OyAvKiBTaG91bGQgaGF2ZSBubyBlZmZl Y3QgKi8KCiAgICAgICAgaGVpZ2h0OiA1MHB4OwogICAgICAgIGJhY2tncm91bmQ6IHRlYWw7CiAg ICAgIH0KICAgIDwvc3R5bGU+CiAgPC9oZWFkPgogIDxib2R5PgogICAgVGhpcyBzaG91bGQgYmUg YSA1MHB4LWJ5LTUwcHggdGVhbCBzcXVhcmUuIDxicj4KICAgIE5vIHRlYWwgc2hvdWxkIGJlIG91 dHNpZGUgdGhlIGRvdHRlZCBib3JkZXIuCiAgICA8ZGl2IGNsYXNzPSJmbGV4Ym94Ij4KICAgICAg PGRpdiBjbGFzcz0iYSI+YWFhPC9kaXY+CiAgICA8L2Rpdj4KCiAgICBUaGlzIGRpdiBzaG91bGQg b25seSBiZSBhcyB3aWRlIGFzIHRoZSB0ZXh0IGl0IGNvbnRhaW5zLgogICAgPGRpdiBjbGFzcz0i ZmxleGJveCI+CiAgICAgIDxkaXYgY2xhc3M9ImEiPmFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYTwvZGl2PgogICAgPC9kaXY+CiAgPC9ib2R5Pgo8L2h0bWw+Cg== 165910 2012-09-26 18:29:30 -0700 2012-09-26 18:29:30 -0700 reference case 1 flexbox-minsize-reference.html text/html 905 dholbert PGh0bWw+CjwhLS0KICAgICBUaGlzIHRlc3QgY2hlY2tzIHRoYXQgYSBibG9jaydzIHJlc29sdmVk ICJtaW4td2lkdGg6IGF1dG8iIHZhbHVlCiAgICAgaXMgaGFuZGxlZCBjb3JyZWN0bHkgKGkuZS4g aXNuJ3QgaW5mbHVlbmNlZCBieSB0aGUgIndpZHRoIiBwcm9wZXJ0eSkuCi0tPgogIDxoZWFkPgog ICAgPHN0eWxlPgogICAgICBkaXYuZmxleGJveCB7CiAgICAgICAgaGVpZ2h0OiA1MHB4OwogICAg ICAgIHdpZHRoOiA1MHB4OwoKICAgICAgICBib3JkZXI6IDJweCBkb3R0ZWQgYmxhY2s7CgogICAg ICAgIGRpc3BsYXk6IC1tb3otZmxleDsKICAgICAgICBkaXNwbGF5OiAtd2Via2l0LWZsZXg7CiAg ICAgICAgZGlzcGxheTogZmxleDsKICAgICAgfQogICAgICBkaXYuYSB7CiAgICAgICAgLW1vei1m bGV4OiAxIDEgMHB4OwogICAgICAgIC13ZWJraXQtZmxleDogMSAxIDBweDsKICAgICAgICBmbGV4 OiAxIDEgMHB4OwogICAgICAgIGhlaWdodDogNTBweDsKICAgICAgICBiYWNrZ3JvdW5kOiB0ZWFs OwogICAgICB9CiAgICA8L3N0eWxlPgogIDwvaGVhZD4KICA8Ym9keT4KICAgIFRoaXMgc2hvdWxk IGJlIGEgNTBweC1ieS01MHB4IHRlYWwgc3F1YXJlLiA8YnI+CiAgICBObyB0ZWFsIHNob3VsZCBi ZSBvdXRzaWRlIHRoZSBkb3R0ZWQgYm9yZGVyLgogICAgPGRpdiBjbGFzcz0iZmxleGJveCI+CiAg ICAgIDxkaXYgY2xhc3M9ImEiPmFhYTwvZGl2PgogICAgPC9kaXY+CgogICAgVGhpcyBkaXYgc2hv dWxkIG9ubHkgYmUgYXMgd2lkZSBhcyB0aGUgdGV4dCBpdCBjb250YWlucy4KICAgIDxkaXYgY2xh c3M9ImZsZXhib3giPgogICAgICA8ZGl2IGNsYXNzPSJhIj5hYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWE8L2Rpdj4KICAgIDwvZGl2PgogIDwvYm9keT4KPC9odG1sPgo=