97608 2012-09-25 14:52:11 -0700 Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation 2012-10-03 23:52:09 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98343 1 benjamin benjamin sam oldest_to_newest 727989 0 benjamin 2012-09-25 14:52:11 -0700 All tests passing, yeeaaaahh! ;) 727993 1 165682 benjamin 2012-09-25 15:02:04 -0700 Created attachment 165682 Patch 734053 2 benjamin 2012-10-03 14:45:50 -0700 Committed r130325: <http://trac.webkit.org/changeset/130325> 165682 2012-09-25 15:02:04 -0700 2012-10-02 20:18:40 -0700 Patch bug-97608-20120925150124.patch text/plain 7651 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmFkZmQyMzJkZGVkZDJmMzMyYjY2Zjg4Yzg2NDg4YTMw YmZiODIyZi4uZjdhNTcxODExOTlhMDJlMmY0ZWU0NzliNDVjYWQwMzM0ZGNiZjIyOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM4 IEBACiAyMDEyLTA5LTI1ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgog CisgICAgICAgIEZpeCBHZW9sb2NhdGlvbi93aW5kb3ctY2xvc2UtY3Jhc2guaHRtbCBhbmQgaGFy ZGVuIFdlYktpdFRlc3RSdW5uZXIgZm9yIEdlb2xvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzYwOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0ZXN0IGZhc3QvZG9tL0dlb2xvY2F0aW9u L3dpbmRvdy1jbG9zZS1jcmFzaC5odG1sIHdhcyBjcmFzaGluZyBiZWNhdXNlCisgICAgICAgIGhh bmRsZUdlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3QoKSB3YXMgZXhlY3V0ZWQgb24gdGhlIHdy b25nIHBvaW50ZXIuIERlcGVuZGluZyBvbiBob3cKKyAgICAgICAgdGhlIHBhZ2Ugd2FzIGNyZWF0 ZWQsIHRoZSB2b2lkKiBjbGllbnRJbmZvIGNhbiBlaXRoZXIgYmUgYSBQbGF0Zm9ybVdlYlZpZXcg b3IKKyAgICAgICAgYSBUZXN0Q29udHJvbGxlci4KKworICAgICAgICBVc2luZyB0aGUgZ2xvYmFs IFRlc3RDb250cm9sbGVyIGZpeGVzIHRoZSBpc3N1ZS4KKworICAgICAgICAqIFdlYktpdFRlc3RS dW5uZXIvR2VvbG9jYXRpb25Qcm92aWRlck1vY2suY3BwOgorICAgICAgICAoV1RSOjpHZW9sb2Nh dGlvblByb3ZpZGVyTW9jazo6c2V0UG9zaXRpb24pOgorICAgICAgICAoV1RSOjpHZW9sb2NhdGlv blByb3ZpZGVyTW9jazo6c2V0UG9zaXRpb25VbmF2YWlsYWJsZUVycm9yKToKKyAgICAgICAgVG8g YmUgcmVsaWFibGUsIHRoZSB0ZXN0IGZhc3QvZG9tL0dlb2xvY2F0aW9uL21heGltdW0tYWdlLmh0 bWwgbmVlZHMgdGhlIHNldHRpbmcgdGhlIHBvc2l0aW9uCisgICAgICAgIHRvIGNsZWFyIHRoZSBl cnJvciBhbmQgdmljZSB2ZXJzYS4KKyAgICAgICAgVGhpcyBpcyB0aGUgc2FtZSBiZWhhdmlvciBh cyBHZW9sb2NhdGlvbkNsaWVudE1vY2sgYW5kIE1vY2tHZW9sb2NhdGlvblByb3ZpZGVyIG9mIFdl YktpdDEuCisKKyAgICAgICAgKFdUUjo6R2VvbG9jYXRpb25Qcm92aWRlck1vY2s6OnNlbmRQb3Np dGlvbklmTmVlZGVkKToKKyAgICAgICAgKFdUUjo6R2VvbG9jYXRpb25Qcm92aWRlck1vY2s6OnNl bmRFcnJvcklmTmVlZGVkKToKKyAgICAgICAgU29tZSB0ZXN0cyBleHBlY3QgdGhlIHBvc2l0aW9u L2Vycm9yIGNhbnQgYmUgc2VudCBtdWx0aXBsZSB0aW1lLAorICAgICAgICBqdXN0IGtlZXAgdGhl IHBvc2l0aW9uIGFmdGVyIHNlbmRpbmcuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rl c3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6ZGVjaWRlUG9saWN5Rm9yR2VvbG9jYXRp b25QZXJtaXNzaW9uUmVxdWVzdCk6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpkZWNp ZGVQb2xpY3lGb3JHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0SWZQb3NzaWJsZSk6CisgICAg ICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oOgorICAgICAgICBMZXQncyBw bGF5IGFzIGlmIHdlIGRpZCBub3Qga25vdyB3aGF0IGlzIGluIEdlb2xvY2F0aW9uUGVybWlzc2lv blJlcXVlc3RNYW5hZ2VyUHJveHkgbGlrZSBhIHJlYWwKKyAgICAgICAgY2xpZW50IHdvdWxkIGhh dmUgdG8gZG8uCisKKzIwMTItMDktMjUgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBs ZS5jb20+CisKICAgICAgICAgQWRkIG1pc3Npbmcgc3VwcG9ydCBmb3IgR2VvbG9jYXRpb24gdGVz dHMgb24gV2ViS2l0MgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTc1MTgKIApkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HZW9sb2Nh dGlvblByb3ZpZGVyTW9jay5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dlb2xvY2F0aW9u UHJvdmlkZXJNb2NrLmNwcAppbmRleCA1ODc3YzY1ZjY5NTRhNDkwZTZiYzI2YTBmMzEzOWE4N2U1 ZjlkYjg3Li5hNWI2YjY1Mjc2ODI3NDMxY2Q3M2NlMGI3ZGMwODIxYTIzNTA3MjA2IDEwMDY0NAot LS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dlb2xvY2F0aW9uUHJvdmlkZXJNb2NrLmNwcAor KysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dlb2xvY2F0aW9uUHJvdmlkZXJNb2NrLmNwcApA QCAtNjEsNiArNjEsMTAgQEAgR2VvbG9jYXRpb25Qcm92aWRlck1vY2s6Okdlb2xvY2F0aW9uUHJv dmlkZXJNb2NrKFdLQ29udGV4dFJlZiBjb250ZXh0KQogdm9pZCBHZW9sb2NhdGlvblByb3ZpZGVy TW9jazo6c2V0UG9zaXRpb24oZG91YmxlIGxhdGl0dWRlLCBkb3VibGUgbG9uZ2l0dWRlLCBkb3Vi bGUgYWNjdXJhY3kpCiB7CiAgICAgbV9wb3NpdGlvbi5hZG9wdChXS0dlb2xvY2F0aW9uUG9zaXRp b25DcmVhdGUoY3VycmVudFRpbWUoKSwgbGF0aXR1ZGUsIGxvbmdpdHVkZSwgYWNjdXJhY3kpKTsK KworICAgIG1faGFzRXJyb3IgPSBmYWxzZTsKKyAgICBtX2Vycm9yTWVzc2FnZS5jbGVhcigpOwor CiAgICAgc2VuZFBvc2l0aW9uSWZOZWVkZWQoKTsKIH0KIApAQCAtNjgsNiArNzIsOSBAQCB2b2lk IEdlb2xvY2F0aW9uUHJvdmlkZXJNb2NrOjpzZXRQb3NpdGlvblVuYXZhaWxhYmxlRXJyb3IoV0tT dHJpbmdSZWYgZXJyb3JNZXNzYQogewogICAgIG1fZXJyb3JNZXNzYWdlID0gZXJyb3JNZXNzYWdl OwogICAgIG1faGFzRXJyb3IgPSB0cnVlOworCisgICAgbV9wb3NpdGlvbi5jbGVhcigpOworCiAg ICAgc2VuZEVycm9ySWZOZWVkZWQoKTsKIH0KIApAQCAtODksMTkgKzk2LDE0IEBAIHZvaWQgR2Vv bG9jYXRpb25Qcm92aWRlck1vY2s6OnN0b3BVcGRhdGluZyhXS0dlb2xvY2F0aW9uTWFuYWdlclJl ZiBnZW9sb2NhdGlvbk1hCiAKIHZvaWQgR2VvbG9jYXRpb25Qcm92aWRlck1vY2s6OnNlbmRQb3Np dGlvbklmTmVlZGVkKCkKIHsKLSAgICBpZiAobV9pc0FjdGl2ZSAmJiBtX3Bvc2l0aW9uKSB7Cisg ICAgaWYgKG1faXNBY3RpdmUgJiYgbV9wb3NpdGlvbikKICAgICAgICAgV0tHZW9sb2NhdGlvbk1h bmFnZXJQcm92aWRlckRpZENoYW5nZVBvc2l0aW9uKG1fZ2VvbG9jYXRpb25NYW5hZ2VyLCBtX3Bv c2l0aW9uLmdldCgpKTsKLSAgICAgICAgbV9wb3NpdGlvbi5jbGVhcigpOwotICAgIH0KIH0KIAog dm9pZCBHZW9sb2NhdGlvblByb3ZpZGVyTW9jazo6c2VuZEVycm9ySWZOZWVkZWQoKQogewotICAg IGlmIChtX2lzQWN0aXZlICYmIG1faGFzRXJyb3IpIHsKLSAgICAgICAgbV9oYXNFcnJvciA9IGZh bHNlOworICAgIGlmIChtX2lzQWN0aXZlICYmIG1faGFzRXJyb3IpCiAgICAgICAgIFdLR2VvbG9j YXRpb25NYW5hZ2VyUHJvdmlkZXJEaWRGYWlsVG9EZXRlcm1pbmVQb3NpdGlvbldpdGhFcnJvck1l c3NhZ2UobV9nZW9sb2NhdGlvbk1hbmFnZXIsIG1fZXJyb3JNZXNzYWdlLmdldCgpKTsKLSAgICAg ICAgbV9lcnJvck1lc3NhZ2UuY2xlYXIoKTsKLSAgICB9CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdU UgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAg Yi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAppbmRleCBlNmJkYzlk ZDYzM2IyZjEzMTRkZTM5MmIyZjI1ODcyNTA5M2I0ZDllLi45ZWI0OTU3ZWMyNTM3ZGVlOTg2ZmU2 NTQ4ZGZjY2JhZDA5NWIxZWY5IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rl c3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9s bGVyLmNwcApAQCAtMTc0LDggKzE3NCw3IEBAIHN0YXRpYyB2b2lkIHVuZm9jdXMoV0tQYWdlUmVm IHBhZ2UsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiAKIHN0YXRpYyB2b2lkIGRlY2lkZVBvbGlj eUZvckdlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3QoV0tQYWdlUmVmLCBXS0ZyYW1lUmVmLCBX S1NlY3VyaXR5T3JpZ2luUmVmLCBXS0dlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3RSZWYgcGVy bWlzc2lvblJlcXVlc3QsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7Ci0gICAgVGVzdENvbnRy b2xsZXIqIHRlc3RDb250cm9sbGVyID0gc3RhdGljX2Nhc3Q8VGVzdENvbnRyb2xsZXIqPihjb25z dF9jYXN0PHZvaWQqPihjbGllbnRJbmZvKSk7Ci0gICAgdGVzdENvbnRyb2xsZXItPmhhbmRsZUdl b2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3QocGVybWlzc2lvblJlcXVlc3QpOworICAgIFRlc3RD b250cm9sbGVyOjpzaGFyZWQoKS5oYW5kbGVHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0KHBl cm1pc3Npb25SZXF1ZXN0KTsKIH0KIAogV0tQYWdlUmVmIFRlc3RDb250cm9sbGVyOjpjcmVhdGVP dGhlclBhZ2UoV0tQYWdlUmVmIG9sZFBhZ2UsIFdLVVJMUmVxdWVzdFJlZiwgV0tEaWN0aW9uYXJ5 UmVmLCBXS0V2ZW50TW9kaWZpZXJzLCBXS0V2ZW50TW91c2VCdXR0b24sIGNvbnN0IHZvaWQqKQpA QCAtMTAzMSwxMiArMTAzMCwxMyBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjpkZWNpZGVQb2xpY3lG b3JHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0SWZQb3NzaWJsZSgpCiAgICAgICAgIHJldHVy bjsKIAogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9nZW9sb2NhdGlvblBlcm1pc3Npb25S ZXF1ZXN0cy5zaXplKCk7ICsraSkgewotICAgICAgICBXS0dlb2xvY2F0aW9uUGVybWlzc2lvblJl cXVlc3RSZWYmIHBlcm1pc3Npb25SZXF1ZXN0ID0gbV9nZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1 ZXN0c1tpXTsKKyAgICAgICAgV0tHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0UmVmIHBlcm1p c3Npb25SZXF1ZXN0ID0gbV9nZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0c1tpXS5nZXQoKTsK ICAgICAgICAgaWYgKG1faXNHZW9sb2NhdGlvblBlcm1pc3Npb25BbGxvd2VkKQogICAgICAgICAg ICAgV0tHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0QWxsb3cocGVybWlzc2lvblJlcXVlc3Qp OwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBXS0dlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVl c3REZW55KHBlcm1pc3Npb25SZXF1ZXN0KTsKICAgICB9CisgICAgbV9nZW9sb2NhdGlvblBlcm1p c3Npb25SZXF1ZXN0cy5jbGVhcigpOwogfQogCiB2b2lkIFRlc3RDb250cm9sbGVyOjpkZWNpZGVQ b2xpY3lGb3JOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdChXS1BhZ2VSZWYgcGFnZSwgV0tT ZWN1cml0eU9yaWdpblJlZiBvcmlnaW4sIFdLTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RS ZWYgcmVxdWVzdCwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKZGlmZiAtLWdpdCBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv VGVzdENvbnRyb2xsZXIuaAppbmRleCBmNzg4ODkyM2JkMWZlODQxMmFlOWUxOWRhYWU3ZjE1M2Mx YzExNTliLi41M2UxYTIxYzU2YzNjYTdhZDNlMThkYmJlYjFmZjRjYzI5NmIzMDZmIDEwMDY0NAot LS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmgKKysrIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCkBAIC0xNTQsNyArMTU0LDcgQEAgcHJp dmF0ZToKICAgICBib29sIG1fYmVmb3JlVW5sb2FkUmV0dXJuVmFsdWU7CiAKICAgICBPd25QdHI8 R2VvbG9jYXRpb25Qcm92aWRlck1vY2s+IG1fZ2VvbG9jYXRpb25Qcm92aWRlcjsKLSAgICBWZWN0 b3I8V0tHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0UmVmPiBtX2dlb2xvY2F0aW9uUGVybWlz c2lvblJlcXVlc3RzOworICAgIFZlY3RvcjxXS1JldGFpblB0cjxXS0dlb2xvY2F0aW9uUGVybWlz c2lvblJlcXVlc3RSZWY+ID4gbV9nZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0czsKICAgICBi b29sIG1faXNHZW9sb2NhdGlvblBlcm1pc3Npb25TZXQ7CiAgICAgYm9vbCBtX2lzR2VvbG9jYXRp b25QZXJtaXNzaW9uQWxsb3dlZDsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDc1M2FlMDkxZjY0NDRjYzRjNzc3MTMwMjg3 MzlhY2E1NjM3YWZiMmIuLmZhMTk1OTJmYWYwYmMyOGU1YzYyMjUyOGUwMzNmOGI4YzBhODhiOTUg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAxMi0wOS0yNSAgQmVuamFtaW4gUG91bGFpbiAgPGJw b3VsYWluQGFwcGxlLmNvbT4KIAorICAgICAgICBGaXggR2VvbG9jYXRpb24vd2luZG93LWNsb3Nl LWNyYXNoLmh0bWwgYW5kIGhhcmRlbiBXZWJLaXRUZXN0UnVubmVyIGZvciBHZW9sb2NhdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc2MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt L3drMi9Ta2lwcGVkOgorICAgICAgICBVbnNraXAgZmFzdC9kb20vR2VvbG9jYXRpb24vd2luZG93 LWNsb3NlLWNyYXNoLmh0bWwuCisKKzIwMTItMDktMjUgIEJlbmphbWluIFBvdWxhaW4gIDxicG91 bGFpbkBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIG1pc3Npbmcgc3VwcG9ydCBmb3IgR2VvbG9j YXRpb24gdGVzdHMgb24gV2ViS2l0MgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTc1MTgKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v d2syL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvU2tpcHBlZAppbmRleCA4ZmM1 MjFjMzc2ODhmNDNjNWU3MzVmZjUwNWIzZTk0NDY4ZWJmNzgzLi5lMDhmMzQxZThhM2MwOGFkMDE4 Y2E2ZDI1N2ZkMTA0MGIzMWNiOTJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93 azIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvU2tpcHBlZApAQCAtMjky LDkgKzI5Miw2IEBAIHBsYXRmb3JtL21hYy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0aW9uVUktZGlm ZmVyaW5nLWJhY2tncm91bmQuaHRtbAogcGxhdGZvcm0vbWFjL2VkaXRpbmcvZGVsZXRpbmcvZGVs ZXRpb25VSS1taW5pbXVtLXNpemUuaHRtbAogcGxhdGZvcm0vbWFjL2VkaXRpbmcvZGVsZXRpbmcv ZGVsZXRpb25VSS1zdWNjZXNzZnVsLWRlbGV0aW9uLmh0bWwKIAotIyBGYWlsIG9uIFdlYktpdDIs IHRoZSB0ZXN0IGNyYXNoLgotZmFzdC9kb20vR2VvbG9jYXRpb24vd2luZG93LWNsb3NlLWNyYXNo Lmh0bWwKLQogIyBXZWJLaXRUZXN0UnVubmVyIG5lZWRzIGxheW91dFRlc3RDb250cm9sbGVyLnNl dERhc2hib2FyZENvbXBhdGliaWxpdHlNb2RlCiAjIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDI1NDc+CiBmYXN0L2NhbnZhcy9jYW52YXMtZ3JhZGllbnQtYWRkU3Rv cC1lcnJvci5odG1sCg==