97486 2012-09-24 15:19:52 -0700 Replace 2 uses of updateLogicalHeight with computeLogicalHeight 2012-09-24 16:43:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96804 1 tony tony eric ojan webkit.review.bot oldest_to_newest 727040 0 tony 2012-09-24 15:19:52 -0700 Replace 2 uses of updateLogicalHeight with computeLogicalHeight 727049 1 165457 tony 2012-09-24 15:38:57 -0700 Created attachment 165457 Patch 727073 2 165457 webkit.review.bot 2012-09-24 16:43:09 -0700 Comment on attachment 165457 Patch Clearing flags on attachment: 165457 Committed r129427: <http://trac.webkit.org/changeset/129427> 727074 3 webkit.review.bot 2012-09-24 16:43:12 -0700 All reviewed patches have been landed. Closing bug. 165457 2012-09-24 15:38:57 -0700 2012-09-24 16:43:09 -0700 Patch bug-97486-20120924153818.patch text/plain 5165 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5Mzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRkNGFlZmM1NGQxNjM3 ODY4ZGM0ZWEyMzVkOTM3MjIzYTVjODQ0Yy4uNGVlZjY3MjE1ZDhjZTk3ZDcxOWIxMjg5MjI5NTY4 Y2JkNTEzMzU5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTI0ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVwbGFjZSAyIHVzZXMgb2Yg dXBkYXRlTG9naWNhbEhlaWdodCB3aXRoIGNvbXB1dGVMb2dpY2FsSGVpZ2h0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ4NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vcmUgd29yayBmb3IgYnVnIDk2 ODA0LiAgVGhpcyBpcyBqdXN0IGEgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBiZWhhdmlvciBzaG91bGQgYmUgdGhlIHNhbWUgYXMgYmVmb3JlLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxv d1RocmVhZDo6Y29tcHV0ZUxvZ2ljYWxIZWlnaHQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJGbG93VGhyZWFkLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uRmxv d1RocmVhZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJl YWQ6OmNvbXB1dGVMb2dpY2FsSGVpZ2h0KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuaDoKKyAgICAgICAgKFJlbmRl ck11bHRpQ29sdW1uRmxvd1RocmVhZCk6CisKIDIwMTItMDktMjQgIFRvbW15IFdpZGVuZmx5Y2h0 ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBGaXggdGhl IGluY29ycmVjdGx5IHNwZWxsZWQgUlRDUGVlckNvbm5lY3Rpb246Om9ubmVnb3RpYXRpb25uZWVk ZWQgY2FsbGJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG bG93VGhyZWFkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFk LmNwcAppbmRleCAwNzQxZWE4YzhhZjQ4MmUyNWE5YzVjYzQyYmU0Zjg5ZjNmNDUzMTY0Li5kNWE5 OWI3YmIwYTdhN2RkMzliYWViZGMyMjhiYmZiMjNhYzdmOTUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwCkBAIC0yMjIsMTkgKzIyMiwxOCBAQCB2 b2lkIFJlbmRlckZsb3dUaHJlYWQ6OnVwZGF0ZUxvZ2ljYWxXaWR0aCgpCiAgICAgfQogfQogCi12 b2lkIFJlbmRlckZsb3dUaHJlYWQ6OnVwZGF0ZUxvZ2ljYWxIZWlnaHQoKQordm9pZCBSZW5kZXJG bG93VGhyZWFkOjpjb21wdXRlTG9naWNhbEhlaWdodChMYXlvdXRVbml0LCBMYXlvdXRVbml0IGxv Z2ljYWxUb3AsIExvZ2ljYWxFeHRlbnRDb21wdXRlZFZhbHVlcyYgY29tcHV0ZWRWYWx1ZXMpIGNv bnN0CiB7Ci0gICAgTGF5b3V0VW5pdCBsb2dpY2FsSGVpZ2h0ID0gMDsKKyAgICBjb21wdXRlZFZh bHVlcy5tX3Bvc2l0aW9uID0gbG9naWNhbFRvcDsKKyAgICBjb21wdXRlZFZhbHVlcy5tX2V4dGVu dCA9IDA7CiAKLSAgICBmb3IgKFJlbmRlclJlZ2lvbkxpc3Q6Oml0ZXJhdG9yIGl0ZXIgPSBtX3Jl Z2lvbkxpc3QuYmVnaW4oKTsgaXRlciAhPSBtX3JlZ2lvbkxpc3QuZW5kKCk7ICsraXRlcikgewor ICAgIGZvciAoUmVuZGVyUmVnaW9uTGlzdDo6Y29uc3RfaXRlcmF0b3IgaXRlciA9IG1fcmVnaW9u TGlzdC5iZWdpbigpOyBpdGVyICE9IG1fcmVnaW9uTGlzdC5lbmQoKTsgKytpdGVyKSB7CiAgICAg ICAgIFJlbmRlclJlZ2lvbiogcmVnaW9uID0gKml0ZXI7CiAgICAgICAgIGlmICghcmVnaW9uLT5p c1ZhbGlkKCkpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgQVNTRVJUKCFyZWdpb24t Pm5lZWRzTGF5b3V0KCkpOwotICAgICAgICBsb2dpY2FsSGVpZ2h0ICs9IHJlZ2lvbi0+bG9naWNh bEhlaWdodE9mQWxsRmxvd1RocmVhZENvbnRlbnQoKTsKKyAgICAgICAgY29tcHV0ZWRWYWx1ZXMu bV9leHRlbnQgKz0gcmVnaW9uLT5sb2dpY2FsSGVpZ2h0T2ZBbGxGbG93VGhyZWFkQ29udGVudCgp OwogICAgIH0KLQotICAgIHNldExvZ2ljYWxIZWlnaHQobG9naWNhbEhlaWdodCk7CiB9CiAKIHZv aWQgUmVuZGVyRmxvd1RocmVhZDo6cGFpbnRGbG93VGhyZWFkUG9ydGlvbkluUmVnaW9uKFBhaW50 SW5mbyYgcGFpbnRJbmZvLCBSZW5kZXJSZWdpb24qIHJlZ2lvbiwgTGF5b3V0UmVjdCBmbG93VGhy ZWFkUG9ydGlvblJlY3QsIExheW91dFJlY3QgZmxvd1RocmVhZFBvcnRpb25PdmVyZmxvd1JlY3Qs IGNvbnN0IExheW91dFBvaW50JiBwYWludE9mZnNldCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmggYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5oCmluZGV4IGQwOTE4M2Q5NTY2MjYwZGFjMzBlNGVm NTg5NTZkZGMxZjY5MjAyYzYuLmI5NDJlZWU1NzJlOTVhZGFjM2MwODllMTMyNTM3NjU2NmRkMTY1 MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFk LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuaApAQCAt NzQsNyArNzQsNyBAQCBwdWJsaWM6CiAgICAgY29uc3QgUmVuZGVyUmVnaW9uTGlzdCYgcmVuZGVy UmVnaW9uTGlzdCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVnaW9uTGlzdDsgfQogCiAgICAgdmlydHVh bCB2b2lkIHVwZGF0ZUxvZ2ljYWxXaWR0aCgpIE9WRVJSSURFOwotICAgIHZpcnR1YWwgdm9pZCB1 cGRhdGVMb2dpY2FsSGVpZ2h0KCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIGNvbXB1dGVM b2dpY2FsSGVpZ2h0KExheW91dFVuaXQgbG9naWNhbEhlaWdodCwgTGF5b3V0VW5pdCBsb2dpY2Fs VG9wLCBMb2dpY2FsRXh0ZW50Q29tcHV0ZWRWYWx1ZXMmKSBjb25zdCBPVkVSUklERTsKIAogICAg IHZvaWQgcGFpbnRGbG93VGhyZWFkUG9ydGlvbkluUmVnaW9uKFBhaW50SW5mbyYsIFJlbmRlclJl Z2lvbiosIExheW91dFJlY3QgZmxvd1RocmVhZFBvcnRpb25SZWN0LCBMYXlvdXRSZWN0IGZsb3dU aHJlYWRQb3J0aW9uT3ZlcmZsb3dSZWN0LCBjb25zdCBMYXlvdXRQb2ludCYpIGNvbnN0OwogICAg IGJvb2wgaGl0VGVzdEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdpb24oUmVuZGVyUmVnaW9uKiwgTGF5 b3V0UmVjdCBmbG93VGhyZWFkUG9ydGlvblJlY3QsIExheW91dFJlY3QgZmxvd1RocmVhZFBvcnRp b25PdmVyZmxvd1JlY3QsIGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiwgSGl0VGVzdFJlc3VsdCYsIGNv bnN0IEhpdFRlc3RMb2NhdGlvbiYgbG9jYXRpb25JbkNvbnRhaW5lciwgY29uc3QgTGF5b3V0UG9p bnQmIGFjY3VtdWxhdGVkT2Zmc2V0KSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZC5jcHAKaW5kZXggZTU1M2M1 NDAxYzBlMTBiMzk1MWVjM2VhYjBhMGFlNDdhMWUxMDMxMC4uNTYyNTA2ODQyYzE4ODdlOWE5ZjQ1 N2NkOWI0NWI3Y2I4ZWIwZWUyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZC5jcHAKQEAgLTQyLDQgKzQyLDExIEBA IGNvbnN0IGNoYXIqIFJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZDo6cmVuZGVyTmFtZSgpIGNv bnN0CiAgICAgcmV0dXJuICJSZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQiOwogfQogCit2b2lk IFJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZDo6Y29tcHV0ZUxvZ2ljYWxIZWlnaHQoTGF5b3V0 VW5pdCBsb2dpY2FsSGVpZ2h0LCBMYXlvdXRVbml0IGxvZ2ljYWxUb3AsIExvZ2ljYWxFeHRlbnRD b21wdXRlZFZhbHVlcyYgY29tcHV0ZWRWYWx1ZXMpIGNvbnN0Cit7CisgICAgLy8gV2Ugc2ltcGx5 IHJlbWFpbiBhdCBvdXIgaW50cmluc2ljIGhlaWdodC4KKyAgICBjb21wdXRlZFZhbHVlcy5tX2V4 dGVudCA9IGxvZ2ljYWxIZWlnaHQ7CisgICAgY29tcHV0ZWRWYWx1ZXMubV9wb3NpdGlvbiA9IGxv Z2ljYWxUb3A7Cit9CisKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuaAppbmRleCAzNjNjZDA3NzEyOGNiZjVjOTY4OTc0 ZTdmMjkyMmU3Yzc3YTQ3NTQ4Li41OTUyMjI3ODQ2MWJhYjdlNzY1ZGNjMmI3MzYxMmU0MTJhMmJj NTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1 bW5GbG93VGhyZWFkLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRp Q29sdW1uRmxvd1RocmVhZC5oCkBAIC0zOSw3ICszOSw3IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAg ICAgdmlydHVhbCBjb25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3QgT1ZFUlJJREU7CiAgICAg Ci0gICAgdmlydHVhbCB2b2lkIHVwZGF0ZUxvZ2ljYWxIZWlnaHQoKSBPVkVSUklERSB7IH0gLy8g V2Ugc2ltcGx5IHJlbWFpbiBhdCBvdXIgaW50cmluc2ljIGhlaWdodC4KKyAgICB2aXJ0dWFsIHZv aWQgY29tcHV0ZUxvZ2ljYWxIZWlnaHQoTGF5b3V0VW5pdCBsb2dpY2FsSGVpZ2h0LCBMYXlvdXRV bml0IGxvZ2ljYWxUb3AsIExvZ2ljYWxFeHRlbnRDb21wdXRlZFZhbHVlcyYpIGNvbnN0IE9WRVJS SURFOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=