97456 2012-09-24 08:21:06 -0700 MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback 2012-09-24 11:56:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw abarth eric.carlson feature-media-reviews ojan webkit.review.bot oldest_to_newest 726679 0 tommyw 2012-09-24 08:21:06 -0700 Rename onnegotationneeded to onnegotiationneeded. 726701 1 165389 tommyw 2012-09-24 08:38:09 -0700 Created attachment 165389 Patch 726894 2 165389 webkit.review.bot 2012-09-24 11:56:01 -0700 Comment on attachment 165389 Patch Clearing flags on attachment: 165389 Committed r129397: <http://trac.webkit.org/changeset/129397> 726895 3 webkit.review.bot 2012-09-24 11:56:05 -0700 All reviewed patches have been landed. Closing bug. 165389 2012-09-24 08:38:09 -0700 2012-09-24 11:56:01 -0700 Patch bug-97456-20120924173730.patch text/plain 6046 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk2ZGNlNGUzYzczYTEz OWI1MWFhMDhhYTBlZGJmMDUzYzVjZjc4MS4uODFjZTZkOTU5OTE1NTVmYWQ2MzczOTI2NTA0Mjlm N2RlMmE1NGFiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTI0ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogRml4IHRoZSBpbmNvcnJlY3RseSBzcGVsbGVkIFJUQ1BlZXJDb25uZWN0aW9uOjpvbm5l Z290aWF0aW9ubmVlZGVkIGNhbGxiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05NzQ1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbmFtZWQgb25uZWdvdGF0aW9ubmVlZGVkIHRvIG9ubmVnb3RpYXRp b25uZWVkZWQuCisKKyAgICAgICAgRXhpc3RpbmcgdGVzdCB1cGRhdGVkLiAKKworICAgICAgICAq IE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UlRDUGVlckNvbm5lY3Rpb246Om5lZ290aWF0aW9uTmVlZGVkKToKKyAgICAgICAgKiBN b2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmg6CisgICAgICAgIChSVENQZWVy Q29ubmVjdGlvbik6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVj dGlvbi5pZGw6CisgICAgICAgICogZG9tL0V2ZW50TmFtZXMuaDoKKyAgICAgICAgKFdlYkNvcmUp OgorCiAyMDEyLTA5LTI0ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgogCiAgICAg ICAgIFVzZSB1bnNpZ25lZCBjaGFyIGZvciBiaXRmaWVsZCBpbnN0ZWFkIG9mIHVuc2lnbmVkLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29u bmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJD b25uZWN0aW9uLmNwcAppbmRleCA3ODg5NmE3OTY5MmI1ZTBjNTQ2NGRhNDQwY2Y3MzIzZjVhNWEz YjRkLi5jYjliYTdjNWE4NjU2ZTEyZjQ1NGVjMTkwZDE5MWZiOWQ0YzIyYjM0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0 aW9uLmNwcApAQCAtMzkzLDcgKzM5Myw3IEBAIHZvaWQgUlRDUGVlckNvbm5lY3Rpb246OmNsb3Nl KEV4Y2VwdGlvbkNvZGUmIGVjKQogCiB2b2lkIFJUQ1BlZXJDb25uZWN0aW9uOjpuZWdvdGlhdGlv bk5lZWRlZCgpCiB7Ci0gICAgZGlzcGF0Y2hFdmVudChFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMo KS5uZWdvdGF0aW9ubmVlZGVkRXZlbnQsIGZhbHNlLCBmYWxzZSkpOworICAgIGRpc3BhdGNoRXZl bnQoRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkubmVnb3RpYXRpb25uZWVkZWRFdmVudCwgZmFs c2UsIGZhbHNlKSk7CiB9CiAKIHZvaWQgUlRDUGVlckNvbm5lY3Rpb246OmRpZEdlbmVyYXRlSWNl Q2FuZGlkYXRlKFBhc3NSZWZQdHI8UlRDSWNlQ2FuZGlkYXRlRGVzY3JpcHRvcj4gaWNlQ2FuZGlk YXRlRGVzY3JpcHRvcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaAppbmRleCAxNjE1NTgxYTU1ZmEzNTdlMzc1ZDBjNzI3 NjQxZTAzMWE4YmFlZjM1Li44NGQxZTFmYmU0NmNlZmJmNGJlYmY1ZDRiOTFjN2E5ZjRlOTNlMTk3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJD b25uZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQ ZWVyQ29ubmVjdGlvbi5oCkBAIC04Niw3ICs4Niw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgY2xv c2UoRXhjZXB0aW9uQ29kZSYpOwogCi0gICAgREVGSU5FX0FUVFJJQlVURV9FVkVOVF9MSVNURU5F UihuZWdvdGF0aW9ubmVlZGVkKTsKKyAgICBERUZJTkVfQVRUUklCVVRFX0VWRU5UX0xJU1RFTkVS KG5lZ290aWF0aW9ubmVlZGVkKTsKICAgICBERUZJTkVfQVRUUklCVVRFX0VWRU5UX0xJU1RFTkVS KGljZWNhbmRpZGF0ZSk7CiAgICAgREVGSU5FX0FUVFJJQlVURV9FVkVOVF9MSVNURU5FUihvcGVu KTsKICAgICBERUZJTkVfQVRUUklCVVRFX0VWRU5UX0xJU1RFTkVSKHN0YXRlY2hhbmdlKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5l Y3Rpb24uaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29u bmVjdGlvbi5pZGwKaW5kZXggOTY3YWQ0MDIzZjc2NTYxOWQ1MTc5NWMwNDNjZWU1NTBhMTk5NTdi Yy4uYmM0MzkwZjU0NmUyZWI2M2ExNjVkYjRhZTE3NDU1ZTcxNTgyNWQ3NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5pZGwK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlv bi5pZGwKQEAgLTc1LDcgKzc1LDcgQEAgbW9kdWxlIG1lZGlhc3RyZWFtIHsKICAgICAgICAgdm9p ZCBjbG9zZSgpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKIAotICAgICAgICBh dHRyaWJ1dGUgRXZlbnRMaXN0ZW5lciBvbm5lZ290YXRpb25uZWVkZWQ7CisgICAgICAgIGF0dHJp YnV0ZSBFdmVudExpc3RlbmVyIG9ubmVnb3RpYXRpb25uZWVkZWQ7CiAgICAgICAgIGF0dHJpYnV0 ZSBFdmVudExpc3RlbmVyIG9uaWNlY2FuZGlkYXRlOwogICAgICAgICBhdHRyaWJ1dGUgRXZlbnRM aXN0ZW5lciBvbm9wZW47CiAgICAgICAgIGF0dHJpYnV0ZSBFdmVudExpc3RlbmVyIG9uc3RhdGVj aGFuZ2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnROYW1lcy5oIGIvU291 cmNlL1dlYkNvcmUvZG9tL0V2ZW50TmFtZXMuaAppbmRleCBiM2NkODQ2ZWE4MDFiYTNjZDc2NzIx Y2JhNTIxZTlmYTAzMzhiMmEzLi4xMzZmN2FhYzIwZTc1YTdhMzk0OWJhZDAyMTgyZDM0MDQwZTk4 Zjc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnROYW1lcy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FdmVudE5hbWVzLmgKQEAgLTIyOSw3ICsyMjksNyBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgbWFjcm8odW5tdXRlKSBcCiAgICAgbWFjcm8oaWNlY2hhbmdlKSBc CiAgICAgbWFjcm8oaWNlY2FuZGlkYXRlKSBcCi0gICAgbWFjcm8obmVnb3RhdGlvbm5lZWRlZCkg XAorICAgIG1hY3JvKG5lZ290aWF0aW9ubmVlZGVkKSBcCiAgICAgXAogICAgIG1hY3JvKHNob3cp IFwKICAgICBcCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNjczNmY4Njg5ZWVjNDIwYzI1MjU5MDE0MzQ2ODViYzJiOTUxOGU0 NC4uNDEzYzM1YjBjNWVlZWVjOTgxNTZmYzlkMzYzNzQwYTQ2NDkxYmUwOCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA5LTI0ICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUu Y29tPgorCisgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogRml4IHRoZSBpbmNvcnJlY3RseSBzcGVs bGVkIFJUQ1BlZXJDb25uZWN0aW9uOjpvbm5lZ290aWF0aW9ubmVlZGVkIGNhbGxiYWNrCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ1NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZWQgb25uZWdv dGF0aW9ubmVlZGVkIHRvIG9ubmVnb3RpYXRpb25uZWVkZWQuCisKKyAgICAgICAgKiBmYXN0L21l ZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLW9ubmVnb3RpYXRpb25uZWVkZWQtZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24tb25uZWdv dGlhdGlvbm5lZWRlZC5odG1sOgorCiAyMDEyLTA5LTI0ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hy aXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gUmViYXNlbGluZSBzZXZl cmFsIHRlc3QgY2FzZXMgaW4gU2tpcHBlZCBsaXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLW9ubmVnb3RpYXRpb25uZWVkZWQtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlv bi1vbm5lZ290aWF0aW9ubmVlZGVkLWV4cGVjdGVkLnR4dAppbmRleCA4ZWU3NTEzOTk4ODE1ZDdm ZTMzZTg5YWM5OTU0NjM5MzcyOGJiMjc0Li5kMGY5OWU4NTI2NGJiYzRlMzZmMmViZjg2NTVhYjAy YTRhOWQzOTY0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1Bl ZXJDb25uZWN0aW9uLW9ubmVnb3RpYXRpb25uZWVkZWQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24tb25uZWdvdGlhdGlvbm5l ZWRlZC1leHBlY3RlZC50eHQKQEAgLTQsNyArNCw3IEBAIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNl ZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRF CiAKIAogUEFTUyBHb3QgYSBzdHJlYW0uCi1QQVNTIG9uTmVnb3RhdGlvbk5lZWRlZCB3YXMgY2Fs bGVkLgorUEFTUyBvbk5lZ290aWF0aW9uTmVlZGVkIHdhcyBjYWxsZWQuCiBQQVNTIHN1Y2Nlc3Nm dWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24tb25uZWdvdGlhdGlvbm5lZWRl ZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1v bm5lZ290aWF0aW9ubmVlZGVkLmh0bWwKaW5kZXggZDQ2NDZkZTcwNjk3ZDJlMTU4YzI3NmExNjJl OTY4ZTBmMTI2YzdhYi4uZDhlOGRmMTBkOGRlYTgwYjRiYmEzYmJjNjljZjk1NmJiNjMzYTNmOCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlv bi1vbm5lZ290aWF0aW9ubmVlZGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0 cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1vbm5lZ290aWF0aW9ubmVlZGVkLmh0bWwKQEAgLTI0LDgg KzI0LDggQEAgZnVuY3Rpb24gZ2V0VXNlck1lZGlhKGRpY3Rpb25hcnksIGNhbGxiYWNrKSB7CiAg ICAgfQogfQogCi1mdW5jdGlvbiBvbk5lZ290YXRpb25OZWVkZWQoZXZlbnQpIHsKLSAgICB0ZXN0 UGFzc2VkKCdvbk5lZ290YXRpb25OZWVkZWQgd2FzIGNhbGxlZC4nKTsKK2Z1bmN0aW9uIG9uTmVn b3RpYXRpb25OZWVkZWQoZXZlbnQpIHsKKyAgICB0ZXN0UGFzc2VkKCdvbk5lZ290aWF0aW9uTmVl ZGVkIHdhcyBjYWxsZWQuJyk7CiAKICAgICBmaW5pc2hKU1Rlc3QoKTsKIH0KQEAgLTM1LDcgKzM1 LDcgQEAgZnVuY3Rpb24gZ290U3RyZWFtKHMpIHsKICAgICBzdHJlYW0gPSBzOwogCiAgICAgcGMg PSBuZXcgd2Via2l0UlRDUGVlckNvbm5lY3Rpb24obnVsbCwgbnVsbCk7Ci0gICAgcGMub25uZWdv dGF0aW9ubmVlZGVkID0gb25OZWdvdGF0aW9uTmVlZGVkOworICAgIHBjLm9ubmVnb3RpYXRpb25u ZWVkZWQgPSBvbk5lZ290aWF0aW9uTmVlZGVkOwogCiAgICAgcGMuYWRkU3RyZWFtKHN0cmVhbSk7 CiB9Cg==