<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>97425</bug_id>
          
          <creation_ts>2012-09-23 22:30:19 -0700</creation_ts>
          <short_desc>Skeleton implementation of dialog.showModal()</short_desc>
          <delta_ts>2012-09-24 00:40:49 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>84796</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Falkenhagen">falken</reporter>
          <assigned_to name="Matt Falkenhagen">falken</assigned_to>
          <cc>abarth</cc>
    
    <cc>ojan</cc>
    
    <cc>tkent</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>726388</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Falkenhagen">falken</who>
    <bug_when>2012-09-23 22:30:19 -0700</bug_when>
    <thetext>Add a simple implementation of dialog.showModal() so it can later be used to test the top layer (not yet implemented, bug 84796). Modal dialogs should be in the top layer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726391</commentid>
    <comment_count>1</comment_count>
      <attachid>165312</attachid>
    <who name="Matt Falkenhagen">falken</who>
    <bug_when>2012-09-23 22:47:43 -0700</bug_when>
    <thetext>Created attachment 165312
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726394</commentid>
    <comment_count>2</comment_count>
      <attachid>165312</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-09-23 23:03:19 -0700</bug_when>
    <thetext>Comment on attachment 165312
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165312&amp;action=review

&gt; Source/WebCore/html/HTMLDialogElement.cpp:70
&gt; +    if (fastHasAttribute(openAttr) || !inDocument()) {
&gt; +        ec = INVALID_STATE_ERR;
&gt; +        return;
&gt; +    }

What should happen if the document is not attached to any pages?  We can make such documents by DOMImplementation::createHTMLDocument(), etc.

&gt; LayoutTests/fast/dom/HTMLDialogElement/dialog-show-modal.html:17
&gt; +shouldBe(&quot;computedStyle.getPropertyValue(&apos;display&apos;)&quot;, &quot;&apos;none&apos;&quot;);

We had better use shouldBeEqualToString() to avoid nested quotation marks.

&gt; LayoutTests/fast/dom/HTMLDialogElement/dialog-show-modal.html:21
&gt; +dialog.showModal();
&gt; +computedStyle = window.getComputedStyle(dialog, null);
&gt; +shouldBe(&quot;computedStyle.getPropertyValue(&apos;display&apos;)&quot;, &quot;&apos;block&apos;&quot;);

Will this work when we implement modal behavior for showModal()?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726409</commentid>
    <comment_count>3</comment_count>
      <attachid>165312</attachid>
    <who name="Matt Falkenhagen">falken</who>
    <bug_when>2012-09-24 00:00:51 -0700</bug_when>
    <thetext>Comment on attachment 165312
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165312&amp;action=review

&gt;&gt; Source/WebCore/html/HTMLDialogElement.cpp:70
&gt;&gt; +    }
&gt; 
&gt; What should happen if the document is not attached to any pages?  We can make such documents by DOMImplementation::createHTMLDocument(), etc.

It looks like the spec doesn&apos;t say anything about this case. I think showModal() can execute as normal. When there is no document, it can&apos;t proceed because there is no &quot;pending dialog stack&quot;.

&gt;&gt; LayoutTests/fast/dom/HTMLDialogElement/dialog-show-modal.html:21
&gt;&gt; +shouldBe(&quot;computedStyle.getPropertyValue(&apos;display&apos;)&quot;, &quot;&apos;block&apos;&quot;);
&gt; 
&gt; Will this work when we implement modal behavior for showModal()?

Yes, I believe modal doesn&apos;t block JavaScript execution. It just blocks user interaction with the rest of the document.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726410</commentid>
    <comment_count>4</comment_count>
      <attachid>165317</attachid>
    <who name="Matt Falkenhagen">falken</who>
    <bug_when>2012-09-24 00:03:24 -0700</bug_when>
    <thetext>Created attachment 165317
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726412</commentid>
    <comment_count>5</comment_count>
      <attachid>165317</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-09-24 00:09:31 -0700</bug_when>
    <thetext>Comment on attachment 165317
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165317&amp;action=review

Almost ok.
Some nits.

&gt; LayoutTests/fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt:12
&gt; +PASS computedStyle.getPropertyValue(&apos;display&apos;) is &quot;none&quot;
&gt; +PASS computedStyle.getPropertyValue(&apos;display&apos;) is &quot;block&quot;
&gt; +PASS dialog.showModal(); threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
&gt; +PASS computedStyle.getPropertyValue(&apos;display&apos;) is &quot;none&quot;
&gt; +PASS dialog.showModal(); threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
&gt; +PASS dialog.open is false
&gt; +PASS dialog.open is true

The readability of test result is not good.  Please print some explanations about what we are testing.

&gt; LayoutTests/fast/dom/HTMLDialogElement/dialog-show-modal.html:23
&gt; +// &quot;If dialog already has an open attribute, then throw an InvalidStateError exception.&quot;

This sentence should be printed with debug().

&gt; LayoutTests/fast/dom/HTMLDialogElement/dialog-show-modal.html:30
&gt; +// &quot;If dialog is not in a Document, then throw an InvalidStateError exception.&quot;

ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726417</commentid>
    <comment_count>6</comment_count>
      <attachid>165319</attachid>
    <who name="Matt Falkenhagen">falken</who>
    <bug_when>2012-09-24 00:17:34 -0700</bug_when>
    <thetext>Created attachment 165319
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726418</commentid>
    <comment_count>7</comment_count>
      <attachid>165319</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-09-24 00:18:29 -0700</bug_when>
    <thetext>Comment on attachment 165319
Patch

ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726427</commentid>
    <comment_count>8</comment_count>
      <attachid>165319</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-24 00:40:45 -0700</bug_when>
    <thetext>Comment on attachment 165319
Patch

Clearing flags on attachment: 165319

Committed r129330: &lt;http://trac.webkit.org/changeset/129330&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726428</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-24 00:40:49 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165312</attachid>
            <date>2012-09-23 22:47:43 -0700</date>
            <delta_ts>2012-09-24 00:03:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-97425-20120924144704.patch</filename>
            <type>text/plain</type>
            <size>6454</size>
            <attacher name="Matt Falkenhagen">falken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTkwY2ZkYmU3Y2JlYTA0
ODU3MWQ0OTgyNDhmNDczYjFkZWJlZGY1ZS4uZTU5NzM2M2QxYzQ4ZTFjMGEwZDY5ODk5OTZmMTBj
NmYwN2Q4YzZlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTIzICBNYXR0
IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBTa2VsZXRvbiBp
bXBsZW1lbnRhdGlvbiBvZiBkaWFsb2cuc2hvd01vZGFsKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhZGRzIGEgYmFzaWMgaW1wbGVtZW50YXRp
b24gb2Ygc2hvd01vZGFsKCksIHNvIHRoZSB0b3AgbGF5ZXIKKyAgICAgICAgY2FuIGJlIHRlc3Rl
ZCBvbmNlIGl0IGlzIGltcGxlbWVudGVkLiBUaGUgbWFpbiBmZWF0dXJlcyBvZgorICAgICAgICBz
aG93TW9kYWwoKSwgbW9kYWxpdHkgYW5kIHRoZSB0b3AgbGF5ZXIsIGFyZSBub3QgeWV0IGltcGxl
bWVudGVkLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxv
Zy1zaG93LW1vZGFsLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6SFRNTERpYWxvZ0VsZW1lbnQ6OnNob3dNb2RhbCk6IFRoZSBz
YW1lIGFzIHNob3coKSwgYnV0IHRocm93cyBhbiBlcnJvciBpbiB0aGUgY2FzZXMgc3BlY2lmaWVk
IGluIHRoZSBzcGVjLgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogaHRtbC9IVE1MRGlh
bG9nRWxlbWVudC5oOgorICAgICAgICAoSFRNTERpYWxvZ0VsZW1lbnQpOgorICAgICAgICAqIGh0
bWwvSFRNTERpYWxvZ0VsZW1lbnQuaWRsOgorCiAyMDEyLTA5LTIxICBFdmFuIFdhbGxhY2UgIDxl
dmFuLmV4ZUBnbWFpbC5jb20+CiAKICAgICAgICAgW1dlYlNvY2tldF0gUmVjZWl2aW5nIGEgbGFy
Z2UgbWVzc2FnZSBpcyByZWFsbHkgc2xvdwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt
bC9IVE1MRGlhbG9nRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dF
bGVtZW50LmNwcAppbmRleCA1Mzc0MzI5NjAzMDg3NzA3NTc4OWJjMWNlYTc1MDkzNzc5NjdhYzg5
Li43ZDRkNjQ1MWJlM2E5OWY2OTBkMzZlODM2ODk3MWYzMGM1ZTljMzQ2IDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcApAQCAtNjIsNiArNjIsMTUgQEAgdm9pZCBI
VE1MRGlhbG9nRWxlbWVudDo6c2hvdygpCiAgICAgc2V0Qm9vbGVhbkF0dHJpYnV0ZShvcGVuQXR0
ciwgdHJ1ZSk7CiB9CiAKK3ZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OnNob3dNb2RhbChFeGNlcHRp
b25Db2RlJiBlYykKK3sKKyAgICBpZiAoZmFzdEhhc0F0dHJpYnV0ZShvcGVuQXR0cikgfHwgIWlu
RG9jdW1lbnQoKSkgeworICAgICAgICBlYyA9IElOVkFMSURfU1RBVEVfRVJSOworICAgICAgICBy
ZXR1cm47CisgICAgfQorICAgIHNldEJvb2xlYW5BdHRyaWJ1dGUob3BlbkF0dHIsIHRydWUpOwor
fQorCiBib29sIEhUTUxEaWFsb2dFbGVtZW50Ojppc1ByZXNlbnRhdGlvbkF0dHJpYnV0ZShjb25z
dCBRdWFsaWZpZWROYW1lJiBuYW1lKSBjb25zdAogewogICAgIC8vIEZJWE1FOiBXb3JrYXJvdW5k
IGZvciA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMDU4PjogbW9k
aWZ5aW5nIGFuIGF0dHJpYnV0ZSBmb3Igd2hpY2ggdGhlcmUgaXMgYW4gYXR0cmlidXRlIHNlbGVj
dG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50Lmgg
Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmgKaW5kZXggN2E3YjAxMTlm
ZGZlYjBiN2JlNzFhODY1YzAxY2FhN2EyZTdlZTlkMy4uZTAxMDQ1YmNlOWFkMjYwOTJmZDk5NTNi
Mjg1Njg4MTA5NmRhOTA3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlh
bG9nRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQu
aApAQCAtNDEsNiArNDEsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGNsb3NlKEV4Y2VwdGlvbkNv
ZGUmKTsKICAgICB2b2lkIHNob3coKTsKKyAgICB2b2lkIHNob3dNb2RhbChFeGNlcHRpb25Db2Rl
Jik7CiAKIHByaXZhdGU6CiAgICAgSFRNTERpYWxvZ0VsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFt
ZSYsIERvY3VtZW50Kik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFs
b2dFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaWRs
CmluZGV4IDQ0MmY5M2ZkODEwYTBkNTdiZWU0YzM5MjI0YmMwZDNkMGIwMjllYzcuLjNjNzBjMGM1
MzZmYzZiYjc2MDg3YThiMzMyYTI3NmMwMmRmMjFiMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv
SFRNTERpYWxvZ0VsZW1lbnQuaWRsCkBAIC0zMSw2ICszMSw3IEBAIG1vZHVsZSBodG1sIHsKICAg
ICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIG9wZW47CiAgICAgICAgIHZvaWQgY2xv
c2UoKSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICAgICAgICAgdm9pZCBzaG93KCk7CisgICAgICAg
IHZvaWQgc2hvd01vZGFsKCkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAgICAgfTsKIAogfQpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu
ZGV4IDI1YWRjNzFjZGU5YTVmYzViMGFiOTMxOGVjMGZkNzlkYjNhZjI0MzEuLmE2YzE0NzI3NmQ0
OTdhZDBhNThlZDY2YTVlMWE4MjcxZjZmMWQ5MTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No
YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAx
Mi0wOS0yMyAgTWF0dCBGYWxrZW5oYWdlbiAgPGZhbGtlbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg
ICAgU2tlbGV0b24gaW1wbGVtZW50YXRpb24gb2YgZGlhbG9nLnNob3dNb2RhbCgpCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQyNQorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHRlc3QgdGhhdCBz
aG93TW9kYWwoKSBvcGVucyB0aGUgZGlhbG9nIG9yIHRocm93cyBhbiBlcnJvciBpbiB0aGUgY2Fz
ZXMgc3BlY2lmaWVkIGluIHRoZSBzcGVjLgorCisgICAgICAgICogZmFzdC9kb20vSFRNTERpYWxv
Z0VsZW1lbnQvZGlhbG9nLXNob3ctbW9kYWwtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg
KiBmYXN0L2RvbS9IVE1MRGlhbG9nRWxlbWVudC9kaWFsb2ctc2hvdy1tb2RhbC5odG1sOiBBZGRl
ZC4KKwogMjAxMi0wOS0yMSAgTWFyY2VsbyBMaXJhICA8bWFyY2Vsby5saXJhQG9wZW5ib3NzYS5v
cmc+CiAKICAgICAgICAgW1F0XSBSRUdSRVNTSU9OOiA1IHRlc3RzIHN0YXJ0ZWQgdG8gZmFpbCB3
aXRoIG5ld2VyIFF0NQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERpYWxv
Z0VsZW1lbnQvZGlhbG9nLXNob3ctbW9kYWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz
dC9kb20vSFRNTERpYWxvZ0VsZW1lbnQvZGlhbG9nLXNob3ctbW9kYWwtZXhwZWN0ZWQudHh0Cm5l
dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAuLjJkYjZjN2ZlY2Y3ZmM5NDkyY2MwZWE4ZTIxYWNkYzA0MjMyZTg4YTcKLS0tIC9k
ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRGlhbG9nRWxlbWVudC9kaWFs
b2ctc2hvdy1tb2RhbC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNCBAQAorVGVzdHMgdGhhdCBz
aG93TW9kYWwoKSBwZXJmb3JtcyB0aGUgc3RlcHMgc3BlY2lmaWVkIGluIHRoZSBIVE1MIHNwZWMu
IGJ1ZyA5NzQyNQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1Mi
IG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBjb21wdXRl
ZFN0eWxlLmdldFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSBpcyAnbm9uZScKK1BBU1MgY29tcHV0
ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdkaXNwbGF5JykgaXMgJ2Jsb2NrJworUEFTUyBkaWFs
b2cuc2hvd01vZGFsKCk7IHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogSU5WQUxJRF9TVEFURV9FUlI6
IERPTSBFeGNlcHRpb24gMTEuCitQQVNTIGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgn
ZGlzcGxheScpIGlzICdub25lJworUEFTUyBkaWFsb2cuc2hvd01vZGFsKCk7IHRocmV3IGV4Y2Vw
dGlvbiBFcnJvcjogSU5WQUxJRF9TVEFURV9FUlI6IERPTSBFeGNlcHRpb24gMTEuCitQQVNTIHN1
Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEv
TGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERpYWxvZ0VsZW1lbnQvZGlhbG9nLXNob3ctbW9kYWwu
aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93
LW1vZGFsLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjg4YTMyNmYyMzkwOTI4ZTVhMDlhMDhmYzRlN2JkZjcz
NWJlNGVkNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEaWFs
b2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFsLmh0bWwKQEAgLTAsMCArMSwzNiBAQAorPCFET0NU
WVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNl
cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5pbnRlcm5h
bHMpCisgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldERpYWxvZ0VsZW1lbnRFbmFibGVkKHRydWUp
OworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaWFsb2cgaWQ9Im15ZGlhbG9nIj5JdCdz
IG15IGRpYWxvZy48L2RpYWxvZz4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgdGhhdCBz
aG93TW9kYWwoKSBwZXJmb3JtcyB0aGUgc3RlcHMgc3BlY2lmaWVkIGluIHRoZSBIVE1MIHNwZWMu
IGJ1ZyA5NzQyNSIpOworCitkaWFsb2cgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbXlkaWFs
b2cnKTsKK2NvbXB1dGVkU3R5bGUgPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShkaWFsb2csIG51
bGwpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnZGlzcGxheScp
IiwgIidub25lJyIpOworCitkaWFsb2cuc2hvd01vZGFsKCk7Citjb21wdXRlZFN0eWxlID0gd2lu
ZG93LmdldENvbXB1dGVkU3R5bGUoZGlhbG9nLCBudWxsKTsKK3Nob3VsZEJlKCJjb21wdXRlZFN0
eWxlLmdldFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSIsICInYmxvY2snIik7CisKKy8vIFRoZSBx
dW90ZWQgdGV4dCBpbiB0aGUgY29tbWVudHMgYmVsb3cgYXJlIGZyb20gPGh0dHA6Ly93d3cud2hh
dHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL2NvbW1hbmRzLmh0
bWwjZG9tLWRpYWxvZy1zaG93bW9kYWw+LgorLy8gIklmIGRpYWxvZyBhbHJlYWR5IGhhcyBhbiBv
cGVuIGF0dHJpYnV0ZSwgdGhlbiB0aHJvdyBhbiBJbnZhbGlkU3RhdGVFcnJvciBleGNlcHRpb24u
Igorc2hvdWxkVGhyb3coJ2RpYWxvZy5zaG93TW9kYWwoKTsnLCAiJ0Vycm9yOiBJTlZBTElEX1NU
QVRFX0VSUjogRE9NIEV4Y2VwdGlvbiAxMSciKTsKKworZGlhbG9nLmNsb3NlKCk7CitzaG91bGRC
ZSgiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdkaXNwbGF5JykiLCAiJ25vbmUnIik7
CisKK2RpYWxvZy5wYXJlbnROb2RlLnJlbW92ZUNoaWxkKGRpYWxvZyk7CisvLyAiSWYgZGlhbG9n
IGlzIG5vdCBpbiBhIERvY3VtZW50LCB0aGVuIHRocm93IGFuIEludmFsaWRTdGF0ZUVycm9yIGV4
Y2VwdGlvbi4iCitzaG91bGRUaHJvdygnZGlhbG9nLnNob3dNb2RhbCgpOycsICInRXJyb3I6IElO
VkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9uIDExJyIpOworPC9zY3JpcHQ+Cis8c2NyaXB0
IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2Jv
ZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165317</attachid>
            <date>2012-09-24 00:03:24 -0700</date>
            <delta_ts>2012-09-24 00:17:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-97425-20120924160245.patch</filename>
            <type>text/plain</type>
            <size>6668</size>
            <attacher name="Matt Falkenhagen">falken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTkwY2ZkYmU3Y2JlYTA0
ODU3MWQ0OTgyNDhmNDczYjFkZWJlZGY1ZS4uYTE5MGVmYTk5NjQwOWQzZGNhMDgwYjIzOTdmZDA4
MzlmYmI4NTZjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTIzICBNYXR0
IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBTa2VsZXRvbiBp
bXBsZW1lbnRhdGlvbiBvZiBkaWFsb2cuc2hvd01vZGFsKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhZGRzIGEgYmFzaWMgaW1wbGVtZW50YXRp
b24gb2Ygc2hvd01vZGFsKCksIHNvIGl0IGxhdGVyIGNhbiBiZQorICAgICAgICB1c2VkIHRvIHRl
c3QgdGhlIHRvcCBsYXllciwgb25jZSBpdCBpcyBpbXBsZW1lbnRlZC4gVGhlIG1haW4gZmVhdHVy
ZXMKKyAgICAgICAgb2Ygc2hvd01vZGFsKCksIG1vZGFsaXR5IGFuZCB0aGUgdG9wIGxheWVyLCBh
cmUgbm90IHlldCBpbXBsZW1lbnRlZC4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MRGlh
bG9nRWxlbWVudC9kaWFsb2ctc2hvdy1tb2RhbC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxE
aWFsb2dFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dFbGVtZW50Ojpz
aG93TW9kYWwpOiBUaGUgc2FtZSBhcyBzaG93KCksIGJ1dCB0aHJvd3MgYW4gZXJyb3IgaW4gdGhl
IGNhc2VzIHNwZWNpZmllZCBpbiB0aGUgc3BlYy4KKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAg
ICAqIGh0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaDoKKyAgICAgICAgKEhUTUxEaWFsb2dFbGVtZW50
KToKKyAgICAgICAgKiBodG1sL0hUTUxEaWFsb2dFbGVtZW50LmlkbDoKKwogMjAxMi0wOS0yMSAg
RXZhbiBXYWxsYWNlICA8ZXZhbi5leGVAZ21haWwuY29tPgogCiAgICAgICAgIFtXZWJTb2NrZXRd
IFJlY2VpdmluZyBhIGxhcmdlIG1lc3NhZ2UgaXMgcmVhbGx5IHNsb3cKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv
aHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAKaW5kZXggNTM3NDMyOTYwMzA4NzcwNzU3ODliYzFj
ZWE3NTA5Mzc3OTY3YWM4OS4uN2Q0ZDY0NTFiZTNhOTlmNjkwZDM2ZTgzNjg5NzFmMzBjNWU5YzM0
NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAK
KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAKQEAgLTYyLDYg
KzYyLDE1IEBAIHZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OnNob3coKQogICAgIHNldEJvb2xlYW5B
dHRyaWJ1dGUob3BlbkF0dHIsIHRydWUpOwogfQogCit2b2lkIEhUTUxEaWFsb2dFbGVtZW50Ojpz
aG93TW9kYWwoRXhjZXB0aW9uQ29kZSYgZWMpCit7CisgICAgaWYgKGZhc3RIYXNBdHRyaWJ1dGUo
b3BlbkF0dHIpIHx8ICFpbkRvY3VtZW50KCkpIHsKKyAgICAgICAgZWMgPSBJTlZBTElEX1NUQVRF
X0VSUjsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBzZXRCb29sZWFuQXR0cmlidXRlKG9w
ZW5BdHRyLCB0cnVlKTsKK30KKwogYm9vbCBIVE1MRGlhbG9nRWxlbWVudDo6aXNQcmVzZW50YXRp
b25BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkgY29uc3QKIHsKICAgICAvLyBG
SVhNRTogV29ya2Fyb3VuZCBmb3IgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD05MTA1OD46IG1vZGlmeWluZyBhbiBhdHRyaWJ1dGUgZm9yIHdoaWNoIHRoZXJlIGlzIGFu
IGF0dHJpYnV0ZSBzZWxlY3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M
RGlhbG9nRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5o
CmluZGV4IDdhN2IwMTE5ZmRmZWIwYjdiZTcxYTg2NWMwMWNhYTdhMmU3ZWU5ZDMuLmUwMTA0NWJj
ZTlhZDI2MDkyZmQ5OTUzYjI4NTY4ODEwOTZkYTkwNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU
TUxEaWFsb2dFbGVtZW50LmgKQEAgLTQxLDYgKzQxLDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBj
bG9zZShFeGNlcHRpb25Db2RlJik7CiAgICAgdm9pZCBzaG93KCk7CisgICAgdm9pZCBzaG93TW9k
YWwoRXhjZXB0aW9uQ29kZSYpOwogCiBwcml2YXRlOgogICAgIEhUTUxEaWFsb2dFbGVtZW50KGNv
bnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxE
aWFsb2dFbGVtZW50LmlkbAppbmRleCA0NDJmOTNmZDgxMGEwZDU3YmVlNGMzOTIyNGJjMGQzZDBi
MDI5ZWM3Li4zYzcwYzBjNTM2ZmM2YmI3NjA4N2E4YjMzMmEyNzZjMDJkZjIxYjM1IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmlkbAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmlkbApAQCAtMzEsNiArMzEsNyBAQCBt
b2R1bGUgaHRtbCB7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gYm9vbGVhbiBvcGVuOwog
ICAgICAgICB2b2lkIGNsb3NlKCkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAgICAgICAgIHZvaWQg
c2hvdygpOworICAgICAgICB2b2lkIHNob3dNb2RhbCgpIHJhaXNlcyhET01FeGNlcHRpb24pOwog
ICAgIH07CiAKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl
c3RzL0NoYW5nZUxvZwppbmRleCAyNWFkYzcxY2RlOWE1ZmM1YjBhYjkzMThlYzBmZDc5ZGIzYWYy
NDMxLi5hNmMxNDcyNzZkNDk3YWQwYTU4ZWQ2NmE1ZTFhODI3MWY2ZjFkOTE4IDEwMDY0NAotLS0g
YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTUgQEAKKzIwMTItMDktMjMgIE1hdHQgRmFsa2VuaGFnZW4gIDxmYWxrZW5AY2hyb21p
dW0ub3JnPgorCisgICAgICAgIFNrZWxldG9uIGltcGxlbWVudGF0aW9uIG9mIGRpYWxvZy5zaG93
TW9kYWwoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
OTc0MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB
ZGQgYSB0ZXN0IHRoYXQgc2hvd01vZGFsKCkgb3BlbnMgdGhlIGRpYWxvZyBvciB0aHJvd3MgYW4g
ZXJyb3IgaW4gdGhlIGNhc2VzIHNwZWNpZmllZCBpbiB0aGUgc3BlYy4KKworICAgICAgICAqIGZh
c3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFsLWV4cGVjdGVkLnR4dDog
QWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTERpYWxvZ0VsZW1lbnQvZGlhbG9nLXNob3ct
bW9kYWwuaHRtbDogQWRkZWQuCisKIDIwMTItMDktMjEgIE1hcmNlbG8gTGlyYSAgPG1hcmNlbG8u
bGlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtRdF0gUkVHUkVTU0lPTjogNSB0ZXN0cyBz
dGFydGVkIHRvIGZhaWwgd2l0aCBuZXdlciBRdDUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh
c3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFsLWV4cGVjdGVkLnR4dCBi
L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFs
LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xODVjODkwMTM5ODkyMDIyZTQwZjkzMzcwMDVkNzc3
NzlkOTc1OWQ1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERp
YWxvZ0VsZW1lbnQvZGlhbG9nLXNob3ctbW9kYWwtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTYg
QEAKK1Rlc3RzIHRoYXQgc2hvd01vZGFsKCkgcGVyZm9ybXMgdGhlIHN0ZXBzIHNwZWNpZmllZCBp
biB0aGUgSFRNTCBzcGVjLiBidWcgOTc0MjUKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg
c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgor
CisKK1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdkaXNwbGF5JykgaXMgIm5v
bmUiCitQQVNTIGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnZGlzcGxheScpIGlzICJi
bG9jayIKK1BBU1MgZGlhbG9nLnNob3dNb2RhbCgpOyB0aHJldyBleGNlcHRpb24gRXJyb3I6IElO
VkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9uIDExLgorUEFTUyBjb21wdXRlZFN0eWxlLmdl
dFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSBpcyAibm9uZSIKK1BBU1MgZGlhbG9nLnNob3dNb2Rh
bCgpOyB0aHJldyBleGNlcHRpb24gRXJyb3I6IElOVkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0
aW9uIDExLgorUEFTUyBkaWFsb2cub3BlbiBpcyBmYWxzZQorUEFTUyBkaWFsb2cub3BlbiBpcyB0
cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpk
aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERpYWxvZ0VsZW1lbnQvZGlhbG9n
LXNob3ctbW9kYWwuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50
L2RpYWxvZy1zaG93LW1vZGFsLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZGU5ZmZkNzMzNjRjMmJjZWRiNDI3
ZTMxYTc0OGM1N2Q3ZDkzODQyYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv
ZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFsLmh0bWwKQEAgLTAsMCArMSw0
MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4u
L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgoraWYgKHdp
bmRvdy5pbnRlcm5hbHMpCisgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldERpYWxvZ0VsZW1lbnRF
bmFibGVkKHRydWUpOworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaWFsb2cgaWQ9Im15
ZGlhbG9nIj5JdCdzIG15IGRpYWxvZy48L2RpYWxvZz4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigi
VGVzdHMgdGhhdCBzaG93TW9kYWwoKSBwZXJmb3JtcyB0aGUgc3RlcHMgc3BlY2lmaWVkIGluIHRo
ZSBIVE1MIHNwZWMuIGJ1ZyA5NzQyNSIpOworCitkaWFsb2cgPSBkb2N1bWVudC5nZXRFbGVtZW50
QnlJZCgnbXlkaWFsb2cnKTsKK2NvbXB1dGVkU3R5bGUgPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHls
ZShkaWFsb2csIG51bGwpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJjb21wdXRlZFN0eWxlLmdl
dFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSIsICJub25lIik7CisKK2RpYWxvZy5zaG93TW9kYWwo
KTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVl
KCdkaXNwbGF5JykiLCAiYmxvY2siKTsKKworLy8gVGhlIHF1b3RlZCB0ZXh0IGluIHRoZSBjb21t
ZW50cyBiZWxvdyBhcmUgZnJvbSA8aHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBz
L2N1cnJlbnQtd29yay9tdWx0aXBhZ2UvY29tbWFuZHMuaHRtbCNkb20tZGlhbG9nLXNob3dtb2Rh
bD4uCisvLyAiSWYgZGlhbG9nIGFscmVhZHkgaGFzIGFuIG9wZW4gYXR0cmlidXRlLCB0aGVuIHRo
cm93IGFuIEludmFsaWRTdGF0ZUVycm9yIGV4Y2VwdGlvbi4iCitzaG91bGRUaHJvdygnZGlhbG9n
LnNob3dNb2RhbCgpOycsICInRXJyb3I6IElOVkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9u
IDExJyIpOworCitkaWFsb2cuY2xvc2UoKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiY29tcHV0
ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdkaXNwbGF5JykiLCAibm9uZSIpOworCitkaWFsb2cu
cGFyZW50Tm9kZS5yZW1vdmVDaGlsZChkaWFsb2cpOworLy8gIklmIGRpYWxvZyBpcyBub3QgaW4g
YSBEb2N1bWVudCwgdGhlbiB0aHJvdyBhbiBJbnZhbGlkU3RhdGVFcnJvciBleGNlcHRpb24uIgor
c2hvdWxkVGhyb3coJ2RpYWxvZy5zaG93TW9kYWwoKTsnLCAiJ0Vycm9yOiBJTlZBTElEX1NUQVRF
X0VSUjogRE9NIEV4Y2VwdGlvbiAxMSciKTsKKworZG9jID0gZG9jdW1lbnQuaW1wbGVtZW50YXRp
b24uY3JlYXRlSFRNTERvY3VtZW50KCk7Citkb2MuYm9keS5hcHBlbmRDaGlsZChkaWFsb2cpOwor
c2hvdWxkQmVGYWxzZSgiZGlhbG9nLm9wZW4iKTsKK2RpYWxvZy5zaG93TW9kYWwoKTsKK3Nob3Vs
ZEJlVHJ1ZSgiZGlhbG9nLm9wZW4iKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pz
L3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165319</attachid>
            <date>2012-09-24 00:17:34 -0700</date>
            <delta_ts>2012-09-24 00:40:45 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-97425-20120924161655.patch</filename>
            <type>text/plain</type>
            <size>7031</size>
            <attacher name="Matt Falkenhagen">falken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTkwY2ZkYmU3Y2JlYTA0
ODU3MWQ0OTgyNDhmNDczYjFkZWJlZGY1ZS4uYTE5MGVmYTk5NjQwOWQzZGNhMDgwYjIzOTdmZDA4
MzlmYmI4NTZjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTIzICBNYXR0
IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBTa2VsZXRvbiBp
bXBsZW1lbnRhdGlvbiBvZiBkaWFsb2cuc2hvd01vZGFsKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhZGRzIGEgYmFzaWMgaW1wbGVtZW50YXRp
b24gb2Ygc2hvd01vZGFsKCksIHNvIGl0IGxhdGVyIGNhbiBiZQorICAgICAgICB1c2VkIHRvIHRl
c3QgdGhlIHRvcCBsYXllciwgb25jZSBpdCBpcyBpbXBsZW1lbnRlZC4gVGhlIG1haW4gZmVhdHVy
ZXMKKyAgICAgICAgb2Ygc2hvd01vZGFsKCksIG1vZGFsaXR5IGFuZCB0aGUgdG9wIGxheWVyLCBh
cmUgbm90IHlldCBpbXBsZW1lbnRlZC4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MRGlh
bG9nRWxlbWVudC9kaWFsb2ctc2hvdy1tb2RhbC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxE
aWFsb2dFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dFbGVtZW50Ojpz
aG93TW9kYWwpOiBUaGUgc2FtZSBhcyBzaG93KCksIGJ1dCB0aHJvd3MgYW4gZXJyb3IgaW4gdGhl
IGNhc2VzIHNwZWNpZmllZCBpbiB0aGUgc3BlYy4KKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAg
ICAqIGh0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaDoKKyAgICAgICAgKEhUTUxEaWFsb2dFbGVtZW50
KToKKyAgICAgICAgKiBodG1sL0hUTUxEaWFsb2dFbGVtZW50LmlkbDoKKwogMjAxMi0wOS0yMSAg
RXZhbiBXYWxsYWNlICA8ZXZhbi5leGVAZ21haWwuY29tPgogCiAgICAgICAgIFtXZWJTb2NrZXRd
IFJlY2VpdmluZyBhIGxhcmdlIG1lc3NhZ2UgaXMgcmVhbGx5IHNsb3cKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv
aHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAKaW5kZXggNTM3NDMyOTYwMzA4NzcwNzU3ODliYzFj
ZWE3NTA5Mzc3OTY3YWM4OS4uN2Q0ZDY0NTFiZTNhOTlmNjkwZDM2ZTgzNjg5NzFmMzBjNWU5YzM0
NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAK
KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAKQEAgLTYyLDYg
KzYyLDE1IEBAIHZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OnNob3coKQogICAgIHNldEJvb2xlYW5B
dHRyaWJ1dGUob3BlbkF0dHIsIHRydWUpOwogfQogCit2b2lkIEhUTUxEaWFsb2dFbGVtZW50Ojpz
aG93TW9kYWwoRXhjZXB0aW9uQ29kZSYgZWMpCit7CisgICAgaWYgKGZhc3RIYXNBdHRyaWJ1dGUo
b3BlbkF0dHIpIHx8ICFpbkRvY3VtZW50KCkpIHsKKyAgICAgICAgZWMgPSBJTlZBTElEX1NUQVRF
X0VSUjsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBzZXRCb29sZWFuQXR0cmlidXRlKG9w
ZW5BdHRyLCB0cnVlKTsKK30KKwogYm9vbCBIVE1MRGlhbG9nRWxlbWVudDo6aXNQcmVzZW50YXRp
b25BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkgY29uc3QKIHsKICAgICAvLyBG
SVhNRTogV29ya2Fyb3VuZCBmb3IgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD05MTA1OD46IG1vZGlmeWluZyBhbiBhdHRyaWJ1dGUgZm9yIHdoaWNoIHRoZXJlIGlzIGFu
IGF0dHJpYnV0ZSBzZWxlY3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M
RGlhbG9nRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5o
CmluZGV4IDdhN2IwMTE5ZmRmZWIwYjdiZTcxYTg2NWMwMWNhYTdhMmU3ZWU5ZDMuLmUwMTA0NWJj
ZTlhZDI2MDkyZmQ5OTUzYjI4NTY4ODEwOTZkYTkwNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU
TUxEaWFsb2dFbGVtZW50LmgKQEAgLTQxLDYgKzQxLDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBj
bG9zZShFeGNlcHRpb25Db2RlJik7CiAgICAgdm9pZCBzaG93KCk7CisgICAgdm9pZCBzaG93TW9k
YWwoRXhjZXB0aW9uQ29kZSYpOwogCiBwcml2YXRlOgogICAgIEhUTUxEaWFsb2dFbGVtZW50KGNv
bnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxE
aWFsb2dFbGVtZW50LmlkbAppbmRleCA0NDJmOTNmZDgxMGEwZDU3YmVlNGMzOTIyNGJjMGQzZDBi
MDI5ZWM3Li4zYzcwYzBjNTM2ZmM2YmI3NjA4N2E4YjMzMmEyNzZjMDJkZjIxYjM1IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmlkbAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmlkbApAQCAtMzEsNiArMzEsNyBAQCBt
b2R1bGUgaHRtbCB7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gYm9vbGVhbiBvcGVuOwog
ICAgICAgICB2b2lkIGNsb3NlKCkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAgICAgICAgIHZvaWQg
c2hvdygpOworICAgICAgICB2b2lkIHNob3dNb2RhbCgpIHJhaXNlcyhET01FeGNlcHRpb24pOwog
ICAgIH07CiAKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl
c3RzL0NoYW5nZUxvZwppbmRleCAyNWFkYzcxY2RlOWE1ZmM1YjBhYjkzMThlYzBmZDc5ZGIzYWYy
NDMxLi5hNmMxNDcyNzZkNDk3YWQwYTU4ZWQ2NmE1ZTFhODI3MWY2ZjFkOTE4IDEwMDY0NAotLS0g
YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTUgQEAKKzIwMTItMDktMjMgIE1hdHQgRmFsa2VuaGFnZW4gIDxmYWxrZW5AY2hyb21p
dW0ub3JnPgorCisgICAgICAgIFNrZWxldG9uIGltcGxlbWVudGF0aW9uIG9mIGRpYWxvZy5zaG93
TW9kYWwoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
OTc0MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB
ZGQgYSB0ZXN0IHRoYXQgc2hvd01vZGFsKCkgb3BlbnMgdGhlIGRpYWxvZyBvciB0aHJvd3MgYW4g
ZXJyb3IgaW4gdGhlIGNhc2VzIHNwZWNpZmllZCBpbiB0aGUgc3BlYy4KKworICAgICAgICAqIGZh
c3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFsLWV4cGVjdGVkLnR4dDog
QWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTERpYWxvZ0VsZW1lbnQvZGlhbG9nLXNob3ct
bW9kYWwuaHRtbDogQWRkZWQuCisKIDIwMTItMDktMjEgIE1hcmNlbG8gTGlyYSAgPG1hcmNlbG8u
bGlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtRdF0gUkVHUkVTU0lPTjogNSB0ZXN0cyBz
dGFydGVkIHRvIGZhaWwgd2l0aCBuZXdlciBRdDUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh
c3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFsLWV4cGVjdGVkLnR4dCBi
L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFs
LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hM2RjNDUzZjYyNjgwYTYxMGJlZTNjYmJjYTVmYmM0
N2E2OTM4ODMwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERp
YWxvZ0VsZW1lbnQvZGlhbG9nLXNob3ctbW9kYWwtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTkg
QEAKK1Rlc3RzIHRoYXQgc2hvd01vZGFsKCkgcGVyZm9ybXMgdGhlIHN0ZXBzIHNwZWNpZmllZCBp
biB0aGUgSFRNTCBzcGVjLiBidWcgOTc0MjUKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg
c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgor
CisKK1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdkaXNwbGF5JykgaXMgIm5v
bmUiCitQQVNTIGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnZGlzcGxheScpIGlzICJi
bG9jayIKKyJJZiBkaWFsb2cgYWxyZWFkeSBoYXMgYW4gb3BlbiBhdHRyaWJ1dGUsIHRoZW4gdGhy
b3cgYW4gSW52YWxpZFN0YXRlRXJyb3IgZXhjZXB0aW9uLiIKK1BBU1MgZGlhbG9nLnNob3dNb2Rh
bCgpOyB0aHJldyBleGNlcHRpb24gRXJyb3I6IElOVkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0
aW9uIDExLgorUEFTUyBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSBp
cyAibm9uZSIKKyJJZiBkaWFsb2cgaXMgbm90IGluIGEgRG9jdW1lbnQsIHRoZW4gdGhyb3cgYW4g
SW52YWxpZFN0YXRlRXJyb3IgZXhjZXB0aW9uLiIKK1BBU1MgZGlhbG9nLnNob3dNb2RhbCgpOyB0
aHJldyBleGNlcHRpb24gRXJyb3I6IElOVkFMSURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9uIDEx
LgorUEFTUyBkaWFsb2cub3BlbiBpcyBmYWxzZQorQWx0aG91Z2ggdGhlIGRvY3VtZW50IGlzIG5v
dCBhdHRhY2hlZCB0byBhbnkgcGFnZXMsIHNob3dNb2RhbCgpIHNob3VsZCBleGVjdXRlIGFzIG5v
cm1hbC4KK1BBU1MgZGlhbG9nLm9wZW4gaXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg
aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv
ZG9tL0hUTUxEaWFsb2dFbGVtZW50L2RpYWxvZy1zaG93LW1vZGFsLmh0bWwgYi9MYXlvdXRUZXN0
cy9mYXN0L2RvbS9IVE1MRGlhbG9nRWxlbWVudC9kaWFsb2ctc2hvdy1tb2RhbC5odG1sCm5ldyBm
aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAuLjQ0ZDA0M2FjYTdiNDE5NzllNDMyYjI5NGE5ZDY0MTM3NzRiZTQwZTAKLS0tIC9kZXYv
bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRGlhbG9nRWxlbWVudC9kaWFsb2ct
c2hvdy1tb2RhbC5odG1sCkBAIC0wLDAgKzEsNDIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+
Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMi
Pjwvc2NyaXB0PgorPHNjcmlwdD4KK2lmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgIGludGVybmFs
cy5zZXR0aW5ncy5zZXREaWFsb2dFbGVtZW50RW5hYmxlZCh0cnVlKTsKKzwvc2NyaXB0PgorPC9o
ZWFkPgorPGJvZHk+Cis8ZGlhbG9nIGlkPSJteWRpYWxvZyI+SXQncyBteSBkaWFsb2cuPC9kaWFs
b2c+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIHRoYXQgc2hvd01vZGFsKCkgcGVyZm9y
bXMgdGhlIHN0ZXBzIHNwZWNpZmllZCBpbiB0aGUgSFRNTCBzcGVjLiBidWcgOTc0MjUiKTsKKwor
ZGlhbG9nID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ215ZGlhbG9nJyk7Citjb21wdXRlZFN0
eWxlID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZGlhbG9nLCBudWxsKTsKK3Nob3VsZEJlRXF1
YWxUb1N0cmluZygiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdkaXNwbGF5JykiLCAi
bm9uZSIpOworCitkaWFsb2cuc2hvd01vZGFsKCk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImNv
bXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnZGlzcGxheScpIiwgImJsb2NrIik7CisKKy8v
IFRoZSBxdW90ZWQgdGV4dHMgb3V0cHV0IGJlbG93IGFyZSBmcm9tIDxodHRwOi8vd3d3LndoYXR3
Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrL211bHRpcGFnZS9jb21tYW5kcy5odG1s
I2RvbS1kaWFsb2ctc2hvd21vZGFsPi4KK2RlYnVnKCciSWYgZGlhbG9nIGFscmVhZHkgaGFzIGFu
IG9wZW4gYXR0cmlidXRlLCB0aGVuIHRocm93IGFuIEludmFsaWRTdGF0ZUVycm9yIGV4Y2VwdGlv
bi4iJyk7CitzaG91bGRUaHJvdygnZGlhbG9nLnNob3dNb2RhbCgpOycsICInRXJyb3I6IElOVkFM
SURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9uIDExJyIpOworCitkaWFsb2cuY2xvc2UoKTsKK3No
b3VsZEJlRXF1YWxUb1N0cmluZygiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdkaXNw
bGF5JykiLCAibm9uZSIpOworCitkaWFsb2cucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChkaWFsb2cp
OworZGVidWcoJyJJZiBkaWFsb2cgaXMgbm90IGluIGEgRG9jdW1lbnQsIHRoZW4gdGhyb3cgYW4g
SW52YWxpZFN0YXRlRXJyb3IgZXhjZXB0aW9uLiInKTsKK3Nob3VsZFRocm93KCdkaWFsb2cuc2hv
d01vZGFsKCk7JywgIidFcnJvcjogSU5WQUxJRF9TVEFURV9FUlI6IERPTSBFeGNlcHRpb24gMTEn
Iik7CisKK2RvYyA9IGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNyZWF0ZUhUTUxEb2N1bWVudCgp
OworZG9jLmJvZHkuYXBwZW5kQ2hpbGQoZGlhbG9nKTsKK3Nob3VsZEJlRmFsc2UoImRpYWxvZy5v
cGVuIik7CitkaWFsb2cuc2hvd01vZGFsKCk7CitkZWJ1ZygnQWx0aG91Z2ggdGhlIGRvY3VtZW50
IGlzIG5vdCBhdHRhY2hlZCB0byBhbnkgcGFnZXMsIHNob3dNb2RhbCgpIHNob3VsZCBleGVjdXRl
IGFzIG5vcm1hbC4nKTsKK3Nob3VsZEJlVHJ1ZSgiZGlhbG9nLm9wZW4iKTsKKzwvc2NyaXB0Pgor
PHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0
PgorPC9ib2R5PgorPC9odG1sPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>