97263 2012-09-20 15:15:07 -0700 Replace RenderListBox::updateLogicalHeight with RenderListBox::computeLogicalHeight 2012-09-20 16:10:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96804 1 tony tony eric mifenton ojan tkent webkit.review.bot oldest_to_newest 724903 0 tony 2012-09-20 15:15:07 -0700 Replace RenderListBox::updateLogicalHeight with RenderListBox::computeLogicalHeight 724906 1 164991 tony 2012-09-20 15:20:53 -0700 Created attachment 164991 Patch 724954 2 164991 webkit.review.bot 2012-09-20 16:10:54 -0700 Comment on attachment 164991 Patch Clearing flags on attachment: 164991 Committed r129174: <http://trac.webkit.org/changeset/129174> 724955 3 webkit.review.bot 2012-09-20 16:10:57 -0700 All reviewed patches have been landed. Closing bug. 164991 2012-09-20 15:20:53 -0700 2012-09-20 16:10:53 -0700 Patch bug-97263-20120920152018.patch text/plain 5109 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAyMjJiMTNlNmQ0NmEy YTMwODg2NDAzMTUwYTY1MzdkZWRmNmFhZS4uNzg2YjgwZDlkNzQ3OTk2OGY3OTBhMjczODY5Mzg0 YjdiMmJhZWViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTIwICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVwbGFjZSBSZW5kZXJMaXN0 Qm94Ojp1cGRhdGVMb2dpY2FsSGVpZ2h0IHdpdGggUmVuZGVyTGlzdEJveDo6Y29tcHV0ZUxvZ2lj YWxIZWlnaHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk3MjYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyBpcyBwYXJ0IG9mIG1ha2luZyBjb21wdXRlTG9naWNhbEhlaWdodCB2aXJ0dWFsIHNvIHdp dGggYW55IFJlbmRlckJveCBwb2ludGVyLCBvbmUKKyAgICAgICAgY2FuIGNvbXB1dGUgdGhlIGxv Z2ljYWwgaGVpZ2h0IHdpdGhvdXQgbXV0YXRpbmcgdGhlIFJlbmRlckJveC4KKworICAgICAgICBO byBuZXcgdGVzdHMsIHRoaXMgaXMgYSByZWZhY3RvciBhbmQgZXhpc3RpbmcgbGlzdCBib3ggdGVz dHMgc2hvdWxkIHBhc3MuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94Lmg6CisgICAg ICAgIChSZW5kZXJCb3gpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpc3RCb3g6OmxheW91dCk6IE1vdmUgbGF5b3V0IHJl bGF0ZWQgbG9naWMgaGVyZS4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpc3RCb3g6OmNvbXB1 dGVMb2dpY2FsSGVpZ2h0KTogVXNlIGNvbnN0IHZlcnNpb24gYW5kIHJlbW92ZSBsYXlvdXQgcmVs YXRlZCBjb2RlLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMaXN0Qm94Lmg6CisgICAgICAg IChSZW5kZXJMaXN0Qm94KTogT3ZlcnJpZGUgY29tcHV0ZUxvZ2ljYWxIZWlnaHQuCisKIDIwMTIt MDktMjAgIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1AgcmVw b3J0cyBzaG91bGQgc2VuZCBhbiBlbXB0eSAncmVmZXJyZXInIHJhdGhlciB0aGFuIG5vdGhpbmcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmggYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKaW5kZXggOGI1ODBlMTEyYzMxY2EwNmI0 NWVmZjMwMmZiM2JiNjAwY2YyZDQ1NC4uZGIyNzRmYjg0MTJkNmVhZDQ4NjBhZDJiOTRhMWRmOWQ1 NTU4MTU0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaApAQCAtMzY2LDcgKzM2 Niw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVMb2dpY2FsV2lkdGgoKTsK ICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlTG9naWNhbEhlaWdodCgpOwotICAgIHZvaWQgY29tcHV0 ZUxvZ2ljYWxIZWlnaHQoTGF5b3V0VW5pdCBsb2dpY2FsSGVpZ2h0LCBMYXlvdXRVbml0IGxvZ2lj YWxUb3AsIExvZ2ljYWxFeHRlbnRDb21wdXRlZFZhbHVlcyYpIGNvbnN0OworICAgIHZpcnR1YWwg dm9pZCBjb21wdXRlTG9naWNhbEhlaWdodChMYXlvdXRVbml0IGxvZ2ljYWxIZWlnaHQsIExheW91 dFVuaXQgbG9naWNhbFRvcCwgTG9naWNhbEV4dGVudENvbXB1dGVkVmFsdWVzJikgY29uc3Q7CiAK ICAgICBSZW5kZXJCb3hSZWdpb25JbmZvKiByZW5kZXJCb3hSZWdpb25JbmZvKFJlbmRlclJlZ2lv biosIExheW91dFVuaXQgb2Zmc2V0RnJvbUxvZ2ljYWxUb3BPZkZpcnN0UGFnZSwgUmVuZGVyQm94 UmVnaW9uSW5mb0ZsYWdzID0gQ2FjaGVSZW5kZXJCb3hSZWdpb25JbmZvKSBjb25zdDsKICAgICB2 b2lkIGNvbXB1dGVMb2dpY2FsV2lkdGhJblJlZ2lvbihMb2dpY2FsRXh0ZW50Q29tcHV0ZWRWYWx1 ZXMmLCBSZW5kZXJSZWdpb24qID0gMCwgTGF5b3V0VW5pdCBvZmZzZXRGcm9tTG9naWNhbFRvcE9m Rmlyc3RQYWdlID0gWkVST19MQVlPVVRfVU5JVCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGlzdEJveC5jcHAKaW5kZXggN2EyNDM5Nzc5NzMyOTY3OGE5NDY3ODM2YzY4 N2M0ZmIzYzIyZGFhNy4uMDc5Y2U0MjljNzQxZTAyZTQzY2ZiZTc5YWNkNTM4OTk2YTNhNDdlNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmNwcApAQCAtMTczLDYg KzE3MywxOCBAQCB2b2lkIFJlbmRlckxpc3RCb3g6OnNlbGVjdGlvbkNoYW5nZWQoKQogdm9pZCBS ZW5kZXJMaXN0Qm94OjpsYXlvdXQoKQogewogICAgIFJlbmRlckJsb2NrOjpsYXlvdXQoKTsKKwor ICAgIGlmIChtX3ZCYXIpIHsKKyAgICAgICAgYm9vbCBlbmFibGVkID0gbnVtVmlzaWJsZUl0ZW1z KCkgPCBudW1JdGVtcygpOworICAgICAgICBtX3ZCYXItPnNldEVuYWJsZWQoZW5hYmxlZCk7Cisg ICAgICAgIG1fdkJhci0+c2V0U3RlcHMoMSwgbWF4KDEsIG51bVZpc2libGVJdGVtcygpIC0gMSks IGl0ZW1IZWlnaHQoKSk7CisgICAgICAgIG1fdkJhci0+c2V0UHJvcG9ydGlvbihudW1WaXNpYmxl SXRlbXMoKSwgbnVtSXRlbXMoKSk7CisgICAgICAgIGlmICghZW5hYmxlZCkgeworICAgICAgICAg ICAgc2Nyb2xsVG9PZmZzZXRXaXRob3V0QW5pbWF0aW9uKFZlcnRpY2FsU2Nyb2xsYmFyLCAwKTsK KyAgICAgICAgICAgIG1faW5kZXhPZmZzZXQgPSAwOworICAgICAgICB9CisgICAgfQorCiAgICAg aWYgKG1fc2Nyb2xsVG9SZXZlYWxTZWxlY3Rpb25BZnRlckxheW91dCkgewogICAgICAgICBMYXlv dXRTdGF0ZURpc2FibGVyIGxheW91dFN0YXRlRGlzYWJsZXIodmlldygpKTsKICAgICAgICAgc2Ny b2xsVG9SZXZlYWxTZWxlY3Rpb24oKTsKQEAgLTI1MCwyNSArMjYyLDEwIEBAIExheW91dFVuaXQg UmVuZGVyTGlzdEJveDo6bGlzdEhlaWdodCgpIGNvbnN0CiAgICAgcmV0dXJuIGl0ZW1IZWlnaHQo KSAqIG51bUl0ZW1zKCkgLSByb3dTcGFjaW5nOwogfQogCi12b2lkIFJlbmRlckxpc3RCb3g6OnVw ZGF0ZUxvZ2ljYWxIZWlnaHQoKQordm9pZCBSZW5kZXJMaXN0Qm94Ojpjb21wdXRlTG9naWNhbEhl aWdodChMYXlvdXRVbml0LCBMYXlvdXRVbml0IGxvZ2ljYWxUb3AsIExvZ2ljYWxFeHRlbnRDb21w dXRlZFZhbHVlcyYgY29tcHV0ZWRWYWx1ZXMpIGNvbnN0CiB7Ci0gICAgaW50IHRvQWRkID0gYm9y ZGVyQW5kUGFkZGluZ0hlaWdodCgpOwotIAotICAgIGludCBpdGVtSGVpZ2h0ID0gUmVuZGVyTGlz dEJveDo6aXRlbUhlaWdodCgpOwotICAgIHNldEhlaWdodChpdGVtSGVpZ2h0ICogc2l6ZSgpIC0g cm93U3BhY2luZyArIHRvQWRkKTsKLSAgICAKLSAgICBSZW5kZXJCbG9jazo6dXBkYXRlTG9naWNh bEhlaWdodCgpOwotICAgIAotICAgIGlmIChtX3ZCYXIpIHsKLSAgICAgICAgYm9vbCBlbmFibGVk ID0gbnVtVmlzaWJsZUl0ZW1zKCkgPCBudW1JdGVtcygpOwotICAgICAgICBtX3ZCYXItPnNldEVu YWJsZWQoZW5hYmxlZCk7Ci0gICAgICAgIG1fdkJhci0+c2V0U3RlcHMoMSwgbWF4KDEsIG51bVZp c2libGVJdGVtcygpIC0gMSksIGl0ZW1IZWlnaHQpOwotICAgICAgICBtX3ZCYXItPnNldFByb3Bv cnRpb24obnVtVmlzaWJsZUl0ZW1zKCksIG51bUl0ZW1zKCkpOwotICAgICAgICBpZiAoIWVuYWJs ZWQpIHsKLSAgICAgICAgICAgIHNjcm9sbFRvT2Zmc2V0V2l0aG91dEFuaW1hdGlvbihWZXJ0aWNh bFNjcm9sbGJhciwgMCk7Ci0gICAgICAgICAgICBtX2luZGV4T2Zmc2V0ID0gMDsKLSAgICAgICAg fQotICAgIH0KKyAgICBMYXlvdXRVbml0IGhlaWdodCA9IGl0ZW1IZWlnaHQoKSAqIHNpemUoKSAt IHJvd1NwYWNpbmcgKyBib3JkZXJBbmRQYWRkaW5nSGVpZ2h0KCk7CisgICAgUmVuZGVyQm94Ojpj b21wdXRlTG9naWNhbEhlaWdodChoZWlnaHQsIGxvZ2ljYWxUb3AsIGNvbXB1dGVkVmFsdWVzKTsK IH0KIAogTGF5b3V0VW5pdCBSZW5kZXJMaXN0Qm94OjpiYXNlbGluZVBvc2l0aW9uKEZvbnRCYXNl bGluZSBiYXNlbGluZVR5cGUsIGJvb2wgZmlyc3RMaW5lLCBMaW5lRGlyZWN0aW9uTW9kZSBsaW5l RGlyZWN0aW9uLCBMaW5lUG9zaXRpb25Nb2RlIGxpbmVQb3NpdGlvbk1vZGUpIGNvbnN0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEJveC5oIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RCb3guaAppbmRleCBkMjU5ZTc2N2M4M2U2NTk5 MDVkZGU1ZjBkOTczZWM3NWI4NmYxMGIzLi5lOTM2ZGMyY2U1MDA4ZmJjZDA2YjU0ZTBkNWRjYjM5 OWUyODdjZTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlz dEJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmgKQEAg LTc3LDcgKzc3LDcgQEAgcHJpdmF0ZToKIAogICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlUHJlZmVy cmVkTG9naWNhbFdpZHRocygpOwogICAgIHZpcnR1YWwgTGF5b3V0VW5pdCBiYXNlbGluZVBvc2l0 aW9uKEZvbnRCYXNlbGluZSwgYm9vbCBmaXJzdExpbmUsIExpbmVEaXJlY3Rpb25Nb2RlLCBMaW5l UG9zaXRpb25Nb2RlID0gUG9zaXRpb25PbkNvbnRhaW5pbmdMaW5lKSBjb25zdDsKLSAgICB2aXJ0 dWFsIHZvaWQgdXBkYXRlTG9naWNhbEhlaWdodCgpIE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9p ZCBjb21wdXRlTG9naWNhbEhlaWdodChMYXlvdXRVbml0IGxvZ2ljYWxIZWlnaHQsIExheW91dFVu aXQgbG9naWNhbFRvcCwgTG9naWNhbEV4dGVudENvbXB1dGVkVmFsdWVzJikgY29uc3QgT1ZFUlJJ REU7CiAKICAgICB2aXJ0dWFsIHZvaWQgbGF5b3V0KCk7CiAK