97160 2012-09-19 18:50:34 -0700 [Refactoring] Extract a code to match attribute selector from SelectorChecker::checkOneSelector 2012-10-04 06:06:25 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 96990 1 shinyak shinyak cmarcelo dglazkov hayato macpherson menard webcomponents-bugzilla webkit.review.bot oldest_to_newest 724061 0 shinyak 2012-09-19 18:50:34 -0700 For preparation of https://bugs.webkit.org/show_bug.cgi?id=96990, we would like to extract a code to match attribute selector. We will reuse the code later. 724081 1 164823 shinyak 2012-09-19 19:08:18 -0700 Created attachment 164823 Patch 724084 2 164823 morrita 2012-09-19 19:09:48 -0700 Comment on attachment 164823 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164823&action=review > Source/WebCore/css/SelectorChecker.cpp:1282 > + if (!anyAttributeMatches(element, static_cast<CSSSelector::Match>(selector->m_match), attr, selector->value(), caseSensitive)) Why not just return here? 724100 3 dglazkov 2012-09-19 19:49:55 -0700 Can we hold off on this patch until we have a slightly better idea on how content selector matching machinery will look like? 732748 4 164823 dglazkov 2012-10-02 09:52:44 -0700 Comment on attachment 164823 Patch This is now obsolete. Right? 734632 5 hayato 2012-10-04 06:06:25 -0700 (In reply to comment #4) > (From update of attachment 164823 [details]) > This is now obsolete. Right? Seems obsolete. 164823 2012-09-19 19:08:18 -0700 2012-10-02 09:52:43 -0700 Patch bug-97160-20120920110743.patch text/plain 3480 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTA4Zjg0N2U0YzI5ZTUx Yjg2NzY1OTVlYzE4MGRiM2Q5MmFlNjQwOC4uNGQwNWRlZmRlODc0YmY1MmU5MDVmODA0MDQ2MjAy MjA1YzVlNWY1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTE5ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIEV4dHJhY3QgYSBjb2RlIHRvIG1hdGNoIGF0dHJpYnV0ZSBzZWxlY3RvciBmcm9tIFNlbGVj dG9yQ2hlY2tlcjo6Y2hlY2tPbmVTZWxlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcxNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZSBleHRyYWN0IGEgY29kZSB0byBtYXRjaCBhdHRyaWJ1dGUg c2VsZWN0b3IgZnJvbSBTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3IuIFRoaXMgbmV3 IG1ldGhvZAorICAgICAgICB3aWxsIGJlIHJldXNlZCBmb3IgU2hhZG93RE9NIGNvbnRlbnQgcmVw cm9qZWN0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgc2ltcGxlIHJlZmFjdG9yaW5nLgor CisgICAgICAgICogY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT ZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3IpOgorICAgICAgICAoV2ViQ29yZTo6U2Vs ZWN0b3JDaGVja2VyOjpjaGVja0F0dHJpYnV0ZVNlbGVjdG9yKToKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAqIGNzcy9TZWxlY3RvckNoZWNrZXIuaDoKKwogMjAxMi0wOS0xOSAgSnVsaWVu IENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBUaGUgY29sbGFw c2luZyBib3JkZXIgY29kZSBuZWVkcyBkaXJlY3Rpb24tYXdhcmUgYm9yZGVyIGdldHRlcnMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKaW5kZXggMTMzZTJhOGFhNGNlNmZlMzBj YWIzYmQ3OTgzNDJmNzdkYzQ4ZmIzMy4uNGY0ZDEzZjY0ZjYxN2IzNGIzNmZlZDA1YjAwYjRkNWVh MDkwZWI2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKQEAgLTcxNywx NCArNzE3LDcgQEAgYm9vbCBTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3IoY29uc3Qg U2VsZWN0b3JDaGVja2luZ0NvbnRleHQmIGNvbnRleHQsIFAKICAgICAgICAgcmV0dXJuIGVsZW1l bnQtPmhhc0lEKCkgJiYgZWxlbWVudC0+aWRGb3JTdHlsZVJlc29sdXRpb24oKSA9PSBzZWxlY3Rv ci0+dmFsdWUoKTsKIAogICAgIGlmIChzZWxlY3Rvci0+aXNBdHRyaWJ1dGVTZWxlY3RvcigpKSB7 Ci0gICAgICAgIGNvbnN0IFF1YWxpZmllZE5hbWUmIGF0dHIgPSBzZWxlY3Rvci0+YXR0cmlidXRl KCk7Ci0KLSAgICAgICAgaWYgKCFlbGVtZW50LT5oYXNBdHRyaWJ1dGVzKCkpCi0gICAgICAgICAg ICByZXR1cm4gZmFsc2U7Ci0KLSAgICAgICAgYm9vbCBjYXNlU2Vuc2l0aXZlID0gIW1fZG9jdW1l bnRJc0hUTUwgfHwgIWh0bWxBdHRyaWJ1dGVIYXNDYXNlSW5zZW5zaXRpdmVWYWx1ZShhdHRyKTsK LQotICAgICAgICBpZiAoIWFueUF0dHJpYnV0ZU1hdGNoZXMoZWxlbWVudCwgc3RhdGljX2Nhc3Q8 Q1NTU2VsZWN0b3I6Ok1hdGNoPihzZWxlY3Rvci0+bV9tYXRjaCksIGF0dHIsIHNlbGVjdG9yLT52 YWx1ZSgpLCBjYXNlU2Vuc2l0aXZlKSkKKyAgICAgICAgaWYgKCFjaGVja0F0dHJpYnV0ZVNlbGVj dG9yKHNlbGVjdG9yLCBlbGVtZW50KSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9 CiAKQEAgLTEyNzcsNiArMTI3MCwyMSBAQCBib29sIFNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tTY3Jv bGxiYXJQc2V1ZG9DbGFzcyhDU1NTZWxlY3Rvciogc2VsLCBQc2V1ZG9JZCYpIGNvbgogICAgIH0K IH0KIAorYm9vbCBTZWxlY3RvckNoZWNrZXI6OmNoZWNrQXR0cmlidXRlU2VsZWN0b3IoQ1NTU2Vs ZWN0b3IqIHNlbGVjdG9yLCBFbGVtZW50KiBlbGVtZW50KSBjb25zdAoreworICAgIGNvbnN0IFF1 YWxpZmllZE5hbWUmIGF0dHIgPSBzZWxlY3Rvci0+YXR0cmlidXRlKCk7CisKKyAgICBpZiAoIWVs ZW1lbnQtPmhhc0F0dHJpYnV0ZXMoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAorICAg IGJvb2wgY2FzZVNlbnNpdGl2ZSA9ICFtX2RvY3VtZW50SXNIVE1MIHx8ICFodG1sQXR0cmlidXRl SGFzQ2FzZUluc2Vuc2l0aXZlVmFsdWUoYXR0cik7CisKKyAgICBpZiAoIWFueUF0dHJpYnV0ZU1h dGNoZXMoZWxlbWVudCwgc3RhdGljX2Nhc3Q8Q1NTU2VsZWN0b3I6Ok1hdGNoPihzZWxlY3Rvci0+ bV9tYXRjaCksIGF0dHIsIHNlbGVjdG9yLT52YWx1ZSgpLCBjYXNlU2Vuc2l0aXZlKSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworCisgICAgcmV0dXJuIHRydWU7Cit9CisKIHZvaWQgU2VsZWN0b3JD aGVja2VyOjphbGxWaXNpdGVkU3RhdGVDaGFuZ2VkKCkKIHsKICAgICBpZiAobV9saW5rc0NoZWNr ZWRGb3JWaXNpdGVkU3RhdGUuaXNFbXB0eSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL1NlbGVjdG9yQ2hlY2tlci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tl ci5oCmluZGV4IGYxNWNlMGQwOGVlNDMyOThiNDEyMDQxMmNmNzZkOTVhYTViZjNjMDEuLjVkYmRj OWVhYTYxZWFjMjJkNTU5MjM4Y2Q5OTJjYzRiMWU1MzRiN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU2Vs ZWN0b3JDaGVja2VyLmgKQEAgLTExOSw2ICsxMTksOCBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAg IGJvb2wgY2hlY2tPbmVTZWxlY3Rvcihjb25zdCBTZWxlY3RvckNoZWNraW5nQ29udGV4dCYsIFBz ZXVkb0lkJiwgYm9vbCYgaGFzVW5rbm93blBzZXVkb0VsZW1lbnRzKSBjb25zdDsKICAgICBib29s IGNoZWNrU2Nyb2xsYmFyUHNldWRvQ2xhc3MoQ1NTU2VsZWN0b3IqLCBQc2V1ZG9JZCYgZHluYW1p Y1BzZXVkbykgY29uc3Q7CisgICAgYm9vbCBjaGVja0F0dHJpYnV0ZVNlbGVjdG9yKENTU1NlbGVj dG9yKiwgRWxlbWVudCopIGNvbnN0OworCiAgICAgc3RhdGljIGJvb2wgaXNGcmFtZUZvY3VzZWQo Y29uc3QgRWxlbWVudCopOwogCiAgICAgYm9vbCBmYXN0Q2hlY2tSaWdodG1vc3RTZWxlY3Rvcihj b25zdCBDU1NTZWxlY3RvciosIGNvbnN0IEVsZW1lbnQqLCBWaXNpdGVkTWF0Y2hUeXBlKSBjb25z dDsK