96993 2012-09-18 01:38:27 -0700 [Refactoring] ContentDistributor::distributeSelectionsTo should not change ContentDistribution pool. 2012-09-18 18:04:41 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96988 1 shinyak shinyak webcomponents-bugzilla webkit.review.bot oldest_to_newest 722590 0 shinyak 2012-09-18 01:38:27 -0700 Since we would like to reuse the ContentDistribution pool later, it should be const in this method. Instead, we should have Vector<bool> to know each element is distributed or not. 722598 1 164516 shinyak 2012-09-18 01:47:02 -0700 Created attachment 164516 Patch 723159 2 164516 webkit.review.bot 2012-09-18 18:04:37 -0700 Comment on attachment 164516 Patch Clearing flags on attachment: 164516 Committed r128956: <http://trac.webkit.org/changeset/128956> 723160 3 webkit.review.bot 2012-09-18 18:04:41 -0700 All reviewed patches have been landed. Closing bug. 164516 2012-09-18 01:47:02 -0700 2012-09-18 18:04:36 -0700 Patch bug-96993-20120918174629.patch text/plain 4118 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE5OTQzNjVjOWU4M2Fj NTZkODM5MTA4YTYwZjJiNDExODAzYjY2Ni4uNjI5ZTY3MjA0OTUzODBiNWIxMWFiMDNlYjg2ZmQ0 YTk2ZTczMDVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTE4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIENvbnRlbnREaXN0cmlidXRvcjo6ZGlzdHJpYnV0ZVNlbGVjdGlvbnNUbyBzaG91bGQgbm90 IGNoYW5nZSBDb250ZW50RGlzdHJpYnV0aW9uIHBvb2wuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHdlIHdvdWxkIGxpa2UgdG8gcmV1c2UgQ29u dGVudERpc3RyaWJ1dGlvbiBwb29sLCBpdCBzaG91bGQgbm90IGJlIHVwZGF0ZWQgaW4KKyAgICAg ICAgQ29udGVudERpc3RyaWJ1dG9yOjpkaXN0cmlidXRlU2VsZWN0aW9uc1RvLiBJbnN0ZWFkLCB3 ZSBzaG91bGQgaGF2ZSBWZWN0b3I8Ym9vbD4gdG8gaW5kaWNhdGUgYW4gZWxlbWVudCBpcworICAg ICAgICBkaXN0cmlidXRlZCBvciBub3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW1wbGUg cmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9Db250ZW50RGlzdHJpYnV0b3Iu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudERpc3RyaWJ1dG9yOjpkaXN0cmlidXRlKToK KyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnREaXN0cmlidXRvcjo6ZGlzdHJpYnV0ZVNlbGVjdGlv bnNUbyk6CisgICAgICAgICogaHRtbC9zaGFkb3cvQ29udGVudERpc3RyaWJ1dG9yLmg6CisgICAg ICAgIChDb250ZW50RGlzdHJpYnV0b3IpOgorCiAyMDEyLTA5LTE3ICBDc2FiYSBPc3p0cm9nb27D oWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjEyODgyNiBhbmQgcjEyODgxMy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hh ZG93L0NvbnRlbnREaXN0cmlidXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9D b250ZW50RGlzdHJpYnV0b3IuY3BwCmluZGV4IGIzYzhlYjBlNDdiNzViOWE2YWQyMjM1YmQyMzk0 MjUwNTcxNGEzNzguLjA3NmE3MjNjOGE5MWFmZTkzMTg4NzY1ODk0Y2U3NzM2ZGMzNjZhMDAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0NvbnRlbnREaXN0cmlidXRvci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvQ29udGVudERpc3RyaWJ1dG9yLmNw cApAQCAtNTksNiArNTksOCBAQCB2b2lkIENvbnRlbnREaXN0cmlidXRvcjo6ZGlzdHJpYnV0ZShF bGVtZW50KiBob3N0KQogICAgIENvbnRlbnREaXN0cmlidXRpb24gcG9vbDsKICAgICBmb3IgKE5v ZGUqIG5vZGUgPSBob3N0LT5maXJzdENoaWxkKCk7IG5vZGU7IG5vZGUgPSBub2RlLT5uZXh0U2li bGluZygpKQogICAgICAgICBwb29sLmFwcGVuZChub2RlKTsKKyAgICBWZWN0b3I8Ym9vbD4gZGlz dHJpYnV0ZWQocG9vbC5zaXplKCkpOworICAgIGRpc3RyaWJ1dGVkLmZpbGwoZmFsc2UpOwogCiAg ICAgZm9yIChTaGFkb3dSb290KiByb290ID0gaG9zdC0+eW91bmdlc3RTaGFkb3dSb290KCk7IHJv b3Q7IHJvb3QgPSByb290LT5vbGRlclNoYWRvd1Jvb3QoKSkgewogICAgICAgICBmb3IgKE5vZGUq IG5vZGUgPSByb290OyBub2RlOyBub2RlID0gbm9kZS0+dHJhdmVyc2VOZXh0Tm9kZShyb290KSkg ewpAQCAtNjksNyArNzEsNyBAQCB2b2lkIENvbnRlbnREaXN0cmlidXRvcjo6ZGlzdHJpYnV0ZShF bGVtZW50KiBob3N0KQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgU2hh ZG93Um9vdCogb2xkZXIgPSByb290LT5vbGRlclNoYWRvd1Jvb3QoKTsKICAgICAgICAgICAgIGlm IChwb2ludC0+ZG9lc1NlbGVjdEZyb21Ib3N0Q2hpbGRyZW4oKSkKLSAgICAgICAgICAgICAgICBk aXN0cmlidXRlU2VsZWN0aW9uc1RvKHBvaW50LCBwb29sKTsKKyAgICAgICAgICAgICAgICBkaXN0 cmlidXRlU2VsZWN0aW9uc1RvKHBvaW50LCBwb29sLCBkaXN0cmlidXRlZCk7CiAgICAgICAgICAg ICBlbHNlIGlmIChvbGRlciAmJiAhb2xkZXItPmFzc2lnbmVkVG8oKSkgewogICAgICAgICAgICAg ICAgIGRpc3RyaWJ1dGVOb2RlQ2hpbGRyZW5Ubyhwb2ludCwgb2xkZXIpOwogICAgICAgICAgICAg ICAgIG9sZGVyLT5zZXRBc3NpZ25lZFRvKHBvaW50KTsKQEAgLTEwNiwyMSArMTA4LDIyIEBAIHZv aWQgQ29udGVudERpc3RyaWJ1dG9yOjpmaW5pc2hJbml2YWxpZGF0aW9uKCkKICAgICBtX3ZhbGlk aXR5ID0gSW52YWxpZGF0ZWQ7CiB9CiAKLXZvaWQgQ29udGVudERpc3RyaWJ1dG9yOjpkaXN0cmli dXRlU2VsZWN0aW9uc1RvKEluc2VydGlvblBvaW50KiBpbnNlcnRpb25Qb2ludCwgQ29udGVudERp c3RyaWJ1dGlvbiYgcG9vbCkKK3ZvaWQgQ29udGVudERpc3RyaWJ1dG9yOjpkaXN0cmlidXRlU2Vs ZWN0aW9uc1RvKEluc2VydGlvblBvaW50KiBpbnNlcnRpb25Qb2ludCwgY29uc3QgQ29udGVudERp c3RyaWJ1dGlvbiYgcG9vbCwgVmVjdG9yPGJvb2w+JiBkaXN0cmlidXRlZCkKIHsKICAgICBDb250 ZW50RGlzdHJpYnV0aW9uIGRpc3RyaWJ1dGlvbjsKICAgICBDb250ZW50U2VsZWN0b3JRdWVyeSBx dWVyeShpbnNlcnRpb25Qb2ludCk7CiAKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHBvb2wu c2l6ZSgpOyArK2kpIHsKLSAgICAgICAgTm9kZSogY2hpbGQgPSBwb29sW2ldLmdldCgpOwotICAg ICAgICBpZiAoIWNoaWxkKQorICAgICAgICBpZiAoZGlzdHJpYnV0ZWRbaV0pCiAgICAgICAgICAg ICBjb250aW51ZTsKKworICAgICAgICBOb2RlKiBjaGlsZCA9IHBvb2xbaV0uZ2V0KCk7CiAgICAg ICAgIGlmICghcXVlcnkubWF0Y2hlcyhjaGlsZCkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAog ICAgICAgICBkaXN0cmlidXRpb24uYXBwZW5kKGNoaWxkKTsKICAgICAgICAgbV9ub2RlVG9JbnNl cnRpb25Qb2ludC5hZGQoY2hpbGQsIGluc2VydGlvblBvaW50KTsKLSAgICAgICAgcG9vbFtpXSA9 IDA7CisgICAgICAgIGRpc3RyaWJ1dGVkW2ldID0gdHJ1ZTsKICAgICB9CiAKICAgICBpbnNlcnRp b25Qb2ludC0+c2V0RGlzdHJpYnV0aW9uKGRpc3RyaWJ1dGlvbik7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL3NoYWRvdy9Db250ZW50RGlzdHJpYnV0b3IuaCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L0NvbnRlbnREaXN0cmlidXRvci5oCmluZGV4IDA4Y2I1NDNmOGI3YTg3 YTEwNDdlNDA2YmE2ODJlYmFkNzllY2YyN2UuLmJlZTkyYTU2YWMxNDBhZjY1NWYwNWU4MzljYmE2 NjAzYzU0MmQyNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0NvbnRl bnREaXN0cmlidXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0NvbnRlbnRE aXN0cmlidXRvci5oCkBAIC02OSw3ICs2OSw3IEBAIHB1YmxpYzoKICAgICBib29sIG5lZWRzRGlz dHJpYnV0aW9uKCkgY29uc3Q7CiAgICAgYm9vbCBuZWVkc0ludmFsaWRhdGlvbigpIGNvbnN0IHsg cmV0dXJuIG1fdmFsaWRpdHkgIT0gSW52YWxpZGF0ZWQ7IH0KIAotICAgIHZvaWQgZGlzdHJpYnV0 ZVNlbGVjdGlvbnNUbyhJbnNlcnRpb25Qb2ludCosIENvbnRlbnREaXN0cmlidXRpb24mIHBvb2wp OworICAgIHZvaWQgZGlzdHJpYnV0ZVNlbGVjdGlvbnNUbyhJbnNlcnRpb25Qb2ludCosIGNvbnN0 IENvbnRlbnREaXN0cmlidXRpb24mIHBvb2wsIFZlY3Rvcjxib29sPiYgZGlzdHJpYnV0ZWQpOwog ICAgIHZvaWQgZGlzdHJpYnV0ZU5vZGVDaGlsZHJlblRvKEluc2VydGlvblBvaW50KiwgQ29udGFp bmVyTm9kZSopOwogICAgIHZvaWQgaW52YWxpZGF0ZURpc3RyaWJ1dGlvbkluKENvbnRlbnREaXN0 cmlidXRpb24qKTsKIAo=