96960 2012-09-17 15:15:03 -0700 Turn on ENABLE_MATHML for Chromium 2012-10-10 13:33:32 -0700 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 96843 97606 84019 1 eric dbarton abarth cdumez davidc dbarton dglazkov donggwan.kim eae ericbidelman fred.wang inferno japhet jchaffraix leviw ojan peter syoichi tony webkit.review.bot yurys oldest_to_newest 722308 0 eric 2012-09-17 15:15:03 -0700 Turn on ENABLE_MATHML for Chromium After bug 96843, Dave believes most (if not all) of the known crashers for MathML are resolved, and it's ready to enable for Chromium. We'll flip the switch after M23 has branched, which should be tomorrow. We'll probably need to inform the current gardener that there may be some massive MathML pixel rebaselines incoming. :) 722310 1 eric 2012-09-17 15:16:11 -0700 Once its on, it the chromium fuzzer bots should tell us if we have any stability issues left to worry about. If so, we can always turn it off again before branching for m24 in another 6 weeks. 722312 2 inferno 2012-09-17 15:18:06 -0700 Sounds good!! 722315 3 eric 2012-09-17 15:26:07 -0700 I've CC'd the upcoming WebKit gardeners for this week so they're aware of this impending change (feel free to remove yourself if you're not interested!) 722411 4 eric 2012-09-17 18:40:25 -0700 http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/features.gypi is the file to change, btw. 722412 5 eric 2012-09-17 18:41:52 -0700 We'll also want to remove this line once MATHML is turned back on: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/TestExpectations#L1651 or perhaps as part of turning it on. 722981 6 dbarton 2012-09-18 12:36:34 -0700 Other than checking for crashers, I think our two main issues will be: 1. Most of the MathML tests are pixel tests. I still need to tweak MathML layout sometimes, and when I do, it often triggers a ~1MB patch (sigh). This is almost all test results in LayoutTests/platform/*/mathml/presentation. Actually, so far the only platforms are mac, efl, and gtk. I verify the results in platform/mac, and lately Christophe Dumez usually checks the efl and gtk ones. I'd be happy to check results on various platforms if gardeners want to upload them or e-mail a zip file to me. Actually WebKit MathML isn't used yet in the wild too much, so we don't have to be too paranoid about small changes. If you check the .png files quickly and they look similar to the platform/mac ones, then I'd just rebaseline (.png and .txt) if I were you. If your .png files look bad, then please upload or send your results to me. 2. The biggest platform issue for MathML will doubtless be fonts. We can minimize this problem by ensuring the STIX fonts are on all the bots - then we might even be able to combine some pixel test baselines. On Mac bots the OS must be at least OS X 10.7.4, or else the STIX fonts come out always italic. Can someone verify the OS version on the Chromium Mac bots? There are also some issues on linux - search LayoutTests/platform/efl/Skipped for "mathml"; and see bug 47744; and bug 38377, comment 2 (I need to fix that, I think). But the biggest issue is probably -webkit-line-box-contain on Windows - see <http://code.google.com/p/chromium/issues/detail?id=77095>. Christophe Dumez was able to fix this on linux fairly quickly in bug 93073 - see its comments 8, 11 and 12, and its patch. It'd be great if a Windows font expert could do this on Windows also. Bug 48124 may also be an issue on Windows. Note the Apple Mac port doesn't enable subpixel layout yet I believe, so its MathML baselines may be slightly different from Chromium. I think the summary is that it'll be great to test MathML for crashes, and hopefully we can also get it looking good on Mac, Linux, and Windows soon. If not, we may have to turn it off on some platforms for now. But MathML in Chrome is still exciting! 726341 7 dbarton 2012-09-23 19:40:52 -0700 (In reply to comment #4) > http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/features.gypi is the file to change, btw. Apparently you also have to add an include path of Source/WebCore/rendering/mathml somewhere. Does anyone know where? Has anyone been able to compile chromium with ENABLE(MATHML) locally? Is there anything else I need to do? Thanks in advance! 726346 8 eric 2012-09-23 20:05:02 -0700 http://trac.webkit.org/browser/trunk/Source/WebCore/WebCore.gypi is where the files go, http://trac.webkit.org/browser/trunk/Source/WebCore/WebCore.gyp/WebCore.gyp is where the include paths go, I believe. Tony Chang is the many I ask all my gyp questions to, he'll correct me if I'm wrong. :) 726347 9 eric 2012-09-23 20:05:52 -0700 I'm away from my work machine, otherwise I'd test this build for you. update-webkit-chromium && build-webkit --chromium should also work if you need to try yourself. 726349 10 eric 2012-09-23 20:07:02 -0700 update-webkit-chromium is just the fancy script that update-webkit --chromium (note the space) calls to update the generated project files (in your case, XCode file, presumably) after each update. It can be called manually to update the generated project files w/o updating the repository (despite it's confusing name). :) 726365 11 dbarton 2012-09-23 21:01:17 -0700 That all looks to be working great, thanks! (Sorry, I had been looking in Source/WebKit/chromium.) 726859 12 tony 2012-09-24 11:17:37 -0700 Sounds like you got things building. For TestExpectations, I would just mark the lines as [ Failure ]. This will run the tests on the bot and allow anyone to rebaseline them using garden-o-matic. I don't think using a special font will avoid pixel results since there will still be antialiasing differences across platforms. It looks like there are only 32 pixel tests. Adding 32 * 2 (txt and png file) * 3 (win, mac, linux) = 192 files for Chromium pixel results isn't great, but I can't think of anything better. http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/TestExpectations#L1643 727691 13 dbarton 2012-09-25 09:09:30 -0700 Thanks very much for the expert information and advice. I indeed have things building, but have been stuck on an assertion failure due to a combination of MathML, FlexBox, and SubPixel layout units. LayoutTests/mathml/presentation/roots.xhtml causes totalWeightedFlexShrink in RenderFlexibleBox::layoutFlexItems to go negative due to roundoff error, at least for chromium mac snowleopard with ENABLE(MATHML). I think the main issue is that MathML uses flexboxes but without any flex, so every child in RenderFlexibleBox::resolveFlexibleLengths becomes a violation [in a case where availableFreeSpace < 0]. Then RenderFlexibleBox::freezeViolations subtracts each preferredChildSize from totalWeightedFlexShrink [child->style()->flexShrink() is always 1], and the roundoff error brings totalWeightedFlexShrink slightly below 0. I realize I should file a bug for this, but it'd be easier after MathML is enabled in Chrome, since I haven't been able to reproduce this without MathML yet. However, I'm thinking this summary may be enough for Tony & Ojan to say something? Thanks greatly! 727789 14 eric 2012-09-25 10:54:57 -0700 Calling in the sub-pixel brigade! (Be warned, all Googlers are distracted this week with annual peer-reviews, due friday.) 727853 15 ojan 2012-09-25 12:07:58 -0700 This sounds like a genuine flexbox bug. It's not clear to me where the bug is at a quick glance at the code. It's hard to look into it further without a flexbox-only test case. 738186 16 eric 2012-10-09 14:31:13 -0700 I'm happy to help you flip this flag tomorrow if you'd like, Dave. 738289 17 dbarton 2012-10-09 16:03:34 -0700 (In reply to comment #16) > I'm happy to help you flip this flag tomorrow if you'd like, Dave. I have it compiling, and could submit a patch to turn MathML on in Chrome, marking the layout tests as failing. I guess I was waiting on bug 98791, and I'm working on bug 97390, and also I'm guessing -webkit-line-box-contain will fail on Windows so all the MathML won't layout right there. There are also some smaller layout issues, but maybe it's better to turn MathML on so we can see these issues? I think I'll discuss this with you (Eric) by e-mail, so I can get clarity, thanks! 739068 18 168027 dbarton 2012-10-10 10:26:32 -0700 Created attachment 168027 Patch 739081 19 168027 eric 2012-10-10 10:31:13 -0700 Comment on attachment 168027 Patch If the EWS likes it, then I do. SGTM. Please let the bubbles roll before landing. 739082 20 eric 2012-10-10 10:31:29 -0700 CCing todays gardeners. 739189 21 168027 webkit.review.bot 2012-10-10 11:57:24 -0700 Comment on attachment 168027 Patch Attachment 168027 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14259163 New failing tests: http/tests/xmlviewer/dumpAsText/mathml.xml 739222 22 eric 2012-10-10 12:37:30 -0700 abarth says "bring it on". Feel free to land whenever and we'll be in #webkit to help you clean up any troubles. 739233 23 168056 dbarton 2012-10-10 12:52:55 -0700 Created attachment 168056 Patch 739241 24 168056 abarth 2012-10-10 13:11:07 -0700 Comment on attachment 168056 Patch Forwarding Eric's R+. 739262 25 dbarton 2012-10-10 13:33:32 -0700 Committed r130950: <http://trac.webkit.org/changeset/130950> 168027 2012-10-10 10:26:32 -0700 2012-10-10 12:52:51 -0700 Patch bug-96960-20121010102532.patch text/plain 3673 dbarton SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDkxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTEwICBEYXZpZCBC YXJ0b24gIDxkYmFydG9uQG1hdGhzY3JpYmUuY29tPgorCisgICAgICAgIFR1cm4gb24gRU5BQkxF X01BVEhNTCBmb3IgQ2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk2OTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIHRoZSByZW5kZXJpbmcvbWF0aG1sIGRpcmVjdG9yeSB0byBzZWFyY2gu CisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDoKKwogMjAxMi0xMC0xMCAgQW5k cmVpIEJ1Y3VyICA8YWJ1Y3VyQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFJlZ2lvbnNdIENy ZWF0ZSBhIHNlcGFyYXRlIGxpc3QgZm9yIHRoZSBpbnZhbGlkIHJlZ2lvbnMKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCShyZXZpc2lvbiAxMzA3NjIpCisrKyBTb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAkod29ya2luZyBjb3B5KQpAQCAtMTM5 LDYgKzEzOSw3IEBACiAgICAgICAnLi4vcGx1Z2lucycsCiAgICAgICAnLi4vcGx1Z2lucy9jaHJv bWl1bScsCiAgICAgICAnLi4vcmVuZGVyaW5nJywKKyAgICAgICcuLi9yZW5kZXJpbmcvbWF0aG1s JywKICAgICAgICcuLi9yZW5kZXJpbmcvc3R5bGUnLAogICAgICAgJy4uL3JlbmRlcmluZy9zdmcn LAogICAgICAgJy4uL3N0b3JhZ2UnLApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMDkxOSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMTAtMTAgIERhdmlkIEJhcnRvbiAgPGRi YXJ0b25AbWF0aHNjcmliZS5jb20+CisKKyAgICAgICAgVHVybiBvbiBFTkFCTEVfTUFUSE1MIGZv ciBDaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTY5NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGZlYXR1cmVzLmd5cGk6CisKIDIwMTItMTAtMDggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gQWRkIFdlYkVsZW1lbnQ6Omhhc0hUTUxU YWdOYW1lLCBhbmQgZGVwcmVjYXRlIGhhc1RhZ05hbWUKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L2ZlYXR1cmVzLmd5cGkJKHJldmlzaW9uIDEzMDkxNCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vZmVhdHVyZXMuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtODEsNiArODEsNyBAQAogICAgICAg J0VOQUJMRV9MRUdBQ1lfV0VCX0FVRElPPTEnLAogICAgICAgJ0VOQUJMRV9MSU5LX1BSRUZFVENI PTEnLAogICAgICAgJ0VOQUJMRV9MSU5LX1BSRVJFTkRFUj0xJywKKyAgICAgICdFTkFCTEVfTUFU SE1MPTEnLAogICAgICAgJ0VOQUJMRV9NRURJQV9TT1VSQ0U9MScsCiAgICAgICAnRU5BQkxFX01F RElBX1NUQVRJU1RJQ1M9MScsCiAgICAgICAnRU5BQkxFX01FVEVSX0VMRU1FTlQ9MScsCkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiAxMzA5MTkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMC0xMCAgRGF2aWQgQmFydG9uICA8ZGJhcnRv bkBtYXRoc2NyaWJlLmNvbT4KKworICAgICAgICBUdXJuIG9uIEVOQUJMRV9NQVRITUwgZm9yIENo cm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 Njk2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl J3JlIGVuYWJsaW5nIE1hdGhNTCBub3cgcGFydGx5IHRvIGxldCB0aGUgYXV0b21hdGVkIGZ1enpl cnMgZ28gdG8gd29yay4gU29tZSBsYXlvdXQgdHVuaW5nIHdpbGwgYWxzbyBiZSBkb25lIGluIHRo ZQorICAgICAgICBuZXh0IGZldyBkYXlzLCBzbyB3ZSBleHBlY3QgTWF0aE1MIHBpeGVsIHRlc3Rz IHRvIGJlIGNoYW5naW5nIGR1cmluZyB0aGF0IHRpbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTEwLTEwICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgQ2hyb21pdW0g Z2FyZGVuaW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVj dGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0 RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxMzA5MTkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xOTkzLDcgKzE5OTMs MTAgQEAgY3JidWcuY29tLzIwMzQ1IGZhc3QvanMvZ2V0T3duUHJvcGVydHlEZQogY3JidWcuY29t LzIyNTI2IGZhc3QvanMvT2JqZWN0LWRlZmluZVByb3BlcnR5Lmh0bWwgWyBGYWlsdXJlIF0KIAog IyBXZWJLaXQgbWVyZ2UgNDg1MDA6NDg1ODUsIGR1ZSB0byBuZXdseSBhZGRlZCBzdXBwb3J0IGZv ciBNYXRoTUwuCi1jcmJ1Zy5jb20vMjI1NTQgbWF0aG1sCisjIGNyYnVnLmNvbS8yMjU1NCBtYXRo bWwKKyMgVGhlIG1hdGhtbCBwaXhlbCB0ZXN0cyB3aWxsIGJlIGNoYW5naW5nIGZvciBhIGZldyBk YXlzLiBUaGV5J2xsIG5lZWQgcmViYXNlbGluZSBhZnRlciB0aGF0Lgord2Via2l0Lm9yZy9iLzk2 OTYwIG1hdGhtbC94SGVpZ2h0LnhodG1sIFsgUGFzcyBGYWlsdXJlIEltYWdlT25seUZhaWx1cmUg XQord2Via2l0Lm9yZy9iLzk2OTYwIG1hdGhtbC9wcmVzZW50YXRpb24gWyBQYXNzIEZhaWx1cmUg SW1hZ2VPbmx5RmFpbHVyZSBdCiAKICMgV2ViS2l0IHVwZGF0ZSA0ODc5Njo0ODgyMAogIyBUZXN0 ICM5IHRocm93cyBhbiBleGNlcHRpb24uCg== 168056 2012-10-10 12:52:55 -0700 2012-10-10 13:11:07 -0700 Patch bug-96960-20121010125154.patch text/plain 3866 dbarton SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDkxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTEwICBEYXZpZCBC YXJ0b24gIDxkYmFydG9uQG1hdGhzY3JpYmUuY29tPgorCisgICAgICAgIFR1cm4gb24gRU5BQkxF X01BVEhNTCBmb3IgQ2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk2OTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIHRoZSByZW5kZXJpbmcvbWF0aG1sIGRpcmVjdG9yeSB0byBzZWFyY2gu CisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDoKKwogMjAxMi0xMC0xMCAgQW5k cmVpIEJ1Y3VyICA8YWJ1Y3VyQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFJlZ2lvbnNdIENy ZWF0ZSBhIHNlcGFyYXRlIGxpc3QgZm9yIHRoZSBpbnZhbGlkIHJlZ2lvbnMKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCShyZXZpc2lvbiAxMzA3NjIpCisrKyBTb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAkod29ya2luZyBjb3B5KQpAQCAtMTM5 LDYgKzEzOSw3IEBACiAgICAgICAnLi4vcGx1Z2lucycsCiAgICAgICAnLi4vcGx1Z2lucy9jaHJv bWl1bScsCiAgICAgICAnLi4vcmVuZGVyaW5nJywKKyAgICAgICcuLi9yZW5kZXJpbmcvbWF0aG1s JywKICAgICAgICcuLi9yZW5kZXJpbmcvc3R5bGUnLAogICAgICAgJy4uL3JlbmRlcmluZy9zdmcn LAogICAgICAgJy4uL3N0b3JhZ2UnLApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMDkxOSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMTAtMTAgIERhdmlkIEJhcnRvbiAgPGRi YXJ0b25AbWF0aHNjcmliZS5jb20+CisKKyAgICAgICAgVHVybiBvbiBFTkFCTEVfTUFUSE1MIGZv ciBDaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTY5NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGZlYXR1cmVzLmd5cGk6CisKIDIwMTItMTAtMDggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gQWRkIFdlYkVsZW1lbnQ6Omhhc0hUTUxU YWdOYW1lLCBhbmQgZGVwcmVjYXRlIGhhc1RhZ05hbWUKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L2ZlYXR1cmVzLmd5cGkJKHJldmlzaW9uIDEzMDkxNCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vZmVhdHVyZXMuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtODEsNiArODEsNyBAQAogICAgICAg J0VOQUJMRV9MRUdBQ1lfV0VCX0FVRElPPTEnLAogICAgICAgJ0VOQUJMRV9MSU5LX1BSRUZFVENI PTEnLAogICAgICAgJ0VOQUJMRV9MSU5LX1BSRVJFTkRFUj0xJywKKyAgICAgICdFTkFCTEVfTUFU SE1MPTEnLAogICAgICAgJ0VOQUJMRV9NRURJQV9TT1VSQ0U9MScsCiAgICAgICAnRU5BQkxFX01F RElBX1NUQVRJU1RJQ1M9MScsCiAgICAgICAnRU5BQkxFX01FVEVSX0VMRU1FTlQ9MScsCkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiAxMzA5MTkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMC0xMCAgRGF2aWQgQmFydG9uICA8ZGJhcnRv bkBtYXRoc2NyaWJlLmNvbT4KKworICAgICAgICBUdXJuIG9uIEVOQUJMRV9NQVRITUwgZm9yIENo cm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 Njk2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl J3JlIGVuYWJsaW5nIE1hdGhNTCBub3cgcGFydGx5IHRvIGxldCB0aGUgYXV0b21hdGVkIGZ1enpl cnMgZ28gdG8gd29yay4gU29tZSBsYXlvdXQgdHVuaW5nIHdpbGwgYWxzbyBiZSBkb25lIGluIHRo ZQorICAgICAgICBuZXh0IGZldyBkYXlzLCBzbyB3ZSBleHBlY3QgTWF0aE1MIHBpeGVsIHRlc3Rz IHRvIGJlIGNoYW5naW5nIGR1cmluZyB0aGF0IHRpbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTEwLTEwICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgQ2hyb21pdW0g Z2FyZGVuaW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVj dGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0 RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxMzA5NDIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0yMDEwLDcgKzIwMTAs MTIgQEAgY3JidWcuY29tLzIwMzQ1IGZhc3QvanMvZ2V0T3duUHJvcGVydHlEZQogY3JidWcuY29t LzIyNTI2IGZhc3QvanMvT2JqZWN0LWRlZmluZVByb3BlcnR5Lmh0bWwgWyBGYWlsdXJlIF0KIAog IyBXZWJLaXQgbWVyZ2UgNDg1MDA6NDg1ODUsIGR1ZSB0byBuZXdseSBhZGRlZCBzdXBwb3J0IGZv ciBNYXRoTUwuCi1jcmJ1Zy5jb20vMjI1NTQgbWF0aG1sCisjIGNyYnVnLmNvbS8yMjU1NCBtYXRo bWwKKyMgVGhlIG1hdGhtbCBwaXhlbCB0ZXN0cyB3aWxsIGJlIGNoYW5naW5nIGZvciBhIGZldyBk YXlzLiBUaGV5J2xsIG5lZWQgcmViYXNlbGluZSBhZnRlciB0aGF0Lgord2Via2l0Lm9yZy9iLzk2 OTYwIG1hdGhtbC94SGVpZ2h0LnhodG1sIFsgUGFzcyBGYWlsdXJlIEltYWdlT25seUZhaWx1cmUg XQord2Via2l0Lm9yZy9iLzk2OTYwIG1hdGhtbC9wcmVzZW50YXRpb24gWyBQYXNzIEZhaWx1cmUg SW1hZ2VPbmx5RmFpbHVyZSBdCisjIE9uY2UgY2hyb21pdW0gZGVjaWRlcyB0byBkZWZpbml0ZWx5 IGVuYWJsZSBNYXRoTUwsIHdlIGNhbiBkZWxldGUgdGhlIG9sZCBwbGF0Zm9ybS9jaHJvbWl1bSBi YXNlbGluZSBmb3IgdGhpczoKK3dlYmtpdC5vcmcvYi85Njk2MCBodHRwL3Rlc3RzL3htbHZpZXdl ci9kdW1wQXNUZXh0L21hdGhtbC54bWwgWyBQYXNzIEZhaWx1cmUgXQogCiAjIFdlYktpdCB1cGRh dGUgNDg3OTY6NDg4MjAKICMgVGVzdCAjOSB0aHJvd3MgYW4gZXhjZXB0aW9uLgo=