96612 2012-09-13 00:29:24 -0700 [Tests] We should have test for clicking spin button in iframe. 2012-09-13 04:54:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96634 95720 1 yosin yosin tkent oldest_to_newest 719148 0 yosin 2012-09-13 00:29:24 -0700 We saw regression on spinbutton clicking in iframe after changes of https://bugs.webkit.org/show_bug.cgi?id=95720 Although, we couldn't catch this regression. 719163 1 163803 yosin 2012-09-13 00:43:38 -0700 Created attachment 163803 Patch 1 719164 2 163803 yosin 2012-09-13 00:44:21 -0700 Comment on attachment 163803 Patch 1 Could you review this patch? Thanks in advance. 719182 3 163803 tkent 2012-09-13 00:59:25 -0700 Comment on attachment 163803 Patch 1 ok 719222 4 163803 yosin 2012-09-13 01:36:59 -0700 Comment on attachment 163803 Patch 1 Clearing flags on attachment: 163803 Committed r128423: <http://trac.webkit.org/changeset/128423> 719223 5 yosin 2012-09-13 01:37:04 -0700 All reviewed patches have been landed. Closing bug. 163803 2012-09-13 00:43:38 -0700 2012-09-13 01:36:59 -0700 Patch 1 bug-96612-20120913164311.patch text/plain 6503 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NDEyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDg2MTQ0ZmJhMjNkOTdmZmNkZGIz NmY3ZWE1ZTZmMDJkYWIzOTVhMi4uNGJkNGUwNTJhOGM2M2QwNzlkOGFjNjFkMjg5Y2JkZmIxMjU1 YWU2NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA5LTEzICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Rlc3RzXSBXZSBzaG91bGQgaGF2ZSB0 ZXN0IGZvciBjbGlja2luZyBzcGluIGJ1dHRvbiBpbiBpZnJhbWUuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjYxMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyB0d28gdGVzdHMg Zm9yIGNsaWNraW5nIHNwaW4gYnV0dG9uIGluIGlmcmFtZSBmb3IKKyAgICAgICAgaW5wdXQgdHlw ZSAibnVtYmVyIiBhbmQgaW5wdXQgdHlwZSAidGltZSIgd2l0aCBtdWx0aXBsZSBmaWVsZHMgVUku CisKKyAgICAgICAgVGhlc2UgdGVzdHMgYXJlIGFkZGVkIGZvciBjYXRjaGluZyByZWdyZXNzaW9u IGNhdXNlZCBieSByMTI3ODc2LgorCisgICAgICAgICogZmFzdC9mb3Jtcy9udW1iZXIvbnVtYmVy LXNwaW5idXR0b24tY2xpY2staW4taWZyYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9mb3Jtcy9udW1iZXIvbnVtYmVyLXNwaW5idXR0b24tY2xpY2staW4taWZyYW1lLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvcmVzb3VyY2VzL2NvbW1vbi1zcGluYnV0 dG9uLWNsaWNrLWluLWlmcmFtZS5qczogQWRkZWQuCisgICAgICAgIChnZXRTcGluQnV0dG9uKTog RXh0cmFjdHMgc3BpbiBidXR0b24gaW4gc2hhZG93IERPTSB0cmVlLgorICAgICAgICAobW91c2VD bGljayk6IFNpbXVsYXRlcyBtb3VzZSBjbGljay4KKyAgICAgICAgKG1vdXNlTW92ZVRvKTogU2lt dWxhdGVzIG1vdXNlIHBvaW50ZXIgbW92ZS4KKyAgICAgICAgKHJ1bklGcmFtZUxvYWRlZCk6IENo ZWNraW5nIHNwaW4gYnV0dG9uIGNsaWNrZWQuCisgICAgICAgICh0ZXN0Q2xpY2tTcGluQnV0dG9u SW5JRnJhbWUpOiBDcmVhdGVzIGFuZCBwb3B1bGF0ZXMgaWZyYW1lLgorICAgICAgICAqIGZhc3Qv Zm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMtc3BpbmJ1dHRv bi1jbGljay1pbi1pZnJhbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zv cm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLXNwaW5idXR0b24t Y2xpY2staW4taWZyYW1lLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA5LTEzICBTdGVwaGFuaWUgTGV3 aXMgIDxzbGV3aXNAYXBwbGUuY29tPgogCiAgICAgICAgIGZhc3QvdGFibGUvYmFkLXJlcGxhY2Vk LXNpemluZy1wcmVmZXJyZWQtbG9naWNhbC13aWR0aHMuaHRtbCBpcyBmYWlsaW5nIG9uIE1hYywg Q2hyb21pdW0tTWFjLCBHVEssIEVGTC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvbnVtYmVyL251bWJlci1zcGluYnV0dG9uLWNsaWNrLWluLWlmcmFtZS1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL251bWJlci9udW1iZXItc3BpbmJ1dHRvbi1jbGljay1p bi1pZnJhbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNkYzlhZmZmM2IxYWM2NGVkMzNhZjYw ZDhlZWJjNjRiMWY2MDY3MTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL251bWJlci9udW1iZXItc3BpbmJ1dHRvbi1jbGljay1pbi1pZnJhbWUtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMTAgQEAKK0NoZWNrcyBtb3VzZSBjbGljayBvbiBzcGluIGJ1dHRvbiBpbiBp ZnJhbWUuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHRlc3RJbnB1dC52 YWx1ZSBpcyAiMTIzNDYiCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1Qg Q09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvbnVt YmVyLXNwaW5idXR0b24tY2xpY2staW4taWZyYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL251bWJlci9udW1iZXItc3BpbmJ1dHRvbi1jbGljay1pbi1pZnJhbWUuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4zYjhlOTI0YmM3NDYxOWJjNjllZDUyZTVmMmMyMGQ3ZTMyYTQ5YWI4Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvbnVtYmVyLXNwaW5idXR0b24t Y2xpY2staW4taWZyYW1lLmh0bWwKQEAgLTAsMCArMSwxNyBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvY29tbW9u LXNwaW5idXR0b24tY2xpY2staW4taWZyYW1lLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 PgorPHNjcmlwdD4KK3Rlc3RDbGlja1NwaW5CdXR0b25JbklGcmFtZSh7CisgICAgJ2V4cGVjdGVk VmFsdWUnIDogJzEyMzQ2JywKKyAgICAnaW5pdGlhbFZhbHVlJyA6ICcxMjM0NScsCisgICAgJ2lu cHV0VHlwZScgOiAnbnVtYmVyJworfSk7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8u Li9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5Pgor PC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yZXNvdXJjZXMvY29t bW9uLXNwaW5idXR0b24tY2xpY2staW4taWZyYW1lLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9yZXNvdXJjZXMvY29tbW9uLXNwaW5idXR0b24tY2xpY2staW4taWZyYW1lLmpzCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjU2NjdiZDAxM2U2Njk5NDBlYTMzNWI3NDJhMGI4OWFhMjQ1ZjkxNGYKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Jlc291cmNlcy9jb21tb24tc3BpbmJ1dHRv bi1jbGljay1pbi1pZnJhbWUuanMKQEAgLTAsMCArMSw1NCBAQAord2luZG93LmpzVGVzdElzQXN5 bmMgPSB0cnVlOworCit2YXIgaWZyYW1lOwordmFyIHRlc3RJbnB1dDsKKworZnVuY3Rpb24gZ2V0 U3BpbkJ1dHRvbihpbnB1dCkKK3sKKyAgICBpZiAoIXdpbmRvdy5pbnRlcm5hbHMpCisgICAgICAg IHJldHVybiBudWxsOworICAgIHZhciBlZGl0RWxlbWVudCA9IHdpbmRvdy5pbnRlcm5hbHMub2xk ZXN0U2hhZG93Um9vdChpbnB1dCk7CisgICAgcmV0dXJuIGVkaXRFbGVtZW50LmZpcnN0Q2hpbGQu bGFzdENoaWxkOworfQorCitmdW5jdGlvbiBtb3VzZUNsaWNrKCkKK3sKKyAgICBpZiAoIXdpbmRv dy5ldmVudFNlbmRlcikKKyAgICAgICAgcmV0dXJuOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93 bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKK30KKworZnVuY3Rpb24gbW91c2VNb3Zl VG8oeCwgeSkKK3sKKyAgICBpZiAoIXdpbmRvdy5ldmVudFNlbmRlcikKKyAgICAgICAgcmV0dXJu OworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOworfQorCitmdW5jdGlvbiBydW5J RnJhbWVMb2FkZWQoY29uZmlnKQoreworICAgIHRlc3RJbnB1dCA9IGlmcmFtZS5jb250ZW50RG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKKyAgICB2YXIgc3BpbkJ1dHRvbiA9IGdldFNw aW5CdXR0b24odGVzdElucHV0KTsKKyAgICBpZiAoc3BpbkJ1dHRvbikgeworICAgICAgICBtb3Vz ZU1vdmVUbygKKyAgICAgICAgICAgIGlmcmFtZS5vZmZzZXRMZWZ0ICsgc3BpbkJ1dHRvbi5vZmZz ZXRMZWZ0ICsgc3BpbkJ1dHRvbi5vZmZzZXRXaWR0aCAvIDIsCisgICAgICAgICAgICBpZnJhbWUu b2Zmc2V0VG9wICsgc3BpbkJ1dHRvbi5vZmZzZXRUb3AgKyBzcGluQnV0dG9uLm9mZnNldEhlaWdo dCAvIDQpOworICAgIH0KKyAgICBtb3VzZUNsaWNrKCk7CisgICAgc2hvdWxkQmVFcXVhbFRvU3Ry aW5nKCd0ZXN0SW5wdXQudmFsdWUnLCBjb25maWdbJ2V4cGVjdGVkVmFsdWUnXSk7CisgICAgaWZy YW1lLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoaWZyYW1lKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsK K30KKworZnVuY3Rpb24gdGVzdENsaWNrU3BpbkJ1dHRvbkluSUZyYW1lKGNvbmZpZykKK3sKKyAg ICBkZXNjcmlwdGlvbignQ2hlY2tzIG1vdXNlIGNsaWNrIG9uIHNwaW4gYnV0dG9uIGluIGlmcmFt ZS4nKTsKKyAgICBpZiAoIXdpbmRvdy5ldmVudFNlbmRlcikKKyAgICAgICAgZGVidWcoJ1BsZWFz ZSBydW4gaW4gRHVtcFJlbmRlclRyZWUnKTsKKworICAgIGlmcmFtZSA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoJ2lmcmFtZScpOworICAgIGlmcmFtZS5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywg ZnVuY3Rpb24gKCkgeyBydW5JRnJhbWVMb2FkZWQoY29uZmlnKSB9KTsKKyAgICBpZnJhbWUuc3Jj ZG9jID0gJzxpbnB1dCBpZD10ZXN0IHR5cGU9JyArIGNvbmZpZ1snaW5wdXRUeXBlJ10gKyAnIHZh bHVlPSInICsgY29uZmlnWydpbml0aWFsVmFsdWUnXSArICciPic7CisgICAgZG9jdW1lbnQuYm9k eS5hcHBlbmRDaGlsZChpZnJhbWUpOworfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1zcGluYnV0dG9u LWNsaWNrLWluLWlmcmFtZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Rp bWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLXNwaW5idXR0b24tY2xpY2st aW4taWZyYW1lLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lM2RkYTdlNDRmN2JhZWFhN2YwZmMz NzM4NmJmNjZmZWUxYWFjYTNiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1zcGluYnV0dG9u LWNsaWNrLWluLWlmcmFtZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMCBAQAorQ2hlY2tzIG1v dXNlIGNsaWNrIG9uIHNwaW4gYnV0dG9uIGluIGlmcmFtZS4KKworT24gc3VjY2VzcywgeW91IHdp bGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09N UExFVEUiLgorCisKK1BBU1MgdGVzdElucHV0LnZhbHVlIGlzICIwMTowMCIKK1BBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmll bGRzLXNwaW5idXR0b24tY2xpY2staW4taWZyYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLXNwaW5idXR0b24t Y2xpY2staW4taWZyYW1lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjRkZTE4YWM1MWEyMWRhYWNmMWU3YjJi NGFlZTc5MDVkZWVjZjlmNgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMtc3BpbmJ1dHRvbi1j bGljay1pbi1pZnJhbWUuaHRtbApAQCAtMCwwICsxLDE3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMt dGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9jb21tb24t c3BpbmJ1dHRvbi1jbGljay1pbi1pZnJhbWUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+ Cis8c2NyaXB0PgordGVzdENsaWNrU3BpbkJ1dHRvbkluSUZyYW1lKHsKKyAgICAnZXhwZWN0ZWRW YWx1ZScgOiAnMDE6MDAnLAorICAgICdpbml0aWFsVmFsdWUnIDogJzAwOjAwJywKKyAgICAnaW5w dXRUeXBlJyA6ICd0aW1lJworfSk7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9m YXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgo=