96531 2012-09-12 09:23:23 -0700 [Qt][WK2] REGRESSION(r128245): It made zillion API tests fail 2012-09-13 07:42:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 70236 96449 1 ossy abecsi abecsi aestes andersca hausmann jturcotte noam ossy oldest_to_newest 718445 0 ossy 2012-09-12 09:23:23 -0700 Could you check it, please? ********* Start testing of tst_qrawwebview ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_qrawwebview::initTestCase() FAIL! : tst_qrawwebview::paint() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::paint() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(227)] FAIL! : tst_qrawwebview::noBackground1() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground1() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground2() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground2() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground3() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground3() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground3() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(227)] PASS : tst_qrawwebview::cleanupTestCase() Totals: 2 passed, 9 failed, 0 skipped ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : qmltests::WebViewApplicationSchemes::initTestCase() QWARN : qmltests::WebViewApplicationSchemes::test_applicationScheme() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::WebViewApplicationSchemes::test_applicationScheme() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml(75)] QWARN : qmltests::WebViewApplicationSchemes::test_charsets() WARNING: The web process has been successfully restarted. QWARN : qmltests::WebViewApplicationSchemes::test_charsets() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::WebViewApplicationSchemes::test_charsets() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml(108)] QWARN : qmltests::WebViewApplicationSchemes::test_multipleSchemes() WARNING: The web process has been successfully restarted. QWARN : qmltests::WebViewApplicationSchemes::test_multipleSchemes() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::WebViewApplicationSchemes::test_multipleSchemes() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml(83)] QWARN : qmltests::WebViewApplicationSchemes::test_multipleUrlsForScheme() WARNING: The web process has been successfully restarted. QWARN : qmltests::WebViewApplicationSchemes::test_multipleUrlsForScheme() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::WebViewApplicationSchemes::test_multipleUrlsForScheme() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml(95)] PASS : qmltests::WebViewApplicationSchemes::cleanupTestCase() PASS : qmltests::WebViewColorChooser::initTestCase() QWARN : qmltests::WebViewColorChooser::test_accept() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::WebViewColorChooser::test_accept() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml(47)] QWARN : qmltests::WebViewColorChooser::test_currentValue() WARNING: The web process has been successfully restarted. QWARN : qmltests::WebViewColorChooser::test_currentValue() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::WebViewColorChooser::test_currentValue() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml(47)] QWARN : qmltests::WebViewColorChooser::test_reject() WARNING: The web process has been successfully restarted. QWARN : qmltests::WebViewColorChooser::test_reject() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::WebViewColorChooser::test_reject() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml(47)] PASS : qmltests::WebViewColorChooser::cleanupTestCase() PASS : qmltests::DevicePixelRatio::initTestCase() QWARN : qmltests::DevicePixelRatio::test_devicePixelRatio() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::DevicePixelRatio::test_devicePixelRatio() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(33)] QWARN : qmltests::DevicePixelRatio::test_devicePixelRatioMediaQuery() WARNING: The web process has been successfully restarted. QWARN : qmltests::DevicePixelRatio::test_devicePixelRatioMediaQuery() WARNING: The web process experienced a crash on ''. FAIL! : qmltests::DevicePixelRatio::test_devicePixelRatioMediaQuery() 'verify()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(50)] PASS : qmltests::DevicePixelRatio::cleanupTestCase() 718722 1 andersca 2012-09-12 14:28:04 -0700 It looks like the web process is crashing? Do you have web process crash logs? 719283 2 abecsi 2012-09-13 02:56:42 -0700 (In reply to comment #1) > It looks like the web process is crashing? Do you have web process crash logs? (gdb) r Starting program: /home/abecsi/devel/git/webkit-git-svn/WebKitBuild/Debug/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fff977fc700 (LWP 26276)] 0x00007ffff4793fdf in WebKit::WebChromeClient::contentsSizeChanged (this=0x466720, frame=0x476d30, size=...) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:448 448 m_page->drawingArea()->layerTreeHost()->sizeDidChange(m_page->size()); (gdb) bt #0 0x00007ffff4793fdf in WebKit::WebChromeClient::contentsSizeChanged (this=0x466720, frame=0x476d30, size=...) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:448 #1 0x00007ffff50678d9 in WebCore::Chrome::contentsSizeChanged (this=0x4680e0, frame=0x476d30, size=...) at /home/abecsi/devel/git/webkit-git-svn/Source/WebCore/page/Chrome.cpp:125 #2 0x00007ffff50c6814 in WebCore::FrameView::setContentsSize (this=0x4874c0, size=...) at /home/abecsi/devel/git/webkit-git-svn/Source/WebCore/page/FrameView.cpp:547 #3 0x00007ffff50c69eb in WebCore::FrameView::adjustViewSize (this=0x4874c0) at /home/abecsi/devel/git/webkit-git-svn/Source/WebCore/page/FrameView.cpp:567 #4 0x00007ffff50c88b6 in WebCore::FrameView::layout (this=0x4874c0, allowSubtree=false) at /home/abecsi/devel/git/webkit-git-svn/Source/WebCore/page/FrameView.cpp:1192 #5 0x00007ffff50d1625 in WebCore::FrameView::forceLayout (this=0x4874c0, allowSubtree=false) at /home/abecsi/devel/git/webkit-git-svn/Source/WebCore/page/FrameView.cpp:3371 #6 0x00007ffff47ea4f5 in WebKit::WebPage::setFixedLayoutSize (this=0x467560, size=...) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1124 #7 0x00007ffff47e97f0 in WebKit::WebPage::setResizesToContentsUsingLayoutSize (this=0x467560, targetLayoutSize=...) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:911 #8 0x00007ffff47e9b56 in WebKit::WebPage::sendViewportAttributesChanged (this=0x467560) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:952 #9 0x00007ffff47e9c34 in WebKit::WebPage::setViewportSize (this=0x467560, size=...) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:965 #10 0x00007ffff4871125 in CoreIPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(WebCore::IntSize const&), WebCore::IntSize> (args=..., object=0x467560, function= (void (WebKit::WebPage::*)(WebKit::WebPage * const, const WebCore::IntSize &)) 0x7ffff47e9b9e <WebKit::WebPage::setViewportSize(WebCore::IntSize const&)>) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/Platform/CoreIPC/HandleMessage.h:19 #11 0x00007ffff486e7e9 in CoreIPC::handleMessage<Messages::WebPage::SetViewportSize, WebKit::WebPage, void (WebKit::WebPage::*)(WebCore::IntSize const&)> (argumentDecoder=0x7fff98004a80, object=0x467560, function= (void (WebKit::WebPage::*)(WebKit::WebPage * const, const WebCore::IntSize &)) 0x7ffff47e9b9e <WebKit::WebPage::setViewportSize(WebCore::IntSize const&)>) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/Platform/CoreIPC/HandleMessage.h:302 #12 0x00007ffff486be28 in WebKit::WebPage::didReceiveWebPageMessage (this=0x467560, messageID=..., arguments=0x7fff98004a80) at generated/WebPageMessageReceiver.cpp:280 #13 0x00007ffff47f04a8 in WebKit::WebPage::didReceiveMessage (this=0x467560, connection=0x451cd0, messageID=..., arguments=0x7fff98004a80) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2692 #14 0x00007ffff4803658 in WebKit::WebProcess::didReceiveMessage (this=0x451800, connection=0x451cd0, messageID=..., arguments=0x7fff98004a80) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebProcess.cpp:711 #15 0x00007ffff4800ffe in WebKit::WebConnectionToUIProcess::didReceiveMessage (this=0x451c80, connection=0x451cd0, messageID=..., arguments=0x7fff98004a80) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/WebConnectionToUIProcess.cpp:87 #16 0x00007ffff45a2dae in CoreIPC::Connection::dispatchMessage (this=0x451cd0, message=...) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/Platform/CoreIPC/Connection.cpp:691 #17 0x00007ffff45a2f9f in CoreIPC::Connection::dispatchOneMessage (this=0x451cd0) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/Platform/CoreIPC/Connection.cpp:717 #18 0x00007ffff45acfb3 in WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator() (this=0x7fff98004b10, c=0x451cd0) at /home/abecsi/devel/git/webkit-git-svn/Source/WTF/wtf/Functional.h:174 #19 0x00007ffff45acd6c in WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() (this=0x7fff98004b00) at /home/abecsi/devel/git/webkit-git-svn/Source/WTF/wtf/Functional.h:406 #20 0x00007ffff4632fd6 in WTF::Function<void ()>::operator()() const (this=0x7fffffffd5c0) at /home/abecsi/devel/git/webkit-git-svn/Source/WTF/wtf/Functional.h:614 #21 0x00007ffff51d180e in WebCore::RunLoop::performWork (this=0x44f790) at /home/abecsi/devel/git/webkit-git-svn/Source/WebCore/platform/RunLoop.cpp:102 #22 0x00007ffff54ee0d0 in WebCore::RunLoop::TimerObject::performWork (this=0x44e9d0) at /home/abecsi/devel/git/webkit-git-svn/Source/WebCore/platform/qt/RunLoopQt.cpp:48 #23 0x00007ffff54eeb78 in WebCore::RunLoop::TimerObject::qt_static_metacall (_o=0x44e9d0, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7fff98002fe0) at ./RunLoopQt.moc:69 #24 0x00007ffff33aee9e in QObject::event(QEvent*) () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtCore.so.5 #25 0x00007ffff3be507c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtWidgets.so.5 #26 0x00007ffff3be8280 in QApplication::notify(QObject*, QEvent*) () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtWidgets.so.5 #27 0x00007ffff338992e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtCore.so.5 #28 0x00007ffff338b79e in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtCore.so.5 #29 0x00007ffff33d0eb3 in postEventSourceDispatch(_GSource*, int (*)(void*), void*) () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtCore.so.5 #30 0x00007fffecc4c475 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #31 0x00007fffecc4c7a8 in ?? () from /usr/lib/libglib-2.0.so.0 #32 0x00007fffecc4c864 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #33 0x00007ffff33d105b in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtCore.so.5 #34 0x00007ffff33887eb in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtCore.so.5 #35 0x00007ffff338bf4c in QCoreApplication::exec() () from /home/abecsi/devel/git/qt5_build/qtbase/lib/libQtCore.so.5 #36 0x00007ffff54ee307 in WebCore::RunLoop::run () at /home/abecsi/devel/git/webkit-git-svn/Source/WebCore/platform/qt/RunLoopQt.cpp:69 #37 0x00007ffff4816333 in WebKit::WebProcessMainQt (app=0x40f240) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp:195 #38 0x000000000040100c in main (argc=2, argv=0x7fffffffe328) at /home/abecsi/devel/git/webkit-git-svn/Source/WebKit2/qt/MainQt.cpp:87 For this testcase m_page->drawingArea() is allways null at this point. 719319 3 abecsi 2012-09-13 04:13:07 -0700 The issue seems to be that WebPage::updatePreferences is called in the WebPage constructor (in WebPage.cpp:310) before the drawing area is created (in WebPage.cpp:318), therefore after r128245 settings->setForceCompositingMode is never called since m_drawingArea is not yet initialized when WebPage::updatePreferences would call m_drawingArea->updatePreferences(store). 719340 4 163840 abecsi 2012-09-13 04:47:34 -0700 Created attachment 163840 Patch 719401 5 163840 jturcotte 2012-09-13 06:29:23 -0700 Comment on attachment 163840 Patch Looking at platform implementations this doesn't seem to be an issue yet, but I'm wondering if we shouldn't make sure that platformInitialize() keeps being run after updatePreferences. Tell me what you think, this can be moved once it's needed too. 719439 6 abecsi 2012-09-13 07:22:35 -0700 (In reply to comment #5) > (From update of attachment 163840 [details]) > Looking at platform implementations this doesn't seem to be an issue yet, but I'm wondering if we shouldn't make sure that platformInitialize() keeps being run after updatePreferences. Indeed, it could be safer for future implementations of platformInitialize() that might want to set custom settings. 719443 7 163866 abecsi 2012-09-13 07:30:15 -0700 Created attachment 163866 Patch 719462 8 163866 abecsi 2012-09-13 07:42:13 -0700 Comment on attachment 163866 Patch Clearing flags on attachment: 163866 Committed r128457: <http://trac.webkit.org/changeset/128457> 719463 9 abecsi 2012-09-13 07:42:18 -0700 All reviewed patches have been landed. Closing bug. 163840 2012-09-13 04:47:34 -0700 2012-09-13 07:30:10 -0700 Patch bug-96531-20120913134711.patch text/plain 1849 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzMyMTQ1YzViNmFjNzMz MmRjNGIzM2MxZGM2YmYxOTI1YjljMTUzNS4uNmYxYzUxNDA3MjkwMDdjY2Y2ZjM5Zjg4ODIxNmQ1 OTQ4MmY2Y2RjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTEzICBBbmRy YXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAbm9raWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBS RUdSRVNTSU9OKHIxMjgyNDUpOiBJdCBtYWRlIHppbGxpb24gQVBJIHRlc3RzIGZhaWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTMxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJlZmVyZW5jZXMgaGF2 ZSB0byBiZSB1cGRhdGVkIGFmdGVyIHRoZSBkcmF3aW5nIGFyZWEgd2FzIGNyZWF0ZWQKKyAgICAg ICAgZm9yIGNvbXBvc2l0aW5nIG1vZGUgdG8gYmUgc2V0LgorCisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpXZWJQYWdl KToKKwogMjAxMi0wOS0xMyAgT3N3YWxkIEJ1ZGRlbmhhZ2VuICA8b3N3YWxkLmJ1ZGRlbmhhZ2Vu QG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBidWlsZCBhZ2FpbnN0IG5hbWVzcGFjZWQg UXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRl eCBmMjEyNTI4MjY2MTgyOWI3YjkwMGQzMmU3N2MyYTc4MmYwN2I4ZDU2Li5hMTFiMDEyZGNkN2Fm NWM5MDc5MjU4YTM3NTdmMzc5ZThjM2UzNTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0zMDcsOCArMzA3LDYgQEAgV2ViUGFnZTo6V2Vi UGFnZSh1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMmIHBh cmFtZXRlcnMpCiAKICAgICBtX3BhZ2UtPnNldENhblN0YXJ0TWVkaWEoZmFsc2UpOwogCi0gICAg dXBkYXRlUHJlZmVyZW5jZXMocGFyYW1ldGVycy5zdG9yZSk7Ci0KICAgICBtX3BhZ2VHcm91cCA9 IFdlYlByb2Nlc3M6OnNoYXJlZCgpLndlYlBhZ2VHcm91cChwYXJhbWV0ZXJzLnBhZ2VHcm91cERh dGEpOwogICAgIG1fcGFnZS0+c2V0R3JvdXBOYW1lKG1fcGFnZUdyb3VwLT5pZGVudGlmaWVyKCkp OwogICAgIG1fcGFnZS0+c2V0RGV2aWNlU2NhbGVGYWN0b3IocGFyYW1ldGVycy5kZXZpY2VTY2Fs ZUZhY3Rvcik7CkBAIC0zMTgsNiArMzE2LDggQEAgV2ViUGFnZTo6V2ViUGFnZSh1aW50NjRfdCBw YWdlSUQsIGNvbnN0IFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRlcnMpCiAgICAg bV9kcmF3aW5nQXJlYSA9IERyYXdpbmdBcmVhOjpjcmVhdGUodGhpcywgcGFyYW1ldGVycyk7CiAg ICAgbV9kcmF3aW5nQXJlYS0+c2V0UGFpbnRpbmdFbmFibGVkKGZhbHNlKTsKIAorICAgIHVwZGF0 ZVByZWZlcmVuY2VzKHBhcmFtZXRlcnMuc3RvcmUpOworCiAgICAgbV9tYWluRnJhbWUgPSBXZWJG cmFtZTo6Y3JlYXRlTWFpbkZyYW1lKHRoaXMpOwogCiAgICAgc2V0VXNlRml4ZWRMYXlvdXQocGFy YW1ldGVycy51c2VGaXhlZExheW91dCk7Cg== 163866 2012-09-13 07:30:15 -0700 2012-09-13 07:42:13 -0700 Patch bug-96531-20120913162953.patch text/plain 1809 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGFjZTcyNjJiNmY0M2U4 MWIxZDYxYjI0Y2JlNDFlNGEwM2MxMWJhOC4uNGY2YTdkN2IzNWMyZTc3YzI5ZjUwYzcwNDJkOWY2 ODcyN2NiNjc1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTEzICBBbmRy YXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAbm9raWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBS RUdSRVNTSU9OKHIxMjgyNDUpOiBJdCBtYWRlIHppbGxpb24gQVBJIHRlc3RzIGZhaWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTMxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJlZmVyZW5jZXMgaGF2 ZSB0byBiZSB1cGRhdGVkIGFmdGVyIHRoZSBkcmF3aW5nIGFyZWEgd2FzIGNyZWF0ZWQKKyAgICAg ICAgZm9yIGNvbXBvc2l0aW5nIG1vZGUgdG8gYmUgc2V0LgorCisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpXZWJQYWdl KToKKwogMjAxMi0wOS0xMyAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5j b20+CiAKICAgICAgICAgW1F0XSBGaXggVUlQcm9jZXNzIGJ1aWxkIHdpdGggUXQgb24gV2luZG93 cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4 IGYyMTI1MjgyNjYxODI5YjdiOTAwZDMyZTc3YzJhNzgyZjA3YjhkNTYuLjkxNTE0MGY4ZDAyNTdl MWQ3ODYxOTRmODdhNWNhY2I1Y2ZkMmE4OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTMwNywxNyArMzA3LDE2IEBAIFdlYlBhZ2U6Oldl YlBhZ2UodWludDY0X3QgcGFnZUlELCBjb25zdCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzJiBw YXJhbWV0ZXJzKQogCiAgICAgbV9wYWdlLT5zZXRDYW5TdGFydE1lZGlhKGZhbHNlKTsKIAotICAg IHVwZGF0ZVByZWZlcmVuY2VzKHBhcmFtZXRlcnMuc3RvcmUpOwotCiAgICAgbV9wYWdlR3JvdXAg PSBXZWJQcm9jZXNzOjpzaGFyZWQoKS53ZWJQYWdlR3JvdXAocGFyYW1ldGVycy5wYWdlR3JvdXBE YXRhKTsKICAgICBtX3BhZ2UtPnNldEdyb3VwTmFtZShtX3BhZ2VHcm91cC0+aWRlbnRpZmllcigp KTsKICAgICBtX3BhZ2UtPnNldERldmljZVNjYWxlRmFjdG9yKHBhcmFtZXRlcnMuZGV2aWNlU2Nh bGVGYWN0b3IpOwogCi0gICAgcGxhdGZvcm1Jbml0aWFsaXplKCk7Ci0KICAgICBtX2RyYXdpbmdB cmVhID0gRHJhd2luZ0FyZWE6OmNyZWF0ZSh0aGlzLCBwYXJhbWV0ZXJzKTsKICAgICBtX2RyYXdp bmdBcmVhLT5zZXRQYWludGluZ0VuYWJsZWQoZmFsc2UpOwogCisgICAgdXBkYXRlUHJlZmVyZW5j ZXMocGFyYW1ldGVycy5zdG9yZSk7CisgICAgcGxhdGZvcm1Jbml0aWFsaXplKCk7CisKICAgICBt X21haW5GcmFtZSA9IFdlYkZyYW1lOjpjcmVhdGVNYWluRnJhbWUodGhpcyk7CiAKICAgICBzZXRV c2VGaXhlZExheW91dChwYXJhbWV0ZXJzLnVzZUZpeGVkTGF5b3V0KTsK