96408 2012-09-11 10:37:40 -0700 [Skia] Support missing styles on text line rendering 2013-04-09 09:37:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX http://dev.w3.org/csswg/css-text-decor-3/#text-decoration-style-property P2 Normal --- 94094 100546 58491 93509 104682 1 bruno.abinader bruno.abinader darin igor.oliveira jamesr lamarque peter reed senorblanco tomhudson webkit.review.bot oldest_to_newest 717352 0 bruno.abinader 2012-09-11 10:37:40 -0700 The CSS3 property "text-decoration-style" accepts the following values: "solid | double | dotted | dashed | wavy" as seen on the link below: http://dev.w3.org/csswg/css3-text/#text-decoration-style All values except "wavy" were already implemented on Skia due to previous usage on "border-style" property: http://www.w3.org/TR/css3-background/#the-border-style This bug intends to provide Skia platform support for "dashed" and "dotted" values on GraphicsContext::drawLineForText. This bug is a subtask from bug 93509. 717383 1 163403 bruno.abinader 2012-09-11 10:56:45 -0700 Created attachment 163403 Patch Proposed patch. 753507 2 bruno.abinader 2012-10-29 09:28:57 -0700 Peter, can you please take a look at it? :) 753512 3 peter 2012-10-29 09:32:21 -0700 +Mike, Tom I wouldn't know about the Skia code, adding Mike and Tom, hoping that either of them can take a look. Thanks for the patch! 755439 4 tomhudson 2012-10-31 10:31:56 -0700 This is actually in the WebKit-to-Skia glue layer, not inside Skia proper. senorblanco@ or junov@ might be (or know) a better subject-matter expert. I'm surprised that the roundf() in drawLineForText() doesn't break anything? Otherwise after reading over some of the related code this looks reasonable to me. 764418 5 bruno.abinader 2012-11-12 07:43:27 -0800 Hi Tom, You are right, I was trying to avoid using static_cast<int>, however the roundf()/lroundf() trick ~might~ not work on all compilers, as it relies on C99 standard. I'm going to revert this change on an updated patch. (In reply to comment #4) > This is actually in the WebKit-to-Skia glue layer, not inside Skia proper. senorblanco@ or junov@ might be (or know) a better subject-matter expert. > > I'm surprised that the roundf() in drawLineForText() doesn't break anything? > > Otherwise after reading over some of the related code this looks reasonable to me. 764425 6 bruno.abinader 2012-11-12 07:55:58 -0800 Double checking the code, I've reminded myself that roundf() is actually already used to convert strokeThickness() to int (check http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp#L559 for details). I'm sorry I forgot to mention that previosuly. Said this, shall this gets a r+, then? :) 785561 7 bruno.abinader 2012-12-06 19:52:49 -0800 Ping? 788421 8 178798 bruno.abinader 2012-12-11 07:12:44 -0800 Created attachment 178798 Patch Updated version based on Tom's comments. Added 'double' and 'wavy' values under CSS3_TEXT feature flag. 871915 9 178798 darin 2013-04-09 09:37:31 -0700 Comment on attachment 178798 Patch Clearing flags on a Skia-specific patch. 871916 10 darin 2013-04-09 09:37:46 -0700 Skia-specific. 163403 2012-09-11 10:56:45 -0700 2012-12-11 07:12:37 -0800 Patch bug-96408-20120911135619.patch text/plain 3047 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTc1NGZlZGNjNTlkOGIz OGE5MDExYTdlZGVlYjE0MTI4Nzg0NTU4Ni4uNTUzYjJiNWE0MDA3Njc0ZTdhOGZlMmVlMWM0ZWEy NDk4MzFiYjI3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA5LTExICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbU2tpYV0gU3VwcG9ydCAiZGFzaGVkIiBhbmQgImRvdHRlZCIgc3R5bGVzIG9uIHRl eHQgbGluZSByZW5kZXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk2NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIENTUzMgcHJvcGVydHkgInRleHQtZGVjb3JhdGlvbi1zdHlsZSIgYWNjZXB0 cyB0aGUgZm9sbG93aW5nIHZhbHVlczogInNvbGlkIHwKKyAgICAgICAgZG91YmxlIHwgZG90dGVk IHwgZGFzaGVkIHwgd2F2eSIgYXMgc2VlbiBvbiB0aGUgbGluayBiZWxvdzoKKyAgICAgICAgaHR0 cDovL2Rldi53My5vcmcvY3Nzd2cvY3NzMy10ZXh0LyN0ZXh0LWRlY29yYXRpb24tc3R5bGUKKwor ICAgICAgICBBbGwgdmFsdWVzIGV4Y2VwdCAid2F2eSIgd2VyZSBhbHJlYWR5IGltcGxlbWVudGVk IG9uIFNraWEgZHVlIHRvIHByZXZpb3VzIHVzYWdlCisgICAgICAgIG9uICJib3JkZXItc3R5bGUi IHByb3BlcnR5OgorICAgICAgICBodHRwOi8vd3d3LnczLm9yZy9UUi9jc3MzLWJhY2tncm91bmQv I3RoZS1ib3JkZXItc3R5bGUKKworICAgICAgICBUaGlzIGJ1ZyBpbnRlbmRzIHRvIHByb3ZpZGUg U2tpYSBwbGF0Zm9ybSBzdXBwb3J0IGZvciAiZGFzaGVkIiBhbmQgImRvdHRlZCIKKyAgICAgICAg dmFsdWVzIG9uIEdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JUZXh0LiBUaGlzIGJ1ZyBpcyBh IHN1YnRhc2sgZnJvbSBidWcKKyAgICAgICAgOTM1MDkuCisKKyAgICAgICAgTm8gdGVzdHMgcHJv dmlkZWQsIGFzIHByb3BlciB0ZXN0IG9mIHRoaXMgY2hhbmdlIGlzIG1hZGUgYnkgYnVnIDk0MDk0 IChyZW5kZXJpbmcKKyAgICAgICAgc3VwcG9ydCBmb3IgIi13ZWJraXQtdGV4dC1kZWNvcmF0aW9u LXN0eWxlIiBwcm9wZXJ0eSkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dy YXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0 OjpkcmF3TGluZUZvclRleHQpOgorCiAyMDEyLTA5LTExICBTZXJnaW8gVmlsbGFyIFNlbmluICA8 c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYktpdEd0aysgY3Jhc2hlcyB3 aXRoIG5vbi1VVEY4IEhUVFAgaGVhZGVyIG5hbWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcApp bmRleCAzNTIzMWE5ZGFjMjA3MDkwOWQxODU4OTk3YjBlNmY1NzdlYjAxYmUyLi5jOWM5OWFkZGEz NDE4MjE4ZDc3NmVmNmY4MzgwZTk2OTkzN2VkMjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5j cHAKQEAgLTY0Niw3ICs2NDYsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JU ZXh0KGNvbnN0IEZsb2F0UG9pbnQmIHB0LAogICAgIGlmICh3aWR0aCA8PSAwKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBpbnQgdGhpY2tuZXNzID0gU2tNYXgzMihzdGF0aWNfY2FzdDxpbnQ+KHN0 cm9rZVRoaWNrbmVzcygpKSwgMSk7CisgICAgaW50IHRoaWNrbmVzcyA9IFNrTWF4MzIocm91bmRm KHN0cm9rZVRoaWNrbmVzcygpKSwgMSk7CiAgICAgU2tSZWN0IHI7CiAgICAgci5mTGVmdCA9IFdl YkNvcmVGbG9hdFRvU2tTY2FsYXIocHQueCgpKTsKICAgICAvLyBBdm9pZCBhbnRpLWFsaWFzaW5n IGxpbmVzLiBDdXJyZW50bHksIHRoZXNlIGFyZSBhbHdheXMgaG9yaXpvbnRhbC4KQEAgLTY1NSw3 ICs2NTUsMTcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdMaW5lRm9yVGV4dChjb25zdCBG bG9hdFBvaW50JiBwdCwKICAgICByLmZCb3R0b20gPSByLmZUb3AgKyBTa0ludFRvU2NhbGFyKHRo aWNrbmVzcyk7CiAKICAgICBTa1BhaW50IHBhaW50OwotICAgIHBsYXRmb3JtQ29udGV4dCgpLT5z ZXR1cFBhaW50Rm9yRmlsbGluZygmcGFpbnQpOworICAgIC8vIEZJWE1FOiBEbyBub3Qgc2V0dXAg cGFpbnQgZm9yIHN0cm9raW5nIGZvciAnc29saWQnIG9yICdkb3VibGUnIG90aGVyd2lzZSBsaW5l cyBnZXQgdW5leHBlY3RlZCB0aGlja25lc3MuCisgICAgc3dpdGNoIChzdHJva2VTdHlsZSgpKSB7 CisgICAgY2FzZSBOb1N0cm9rZToKKyAgICBjYXNlIFNvbGlkU3Ryb2tlOgorICAgICAgICBwbGF0 Zm9ybUNvbnRleHQoKS0+c2V0dXBQYWludEZvckZpbGxpbmcoJnBhaW50KTsKKyAgICAgICAgYnJl YWs7CisgICAgY2FzZSBEYXNoZWRTdHJva2U6CisgICAgY2FzZSBEb3R0ZWRTdHJva2U6CisgICAg ICAgIHBsYXRmb3JtQ29udGV4dCgpLT5zZXR1cFBhaW50Rm9yU3Ryb2tpbmcoJnBhaW50LCAwLCAw KTsKKyAgICAgICAgYnJlYWs7CisgICAgfQogICAgIC8vIFRleHQgbGluZXMgYXJlIGRyYXduIHVz aW5nIHRoZSBzdHJva2UgY29sb3IuCiAgICAgcGFpbnQuc2V0Q29sb3IocGxhdGZvcm1Db250ZXh0 KCktPmVmZmVjdGl2ZVN0cm9rZUNvbG9yKCkpOwogICAgIHBsYXRmb3JtQ29udGV4dCgpLT5jYW52 YXMoKS0+ZHJhd1JlY3QociwgcGFpbnQpOwo= 178798 2012-12-11 07:12:44 -0800 2013-04-09 09:37:31 -0700 Patch bug-96408-20121211111004.patch text/plain 2785 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQ2YTQ2MTk5NjhkODI0 YWNjM2I0MzM5YjY4YTEzN2Y4N2I2YzU5NS4uMjVkNGRlYTIzNzE2YjU2ODNjZDE4YzAzMWQxY2Qy Njc2OGY1NGFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA5LTExICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbU2tpYV0gU3VwcG9ydCAiZGFzaGVkIiBhbmQgImRvdHRlZCIgc3R5bGVzIG9uIHRl eHQgbGluZSByZW5kZXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk2NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIENTUzMgcHJvcGVydHkgInRleHQtZGVjb3JhdGlvbi1zdHlsZSIgYWNjZXB0 cyB0aGUgZm9sbG93aW5nIHZhbHVlczogInNvbGlkIHwKKyAgICAgICAgZG91YmxlIHwgZG90dGVk IHwgZGFzaGVkIHwgd2F2eSIgYXMgc2VlbiBvbiB0aGUgbGluayBiZWxvdzoKKyAgICAgICAgaHR0 cDovL2Rldi53My5vcmcvY3Nzd2cvY3NzMy10ZXh0LyN0ZXh0LWRlY29yYXRpb24tc3R5bGUKKwor ICAgICAgICBBbGwgdmFsdWVzIGV4Y2VwdCAid2F2eSIgd2VyZSBhbHJlYWR5IGltcGxlbWVudGVk IG9uIFNraWEgZHVlIHRvIHByZXZpb3VzIHVzYWdlCisgICAgICAgIG9uICJib3JkZXItc3R5bGUi IHByb3BlcnR5OgorICAgICAgICBodHRwOi8vd3d3LnczLm9yZy9UUi9jc3MzLWJhY2tncm91bmQv I3RoZS1ib3JkZXItc3R5bGUKKworICAgICAgICBUaGlzIGJ1ZyBpbnRlbmRzIHRvIHByb3ZpZGUg U2tpYSBwbGF0Zm9ybSBzdXBwb3J0IGZvciAiZGFzaGVkIiBhbmQgImRvdHRlZCIKKyAgICAgICAg dmFsdWVzIG9uIEdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JUZXh0LiBUaGlzIGJ1ZyBpcyBh IHN1YnRhc2sgZnJvbSBidWcKKyAgICAgICAgOTM1MDkuCisKKyAgICAgICAgTm8gdGVzdHMgcHJv dmlkZWQsIGFzIHByb3BlciB0ZXN0IG9mIHRoaXMgY2hhbmdlIGlzIG1hZGUgYnkgYnVnIDk0MDk0 IChyZW5kZXJpbmcKKyAgICAgICAgc3VwcG9ydCBmb3IgIi13ZWJraXQtdGV4dC1kZWNvcmF0aW9u LXN0eWxlIiBwcm9wZXJ0eSkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dy YXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0 OjpkcmF3TGluZUZvclRleHQpOgorCiAyMDEyLTEyLTExICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNo aUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVzZSBoaXN0b2dyYW0gZW51bWVyYXRpb24gaW4gQ2Fs ZW5kYXIgUGlja2VyIHNvIHdlIGNhbiBnZXQgc3RhdHMgb24gVUkgdXNhZ2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tp YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29u dGV4dFNraWEuY3BwCmluZGV4IDQ4ZmI3NjllN2IyZjE0M2RkMmUwMGViNzRhN2VlYzRkMDViMTg3 MjAuLmU0N2NkNTBhZjEwYzJlYTcyM2E0MTc3ZjIyYzljZDE4ZjNiY2M0MjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tp YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGlj c0NvbnRleHRTa2lhLmNwcApAQCAtNzM3LDcgKzczNywyMyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDo6ZHJhd0xpbmVGb3JUZXh0KGNvbnN0IEZsb2F0UG9pbnQmIHB0LAogICAgIHIuZkJvdHRvbSA9 IHIuZlRvcCArIFNrSW50VG9TY2FsYXIodGhpY2tuZXNzKTsKIAogICAgIFNrUGFpbnQgcGFpbnQ7 Ci0gICAgcGxhdGZvcm1Db250ZXh0KCktPnNldHVwUGFpbnRGb3JGaWxsaW5nKCZwYWludCk7Cisg ICAgLy8gRklYTUU6IERvIG5vdCBzZXR1cCBwYWludCBmb3Igc3Ryb2tpbmcgZm9yICdzb2xpZCcg b3IgJ2RvdWJsZScgb3RoZXJ3aXNlIGxpbmVzIGdldCB1bmV4cGVjdGVkIHRoaWNrbmVzcy4KKyAg ICBzd2l0Y2ggKHN0cm9rZVN0eWxlKCkpIHsKKyAgICBjYXNlIE5vU3Ryb2tlOgorICAgIGNhc2Ug U29saWRTdHJva2U6CisjaWYgRU5BQkxFKENTUzNfVEVYVCkKKyAgICBjYXNlIERvdWJsZVN0cm9r ZToKKyNlbmRpZiAvLyBDU1MzX1RFWFQKKyAgICAgICAgcGxhdGZvcm1Db250ZXh0KCktPnNldHVw UGFpbnRGb3JGaWxsaW5nKCZwYWludCk7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgRGFzaGVk U3Ryb2tlOgorICAgIGNhc2UgRG90dGVkU3Ryb2tlOgorI2lmIEVOQUJMRShDU1MzX1RFWFQpCisg ICAgY2FzZSBXYXZ5U3Ryb2tlOgorI2VuZGlmCisgICAgICAgIHBsYXRmb3JtQ29udGV4dCgpLT5z ZXR1cFBhaW50Rm9yU3Ryb2tpbmcoJnBhaW50LCAwLCAwKTsKKyAgICAgICAgYnJlYWs7CisgICAg fQogICAgIC8vIFRleHQgbGluZXMgYXJlIGRyYXduIHVzaW5nIHRoZSBzdHJva2UgY29sb3IuCiAg ICAgcGFpbnQuc2V0Q29sb3IocGxhdGZvcm1Db250ZXh0KCktPmVmZmVjdGl2ZVN0cm9rZUNvbG9y KCkpOwogICAgIHBsYXRmb3JtQ29udGV4dCgpLT5kcmF3UmVjdChyLCBwYWludCk7Cg==