96315 2012-09-10 13:52:58 -0700 Reduce the number of treeScope queries when matching rules. 2012-09-10 17:01:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95664 1 dglazkov dglazkov cmarcelo eric kling koivisto macpherson menard morrita webkit.review.bot oldest_to_newest 716474 0 dglazkov 2012-09-10 13:52:58 -0700 Reduce the number of treeScope queries when matching rules. 716485 1 163202 dglazkov 2012-09-10 13:57:03 -0700 Created attachment 163202 Patch 716514 2 163202 eric 2012-09-10 14:27:29 -0700 Comment on attachment 163202 Patch I assume this is a perf change. :) Do we have any benchmarks which notice this? It looks fine though. 716516 3 dglazkov 2012-09-10 14:30:11 -0700 I am still trying to get the benchmark set up running on my machine, but I'll be watching the perf results when this lands. Do you think it's worth promoting treeScope to a member of StyleResolver that's initialized once for styleForElement? 716521 4 eric 2012-09-10 14:34:03 -0700 The treeScope is part of the per-element state, which eventually needs to be ripped out of StyleResolver into a separate object. :) But yes, it could be a member on that state, or on StyleResolver directly until then if you have benchmarks to show that it's important. 716522 5 dglazkov 2012-09-10 14:35:11 -0700 (In reply to comment #4) > The treeScope is part of the per-element state, which eventually needs to be ripped out of StyleResolver into a separate object. :) Did you not have a bug on this somewhere? 716548 6 eric 2012-09-10 14:47:48 -0700 https://bugs.webkit.org/show_bug.cgi?id=89879 is a meta bug I created. I didn't create on specifically about splitting out the per-element state. 716661 7 163202 webkit.review.bot 2012-09-10 16:26:13 -0700 Comment on attachment 163202 Patch Clearing flags on attachment: 163202 Committed r128128: <http://trac.webkit.org/changeset/128128> 716662 8 webkit.review.bot 2012-09-10 16:26:16 -0700 All reviewed patches have been landed. Closing bug. 163202 2012-09-10 13:57:03 -0700 2012-09-10 16:26:13 -0700 Patch bug-96315-20120910135639.patch text/plain 2255 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmE1OTA5MGUyYWViNThj OWE2Mjc1OThmNjc2OWQzYmYyNWU4ZmNmYy4uMjAzMzVlYjc0MDExZDdkMmFkOWFjM2ZkZmQ4NmRk YTk4NDYxMzRmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTEwICBEaW1p dHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVkdWNlIHRo ZSBudW1iZXIgb2YgdHJlZVNjb3BlIHF1ZXJpZXMgd2hlbiBtYXRjaGluZyBydWxlcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MzE1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIHdvcnN0IGNh c2UsIHRyZWVTY29wZSgpIHJlcXVpcmVzIGEgSGFzaE1hcCBsb29rdXAsIHdoaWNoIGNvdWxkIGJl IHNsb3cuIFNpbmNlIHRoZSB2YWx1ZSBpcyBhbHdheXMgdGhlIHNhbWUgZm9yIHRoZSBlbGVtZW50 LAorICAgICAgICB3ZSBjYW4ganVzdCBhc2sgZm9yIGl0IG9uY2UuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNv bHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpjb2xsZWN0TWF0Y2hp bmdSdWxlc0Zvckxpc3QpOiBNb3ZlZCB0aGUgY2FsbCB0byB0cmVlU2NvcGUgb3V0IG9mIHRoZSBs b29wLgorCiAyMDEyLTA5LTA2ICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIGEgY3VzdG9taXplZCBjb3B5KCkgbWV0aG9kIHRvIEND UmVuZGVyUGFzc0RyYXdRdWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVS ZXNvbHZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXgg NGUzMDY1YWJmNmNhMjk1MTBmOTA2OGFmOTA2NTAxZmEyMmVmMmEwMy4uOWY5ZjlmODY5NzI1MjQy MzljNDMxMGZkODVhNzcyNDY3NTQyNWI1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVy LmNwcApAQCAtMTA3MSw2ICsxMDcxLDkgQEAgdm9pZCBTdHlsZVJlc29sdmVyOjpjb2xsZWN0TWF0 Y2hpbmdSdWxlc0Zvckxpc3QoY29uc3QgVmVjdG9yPFJ1bGVEYXRhPiogcnVsZXMsIGkKIHsKICAg ICBpZiAoIXJ1bGVzKQogICAgICAgICByZXR1cm47CisKKyAgICBUcmVlU2NvcGUqIHRyZWVTY29w ZSA9IG1fZWxlbWVudC0+dHJlZVNjb3BlKCk7CisKICAgICAvLyBJbiBzb21lIGNhc2VzIHdlIG1h eSBlbmQgdXAgbG9va2luZyB1cCBzdHlsZSBmb3IgcmFuZG9tIGVsZW1lbnRzIGluIHRoZSBtaWRk bGUgb2YgYSByZWN1cnNpdmUgdHJlZSByZXNvbHZlLgogICAgIC8vIEFuY2VzdG9yIGlkZW50aWZp ZXIgZmlsdGVyIHdvbid0IGJlIHVwLXRvLWRhdGUgaW4gdGhhdCBjYXNlIGFuZCB3ZSBjYW4ndCB1 c2UgdGhlIGZhc3QgcGF0aC4KICAgICBib29sIGNhblVzZUZhc3RSZWplY3QgPSBtX2NoZWNrZXIu cGFyZW50U3RhY2tJc0NvbnNpc3RlbnQobV9wYXJlbnROb2RlKTsKQEAgLTEwOTMsNyArMTA5Niw2 IEBAIHZvaWQgU3R5bGVSZXNvbHZlcjo6Y29sbGVjdE1hdGNoaW5nUnVsZXNGb3JMaXN0KGNvbnN0 IFZlY3RvcjxSdWxlRGF0YT4qIHJ1bGVzLCBpCiAgICAgICAgICAgICAvLyBiKSB0aGUgdHJlZSBz Y29wZSBhbGxvd3MgYXV0aG9yIHJ1bGVzCiAgICAgICAgICAgICAvLyBjKSB0aGUgcnVsZXMgY29t ZXMgZnJvbSBhIHNjb3BlZCBzdHlsZSBzaGVldCB3aXRoaW4gdGhlIHNhbWUgdHJlZSBzY29wZQog ICAgICAgICAgICAgLy8gZCkgdGhlIHJ1bGUgY29udGFpbnMgc2hhZG93LUlEIHBzZXVkbyBlbGVt ZW50cwotICAgICAgICAgICAgVHJlZVNjb3BlKiB0cmVlU2NvcGUgPSBtX2VsZW1lbnQtPnRyZWVT Y29wZSgpOwogICAgICAgICAgICAgaWYgKCFNYXRjaGluZ1VBUnVsZXNTY29wZTo6aXNNYXRjaGlu Z1VBUnVsZXMoKQogICAgICAgICAgICAgICAgICYmICF0cmVlU2NvcGUtPmFwcGx5QXV0aG9yU3R5 bGVzKCkKICNpZiBFTkFCTEUoU1RZTEVfU0NPUEVEKQo=