96300 2012-09-10 12:24:02 -0700 [CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined 2012-09-19 11:50:50 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66643 0 rhudea webkit-unassigned abarth cmarcelo donggwan.kim macpherson menard mihnea ojan webkit.review.bot oldest_to_newest 716359 0 rhudea 2012-09-10 12:24:02 -0700 At least one in Element.idl, regionOverset is visible. 723377 1 164688 rhudea 2012-09-19 01:19:45 -0700 Created attachment 164688 Expose webkitRegionOverset only if CSS_REGIONS is enabled 723455 2 164713 rhudea 2012-09-19 04:44:02 -0700 Created attachment 164713 Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) 723572 3 164713 yurys 2012-09-19 08:02:56 -0700 Comment on attachment 164713 Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > Source/WebCore/css/StyleRule.cpp:87 > + ASSERT_NOT_REACHED(); Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable? 723573 4 rhudea 2012-09-19 08:08:42 -0700 (In reply to comment #3) > (From update of attachment 164713 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > > > Source/WebCore/css/StyleRule.cpp:87 > > + ASSERT_NOT_REACHED(); > > Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable? in that StyleRule.cpp, all 4 types (Unknown, Charset, Keyframe and Regions(when ) are unreachable in all other functions: createCSSOMWrapper(), destroy() and copy(). So, they should also trigger an assert in reportMemoryUsage. They are marked as "Not used" in StyleRule.h 723583 5 164713 webkit.review.bot 2012-09-19 08:30:21 -0700 Comment on attachment 164713 Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) Clearing flags on attachment: 164713 Committed r129009: <http://trac.webkit.org/changeset/129009> 723584 6 webkit.review.bot 2012-09-19 08:30:24 -0700 All reviewed patches have been landed. Closing bug. 723699 7 164713 abarth 2012-09-19 11:50:50 -0700 Comment on attachment 164713 Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > Source/WebCore/dom/Element.idl:146 > - readonly attribute DOMString webkitRegionOverset; > + readonly attribute [Conditional=CSS_REGIONS] DOMString webkitRegionOverset; Thanks! 164688 2012-09-19 01:19:45 -0700 2012-09-19 04:44:02 -0700 Expose webkitRegionOverset only if CSS_REGIONS is enabled patch text/plain 3327 rhudea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3YjBiNzVmLi4yNzUyMTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDktMTkgIFJhdWwgSHVkZWEgIDxyaHVkZWFAYWRvYmUuY29tPgorCisgICAgICAg IFtDU1NSZWdpb25zXVtDU1NPTV0gTWFrZSBzdXJlIGFsbCBSZWdpb25zIEFQSXMgYXJlIG5vdCB2 aXNpYmxlIGlmIENTU19SRUdJT05TIGlzIG5vdCBkZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjMwMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbCBDU1MgUmVnaW9ucyBBUElzIHNob3VsZCBi ZSBleHBvc2VkIG9ubHkgaWYgQ1NTX1JFR0lPTlMgaXMgZW5hYmxlZAorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBiZWNhdXNlIG9mIG5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBjc3Mv U3R5bGVSdWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUnVsZUJhc2U6OnJlcG9ydE1l bW9yeVVzYWdlKTogRml4IGNvbXBpbGUgd2l0aG91dCBDU1NfUkVHSU9OUyBlbmFibGVkCisgICAg ICAgICogZG9tL0VsZW1lbnQuY3BwOiBDb21waWxlIHdlYmtpdFJlZ2lvbk92ZXJzZXQgb25seSBp ZiBDU1NfUkVHSU9OUyBpcyBlbmFibGVkCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBk b20vRWxlbWVudC5oOgorICAgICAgICAqIGRvbS9FbGVtZW50LmlkbDogRXhwb3NlIHdlYmtpdFJl Z2lvbk92ZXJzZXQgb25seSBpZiBDU1NfUkVHSU9OUyBpcyBlbmFibGVkCisKIDIwMTItMDktMTgg IFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAgIEZp eCBjb21waWxhdGlvbiB3aXRoIFF0IDUgb24gTWVlR28gMS4yIEhhcm1hdHRhbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUnVsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv U3R5bGVSdWxlLmNwcAppbmRleCA1OWVkOWU1Li5mYmI2Zjg0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVSdWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVS dWxlLmNwcApAQCAtODEsNiArODEsOSBAQCB2b2lkIFN0eWxlUnVsZUJhc2U6OnJlcG9ydE1lbW9y eVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0CiAgICAgY2Fz ZSBVbmtub3duOgogICAgIGNhc2UgQ2hhcnNldDoKICAgICBjYXNlIEtleWZyYW1lOgorI2lmICFF TkFCTEUoQ1NTX1JFR0lPTlMpCisgICAgY2FzZSBSZWdpb246CisjZW5kaWYKICAgICAgICAgTWVt b3J5Q2xhc3NJbmZvIGluZm8obWVtb3J5T2JqZWN0SW5mbywgdGhpcywgV2ViQ29yZU1lbW9yeVR5 cGVzOjpDU1MpOwogICAgICAgICByZXR1cm47CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmlu ZGV4IDBkNDQ4ZTEuLjNhN2M1NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTIwMzMsNiAr MjAzMyw4IEBAIFJlbmRlclJlZ2lvbiogRWxlbWVudDo6cmVuZGVyUmVnaW9uKCkgY29uc3QKICAg ICByZXR1cm4gMDsKIH0KIAorI2lmIEVOQUJMRShDU1NfUkVHSU9OUykKKwogY29uc3QgQXRvbWlj U3RyaW5nJiBFbGVtZW50Ojp3ZWJraXRSZWdpb25PdmVyc2V0KCkgY29uc3QKIHsKICAgICBkb2N1 bWVudCgpLT51cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKQEAgLTIwNjIs OCArMjA2NCw2IEBAIGNvbnN0IEF0b21pY1N0cmluZyYgRWxlbWVudDo6d2Via2l0UmVnaW9uT3Zl cnNldCgpIGNvbnN0CiAgICAgcmV0dXJuIHVuZGVmaW5lZFN0YXRlOwogfQogCi0jaWYgRU5BQkxF KENTU19SRUdJT05TKQotCiBWZWN0b3I8UmVmUHRyPFJhbmdlPiA+IEVsZW1lbnQ6OndlYmtpdEdl dFJlZ2lvbkZsb3dSYW5nZXMoKSBjb25zdAogewogICAgIGRvY3VtZW50KCktPnVwZGF0ZUxheW91 dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKaW5kZXggMmY0ZTky NS4uMGNkMjA5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCkBAIC00MjYsOCArNDI2LDggQEAgcHVibGlj OgogICAgIFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+IHN0eWxlRm9yUmVuZGVyZXIoKTsKIAogICAg IFJlbmRlclJlZ2lvbiogcmVuZGVyUmVnaW9uKCkgY29uc3Q7Ci0gICAgY29uc3QgQXRvbWljU3Ry aW5nJiB3ZWJraXRSZWdpb25PdmVyc2V0KCkgY29uc3Q7CiAjaWYgRU5BQkxFKENTU19SRUdJT05T KQorICAgIGNvbnN0IEF0b21pY1N0cmluZyYgd2Via2l0UmVnaW9uT3ZlcnNldCgpIGNvbnN0Owog ICAgIFZlY3RvcjxSZWZQdHI8UmFuZ2U+ID4gd2Via2l0R2V0UmVnaW9uRmxvd1JhbmdlcygpIGNv bnN0OwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50Lmlk bCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmlkbAppbmRleCAzM2MxMWRmLi40YmQ2NGVk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuaWRsCkBAIC0xNDMsNyArMTQzLDcgQEAgbW9kdWxlIGNvcmUg ewogICAgICAgICBbQ29uZGl0aW9uYWw9UE9JTlRFUl9MT0NLLCBWOEVuYWJsZWRBdFJ1bnRpbWU9 cG9pbnRlckxvY2tdIHZvaWQgd2Via2l0UmVxdWVzdFBvaW50ZXJMb2NrKCk7CiAKICAgICAgICAg Ly8gQ1NTIFJlZ2lvbnMgQVBJCi0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcg d2Via2l0UmVnaW9uT3ZlcnNldDsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtDb25kaXRp b25hbD1DU1NfUkVHSU9OU10gRE9NU3RyaW5nIHdlYmtpdFJlZ2lvbk92ZXJzZXQ7CiAgICAgICAg IFtDb25kaXRpb25hbD1DU1NfUkVHSU9OU10gc2VxdWVuY2U8UmFuZ2U+IHdlYmtpdEdldFJlZ2lv bkZsb3dSYW5nZXMoKTsKIAogI2lmICFkZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSB8fCAh TEFOR1VBR0VfT0JKRUNUSVZFX0MK 164713 2012-09-19 04:44:02 -0700 2012-09-19 11:50:50 -0700 Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) patch text/plain 3440 rhudea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3YjBiNzVmLi4yNzUyMTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDktMTkgIFJhdWwgSHVkZWEgIDxyaHVkZWFAYWRvYmUuY29tPgorCisgICAgICAg IFtDU1NSZWdpb25zXVtDU1NPTV0gTWFrZSBzdXJlIGFsbCBSZWdpb25zIEFQSXMgYXJlIG5vdCB2 aXNpYmxlIGlmIENTU19SRUdJT05TIGlzIG5vdCBkZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjMwMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbCBDU1MgUmVnaW9ucyBBUElzIHNob3VsZCBi ZSBleHBvc2VkIG9ubHkgaWYgQ1NTX1JFR0lPTlMgaXMgZW5hYmxlZAorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBiZWNhdXNlIG9mIG5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBjc3Mv U3R5bGVSdWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUnVsZUJhc2U6OnJlcG9ydE1l bW9yeVVzYWdlKTogRml4IGNvbXBpbGUgd2l0aG91dCBDU1NfUkVHSU9OUyBlbmFibGVkIGFuZCBh ZGRlZCBhbiBBU1NFUlRfTk9UX1JFQUNIRUQgYXMgaW4gb3RoZXIgZnVuY3Rpb25zCisgICAgICAg ICogZG9tL0VsZW1lbnQuY3BwOiBDb21waWxlIHdlYmtpdFJlZ2lvbk92ZXJzZXQgb25seSBpZiBD U1NfUkVHSU9OUyBpcyBlbmFibGVkCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBkb20v RWxlbWVudC5oOgorICAgICAgICAqIGRvbS9FbGVtZW50LmlkbDogRXhwb3NlIHdlYmtpdFJlZ2lv bk92ZXJzZXQgb25seSBpZiBDU1NfUkVHSU9OUyBpcyBlbmFibGVkCisKIDIwMTItMDktMTggIFNp bW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAgIEZpeCBj b21waWxhdGlvbiB3aXRoIFF0IDUgb24gTWVlR28gMS4yIEhhcm1hdHRhbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUnVsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVSdWxlLmNwcAppbmRleCA1OWVkOWU1Li41ZWNlMWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVSdWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSdWxl LmNwcApAQCAtODEsNyArODEsMTAgQEAgdm9pZCBTdHlsZVJ1bGVCYXNlOjpyZXBvcnRNZW1vcnlV c2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmplY3RJbmZvKSBjb25zdAogICAgIGNhc2Ug VW5rbm93bjoKICAgICBjYXNlIENoYXJzZXQ6CiAgICAgY2FzZSBLZXlmcmFtZToKLSAgICAgICAg TWVtb3J5Q2xhc3NJbmZvIGluZm8obWVtb3J5T2JqZWN0SW5mbywgdGhpcywgV2ViQ29yZU1lbW9y eVR5cGVzOjpDU1MpOworI2lmICFFTkFCTEUoQ1NTX1JFR0lPTlMpCisgICAgY2FzZSBSZWdpb246 CisjZW5kaWYKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5k ZXggMGQ0NDhlMS4uM2E3YzU0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtMjAzMyw2ICsy MDMzLDggQEAgUmVuZGVyUmVnaW9uKiBFbGVtZW50OjpyZW5kZXJSZWdpb24oKSBjb25zdAogICAg IHJldHVybiAwOwogfQogCisjaWYgRU5BQkxFKENTU19SRUdJT05TKQorCiBjb25zdCBBdG9taWNT dHJpbmcmIEVsZW1lbnQ6OndlYmtpdFJlZ2lvbk92ZXJzZXQoKSBjb25zdAogewogICAgIGRvY3Vt ZW50KCktPnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygpOwpAQCAtMjA2Miw4 ICsyMDY0LDYgQEAgY29uc3QgQXRvbWljU3RyaW5nJiBFbGVtZW50Ojp3ZWJraXRSZWdpb25PdmVy c2V0KCkgY29uc3QKICAgICByZXR1cm4gdW5kZWZpbmVkU3RhdGU7CiB9CiAKLSNpZiBFTkFCTEUo Q1NTX1JFR0lPTlMpCi0KIFZlY3RvcjxSZWZQdHI8UmFuZ2U+ID4gRWxlbWVudDo6d2Via2l0R2V0 UmVnaW9uRmxvd1JhbmdlcygpIGNvbnN0CiB7CiAgICAgZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0 SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCAyZjRlOTI1 Li4wY2QyMDlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKQEAgLTQyNiw4ICs0MjYsOCBAQCBwdWJsaWM6 CiAgICAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gc3R5bGVGb3JSZW5kZXJlcigpOwogCiAgICAg UmVuZGVyUmVnaW9uKiByZW5kZXJSZWdpb24oKSBjb25zdDsKLSAgICBjb25zdCBBdG9taWNTdHJp bmcmIHdlYmtpdFJlZ2lvbk92ZXJzZXQoKSBjb25zdDsKICNpZiBFTkFCTEUoQ1NTX1JFR0lPTlMp CisgICAgY29uc3QgQXRvbWljU3RyaW5nJiB3ZWJraXRSZWdpb25PdmVyc2V0KCkgY29uc3Q7CiAg ICAgVmVjdG9yPFJlZlB0cjxSYW5nZT4gPiB3ZWJraXRHZXRSZWdpb25GbG93UmFuZ2VzKCkgY29u c3Q7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaWRs IGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaWRsCmluZGV4IDMzYzExZGYuLjRiZDY0ZWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmlkbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5pZGwKQEAgLTE0Myw3ICsxNDMsNyBAQCBtb2R1bGUgY29yZSB7 CiAgICAgICAgIFtDb25kaXRpb25hbD1QT0lOVEVSX0xPQ0ssIFY4RW5hYmxlZEF0UnVudGltZT1w b2ludGVyTG9ja10gdm9pZCB3ZWJraXRSZXF1ZXN0UG9pbnRlckxvY2soKTsKIAogICAgICAgICAv LyBDU1MgUmVnaW9ucyBBUEkKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyB3 ZWJraXRSZWdpb25PdmVyc2V0OworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0NvbmRpdGlv bmFsPUNTU19SRUdJT05TXSBET01TdHJpbmcgd2Via2l0UmVnaW9uT3ZlcnNldDsKICAgICAgICAg W0NvbmRpdGlvbmFsPUNTU19SRUdJT05TXSBzZXF1ZW5jZTxSYW5nZT4gd2Via2l0R2V0UmVnaW9u Rmxvd1JhbmdlcygpOwogCiAjaWYgIWRlZmluZWQoTEFOR1VBR0VfT0JKRUNUSVZFX0MpIHx8ICFM QU5HVUFHRV9PQkpFQ1RJVkVfQwo=