96246 2012-09-10 01:41:38 -0700 [WK2] Make WK2 C API headers compile in the Qt build on Windows 2012-09-10 02:09:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76776 1 hausmann hausmann vestbo webkit.review.bot oldest_to_newest 715828 0 hausmann 2012-09-10 01:41:38 -0700 [WK2] Make WK2 C API headers compile in the Qt build on Windows 715833 1 163067 hausmann 2012-09-10 01:43:51 -0700 Created attachment 163067 Patch 715837 2 163067 kenneth 2012-09-10 01:49:44 -0700 Comment on attachment 163067 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163067&action=review > Source/WebKit2/Shared/API/c/WKBase.h:32 > +#if (defined(WIN32) || defined(_WIN32)) && !defined(BUILDING_QT__) This couldn't be PLATFORM(WIN) && instead? 715847 3 163067 hausmann 2012-09-10 02:05:01 -0700 Comment on attachment 163067 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163067&action=review >> Source/WebKit2/Shared/API/c/WKBase.h:32 >> +#if (defined(WIN32) || defined(_WIN32)) && !defined(BUILDING_QT__) > > This couldn't be PLATFORM(WIN) && instead? Unfortunately no, as that would require including config.h and WTF's Platform.h, both of which are not available when these header files are used on the application side. 715849 4 163067 webkit.review.bot 2012-09-10 02:09:02 -0700 Comment on attachment 163067 Patch Clearing flags on attachment: 163067 Committed r128033: <http://trac.webkit.org/changeset/128033> 715850 5 webkit.review.bot 2012-09-10 02:09:05 -0700 All reviewed patches have been landed. Closing bug. 163067 2012-09-10 01:43:51 -0700 2012-09-10 02:09:02 -0700 Patch bug-96246-20120910104535.patch text/plain 2118 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODBjMDY0ZDNmZmNiMzkx OTE0ODAyZWRjYTk3YmU3YmQ2ZTMxN2E0Ni4uNmE2N2U1YTMzNDBmMDhlYjhiNGFkYTVlZjExYzU1 ZmMzYmExMjJkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTEwICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbV0syXSBN YWtlIFdLMiBDIEFQSSBoZWFkZXJzIGNvbXBpbGUgaW4gdGhlIFF0IGJ1aWxkIG9uIFdpbmRvd3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MjQ2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0tCYXNlLmgg YW5kIFdLQVBJQ2FzdC5oIGluY2x1ZGUgZmlsZXMgdGhhdCBhcmUgc3BlY2lmaWMgdG8gdGhlIFNh ZmFyaS9XaW5kb3dzCisgICAgICAgIHBvcnQgaWYgV0lOMzIgb3IgX1dJTjMyIGlzIGRlZmluZWQu IFdoZW4gYnVpbGRpbmcgV2ViS2l0MiBvbiBXaW5kb3dzIHdpdGggUXQsIHdlCisgICAgICAgIGRv IG5vdCB3YW50IHRvIGluY2x1ZGUgdGhlc2UgZmlsZXMsIGFzIHRoZXkgZGVmaW5lIGFuIEFQSSB0 aGF0IGlzIGRpZmZlcmVudCB0byBvdXJzCisgICAgICAgICh0aGUgdmlldyBhc3BlY3QgZGlmZmVy cykuIFRoZXJlZm9yZSBndWFyZCB0aGUgaW5jbHVzaW9uIHdpdGggIWRlZmluZWQoQlVJTERJTkdf UVRfXykKKworICAgICAgICAqIFNoYXJlZC9BUEkvYy9XS0Jhc2UuaDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL0MvV0tBUElDYXN0Lmg6CisKIDIwMTItMDktMTAgIENocmlzdG9waGUgRHVtZXog IDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbV0syXSBOZXcgZmFzdC9m b3Jtcy9udW1iZXIvbnVtYmVyLWludGVyYWN0aXZlLXZhbGlkYXRpb24tcmVxdWlyZWQuaHRtbCBm YWlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLQmFzZS5oIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLQmFzZS5oCmluZGV4IDA2YWEyODZhYjVlYzM4 Y2Q5NDc1MGY1NzljNGQxNzkzZTU0NzI3NmQuLjIyMjBlNjdhYTJhNWNmZTM2YjQ2YjhkZjgyOTMz ZWExNDAzMGQzMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS0Jh c2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tCYXNlLmgKQEAgLTI5LDcg KzI5LDcgQEAKIAogI2luY2x1ZGUgPHN0ZGludC5oPgogCi0jaWYgZGVmaW5lZChXSU4zMikgfHwg ZGVmaW5lZChfV0lOMzIpCisjaWYgKGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKSkg JiYgIWRlZmluZWQoQlVJTERJTkdfUVRfXykKICNpbmNsdWRlIDxXZWJLaXQyL1dLQmFzZVdpbi5o PgogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S0FQSUNhc3QuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0FQSUNhc3QuaApp bmRleCBkMGQ3YjMyZmNlZGVjMWFjMWM1ZDZkODdiNGY5ZTAyZmIzYjM0ZmVjLi5mZTU1ZGQ4YWM1 YjVhZTE4NzBjNTVlYTk2ODg0OGEzY2RjZDJmNjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvV0tBUElDYXN0LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLQVBJQ2FzdC5oCkBAIC00MjMsNyArNDIzLDcgQEAgaW5saW5lIFByb3h5aW5n UmVmUHRyPFdlYkdyYW1tYXJEZXRhaWw+IHRvQVBJKGNvbnN0IFdlYkNvcmU6OkdyYW1tYXJEZXRh aWwmIGdyYW0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKLSNpZiBkZWZpbmVkKFdJTjMyKSB8 fCBkZWZpbmVkKF9XSU4zMikKKyNpZiAoZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIp KSAmJiAhZGVmaW5lZChCVUlMRElOR19RVF9fKQogI2luY2x1ZGUgIldLQVBJQ2FzdFdpbi5oIgog I2VuZGlmCiAK