96148 2012-09-07 14:16:39 -0700 Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected 2012-10-09 01:03:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 97077 97084 0 johnjbarton webkit-unassigned apavlov bweinstein caseq cdumez joepeck keishi loislo ossy pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 714968 0 johnjbarton 2012-09-07 14:16:39 -0700 In WebInspector.Panel.wasShown() this.focus() is called, to set the focus within the panel the user just selected. For an ExtensionPanel, the focus should default to be within the iframe hosting the extension code, rather than its container (which, being a div, can't accept focus anyway). By setting focus on the iframe, its contentWindow will become the window with focus. 714982 1 162870 johnjbarton 2012-09-07 14:26:42 -0700 Created attachment 162870 Patch 714990 2 johnjbarton 2012-09-07 14:32:30 -0700 A different solution would store the extensionView on |this|, eg this._extensionView, then define ExtensionPanel.defaultFocusedElement() to return this._extensionView.defaultFocusedElement(). However the origin impl chose not to store the extensionView and perhaps there was a reason. 722885 3 162870 caseq 2012-09-18 10:23:47 -0700 Comment on attachment 162870 Patch LGTM. vsevik, could you please review this? 722907 4 162870 webkit.review.bot 2012-09-18 11:02:15 -0700 Comment on attachment 162870 Patch Clearing flags on attachment: 162870 Committed r128910: <http://trac.webkit.org/changeset/128910> 722908 5 webkit.review.bot 2012-09-18 11:02:18 -0700 All reviewed patches have been landed. Closing bug. 723320 6 ossy 2012-09-18 23:37:09 -0700 (In reply to comment #4) > (From update of attachment 162870 [details]) > Clearing flags on attachment: 162870 > > Committed r128910: <http://trac.webkit.org/changeset/128910> The new inspector/extensions/extensions-panel.html fails on Qt and EFL: --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-actual.txt @@ -22,7 +22,7 @@ show : <function> } Panel shown -focused: true +focused: false Extension panel size correct RUNNING TEST: extension_testSearch Panel hidden Could you check it, please? 723862 7 johnjbarton 2012-09-19 15:11:32 -0700 (In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 162870 [details] [details]) > > Clearing flags on attachment: 162870 > > > > Committed r128910: <http://trac.webkit.org/changeset/128910> > > The new inspector/extensions/extensions-panel.html fails on Qt and EFL: > --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-expected.txt > +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-actual.txt > @@ -22,7 +22,7 @@ > show : <function> > } > Panel shown > -focused: true > +focused: false > Extension panel size correct > RUNNING TEST: extension_testSearch > Panel hidden > > > Could you check it, please? I'm uncertain who you are asking; if your are asking me I don't know how to check it. Do these platforms have different focus behavior? 737505 8 ossy 2012-10-09 01:03:48 -0700 I don't know anything about this test. But I'm sure it is a regression caused by http://trac.webkit.org/changeset/128910 162870 2012-09-07 14:26:42 -0700 2012-09-18 11:02:14 -0700 Patch bug-96148-20120907142621.patch text/plain 4855 johnjbarton U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3ODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGJlMzFmNTZjNTE5MDE3 YzAxNDg1NmZhZWEyZmQ1N2Y1OTI2YjY1OC4uZmYxN2ViZWQ1ZGRkYTgwNWQ4ZmNmMmEwYjE4NDg2 YzcyZWExMzc2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTA3ICBKb2hu IEouIEJhcnRvbiAgPGpvaG5qYmFydG9uQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBTZXQgZm9jdXMgb24gdGhlIEV4dGVuc2lvblBhbmVsJ3MgaWZyYW1lIHdoZW4gaXQg aXMgc2VsZWN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk2MTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXh0ZW5zaW9uVmlldyBjdG9yIGNhbGxzIHNldERlZmF1bHRGb2N1c2VkRWxlbWVudCB3aXRo IGl0cyBpZnJhbWUsCisgICAgICAgIEV4dGVuc2lvblBhbmVsIGN0b3IgY2FsbHMgc2V0RGVmYXVs dEZvY3VzZWRFbGVtZW50IHdpdGggdGhlIGV4dGVuc2lvblZpZXcKKyAgICAgICAgYW5kIEV4dGVu c2lvblBhbmVsJ3Mgc2V0RGVmYXVsdEZvY3VzZWRFbGVtZW50IGNhbGxzIGl0cyBncmFuZHBhcmVu dCBpbXBsCisKKyAgICAgICAgVGVzdHM6IEFkZGVkIGhhc0ZvY3VzIHRlc3QgdG8gZXh0ZW5zaW9u cy9leHRlbnNpb24tcGFuZWwuaHRtbAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9F eHRlbnNpb25QYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FeHRlbnNpb25QYW5lbCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRXh0ZW5zaW9uUGFuZWwucHJvdG90eXBlLmRlZmF1bHRG b2N1c2VkRWxlbWVudCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25W aWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkV4dGVuc2lvblZpZXcpOgorCiAyMDEyLTA5 LTA3ICBMaWFuZ2h1aSBDaGVuICA8bGlhY2hlbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0Jl cnJ5XSB3aGVuIG9uZSBvZiBtdWx0aXBsZSB0YWJzIHVzZXMgYXV0aGVudGljYXRpb24sIHVzZXIg Y2FuIGdldCB0aGUgYXV0aCBkaWFsb2cgd2hpbGUgdGhlIG90aGVyIHRhYiBoYXMgZm9jdXMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblBh bmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25QYW5l bC5qcwppbmRleCA0NmNkYjExN2ZjMGJkNTM5NmEyMDhhZWRhYzg4ODIxYjNiNDg4ZjdjLi5mOTZk OWU5OWU5NDUzZjcwZGQ5YzJjODBlNzRlYjM0MTg4MmY5ZWViIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblBhbmVsLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uUGFuZWwuanMKQEAgLTQxLDEy ICs0MSwxMyBAQCBXZWJJbnNwZWN0b3IuRXh0ZW5zaW9uUGFuZWwgPSBmdW5jdGlvbihpZCwgcGFn ZVVSTCkKICAgICB0aGlzLl9zdGF0dXNCYXJJdGVtcyA9IFtdOwogICAgIHZhciBleHRlbnNpb25W aWV3ID0gbmV3IFdlYkluc3BlY3Rvci5FeHRlbnNpb25WaWV3KGlkLCBwYWdlVVJMLCAiZXh0ZW5z aW9uIHBhbmVsIik7CiAgICAgZXh0ZW5zaW9uVmlldy5zaG93KHRoaXMuZWxlbWVudCk7CisgICAg dGhpcy5zZXREZWZhdWx0Rm9jdXNlZEVsZW1lbnQoZXh0ZW5zaW9uVmlldy5kZWZhdWx0Rm9jdXNl ZEVsZW1lbnQoKSk7CiB9CiAKIFdlYkluc3BlY3Rvci5FeHRlbnNpb25QYW5lbC5wcm90b3R5cGUg PSB7CiAgICAgZGVmYXVsdEZvY3VzZWRFbGVtZW50OiBmdW5jdGlvbigpCiAgICAgewotICAgICAg ICByZXR1cm4gdGhpcy5zaWRlYmFyVHJlZUVsZW1lbnQgfHwgdGhpcy5lbGVtZW50OworICAgICAg ICByZXR1cm4gV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90eXBlLmRlZmF1bHRGb2N1c2VkRWxlbWVu dC5jYWxsKHRoaXMpOwogICAgIH0sCiAKICAgICBnZXQgc3RhdHVzQmFySXRlbXMoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25WaWV3Lmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25WaWV3LmpzCmlu ZGV4IGQ0Y2Q3MmM0ZDVjZjM0N2RmMmZiMzA3NzI3YzY0NzQ5NjE4MDQ3MDIuLjE3MGRiMGI2YmY2 ZjdmNmEyNzMyMzY4Y2I4NzU3YTE4ODMwZTc5NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblZpZXcuanMKQEAgLTQ1LDYgKzQ1LDcgQEAg V2ViSW5zcGVjdG9yLkV4dGVuc2lvblZpZXcgPSBmdW5jdGlvbihpZCwgc3JjLCBjbGFzc05hbWUp CiAgICAgdGhpcy5faWZyYW1lLmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCB0aGlzLl9vbkxvYWQu YmluZCh0aGlzKSwgZmFsc2UpOwogICAgIHRoaXMuX2lmcmFtZS5zcmMgPSBzcmM7CiAgICAgdGhp cy5faWZyYW1lLmNsYXNzTmFtZSA9IGNsYXNzTmFtZTsKKyAgICB0aGlzLnNldERlZmF1bHRGb2N1 c2VkRWxlbWVudCh0aGlzLl9pZnJhbWUpOwogCiAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENoaWxk KHRoaXMuX2lmcmFtZSk7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTY2YjUzM2I5NGI1N2JiM2I3ZTZlMmIzYjUyMTU2 ZDVmM2Q2NzExOS4uZGFlNWE5NDI4NDQ1NWM1ZWJjYTYwMjg1MDllYWQwNjVkN2VmYTk3OSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTA3ICBKb2huIEouIEJhcnRvbiAgPGpvaG5qYmFy dG9uQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBTZXQgZm9jdXMgb24g dGhlIEV4dGVuc2lvblBhbmVsJ3MgaWZyYW1lIHdoZW4gaXQgaXMgc2VsZWN0ZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MTQ4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG9uZSBsaW5lIHRvIHZl cmlmeSB0aGF0IHRoZSBwYW5lbCdzIGRvY3VtZW50IGhhcyBmb2N1cyBhZnRlciBzaG93CisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNpb25zLXBhbmVsLWV4cGVjdGVkLnR4 dDoKKyAgICAgICAgKiBpbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNpb25zLXBhbmVsLmh0bWw6 CisKIDIwMTItMDktMDcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbY2hyb21pdW1dIENocm9taXVtIExpbnV4IEVXUyBib3RzIGFuZCBDUSBib3RzIGFyZSBmbGFr eQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMvZXh0ZW5zaW9u cy1wYW5lbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9l eHRlbnNpb25zLXBhbmVsLWV4cGVjdGVkLnR4dAppbmRleCBjMGVmNjVkYjFjNGY3NDFlZmExYWUw NWJmYjJhMzA3MDFlYzZlNTRjLi5jNDc1Y2MyMGEyNTI5Mzg0OWExYTE2MGI0ZDcxYWEwNDM5MzBl YWQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNp b25zLXBhbmVsLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5z aW9ucy9leHRlbnNpb25zLXBhbmVsLWV4cGVjdGVkLnR4dApAQCAtMjIsNiArMjIsNyBAQCBQYW5l bCBjcmVhdGVkCiAgICAgc2hvdyA6IDxmdW5jdGlvbj4KIH0KIFBhbmVsIHNob3duCitmb2N1c2Vk OiB0cnVlCiBFeHRlbnNpb24gcGFuZWwgc2l6ZSBjb3JyZWN0CiBSVU5OSU5HIFRFU1Q6IGV4dGVu c2lvbl90ZXN0U2VhcmNoCiBQYW5lbCBoaWRkZW4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lu c3BlY3Rvci9leHRlbnNpb25zL2V4dGVuc2lvbnMtcGFuZWwuaHRtbCBiL0xheW91dFRlc3RzL2lu c3BlY3Rvci9leHRlbnNpb25zL2V4dGVuc2lvbnMtcGFuZWwuaHRtbAppbmRleCBiMjI0MGRjOGY3 YjBlNmQ2YTI1MGY2ZjExMmIzZDliODQ4MDVlYWNhLi42MzdiZDQ3MGEwZWZlMTY5MGZhZDhkMDQx OTFhYzYzOTM2NDgwZDE1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5z aW9ucy9leHRlbnNpb25zLXBhbmVsLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4 dGVuc2lvbnMvZXh0ZW5zaW9ucy1wYW5lbC5odG1sCkBAIC02NSw2ICs2NSw3IEBAIGZ1bmN0aW9u IGV4dGVuc2lvbl90ZXN0Q3JlYXRlUGFuZWwobmV4dFRlc3QpCiAgICAgICAgICAgICByZXR1cm47 CiAgICAgICAgIH0KICAgICAgICAgb3V0cHV0KCJQYW5lbCBzaG93biIpOworICAgICAgICBvdXRw dXQoImZvY3VzZWQ6ICIgKyB3aW5kb3cuZG9jdW1lbnQuaGFzRm9jdXMoKSk7CiAgICAgICAgIHBh bmVsLm9uU2hvd24ucmVtb3ZlTGlzdGVuZXIob25QYW5lbFNob3duKTsKICAgICAgICAgZXZhbHVh dGVPbkZyb250ZW5kKCJyZXBseShJbnNwZWN0b3JUZXN0LmdldFBhbmVsU2l6ZSgpKSIsIGZ1bmN0 aW9uKHJlc3VsdCkgewogICAgICAgICAgICAgaWYgKHJlc3VsdC53aWR0aCAhPT0gd2luZG93Lmlu bmVyV2lkdGgpCg==