96050 2012-09-06 18:35:18 -0700 We should have localized strings of date time fields for accessibility 2012-09-06 20:35:13 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96032 1 yosin yosin abarth dglazkov donggwan.kim fishd jamesr tkent tkent+wkapi webkit.review.bot oldest_to_newest 713974 0 yosin 2012-09-06 18:35:18 -0700 For accessibility, we should tell meaning of field to accessibility framework. 714009 1 162651 yosin 2012-09-06 19:15:21 -0700 Created attachment 162651 Patch 1 714010 2 162651 yosin 2012-09-06 19:16:01 -0700 Comment on attachment 162651 Patch 1 Could you review this patch? Thanks in advance. 714013 3 webkit.review.bot 2012-09-06 19:19:06 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 714017 4 162651 tkent 2012-09-06 19:21:50 -0700 Comment on attachment 162651 Patch 1 ok 714049 5 162651 yosin 2012-09-06 20:35:09 -0700 Comment on attachment 162651 Patch 1 Clearing flags on attachment: 162651 Committed r127815: <http://trac.webkit.org/changeset/127815> 714050 6 yosin 2012-09-06 20:35:13 -0700 All reviewed patches have been landed. Closing bug. 162651 2012-09-06 19:15:21 -0700 2012-09-06 20:35:09 -0700 Patch 1 bug-96050-20120907111501.patch text/plain 7345 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3ODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ODRiMjBkZjgwZDli M2YzOTQ4ZDliZDAwZTQ1OGRkZWE0OGZjY2NkLi4wNTM4YjI1MDE4ZWQ1YWJhNDY4YmNlZGVmODJh YzVkNzk3MDNhYTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wOS0wNiAg WW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlIHNob3Vs ZCBoYXZlIGxvY2FsaXplZCBzdHJpbmdzIG9mIGRhdGUgdGltZSBmaWVsZHMgZm9yIGFjY2Vzc2li aWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2 MDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBwYXRjaCBhZGRzIGxvY2FsaXplZCBzdHJpbmcgZW51bSBmaWVsZHMgZm9yIGFjY2Vzc2liaWxp dHkgc3VwcG9ydAorICAgICAgICBpbiBtdWx0aXBsZSBmaWVsZHMgZGF0ZSB0aW1lIHJlbGF0ZWQg aW5wdXQgdHlwZXMgZm9yIENocm9taXVtIHBvcnRzLgorCisgICAgICAgICogY2hyb21pdW0vcHVi bGljL1dlYkxvY2FsaXplZFN0cmluZy5oOiBBZGRzIEFYQU1QTUZpZWxkVGV4dCwgQVhEYXlPZk1v bnRoRmllbGQsCisgICAgICAgIEFYSG91ckZpZWxkVGV4dCwgQVhNaWxsaXNlY29uZEZpZWxkVGV4 dCwgQVhNaW51dGVGaWVsZFRleHQsIEFYTW9udGhGaWVsZCwKKyAgICAgICAgQVhTZWNvbmRGaWVs ZFRleHQsIEFYV2Vla09mWWVhckZpZWxkVGV4dCwgYW5kIEFYWWVhckZpZWxkVGV4dC4KKwogMjAx Mi0wOS0wNiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFtjaHJvbWl1bV0gRXhwb3J0IHB1YmxpYyBmdW5jdGlvbnMgb24gV2ViVHJhbnNmb3JtYXRpb25N YXRyaXggc28gdGhleSBjYW4gYmUgdXNlZCBvdXRzaWRlIG9mIFdlYktpdC5kbGwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCA4NTA0YWYwZmUzNGFlZDJlZDUwYzk2NmQyNzg2MDA2NzY0ZGQ5NDc1Li42YmQ2MDc2MmI2 YTdlZWJmMjNiZTE3NGI3NTg0NTMxY2FjMmE5YTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTItMDktMDYgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBXZSBzaG91bGQgaGF2ZSBsb2NhbGl6ZWQgc3RyaW5ncyBvZiBkYXRlIHRpbWUgZmll bGRzIGZvciBhY2Nlc3NpYmlsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05NjA1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBkZWNsYXJhdGlvbnMgb2YgZnVuY3Rpb24gZm9y IGdldHRpbmcgbG9jYWxpemVkIHN0cmluZworICAgICAgICBvZiBkYXRlIHRpbWUgZmllbGQgZm9y IGFjY2Vzc2liaWxpdHkgaW5zaWRlIEVOQUJMRV9JTlBVVF9UWVBFX1RJTUVfTVVMVElQTEVfRklF TERTLgorCisgICAgICAgIFRoZXNlIGZ1bmN0aW9ucyB3aWxsIGJlIHVzZWQgYnkgZGVyaXZlZCBj bGFzc2VzIG9mIERhdGVUaW1lRmllbGRFbGVtZW50LgorCisgICAgICAgIE5vdGU6IFdlJ2xsIHJl bmFtZSBFTkFCTEVfSU5QVVRfVFlQRV9NVUxUSVBMRV9GSUVMRFMgdG8gZ2VuZXJpYyBuYW1lCisg ICAgICAgIHRvIHN1cHBvcnQgImRhdGUiLCAiZGF0ZXRpbWUiLCAibW9udGgiIGFuZCAid2VlayIg bXVsdGlwbGUgZmllbGRzIGlucHV0CisgICAgICAgIFVJLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gVGhpcyBwYXRjaCBkb2Vzbid0IGNoYW5nZSBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRm b3JtL0xvY2FsaXplZFN0cmluZ3MuaDoKKyAgICAgICAgKFdlYkNvcmUpOiBBZGRlZCBkZWNsYXJh dGlvbnMgb2YgQVhBTVBNRmllbGRUZXh0KCksIEFYRGF5T2ZNb250aEZpZWxkVGV4dCgpLAorICAg ICAgICBBWEhvdXJGaWVsZFRleHQoKSwgQVhNaWxsaXNlY29uZEZpZWxkVGV4dCgpLCBBWE1pbnV0 ZUZpZWxkVGV4dCgpLCBBWE1vbnRoRmllbGRUZXh0KCksCisgICAgICAgIEFYU2Vjb25kRmllbGRU ZXh0KCksIEFYV2Vla09mWWVhckZpZWxkVGV4dCgpLCBhbmQgQVhZZWFyRmllbGRUZXh0KCkuCisK IDIwMTItMDktMDYgIEFkYW0gQmFydGggIDxhYmFydGhAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFtWOF0gV2VhdmUgY3JlYXRpb25Db250ZXh0IHRocm91Z2ggdG9WOCBhbmQgcmVsYXRlZCBmdW5j dGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggN2YxZGFiNjYwMDc5NmJiZTQwNDIw MDhkMzViNjA5YmQ4ODZlYjVjMS4uODVhMmM5MTgxMWZjN2IyNDMxNzQ1MWIwMmEyODZkYmRjNjdm YjZiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMCBAQAorMjAxMi0w OS0wNiAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdl IHNob3VsZCBoYXZlIGxvY2FsaXplZCBzdHJpbmdzIG9mIGRhdGUgdGltZSBmaWVsZHMgZm9yIGFj Y2Vzc2liaWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk2MDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBwYXRjaCBhZGRzIGZ1bmN0aW9ucyBmb3IgZ2V0dGluZyBsb2NhbGl6ZWQgc3RyaW5n cyBvZiBkYXRlIHRpbWUKKyAgICAgICAgZmllbGRzIGZvciBhY2Nlc3NpYmlsaXR5IGluc2lkZSBF TkFCTEVfSU5QVVRfVFlQRV9USU1FX01VTFRJUExFX0ZJRUxEUy4KKworICAgICAgICBUaGVzZSBm dW5jdGlvbnMgd2lsbCBiZSB1c2VkIGJ5IGRlcml2ZWQgY2xhc3NlcyBvZiBEYXRlVGltZUZpZWxk RWxlbWVudC4KKworICAgICAgICBOb3RlOiBXZSdsbCByZW5hbWUgRU5BQkxFX0lOUFVUX1RZUEVf TVVMVElQTEVfRklFTERTIHRvIGdlbmVyaWMgbmFtZQorICAgICAgICB0byBzdXBwb3J0ICJkYXRl IiwgImRhdGV0aW1lIiwgIm1vbnRoIiBhbmQgIndlZWsiIG11bHRpcGxlIGZpZWxkcyBpbnB1dAor ICAgICAgICBVSS4KKworICAgICAgICAqIHNyYy9Mb2NhbGl6ZWRTdHJpbmdzLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkFYQU1QTUZpZWxkVGV4dCk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6 QVhEYXlPZk1vbnRoRmllbGRUZXh0KTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpBWEhvdXJG aWVsZFRleHQpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkFYTWlsbGlzZWNvbmRGaWVsZFRl eHQpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkFYTWludXRlRmllbGRUZXh0KTogQWRkZWQu CisgICAgICAgIChXZWJDb3JlOjpBWE1vbnRoRmllbGRUZXh0KTogQWRkZWQuCisgICAgICAgIChX ZWJDb3JlOjpBWFNlY29uZEZpZWxkVGV4dCk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6QVhX ZWVrT2ZZZWFyRmllbGRUZXh0KTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpBWFllYXJGaWVs ZFRleHQpOiBBZGRlZC4KKwogMjAxMi0wOS0wNiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gRG9uJ3QgbGluayBjYyBpbiB0byBXZWJL aXQuZGxsIHdoZW4gdXNlX2xpYmNjX2Zvcl9jb21wb3NpdG9yPTEKZGlmZiAtLWdpdCBhL1NvdXJj ZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTG9jYWxpemVkU3RyaW5nLmggYi9Tb3VyY2Uv UGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkxvY2FsaXplZFN0cmluZy5oCmluZGV4IDQxOWRm YjI0MjE1NmU4MjE2NzhjOTYyZDc3ZDY2NjQyOGI1ODUwMTEuLjc1Mjk1MzdiNzg2NjBiMDI2MjY3 YWVjODFkNGI4YTNlOWQ0OWIwYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvV2ViTG9jYWxpemVkU3RyaW5nLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJMb2NhbGl6ZWRTdHJpbmcuaApAQCAtMzUsMTcgKzM1LDI2IEBAIG5hbWVz cGFjZSBXZWJLaXQgewogCiBzdHJ1Y3QgV2ViTG9jYWxpemVkU3RyaW5nIHsKICAgICBlbnVtIE5h bWUgeworICAgICAgICBBWEFNUE1GaWVsZFRleHQsCiAgICAgICAgIEFYQnV0dG9uQWN0aW9uVmVy YiwKICAgICAgICAgQVhDaGVja2VkQ2hlY2tCb3hBY3Rpb25WZXJiLAorICAgICAgICBBWERheU9m TW9udGhGaWVsZFRleHQsCiAgICAgICAgIEFYSGVhZGluZ1RleHQsCisgICAgICAgIEFYSG91ckZp ZWxkVGV4dCwKICAgICAgICAgQVhJbWFnZU1hcFRleHQsCiAgICAgICAgIEFYTGlua0FjdGlvblZl cmIsCiAgICAgICAgIEFYTGlua1RleHQsCiAgICAgICAgIEFYTGlzdE1hcmtlclRleHQsCisgICAg ICAgIEFYTWlsbGlzZWNvbmRGaWVsZFRleHQsCisgICAgICAgIEFYTWludXRlRmllbGRUZXh0LAor ICAgICAgICBBWE1vbnRoRmllbGRUZXh0LAogICAgICAgICBBWFJhZGlvQnV0dG9uQWN0aW9uVmVy YiwKKyAgICAgICAgQVhTZWNvbmRGaWVsZFRleHQsCiAgICAgICAgIEFYVGV4dEZpZWxkQWN0aW9u VmVyYiwKICAgICAgICAgQVhVbmNoZWNrZWRDaGVja0JveEFjdGlvblZlcmIsCiAgICAgICAgIEFY V2ViQXJlYVRleHQsCisgICAgICAgIEFYV2Vla09mWWVhckZpZWxkVGV4dCwKKyAgICAgICAgQVhZ ZWFyRmllbGRUZXh0LAogICAgICAgICBDYWxlbmRhckNsZWFyLAogICAgICAgICBDYWxlbmRhclRv ZGF5LAogICAgICAgICBEYXRlRm9ybWF0RGF5SW5Nb250aExhYmVsLApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5oCmluZGV4IGMxMTgwYzY2YWQ3ZTZkNDQ4MDMxMWJm Njg0ZThjNTIxN2NjZGQzMmUuLjk4MTI3YTViMGRmN2E5YjUwMjcxZTc3MDM0ZTM0NWFkY2I1MjI1 ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvY2FsaXplZFN0cmluZ3Mu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmgKQEAgLTE2 NSw2ICsxNjUsMTggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIFN0cmluZyBBWE1lbnVMaXN0 UG9wdXBBY3Rpb25WZXJiKCk7CiAgICAgU3RyaW5nIEFYTGlua0FjdGlvblZlcmIoKTsKIAorI2lm IEVOQUJMRShJTlBVVF9UWVBFX1RJTUVfTVVMVElQTEVfRklFTERTKQorICAgIFN0cmluZyBBWEFN UE1GaWVsZFRleHQoKTsKKyAgICBTdHJpbmcgQVhEYXlPZk1vbnRoRmllbGRUZXh0KCk7CisgICAg U3RyaW5nIEFYSG91ckZpZWxkVGV4dCgpOworICAgIFN0cmluZyBBWE1pbGxpc2Vjb25kRmllbGRU ZXh0KCk7CisgICAgU3RyaW5nIEFYTWludXRlRmllbGRUZXh0KCk7CisgICAgU3RyaW5nIEFYTW9u dGhGaWVsZFRleHQoKTsKKyAgICBTdHJpbmcgQVhTZWNvbmRGaWVsZFRleHQoKTsKKyAgICBTdHJp bmcgQVhXZWVrT2ZZZWFyRmllbGRUZXh0KCk7CisgICAgU3RyaW5nIEFYWWVhckZpZWxkVGV4dCgp OworI2VuZGlmCisKICAgICBTdHJpbmcgbWlzc2luZ1BsdWdpblRleHQoKTsKICAgICBTdHJpbmcg Y3Jhc2hlZFBsdWdpblRleHQoKTsKICAgICBTdHJpbmcgYmxvY2tlZFBsdWdpbkJ5Q29udGVudFNl Y3VyaXR5UG9saWN5VGV4dCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvTG9jYWxpemVkU3RyaW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Mb2Nh bGl6ZWRTdHJpbmdzLmNwcAppbmRleCAyYTQ0MzJkOGFkZDIyNjg2MzQwYTYxMmU3NWJjM2IxZDQ1 ZmRmOGU1Li44OWU4MGM4ODVlY2EzMTZjMThjZTExZjE0NTE5NmYxODYxZjllOGQzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Mb2NhbGl6ZWRTdHJpbmdzLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Mb2NhbGl6ZWRTdHJpbmdzLmNwcApAQCAtMjAy LDYgKzIwMiw1MyBAQCBTdHJpbmcgQVhNZW51TGlzdEFjdGlvblZlcmIoKQogICAgIHJldHVybiBT dHJpbmcoKTsKIH0KICAgICAKKyNpZiBFTkFCTEUoSU5QVVRfVFlQRV9USU1FX01VTFRJUExFX0ZJ RUxEUykKK1N0cmluZyBBWEFNUE1GaWVsZFRleHQoKQoreworICAgIHJldHVybiBxdWVyeShXZWJM b2NhbGl6ZWRTdHJpbmc6OkFYQU1QTUZpZWxkVGV4dCk7Cit9CisKK1N0cmluZyBBWERheU9mTW9u dGhGaWVsZFRleHQoKQoreworICAgIHJldHVybiBxdWVyeShXZWJMb2NhbGl6ZWRTdHJpbmc6OkFY RGF5T2ZNb250aEZpZWxkVGV4dCk7Cit9CisKK1N0cmluZyBBWEhvdXJGaWVsZFRleHQoKQorewor ICAgIHJldHVybiBxdWVyeShXZWJMb2NhbGl6ZWRTdHJpbmc6OkFYSG91ckZpZWxkVGV4dCk7Cit9 CisKK1N0cmluZyBBWE1pbGxpc2Vjb25kRmllbGRUZXh0KCkKK3sKKyAgICByZXR1cm4gcXVlcnko V2ViTG9jYWxpemVkU3RyaW5nOjpBWE1pbGxpc2Vjb25kRmllbGRUZXh0KTsKK30KKworU3RyaW5n IEFYTWludXRlRmllbGRUZXh0KCkKK3sKKyAgICByZXR1cm4gcXVlcnkoV2ViTG9jYWxpemVkU3Ry aW5nOjpBWE1pbnV0ZUZpZWxkVGV4dCk7Cit9CisKK1N0cmluZyBBWE1vbnRoRmllbGRUZXh0KCkK K3sKKyAgICByZXR1cm4gcXVlcnkoV2ViTG9jYWxpemVkU3RyaW5nOjpBWE1vbnRoRmllbGRUZXh0 KTsKK30KKworU3RyaW5nIEFYU2Vjb25kRmllbGRUZXh0KCkKK3sKKyAgICByZXR1cm4gcXVlcnko V2ViTG9jYWxpemVkU3RyaW5nOjpBWFNlY29uZEZpZWxkVGV4dCk7Cit9CisKK1N0cmluZyBBWFdl ZWtPZlllYXJGaWVsZFRleHQoKQoreworICAgIHJldHVybiBxdWVyeShXZWJMb2NhbGl6ZWRTdHJp bmc6OkFYV2Vla09mWWVhckZpZWxkVGV4dCk7Cit9CisKK1N0cmluZyBBWFllYXJGaWVsZFRleHQo KQoreworICAgIHJldHVybiBxdWVyeShXZWJMb2NhbGl6ZWRTdHJpbmc6OkFYWWVhckZpZWxkVGV4 dCk7Cit9CisjZW5kaWYKKwogU3RyaW5nIG1pc3NpbmdQbHVnaW5UZXh0KCkKIHsKICAgICByZXR1 cm4gcXVlcnkoV2ViTG9jYWxpemVkU3RyaW5nOjpNaXNzaW5nUGx1Z2luVGV4dCk7Cg==