95943 2012-09-06 00:40:04 -0700 [EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent() 2012-09-06 06:05:20 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 1 cdumez cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 712968 0 cdumez 2012-09-06 00:40:04 -0700 WK2 EFL currently has an empty implementation for WebPage::performDefaultBehaviorForKeyEvent(), causing some test cases to fail. We should provide a proper implementation. 712972 1 162436 cdumez 2012-09-06 00:42:31 -0700 Created attachment 162436 Patch 713007 2 162436 kenneth 2012-09-06 01:13:28 -0700 Comment on attachment 162436 Patch I wonder which platforms actually diverts from this 713213 3 162436 webkit.review.bot 2012-09-06 06:05:15 -0700 Comment on attachment 162436 Patch Clearing flags on attachment: 162436 Committed r127733: <http://trac.webkit.org/changeset/127733> 713214 4 webkit.review.bot 2012-09-06 06:05:20 -0700 All reviewed patches have been landed. Closing bug. 162436 2012-09-06 00:42:31 -0700 2012-09-06 06:05:15 -0700 Patch 95943_performDefaultBehaviorForKeyEvent.patch text/plain 5067 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzODRhMjk1Li5hMzhhNjBiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDkt MDYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXVtXSzJdIFByb3ZpZGUgaW1wbGVtZW50YXRpb24gZm9yIFdlYlBhZ2U6OnBlcmZv cm1EZWZhdWx0QmVoYXZpb3JGb3JLZXlFdmVudCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTk0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCBzZXZlcmFsIHRlc3QgY2FzZXMgdGhhdCBhcmUg cGFzc2luZyBub3cgdGhhdCBFRkwgV0syCisgICAgICAgIGhhcyBhIHByb3BlciBpbXBsZW1lbnRh dGlvbiBmb3IKKyAgICAgICAgV2ViUGFnZTo6cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcktleUV2 ZW50KCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisK IDIwMTItMDktMDUgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBJbmRleGVkREI6IExhcmdlIGludGVnZXIgdmVyc2lvbnMgbm90IHBlcnNpc3RlZCBjb3JyZWN0 bHkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRl eCA4OTZlNmU0Li5hZmI1NTlkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwt d2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9U ZXN0RXhwZWN0YXRpb25zCkBAIC0yMjIsMTMgKzIyMiwxMCBAQCBCVUdXSzk0MTk0IDogaHR0cC90 ZXN0cy9zZWN1cml0eS9mcmFtZU5hdmlnYXRpb24vaW5hY3RpdmUtZnVuY3Rpb24taW4tcG9wdXAt bmF2aQogQlVHV0tFRkwgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL2RlbGV0ZS1zZWxlY3Rpb24taGFz LXN0eWxlLmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6IGVkaXRpbmcvZXhlY0NvbW1hbmQvZm9ybWF0 LWJsb2NrLW11bHRpcGxlLXBhcmFncmFwaHMtaW4tcHJlLmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6 IGVkaXRpbmcvaW5wdXQvZW1hY3MtY3RybC1vLmh0bWwgPSBURVhUCi1CVUdXS0VGTCA6IGVkaXRp bmcvaW5wdXQvcGFnZS11cC1kb3duLXNjcm9sbHMuaHRtbCA9IFRFWFQKIEJVR1dLRUZMIDogZmFz dC9ibG9jay9mbG9hdC9mbG9hdC1pbi1mbG9hdC1oaXQtdGVzdGluZy5odG1sID0gVEVYVAogQlVH V0tFRkwgOiBmYXN0L2Nzcy9iaWRpLW92ZXJyaWRlLWluLWFub255bW91cy1ibG9jay5odG1sID0g VEVYVAogQlVHV0tFRkwgOiBmYXN0L2Nzcy9yZWxhdGl2ZS1wb3NpdGlvbmVkLWJsb2NrLWNyYXNo Lmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6IGZhc3QvZG9tL1dpbmRvdy9tb3ppbGxhLWZvY3VzLWJs dXIuaHRtbCA9IFRFWFQKLUJVR1dLRUZMIDogZmFzdC9ldmVudHMvbm9kZS1ldmVudC1hbmNob3It bG9jay5odG1sID0gVEVYVAotQlVHV0tFRkwgOiBmYXN0L2V2ZW50cy9zY3JvbGwtYWZ0ZXItY2xp Y2stb24tdGFiLWluZGV4Lmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6IGZhc3QvZm9ybXMvYXV0b2Nv bXBsZXRlLW9mZi13aXRoLWRlZmF1bHQtdmFsdWUtZG9lcy1ub3QtY2xlYXIuaHRtbCA9IFRFWFQK IEJVR1dLRUZMIDogZmFzdC9mb3Jtcy9sZWdlbmQtYWNjZXNzLWtleS5odG1sID0gVEVYVAogQlVH V0tFRkwgOiBmYXN0L2Zvcm1zL2xpc3Rib3gtZGVzZWxlY3Qtc2Nyb2xsLmh0bWwgPSBURVhUCkBA IC0yMzgsNyArMjM1LDYgQEAgQlVHV0tFRkwgOiBmYXN0L2Zvcm1zL3NlbGVjdC1tdWx0aXBsZS1l bGVtZW50cy13aXRoLW1vdXNlLWRyYWctd2l0aC1vcHRpb25zLWxlc3MKIEJVR1dLRUZMIDogZmFz dC9mb3Jtcy9zZWxlY3Qtd3JpdGluZy1kaXJlY3Rpb24tbmF0dXJhbC5odG1sID0gVEVYVAogQlVH V0tFRkwgOiBmYXN0L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS1pbi1yZWxhdGl2ZS1ib2R5Lmh0 bWwgPSBURVhUCiBCVUdXS0VGTCA6IGZhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLXRpbnku aHRtbCA9IFRFWFQKLUJVR1dLRUZMIDogZmFzdC9yZXBhaW50L2ZpeGVkLW1vdmUtYWZ0ZXIta2V5 Ym9hcmQtc2Nyb2xsLmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6IGZhc3QvcmVwbGFjZWQvbm8tZm9j dXMtcmluZy1lbWJlZC5odG1sID0gVEVYVAogQlVHV0tFRkwgOiBmYXN0L3JlcGxhY2VkL25vLWZv Y3VzLXJpbmctb2JqZWN0Lmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6IGZhc3Qvdmlld3BvcnQvdmll d3BvcnQtMTI4Lmh0bWwgPSBURVhUCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjU2ZDFkMi4uNjRjZGY1NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTA2ICBDaHJpc3RvcGhlIER1bWV6ICA8 Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBQcm92aWRl IGltcGxlbWVudGF0aW9uIGZvciBXZWJQYWdlOjpwZXJmb3JtRGVmYXVsdEJlaGF2aW9yRm9yS2V5 RXZlbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTU5NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ cm92aWRlIGltcGxlbWVudGF0aW9uIGZvciBXZWJQYWdlOjpwZXJmb3JtRGVmYXVsdEJlaGF2aW9y Rm9yS2V5RXZlbnQoKQorICAgICAgICBpbiBFRkwgV0syLgorCisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL2VmbC9XZWJQYWdlRWZsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6 cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcktleUV2ZW50KToKKwogMjAxMi0wOS0wNSAgUnl1YW4g Q2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBJbXBs ZW1lbnQgbWlzc2luZyBmZWF0dXJlIHRvIHN1cHBvcnQgPHNlbGVjdD4gdGFnCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZWZsL1dlYlBhZ2VFZmwuY3BwIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2VmbC9XZWJQYWdlRWZsLmNwcAppbmRl eCBmYTU3MDM1Li4wMDU3ZTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvZWZsL1dlYlBhZ2VFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9lZmwvV2ViUGFnZUVmbC5jcHAKQEAgLTYyLDggKzYyLDQ4IEBAIHN0YXRpYyBp bmxpbmUgdm9pZCBzY3JvbGwoUGFnZSogcGFnZSwgU2Nyb2xsRGlyZWN0aW9uIGRpcmVjdGlvbiwg U2Nyb2xsR3JhbnVsYXJpCiAKIGJvb2wgV2ViUGFnZTo6cGVyZm9ybURlZmF1bHRCZWhhdmlvckZv cktleUV2ZW50KGNvbnN0IFdlYktleWJvYXJkRXZlbnQmIGtleWJvYXJkRXZlbnQpCiB7Ci0gICAg bm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKGtleWJvYXJkRXZl bnQudHlwZSgpICE9IFdlYkV2ZW50OjpLZXlEb3duICYmIGtleWJvYXJkRXZlbnQudHlwZSgpICE9 IFdlYkV2ZW50OjpSYXdLZXlEb3duKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBzd2l0 Y2ggKGtleWJvYXJkRXZlbnQud2luZG93c1ZpcnR1YWxLZXlDb2RlKCkpIHsKKyAgICBjYXNlIFZL X0JBQ0s6CisgICAgICAgIGlmIChrZXlib2FyZEV2ZW50LnNoaWZ0S2V5KCkpCisgICAgICAgICAg ICBtX3BhZ2UtPmdvRm9yd2FyZCgpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBtX3BhZ2Ut PmdvQmFjaygpOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFZLX1NQQUNFOgorICAgICAgICBz Y3JvbGwobV9wYWdlLmdldCgpLCBrZXlib2FyZEV2ZW50LnNoaWZ0S2V5KCkgPyBTY3JvbGxVcCA6 IFNjcm9sbERvd24sIFNjcm9sbEJ5UGFnZSk7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgVktf TEVGVDoKKyAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwgU2Nyb2xsTGVmdCwgU2Nyb2xsQnlM aW5lKTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBWS19SSUdIVDoKKyAgICAgICAgc2Nyb2xs KG1fcGFnZS5nZXQoKSwgU2Nyb2xsUmlnaHQsIFNjcm9sbEJ5TGluZSk7CisgICAgICAgIGJyZWFr OworICAgIGNhc2UgVktfVVA6CisgICAgICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbFVw LCBTY3JvbGxCeUxpbmUpOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFZLX0RPV046CisgICAg ICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbERvd24sIFNjcm9sbEJ5TGluZSk7CisgICAg ICAgIGJyZWFrOworICAgIGNhc2UgVktfSE9NRToKKyAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQo KSwgU2Nyb2xsVXAsIFNjcm9sbEJ5RG9jdW1lbnQpOworICAgICAgICBicmVhazsKKyAgICBjYXNl IFZLX0VORDoKKyAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwgU2Nyb2xsRG93biwgU2Nyb2xs QnlEb2N1bWVudCk7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgVktfUFJJT1I6CisgICAgICAg IHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbFVwLCBTY3JvbGxCeVBhZ2UpOworICAgICAgICBi cmVhazsKKyAgICBjYXNlIFZLX05FWFQ6CisgICAgICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNj cm9sbERvd24sIFNjcm9sbEJ5UGFnZSk7CisgICAgICAgIGJyZWFrOworICAgIGRlZmF1bHQ6Cisg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogYm9v bCBXZWJQYWdlOjpwbGF0Zm9ybUhhc0xvY2FsRGF0YUZvclVSTChjb25zdCBLVVJMJikK