95891 2012-09-05 14:04:43 -0700 [CSS Shaders] Vertex attributes should be unbound after a custom filter is applied 2012-09-06 12:06:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71392 1 mvujovic mvujovic achicu dino jacobg webkit.review.bot oldest_to_newest 712521 0 mvujovic 2012-09-05 14:04:43 -0700 Chromium sometimes prints the following error message: "GL ERROR :GL_INVALID_OPERATION : glDrawElements: attempt to render with no buffer attached to enabled attribute 2" This happens in the following situation: 1) There are two FECustomFilters on the page. 2) One FECustomFilter has a detached mesh. One FECustomFilter has an attached mesh. The detached FECustomFilter has one more vertex attribute (a_triangleCoord) than the attached FECustomFilter. 3) The detached FECustomFilter is destroyed, but a_triangleCoord remains bound. 4) The attached FECustomFilter tries to render, but Chromium notices that there is no buffer attached to the a_triangleCoord attribute. We should unbind the vertex attributes after a custom filter is applied. 712689 1 162374 mvujovic 2012-09-05 17:09:00 -0700 Created attachment 162374 Patch 712735 2 dino 2012-09-05 18:18:47 -0700 Did you mean to r? this? 712740 3 achicu 2012-09-05 18:28:01 -0700 I think he did. Can you take a look please? 712835 4 mvujovic 2012-09-05 21:04:56 -0700 (In reply to comment #2) > Did you mean to r? this? Yup, thanks Dean! 713367 5 162374 mvujovic 2012-09-06 09:32:21 -0700 Comment on attachment 162374 Patch Bots look good. Setting cq?. 713409 6 dino 2012-09-06 10:15:17 -0700 You can put cq+ yourself in this case (no changes needed from r+). I'll do it now. 713450 7 162374 webkit.review.bot 2012-09-06 10:44:35 -0700 Comment on attachment 162374 Patch Clearing flags on attachment: 162374 Committed r127758: <http://trac.webkit.org/changeset/127758> 713451 8 webkit.review.bot 2012-09-06 10:44:39 -0700 All reviewed patches have been landed. Closing bug. 713551 9 mvujovic 2012-09-06 12:06:35 -0700 (In reply to comment #6) > You can put cq+ yourself in this case (no changes needed from r+). > > I'll do it now. Thanks Dean. I don't have committer status yet :) 162374 2012-09-05 17:09:00 -0700 2012-09-06 10:44:35 -0700 Patch 95891.patch text/plain 5028 mvujovic ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMWNiMzU5Li5lOTU4NDFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzgg QEAKKzIwMTItMDktMDUgIE1heCBWdWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgorCisgICAg ICAgIFtDU1MgU2hhZGVyc10gVmVydGV4IGF0dHJpYnV0ZXMgc2hvdWxkIGJlIHVuYm91bmQgYWZ0 ZXIgYSBjdXN0b20gZmlsdGVyIGlzIGFwcGxpZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk1ODkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm93IHdlIHVuYmluZCB0aGUgdmVydGV4IGF0dHJpYnV0ZXMg YWZ0ZXIgYSBjdXN0b20gZmlsdGVyIGlzIGFwcGxpZWQuCisKKyAgICAgICAgQmVmb3JlIHRoaXMg cGF0Y2gsIENocm9taXVtJ3MgR1BVIHByb2Nlc3Mgd291bGQgc29tZXRpbWVzIHByaW50IHRoZSBm b2xsb3dpbmcgZXJyb3IgbWVzc2FnZToKKyAgICAgICAgIkVSUk9SOmdsZXMyX2NtZF9kZWNvZGVy LmNjKDUxNDIpXSAwMDJDQTQ3QjogR0wgRVJST1IgOkdMX0lOVkFMSURfT1BFUkFUSU9OIDogCisg ICAgICAgIGdsRHJhd0VsZW1lbnRzOiBhdHRlbXB0IHRvIHJlbmRlciB3aXRoIG5vIGJ1ZmZlciBh dHRhY2hlZCB0byBlbmFibGVkIGF0dHJpYnV0ZSAyIgorCisgICAgICAgIFRoaXMgd291bGQgaGFw cGVuIGluIHRoZSBmb2xsb3dpbmcgc2l0dWF0aW9uOiAKKyAgICAgICAgMSkgVGhlcmUgYXJlIHR3 byBGRUN1c3RvbUZpbHRlcnMgb24gdGhlIHBhZ2UuCisgICAgICAgIDIpIE9uZSBGRUN1c3RvbUZp bHRlciBoYXMgYSBkZXRhY2hlZCBtZXNoLiBPbmUgRkVDdXN0b21GaWx0ZXIgaGFzIGFuIGF0dGFj aGVkIG1lc2guIFRoZSAKKyAgICAgICAgICAgZGV0YWNoZWQgRkVDdXN0b21GaWx0ZXIgaGFzIG9u ZSBtb3JlIHZlcnRleCBhdHRyaWJ1dGUgKGFfdHJpYW5nbGVDb29yZCkgdGhhbiB0aGUgYXR0YWNo ZWQKKyAgICAgICAgICAgRkVDdXN0b21GaWx0ZXIuCisgICAgICAgIDMpIFRoZSBkZXRhY2hlZCBG RUN1c3RvbUZpbHRlciBpcyBkZXN0cm95ZWQsIGJ1dCBhX3RyaWFuZ2xlQ29vcmQgcmVtYWlucyBi b3VuZC4KKyAgICAgICAgNCkgVGhlIGF0dGFjaGVkIEZFQ3VzdG9tRmlsdGVyIHRyaWVzIHRvIHJl bmRlciwgYnV0IENocm9taXVtIG5vdGljZXMgdGhhdCB0aGVyZSBpcyBubyBidWZmZXIKKyAgICAg ICAgICAgYXR0YWNoZWQgdG8gdGhlIGFfdHJpYW5nbGVDb29yZCBhdHRyaWJ1dGUuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLiBXZSBjYW4ndCBjcmVhdGUgYW4gYXV0b21hdGVkIHRlc3QgZm9yIHRo aXMgYmVjYXVzZSBpdCBvbmx5IHJlcHJvZHVjZXMgdXNpbmcKKyAgICAgICAgQ2hyb21pdW0ncyBH UFUgcHJvY2Vzcy4gRFJUIGRvZXMgbm90IHVzZSBDaHJvbWl1bSdzIEdQVSBwcm9jZXNzLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGRUN1c3RvbUZpbHRlcjo6YXBwbHlTaGFkZXIpOgorICAgICAgICAg ICAgVW5iaW5kIHRoZSB2ZXJ0ZXggYXR0cmlidXRlcyBhZnRlciB0aGUgZHJhd0VsZW1lbnRzIGNh bGwuCisgICAgICAgIChXZWJDb3JlOjpGRUN1c3RvbUZpbHRlcjo6dW5iaW5kVmVydGV4QXR0cmli dXRlKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6RkVDdXN0b21GaWx0 ZXI6OnVuYmluZFZlcnRleEF0dHJpYnV0ZXMpOgorICAgICAgICAgICAgVW5iaW5kIGFsbCBvZiB0 aGUgYXR0cmlidXRlcyB0aGF0IHdlIGJvdW5kIGVhcmxpZXIuCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5oOgorICAgICAgICAoRkVDdXN0b21GaWx0 ZXIpOgorCiAyMDEyLTA5LTA1ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBp bnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBQcm92aWRlIGltcGxlbWVudGF0aW9uIGZv ciBXZWJQcm9jZXNzIGZ1bmN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcAppbmRleCBmYjY3ZTIy Li5kNjVmZjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9m aWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmNwcApAQCAtMTg3LDYgKzE4Nyw4IEBAIGJv b2wgRkVDdXN0b21GaWx0ZXI6OmFwcGx5U2hhZGVyKCkKICAgICAKICAgICBtX2NvbnRleHQtPmRy YXdFbGVtZW50cyhHcmFwaGljc0NvbnRleHQzRDo6VFJJQU5HTEVTLCBtX21lc2gtPmluZGljZXND b3VudCgpLCBHcmFwaGljc0NvbnRleHQzRDo6VU5TSUdORURfU0hPUlQsIDApOwogICAgIAorICAg IHVuYmluZFZlcnRleEF0dHJpYnV0ZXMoKTsKKwogICAgIEFTU0VSVChzdGF0aWNfY2FzdDxzaXpl X3Q+KG5ld0NvbnRleHRTaXplLndpZHRoKCkgKiBuZXdDb250ZXh0U2l6ZS5oZWlnaHQoKSAqIDQp ID09IGRzdFBpeGVsQXJyYXktPmxlbmd0aCgpKTsKICAgICBtX2NvbnRleHQtPnJlYWRQaXhlbHMo MCwgMCwgbmV3Q29udGV4dFNpemUud2lkdGgoKSwgbmV3Q29udGV4dFNpemUuaGVpZ2h0KCksIEdy YXBoaWNzQ29udGV4dDNEOjpSR0JBLCBHcmFwaGljc0NvbnRleHQzRDo6VU5TSUdORURfQllURSwg ZHN0UGl4ZWxBcnJheS0+ZGF0YSgpKTsKIApAQCAtMjUzLDYgKzI1NSwxMiBAQCB2b2lkIEZFQ3Vz dG9tRmlsdGVyOjpiaW5kVmVydGV4QXR0cmlidXRlKGludCBhdHRyaWJ1dGVMb2NhdGlvbiwgdW5z aWduZWQgc2l6ZSwgdQogICAgIH0KIH0KIAordm9pZCBGRUN1c3RvbUZpbHRlcjo6dW5iaW5kVmVy dGV4QXR0cmlidXRlKGludCBhdHRyaWJ1dGVMb2NhdGlvbikKK3sKKyAgICBpZiAoYXR0cmlidXRl TG9jYXRpb24gIT0gLTEpCisgICAgICAgIG1fY29udGV4dC0+ZGlzYWJsZVZlcnRleEF0dHJpYkFy cmF5KGF0dHJpYnV0ZUxvY2F0aW9uKTsKK30KKwogdm9pZCBGRUN1c3RvbUZpbHRlcjo6YmluZFBy b2dyYW1OdW1iZXJQYXJhbWV0ZXJzKGludCB1bmlmb3JtTG9jYXRpb24sIEN1c3RvbUZpbHRlck51 bWJlclBhcmFtZXRlciogbnVtYmVyUGFyYW1ldGVyKQogewogICAgIHN3aXRjaCAobnVtYmVyUGFy YW1ldGVyLT5zaXplKCkpIHsKQEAgLTM2Niw2ICszNzQsMTYgQEAgdm9pZCBGRUN1c3RvbUZpbHRl cjo6YmluZFByb2dyYW1BbmRCdWZmZXJzKFVpbnQ4Q2xhbXBlZEFycmF5KiBzcmNQaXhlbEFycmF5 KQogICAgIGJpbmRQcm9ncmFtUGFyYW1ldGVycygpOwogfQogCit2b2lkIEZFQ3VzdG9tRmlsdGVy Ojp1bmJpbmRWZXJ0ZXhBdHRyaWJ1dGVzKCkKK3sKKyAgICB1bmJpbmRWZXJ0ZXhBdHRyaWJ1dGUo bV9jb21waWxlZFByb2dyYW0tPnBvc2l0aW9uQXR0cmliTG9jYXRpb24oKSk7CisgICAgdW5iaW5k VmVydGV4QXR0cmlidXRlKG1fY29tcGlsZWRQcm9ncmFtLT50ZXhBdHRyaWJMb2NhdGlvbigpKTsK KyAgICB1bmJpbmRWZXJ0ZXhBdHRyaWJ1dGUobV9jb21waWxlZFByb2dyYW0tPmludGVybmFsVGV4 Q29vcmRBdHRyaWJMb2NhdGlvbigpKTsKKyAgICB1bmJpbmRWZXJ0ZXhBdHRyaWJ1dGUobV9jb21w aWxlZFByb2dyYW0tPm1lc2hBdHRyaWJMb2NhdGlvbigpKTsKKyAgICBpZiAobV9tZXNoVHlwZSA9 PSBDdXN0b21GaWx0ZXJPcGVyYXRpb246OkRFVEFDSEVEKQorICAgICAgICB1bmJpbmRWZXJ0ZXhB dHRyaWJ1dGUobV9jb21waWxlZFByb2dyYW0tPnRyaWFuZ2xlQXR0cmliTG9jYXRpb24oKSk7Cit9 CisKIHZvaWQgRkVDdXN0b21GaWx0ZXI6OmR1bXAoKQogewogfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUN1c3RvbUZpbHRlci5oCmlu ZGV4IDUwNmE1MzguLjk2YmI5MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2ZpbHRlcnMvRkVDdXN0b21GaWx0ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ3VzdG9tRmlsdGVyLmgKQEAgLTgwLDEwICs4MCwx MiBAQCBwcml2YXRlOgogICAgIHZvaWQgZGVsZXRlUmVuZGVyQnVmZmVycygpOwogICAgIHZvaWQg cmVzaXplQ29udGV4dChjb25zdCBJbnRTaXplJiBuZXdDb250ZXh0U2l6ZSk7CiAgICAgdm9pZCBi aW5kVmVydGV4QXR0cmlidXRlKGludCBhdHRyaWJ1dGVMb2NhdGlvbiwgdW5zaWduZWQgc2l6ZSwg dW5zaWduZWQgb2Zmc2V0KTsKKyAgICB2b2lkIHVuYmluZFZlcnRleEF0dHJpYnV0ZShpbnQgYXR0 cmlidXRlTG9jYXRpb24pOwogICAgIHZvaWQgYmluZFByb2dyYW1OdW1iZXJQYXJhbWV0ZXJzKGlu dCB1bmlmb3JtTG9jYXRpb24sIEN1c3RvbUZpbHRlck51bWJlclBhcmFtZXRlciopOwogICAgIHZv aWQgYmluZFByb2dyYW1UcmFuc2Zvcm1QYXJhbWV0ZXIoaW50IHVuaWZvcm1Mb2NhdGlvbiwgQ3Vz dG9tRmlsdGVyVHJhbnNmb3JtUGFyYW1ldGVyKik7CiAgICAgdm9pZCBiaW5kUHJvZ3JhbVBhcmFt ZXRlcnMoKTsKICAgICB2b2lkIGJpbmRQcm9ncmFtQW5kQnVmZmVycyhVaW50OENsYW1wZWRBcnJh eSogc3JjUGl4ZWxBcnJheSk7CisgICAgdm9pZCB1bmJpbmRWZXJ0ZXhBdHRyaWJ1dGVzKCk7CiAg ICAgCiAgICAgLy8gTm8gbmVlZCB0byBrZWVwIGEgcmVmZXJlbmNlIGhlcmUuIEl0IGlzIG93bmVk IGJ5IHRoZSBSZW5kZXJWaWV3LgogICAgIEN1c3RvbUZpbHRlckdsb2JhbENvbnRleHQqIG1fZ2xv YmFsQ29udGV4dDsK