95863 2012-09-05 09:39:02 -0700 Make RenderStyle::colorIncludingFallback use private getters 2012-09-05 14:50:01 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bruno.abinader bruno.abinader eric igor.oliveira webkit.review.bot oldest_to_newest 712145 0 bruno.abinader 2012-09-05 09:39:02 -0700 For readibility and maintanability reasons, I'd suggest us to use private getters for visited* color variables. 712148 1 162268 bruno.abinader 2012-09-05 09:42:05 -0700 Created attachment 162268 Patch Proposed patch. 712162 2 162268 eric 2012-09-05 09:55:11 -0700 Comment on attachment 162268 Patch OK. 712559 3 162268 webkit.review.bot 2012-09-05 14:49:58 -0700 Comment on attachment 162268 Patch Clearing flags on attachment: 162268 Committed r127649: <http://trac.webkit.org/changeset/127649> 712560 4 webkit.review.bot 2012-09-05 14:50:01 -0700 All reviewed patches have been landed. Closing bug. 162268 2012-09-05 09:42:05 -0700 2012-09-05 14:49:58 -0700 Patch bug-95863-20120905124146.patch text/plain 4737 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjMxZTRmN2YzZjY5MWRm YzJjZTIyMTg4YjlmNDU3ODEwZGMzMmY2MS4uMDg5NTg1ZDdmYjlmZGRlODRiZDg3MTc5YjcyODU0 ODk0NzVlNzJhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTA1ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBNYWtlIFJlbmRlclN0eWxlOjpjb2xvckluY2x1ZGluZ0ZhbGxiYWNrIHVzZSBwcml2 YXRlIGdldHRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk1ODYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRm9yIHJlYWRpYmlsaXR5IGFuZCBtYWludGFuYWJpbGl0eSByZWFzb25zLCBpdCBpcyBiZXR0 ZXIgdG8gdXNlIGdldHRlcnMgZm9yCisgICAgICAgIHZpc2l0ZWQqIGNvbG9yIHZhcmlhYmxlcyB0 aGFuIGFjY2Vzc2luZyB0aGVtIGRpcmVjdGx5LgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxl L1JlbmRlclN0eWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclN0eWxlOjpjb2xvcklu Y2x1ZGluZ0ZhbGxiYWNrKToKKwogMjAxMi0wOS0wNSAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNs b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTk1JOiBleHRyYWN0IG92 ZXJsb2FkZWQgaW5zdHJ1bWVudGF0aW9uIG1lbWJlcnMgZm9yIFdlYkNvcmUgY2xhc3NlcyBmcm9t IGNvcmUgTk1JIGNvZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5 bGUvUmVuZGVyU3R5bGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRl clN0eWxlLmNwcAppbmRleCA3ZjAzMDJhMTdhOTU3MjYzOWU1ZWI3NDY0NTliZGJhYjE0OTRlZGIy Li5lMzA4OGUzYTQ2MmI0YWNjNzNjN2E3NTkxNTZkMGRmNzliMmM5MTMyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKQEAgLTEzMzUsNDAgKzEz MzUsNDAgQEAgQ29sb3IgUmVuZGVyU3R5bGU6OmNvbG9ySW5jbHVkaW5nRmFsbGJhY2soaW50IGNv bG9yUHJvcGVydHksIGJvb2wgdmlzaXRlZExpbmspIGMKICAgICBFQm9yZGVyU3R5bGUgYm9yZGVy U3R5bGUgPSBCTk9ORTsKICAgICBzd2l0Y2ggKGNvbG9yUHJvcGVydHkpIHsKICAgICBjYXNlIENT U1Byb3BlcnR5QmFja2dyb3VuZENvbG9yOgotICAgICAgICByZXR1cm4gdmlzaXRlZExpbmsgPyBy YXJlTm9uSW5oZXJpdGVkRGF0YS0+bV92aXNpdGVkTGlua0JhY2tncm91bmRDb2xvciA6IGJhY2tn cm91bmRDb2xvcigpOyAvLyBCYWNrZ3JvdW5kIGNvbG9yIGRvZXNuJ3QgZmFsbCBiYWNrLgorICAg ICAgICByZXR1cm4gdmlzaXRlZExpbmsgPyB2aXNpdGVkTGlua0JhY2tncm91bmRDb2xvcigpIDog YmFja2dyb3VuZENvbG9yKCk7IC8vIEJhY2tncm91bmQgY29sb3IgZG9lc24ndCBmYWxsIGJhY2su CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUJvcmRlckxlZnRDb2xvcjoKLSAgICAgICAgcmVzdWx0ID0g dmlzaXRlZExpbmsgPyByYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV92aXNpdGVkTGlua0JvcmRlckxl ZnRDb2xvciA6IGJvcmRlckxlZnRDb2xvcigpOworICAgICAgICByZXN1bHQgPSB2aXNpdGVkTGlu ayA/IHZpc2l0ZWRMaW5rQm9yZGVyTGVmdENvbG9yKCkgOiBib3JkZXJMZWZ0Q29sb3IoKTsKICAg ICAgICAgYm9yZGVyU3R5bGUgPSBib3JkZXJMZWZ0U3R5bGUoKTsKICAgICAgICAgYnJlYWs7CiAg ICAgY2FzZSBDU1NQcm9wZXJ0eUJvcmRlclJpZ2h0Q29sb3I6Ci0gICAgICAgIHJlc3VsdCA9IHZp c2l0ZWRMaW5rID8gcmFyZU5vbkluaGVyaXRlZERhdGEtPm1fdmlzaXRlZExpbmtCb3JkZXJSaWdo dENvbG9yIDogYm9yZGVyUmlnaHRDb2xvcigpOworICAgICAgICByZXN1bHQgPSB2aXNpdGVkTGlu ayA/IHZpc2l0ZWRMaW5rQm9yZGVyUmlnaHRDb2xvcigpIDogYm9yZGVyUmlnaHRDb2xvcigpOwog ICAgICAgICBib3JkZXJTdHlsZSA9IGJvcmRlclJpZ2h0U3R5bGUoKTsKICAgICAgICAgYnJlYWs7 CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUJvcmRlclRvcENvbG9yOgotICAgICAgICByZXN1bHQgPSB2 aXNpdGVkTGluayA/IHJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX3Zpc2l0ZWRMaW5rQm9yZGVyVG9w Q29sb3IgOiBib3JkZXJUb3BDb2xvcigpOworICAgICAgICByZXN1bHQgPSB2aXNpdGVkTGluayA/ IHZpc2l0ZWRMaW5rQm9yZGVyVG9wQ29sb3IoKSA6IGJvcmRlclRvcENvbG9yKCk7CiAgICAgICAg IGJvcmRlclN0eWxlID0gYm9yZGVyVG9wU3R5bGUoKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2Fz ZSBDU1NQcm9wZXJ0eUJvcmRlckJvdHRvbUNvbG9yOgotICAgICAgICByZXN1bHQgPSB2aXNpdGVk TGluayA/IHJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX3Zpc2l0ZWRMaW5rQm9yZGVyQm90dG9tQ29s b3IgOiBib3JkZXJCb3R0b21Db2xvcigpOworICAgICAgICByZXN1bHQgPSB2aXNpdGVkTGluayA/ IHZpc2l0ZWRMaW5rQm9yZGVyQm90dG9tQ29sb3IoKSA6IGJvcmRlckJvdHRvbUNvbG9yKCk7CiAg ICAgICAgIGJvcmRlclN0eWxlID0gYm9yZGVyQm90dG9tU3R5bGUoKTsKICAgICAgICAgYnJlYWs7 CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUNvbG9yOgotICAgICAgICByZXN1bHQgPSB2aXNpdGVkTGlu ayA/IGluaGVyaXRlZC0+dmlzaXRlZExpbmtDb2xvciA6IGNvbG9yKCk7CisgICAgICAgIHJlc3Vs dCA9IHZpc2l0ZWRMaW5rID8gdmlzaXRlZExpbmtDb2xvcigpIDogY29sb3IoKTsKICAgICAgICAg YnJlYWs7CiAgICAgY2FzZSBDU1NQcm9wZXJ0eU91dGxpbmVDb2xvcjoKLSAgICAgICAgcmVzdWx0 ID0gdmlzaXRlZExpbmsgPyByYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV92aXNpdGVkTGlua091dGxp bmVDb2xvciA6IG91dGxpbmVDb2xvcigpOworICAgICAgICByZXN1bHQgPSB2aXNpdGVkTGluayA/ IHZpc2l0ZWRMaW5rT3V0bGluZUNvbG9yKCkgOiBvdXRsaW5lQ29sb3IoKTsKICAgICAgICAgYnJl YWs7CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdENvbHVtblJ1bGVDb2xvcjoKLSAgICAgICAg cmVzdWx0ID0gdmlzaXRlZExpbmsgPyByYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV9tdWx0aUNvbC0+ bV92aXNpdGVkTGlua0NvbHVtblJ1bGVDb2xvciA6IGNvbHVtblJ1bGVDb2xvcigpOworICAgICAg ICByZXN1bHQgPSB2aXNpdGVkTGluayA/IHZpc2l0ZWRMaW5rQ29sdW1uUnVsZUNvbG9yKCkgOiBj b2x1bW5SdWxlQ29sb3IoKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdl YmtpdFRleHRFbXBoYXNpc0NvbG9yOgotICAgICAgICByZXN1bHQgPSB2aXNpdGVkTGluayA/IHJh cmVJbmhlcml0ZWREYXRhLT52aXNpdGVkTGlua1RleHRFbXBoYXNpc0NvbG9yIDogdGV4dEVtcGhh c2lzQ29sb3IoKTsKKyAgICAgICAgcmVzdWx0ID0gdmlzaXRlZExpbmsgPyB2aXNpdGVkTGlua1Rl eHRFbXBoYXNpc0NvbG9yKCkgOiB0ZXh0RW1waGFzaXNDb2xvcigpOwogICAgICAgICBicmVhazsK ICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VGV4dEZpbGxDb2xvcjoKLSAgICAgICAgcmVzdWx0 ID0gdmlzaXRlZExpbmsgPyByYXJlSW5oZXJpdGVkRGF0YS0+dmlzaXRlZExpbmtUZXh0RmlsbENv bG9yIDogdGV4dEZpbGxDb2xvcigpOworICAgICAgICByZXN1bHQgPSB2aXNpdGVkTGluayA/IHZp c2l0ZWRMaW5rVGV4dEZpbGxDb2xvcigpIDogdGV4dEZpbGxDb2xvcigpOwogICAgICAgICBicmVh azsKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VGV4dFN0cm9rZUNvbG9yOgotICAgICAgICBy ZXN1bHQgPSB2aXNpdGVkTGluayA/IHJhcmVJbmhlcml0ZWREYXRhLT52aXNpdGVkTGlua1RleHRT dHJva2VDb2xvciA6IHRleHRTdHJva2VDb2xvcigpOworICAgICAgICByZXN1bHQgPSB2aXNpdGVk TGluayA/IHZpc2l0ZWRMaW5rVGV4dFN0cm9rZUNvbG9yKCkgOiB0ZXh0U3Ryb2tlQ29sb3IoKTsK ICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVE KCk7CkBAIC0xMzc5LDcgKzEzNzksNyBAQCBDb2xvciBSZW5kZXJTdHlsZTo6Y29sb3JJbmNsdWRp bmdGYWxsYmFjayhpbnQgY29sb3JQcm9wZXJ0eSwgYm9vbCB2aXNpdGVkTGluaykgYwogICAgICAg ICBpZiAoIXZpc2l0ZWRMaW5rICYmIChib3JkZXJTdHlsZSA9PSBJTlNFVCB8fCBib3JkZXJTdHls ZSA9PSBPVVRTRVQgfHwgYm9yZGVyU3R5bGUgPT0gUklER0UgfHwgYm9yZGVyU3R5bGUgPT0gR1JP T1ZFKSkKICAgICAgICAgICAgIHJlc3VsdC5zZXRSR0IoMjM4LCAyMzgsIDIzOCk7CiAgICAgICAg IGVsc2UKLSAgICAgICAgICAgIHJlc3VsdCA9IHZpc2l0ZWRMaW5rID8gaW5oZXJpdGVkLT52aXNp dGVkTGlua0NvbG9yIDogY29sb3IoKTsKKyAgICAgICAgICAgIHJlc3VsdCA9IHZpc2l0ZWRMaW5r ID8gdmlzaXRlZExpbmtDb2xvcigpIDogY29sb3IoKTsKICAgICB9CiAgICAgcmV0dXJuIHJlc3Vs dDsKIH0K