95831 2012-09-05 02:04:06 -0700 [Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows. 2012-09-06 22:45:04 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94082 1 morrita morrita cmarcelo mifenton tkent webcomponents-bugzilla webkit.review.bot oldest_to_newest 711852 0 morrita 2012-09-05 02:04:06 -0700 Each element subclasses should have a method to reject author shadows to protect its UA shadow. Currently we have such checkin ShadowRoot but it should be handled by each element. 711887 1 162202 morrita 2012-09-05 03:20:12 -0700 Created attachment 162202 Patch 711891 2 162202 morrita 2012-09-05 03:21:45 -0700 Comment on attachment 162202 Patch Attached a wrong patch... 711895 3 162206 morrita 2012-09-05 03:23:20 -0700 Created attachment 162206 Patch 711971 4 162206 buildbot 2012-09-05 05:27:58 -0700 Comment on attachment 162206 Patch Attachment 162206 did not pass win-ews (win): Output: http://queues.webkit.org/results/13765174 712092 5 162206 dglazkov 2012-09-05 08:45:16 -0700 Comment on attachment 162206 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162206&action=review The change is good, but needs spelling fixes and a rename to plural. > Source/WebCore/ChangeLog:9 > + This chagne moves that responsibility to each Element subclasses to let coming chagne->change, and "to let coming" -> "to make future" > Source/WebCore/ChangeLog:10 > + author shdaow support improvement local to each replaced elements, rather than shdaow->shadow :) > Source/WebCore/html/HTMLInputElement.h:295 > + virtual bool isAuthorShadowsAllowed() const OVERRIDE { return false; } is->are 712722 6 162385 morrita 2012-09-05 18:01:36 -0700 Created attachment 162385 Patch 712723 7 morrita 2012-09-05 18:03:16 -0700 Thanks for take a look, Dimitri! I kicked my ashamed misspelling out. Could you PTAL? 713982 8 morrita 2012-09-06 18:40:21 -0700 Dimitri: ping? I want this to mask some unpolished elements. 713990 9 162385 morrita 2012-09-06 18:50:02 -0700 Comment on attachment 162385 Patch Thanks ;-) 714019 10 162385 webkit.review.bot 2012-09-06 19:25:14 -0700 Comment on attachment 162385 Patch Clearing flags on attachment: 162385 Committed r127811: <http://trac.webkit.org/changeset/127811> 714020 11 webkit.review.bot 2012-09-06 19:25:18 -0700 All reviewed patches have been landed. Closing bug. 714099 12 162385 esprehn 2012-09-06 22:03:48 -0700 Comment on attachment 162385 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162385&action=review > Source/WebCore/svg/SVGElement.h:141 > + virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; } Note that all SVG elements inherit from SVGElement. If this was to return true you'd allow attaching shadows to things like <path> and <rect> which doesn't make any sense. This should only ever return true from SVGSVGElement.h 714126 13 morrita 2012-09-06 22:45:04 -0700 (In reply to comment #12) > > Note that all SVG elements inherit from SVGElement. If this was to return true you'd allow attaching shadows to things like <path> and <rect> which doesn't make any sense. > > This should only ever return true from SVGSVGElement.h Could you elaborate? Currently SVG uses ShadowRoot in some tricky way and we don't make it work with author shadows yet. This is why we prohibit author shadows here. It has been like that from the beginning and this patch just clarifies what we've been doing and has no behavioral change. Does this make sense? 162202 2012-09-05 03:20:12 -0700 2012-09-05 03:21:45 -0700 Patch bug-95831-20120905191954.patch text/plain 4650 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNmNTQ4N2FjNTYyMmY3 ZTAzY2RmNjAzNDdiYjI4NDJkNTYwZjgxZi4uYjA0ODU5Y2MyMzQzZmFiNDk5NzgyOTlkNDE1NmZl ZjFhODdmNjY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA5LTA1ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFtTaGFkb3cgRE9NXVtS ZWZhY3RvcmluZ10gRWxlbWVudCBzdWJjbGFzc2VzIHNob3VsZCBoYXZlIGEgd2F5IHRvIHJlamVj dCBhdXRob3Igc2hhZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk1ODMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBjaGFuZ2UgaW1wbGVtZW50IFNoYWRvd1Jvb3Q6OmNsb25lTm9kZSgpIHdo aWNoIHRocm93cyBhbiBleGNlcHRpb24uCisgICAgICAgIFRoaXMgYWxzbyBhZGRzIGFuIG92ZXJs b2FkZWQgdmVyc2lvbiBjbG9uZU5vZGUoKSB0byBTaGFkb3dSb290LmlkbAorICAgICAgICB3aGlj aCBpcyBlbmFibGVkIG9ubHkgZm9yIEphdmFTY3JpcHQgaW5zdGVhZCBvZiBjaGFuZ2luZyB0aGUK KyAgICAgICAgc2lnbmF0dXJlIG9mIE5vZGU6OmNsb25lTm9kZSgpLgorCisgICAgICAgIE5vdGUg dGhhdCBjaGFuZ2luZyB0aGUgZXhpc3Rpbmcgc2lnbmF0dXJlIGNhbiBicmVhayBHT2JqZWN0IGJp bmRpbmdzCisgICAgICAgIGNvbXBhdGliaWxpdHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChP T1BTISkuCisKKyAgICAgICAgKiBkb20vU2hhZG93Um9vdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTaGFkb3dSb290OjpjbG9uZU5vZGUpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICog ZG9tL1NoYWRvd1Jvb3QuaDoKKyAgICAgICAgKFNoYWRvd1Jvb3QpOgorICAgICAgICAqIGRvbS9T aGFkb3dSb290LmlkbDoKKwogMjAxMi0wOS0wNSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXggZm9yIFdpbkNFIGFmdGVyIHIxMjc1MjUu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAKaW5kZXggNWRhZjc2NDFlNGE4YTBmNWNhNDM4MzE3 YTdmMjY2NjMzZTZlMjI2NS4uNmI3MzA2OGM3MWNjNTI2NjMwNzdlMTBiNWQ1Yjc1OTg5ZmEyZDUw YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcApAQCAtMTQ1LDYgKzE0NSwxNyBAQCBQYXNz UmVmUHRyPE5vZGU+IFNoYWRvd1Jvb3Q6OmNsb25lTm9kZShib29sKQogICAgIHJldHVybiAwOwog fQogCitQYXNzUmVmUHRyPE5vZGU+IFNoYWRvd1Jvb3Q6OmNsb25lTm9kZShib29sIGRlZXAsIEV4 Y2VwdGlvbkNvZGUmIGVjKQoreworICAgIFJlZlB0cjxOb2RlPiBjbG9uZSA9IGNsb25lTm9kZShk ZWVwKTsKKyAgICBpZiAoIWNsb25lKSB7CisgICAgICAgIGVjID0gREFUQV9DTE9ORV9FUlI7Cisg ICAgICAgIHJldHVybiAwOworICAgIH0KKworICAgIHJldHVybiBjbG9uZTsKK30KKwogU3RyaW5n IFNoYWRvd1Jvb3Q6OmlubmVySFRNTCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGNyZWF0ZU1hcmt1 cCh0aGlzLCBDaGlsZHJlbk9ubHkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1No YWRvd1Jvb3QuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmgKaW5kZXggZDliNDI1 YzYwODNiMTdhZjg4MjZlNjE2NDI3ODFmNTUyNTA3NTI1MC4uNmY3MDA5ZDA5MWM2OTc5ZGJiZGRl YjU2MzYyODMzZmU0Y2JkNjU5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRv d1Jvb3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5oCkBAIC05Myw2ICs5 Myw4IEBAIHB1YmxpYzoKICAgICBTaGFkb3dSb290VHlwZSB0eXBlKCkgY29uc3QgeyByZXR1cm4g bV90eXBlOyB9CiAjZW5kaWYKIAorICAgIFBhc3NSZWZQdHI8Tm9kZT4gY2xvbmVOb2RlKGJvb2ws IEV4Y2VwdGlvbkNvZGUmKTsKKwogcHJpdmF0ZToKICAgICBleHBsaWNpdCBTaGFkb3dSb290KERv Y3VtZW50Kik7CiAgICAgdmlydHVhbCB+U2hhZG93Um9vdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jv b3QuaWRsCmluZGV4IGMwNGMzZTE1ZDUwZTZjODQ3NDhhNTNiNjNmMTI2ZmEyYTM4YjI0NGYuLjll OTkzMjM0OTg2NWFlYzIzMDdkNzI2OGNhZjc1NTY0MTc3YjAyMzQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hh ZG93Um9vdC5pZGwKQEAgLTM5LDYgKzM5LDkgQEAgbW9kdWxlIGNvcmUgewogICAgICAgICBhdHRy aWJ1dGUgW1RyZWF0TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBpbm5lckhUTUwKICAgICAg ICAgICAgIHNldHRlciByYWlzZXMoRE9NRXhjZXB0aW9uKTsKIAorI2lmIGRlZmluZWQoTEFOR1VB R0VfSkFWQVNDUklQVCkgJiYgTEFOR1VBR0VfSkFWQVNDUklQVAorICAgICAgICBOb2RlIGNsb25l Tm9kZShpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVkXSBib29sZWFuIGRlZXApIHJhaXNl cyhET01FeGNlcHRpb24pOworI2VuZGlmCiAgICAgICAgIERPTVNlbGVjdGlvbiBnZXRTZWxlY3Rp b24oKTsKICAgICAgICAgRWxlbWVudCBnZXRFbGVtZW50QnlJZChpbiBbT3B0aW9uYWw9RGVmYXVs dElzVW5kZWZpbmVkXSBET01TdHJpbmcgZWxlbWVudElkKTsKICAgICAgICAgTm9kZUxpc3QgZ2V0 RWxlbWVudHNCeUNsYXNzTmFtZShpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVkXSBET01T dHJpbmcgY2xhc3NOYW1lKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRv dy9zaGFkb3dyb290LWNsb25lbm9kZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Rv bS9zaGFkb3cvc2hhZG93cm9vdC1jbG9uZW5vZGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdk OGQ5ZTg4MWNmMWMwNWYwODY4ZmVkZTU5YWRmYzI4NzAzNzg5Y2EKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93cm9vdC1jbG9uZW5vZGUtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK0NhbGxpbmcgU2hhZG93Um9vdC5jbG9uZU5vZGUoKSBz aG91bGQgdGhyb3cgYSBEQVRBX0NMT05FX0VSUiBleGNlcHRpb24uCisKK09uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KKworCitQQVNTIGV4Y2VwdGlvbkNvZGUgaXMgRE9NRXhjZXB0aW9uLkRBVEFf Q0xPTkVfRVJSCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExF VEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvd3Jvb3Qt Y2xvbmVub2RlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93cm9vdC1j bG9uZW5vZGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xMTBkY2Q3ZGQ1YzAwM2FhZWZjZjMzODRlYjkzNzJk MDM2MTdmNWQyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93 L3NoYWRvd3Jvb3QtY2xvbmVub2RlLmh0bWwKQEAgLTAsMCArMSwyNiBAQAorPCFET0NUWVBFPgor PGh0bWw+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcG9seWZpbGwuanMiPjwvc2NyaXB0Pgor Cis8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KKworPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdDYWxs aW5nIFNoYWRvd1Jvb3QuY2xvbmVOb2RlKCkgc2hvdWxkIHRocm93IGEgREFUQV9DTE9ORV9FUlIg ZXhjZXB0aW9uLicpOworCit2YXIgaG9zdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2Rpdicp OwordmFyIHNoYWRvd1Jvb3QgPSBuZXcgV2ViS2l0U2hhZG93Um9vdChob3N0KTsKKwordmFyIGV4 Y2VwdGlvbkNvZGUgPSBudWxsOwordHJ5IHsKKyAgICBzaGFkb3dSb290LmNsb25lTm9kZSgpCit9 IGNhdGNoIChlKSB7CisgICAgZXhjZXB0aW9uQ29kZSA9IGUuY29kZTsKK30KKworc2hvdWxkQmUo J2V4Y2VwdGlvbkNvZGUnLCAnRE9NRXhjZXB0aW9uLkRBVEFfQ0xPTkVfRVJSJykKKworZmluaXNo SlNUZXN0KCk7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvaHRtbD4K 162206 2012-09-05 03:23:20 -0700 2012-09-05 18:01:32 -0700 Patch bug-95831-20120905192302.patch text/plain 4451 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNmNTQ4N2FjNTYyMmY3 ZTAzY2RmNjAzNDdiYjI4NDJkNTYwZjgxZi4uMjljOTc4OWM4NzAyNGFmYWI0NDM1ZjNlMjY3NGY0 YWQ0YTRjYmRjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTA1ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFtTaGFkb3cgRE9NXVtS ZWZhY3RvcmluZ10gRWxlbWVudCBzdWJjbGFzc2VzIHNob3VsZCBoYXZlIGEgd2F5IHRvIHJlamVj dCBhdXRob3Igc2hhZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk1ODMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgT3JpZ2luYWxseSwgdGhlIGF2YWlsYWJpbGl0eSBvZiBhdXRob3Igc2hhZG93cyB3 YXMgZGVjaWRlZCBieSBTaGFkb3dSb290IGNsYXNzLgorICAgICAgICBUaGlzIGNoYWduZSBtb3Zl cyB0aGF0IHJlc3BvbnNpYmlsaXR5IHRvIGVhY2ggRWxlbWVudCBzdWJjbGFzc2VzIHRvIGxldCBj b21pbmcKKyAgICAgICAgYXV0aG9yIHNoZGFvdyBzdXBwb3J0IGltcHJvdmVtZW50IGxvY2FsIHRv IGVhY2ggcmVwbGFjZWQgZWxlbWVudHMsIHJhdGhlciB0aGFuCisgICAgICAgIHRvdWNoaW5nIFNo YWRvd1Jvb3QuY3BwIGZvciByZWFjaC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFNob3VsZCBo YXZlIG5vIGJlaGF2aW9yYWwgY2hhbmdlLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuaDoKKyAg ICAgICAgKiBkb20vU2hhZG93Um9vdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjphbGxvd3NBdXRo b3JTaGFkb3dSb290KToKKyAgICAgICAgKiBodG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50 Lmg6CisgICAgICAgIChIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudCk6CisgICAgICAgICogc3Zn L1NWR0VsZW1lbnQuaDoKKyAgICAgICAgKFNWR0VsZW1lbnQpOgorCiAyMDEyLTA5LTA1ICBQYXRy aWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeCBm b3IgV2luQ0UgYWZ0ZXIgcjEyNzUyNS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCmluZGV4IDE0MGJjMGJhM2Ew Mjc0YmMxYTA1MzM0YjA4YzkyNmJhMzQ1NmRkNTguLjE5ZTQ5NjQyMDM3YjhiODc0YjIwZmJiOGQy ZDc0Y2VkMWE1ZmJlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaApAQCAtMjc1LDYgKzI3NSw3IEBAIHB1 YmxpYzoKICAgICBFbGVtZW50U2hhZG93KiBzaGFkb3coKSBjb25zdDsKICAgICBFbGVtZW50U2hh ZG93KiBlbnN1cmVTaGFkb3coKTsKICAgICB2aXJ0dWFsIHZvaWQgd2lsbEFkZEF1dGhvclNoYWRv d1Jvb3QoKSB7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNBdXRob3JTaGFkb3dzQWxsb3dlZCgpIGNv bnN0IE9WRVJSSURFIHsgcmV0dXJuIHRydWU7IH0KIAogICAgIFNoYWRvd1Jvb3QqIHVzZXJBZ2Vu dFNoYWRvd1Jvb3QoKSBjb25zdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1No YWRvd1Jvb3QuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwCmluZGV4IDVk YWY3NjQxZTRhOGEwZjVjYTQzODMxN2E3ZjI2NjYzM2U2ZTIyNjUuLmI0N2UzMDUwMDM2YTBlMWY3 NzdhNGJmZWY5YWY2YTE1MjkxZTc5MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9T aGFkb3dSb290LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAKQEAg LTgyLDIzICs4Miw3IEBAIHN0YXRpYyBib29sIGFsbG93c0F1dGhvclNoYWRvd1Jvb3QoRWxlbWVu dCogZWxlbWVudCkKICAgICBpZiAoUnVudGltZUVuYWJsZWRGZWF0dXJlczo6YXV0aG9yU2hhZG93 RE9NRm9yQW55RWxlbWVudEVuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAjZW5kaWYK LQotICAgIC8vIEZJWE1FOiBUaGUgZWxlbWVudHMgaW4gU2hhZG93IERPTSBvZiBhbiBpbnB1dCBl bGVtZW50IGFzc3VtZXMgdGhhdCB0aGV5IGhhdmUgcmVuZGVyZXIgaWYgdGhlIGlucHV0Ci0gICAg Ly8gZWxlbWVudCBoYXMgYSByZW5kZXJlci4gSG93ZXZlciwgdGhpcyBkb2VzIG5vdCBob2xkIHVu dGlsIGlucHV0IGVsZW1uZXQgaXMgQXV0aG9yU2hhZG93RE9NLXJlYWR5LgotICAgIC8vIFNvIHdl IHdvdWxkIGxpa2UgdG8gcHJvaGliaXQgaGF2aW5nIGEgQXV0aG9yU2hhZG93RE9NIGZvciBhIHdo aWxlLiBUaGUgc2FtZSB0aGluZyBoYXBwZW5zIHRvCi0gICAgLy8gdGV4dGFyZWEgZWxlbWVudCBh bHNvLgotICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjYw OAotICAgIGlmIChpc0hUTUxJbnB1dEVsZW1lbnQoZWxlbWVudCkpCi0gICAgICAgIHJldHVybiBm YWxzZTsKLQotICAgIC8vIEZJWE1FOiBXZSBkaXNhYmxlIG11bHRpcGxlIHNoYWRvdyBzdWJ0cmVl cyBmb3IgU1ZHIGZvciB3aGlsZSwgYmVjYXVzZSB0aGVyZSB3aWxsIGJlIHByb2JsZW1zIHRvIHN1 cHBvcnQgaXQuCi0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc4MjA1Ci0gICAgLy8gRXNwZWNpYWxseSBTVkcgVFJFRiByZWNyZWF0ZXMgc2hhZG93IHJvb3Qg ZHluYW1pY2FsbHkuCi0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc3OTM4Ci0gICAgaWYgKGVsZW1lbnQtPmlzU1ZHRWxlbWVudCgpKQotICAgICAgICByZXR1 cm4gZmFsc2U7Ci0KLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gZWxlbWVudC0+aXNBdXRo b3JTaGFkb3dzQWxsb3dlZCgpOwogfQogCiBQYXNzUmVmUHRyPFNoYWRvd1Jvb3Q+IFNoYWRvd1Jv b3Q6OmNyZWF0ZShFbGVtZW50KiBlbGVtZW50LCBFeGNlcHRpb25Db2RlJiBlYykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKaW5kZXggMGY5YzQ1YTQ0Y2NkMmMyMjIxNzU3ZTUx NmYxMTFkZTg5YjA1Mzk5Ni4uY2ZiM2NlMTU0MThiZWQxNGZiYTZjZWNhZDk1ODQyNDBiNjE5YTUx MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKQEAgLTI5MCw2ICsyOTAs OSBAQCBwcm90ZWN0ZWQ6CiAgICAgSFRNTElucHV0RWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1l JiwgRG9jdW1lbnQqLCBIVE1MRm9ybUVsZW1lbnQqLCBib29sIGNyZWF0ZWRCeVBhcnNlcik7CiAg ICAgdm9pZCBjcmVhdGVTaGFkb3dTdWJ0cmVlKCk7CiAgICAgdmlydHVhbCB2b2lkIGRlZmF1bHRF dmVudEhhbmRsZXIoRXZlbnQqKTsKKyAgICAvLyBGSVhNRTogQXV0aG9yIHNoYWRvd3Mgc2hvdWxk IGJlIGFsbG93ZWQKKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTI2MDgKKyAgICB2aXJ0dWFsIGJvb2wgaXNBdXRob3JTaGFkb3dzQWxsb3dlZCgpIGNvbnN0 IE9WRVJSSURFIHsgcmV0dXJuIGZhbHNlOyB9CiAKIHByaXZhdGU6CiAgICAgZW51bSBBdXRvQ29t cGxldGVTZXR0aW5nIHsgVW5pbml0aWFsaXplZCwgT24sIE9mZiB9OwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVt ZW50LmgKaW5kZXggOTAwYjYxNDU0NWMwN2Y5NzI2YTM1OTRiZWY1M2E5OGNmNWY4NjA4MS4uODM5 ODA4ZmM0ZDNmYTc0ZTMwZmRkZTFiYmExZTEyNDFmYmNjMzk3NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxl bWVudC5oCkBAIC0xMzYsNiArMTM2LDEwIEBAIHByb3RlY3RlZDoKIAogICAgIHZvaWQgcmVwb3J0 QXR0cmlidXRlUGFyc2luZ0Vycm9yKFNWR1BhcnNpbmdFcnJvciwgY29uc3QgQXR0cmlidXRlJik7 CiAKKyAgICAvLyBGSVhNRTogQXV0aG9yIHNoYWRvd3Mgc2hvdWxkIGJlIGFsbG93ZWQKKyAgICAv LyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc5MzgKKyAgICB2aXJ0 dWFsIGJvb2wgaXNBdXRob3JTaGFkb3dzQWxsb3dlZCgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJu IGZhbHNlOyB9CisKIHByaXZhdGU6CiAgICAgZnJpZW5kIGNsYXNzIFNWR0VsZW1lbnRJbnN0YW5j ZTsKIAo= 162385 2012-09-05 18:01:36 -0700 2012-09-06 22:03:48 -0700 Patch bug-95831-20120906100117.patch text/plain 4468 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRmMDViY2FkYTY3NGFh YmJkMzA1NTYzMmMwOGQwNjZiNmIyYWNmOC4uNDJmMzJhODBlYzE0Njg2NTFmMTUyZjA1ODNlYTFj MWVlYzgyM2JjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTA1ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFtTaGFkb3cgRE9NXVtS ZWZhY3RvcmluZ10gRWxlbWVudCBzdWJjbGFzc2VzIHNob3VsZCBoYXZlIGEgd2F5IHRvIHJlamVj dCBhdXRob3Igc2hhZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk1ODMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgT3JpZ2luYWxseSwgdGhlIGF2YWlsYWJpbGl0eSBvZiBhdXRob3Igc2hhZG93cyB3 YXMgZGVjaWRlZCBieSBTaGFkb3dSb290IGNsYXNzLgorICAgICAgICBUaGlzIGNoYW5nZSBtb3Zl cyB0aGF0IHJlc3BvbnNpYmlsaXR5IHRvIGVhY2ggRWxlbWVudCBzdWJjbGFzc2VzIHRvIG1ha2Ug ZnV0dXJlCisgICAgICAgIGF1dGhvciBzaGFkb3cgc3VwcG9ydCBpbXByb3ZlbWVudCBsb2NhbCB0 byBlYWNoIHJlcGxhY2VkIGVsZW1lbnRzLCByYXRoZXIgdGhhbgorICAgICAgICB0b3VjaGluZyBT aGFkb3dSb290LmNwcCBmb3IgcmVhY2guCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBTaG91bGQg aGF2ZSBubyBiZWhhdmlvcmFsIGNoYW5nZS4KKworICAgICAgICAqIGRvbS9FbGVtZW50Lmg6Cisg ICAgICAgICogZG9tL1NoYWRvd1Jvb3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YWxsb3dzQXV0 aG9yU2hhZG93Um9vdCk6CisgICAgICAgICogaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVu dC5oOgorICAgICAgICAoSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQpOgorICAgICAgICAqIHN2 Zy9TVkdFbGVtZW50Lmg6CisgICAgICAgIChTVkdFbGVtZW50KToKKwogMjAxMi0wOS0wNSAgS2Vu aWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVt XSBVbnJldmlld2VkLCBidWlsZCBmaXggYXR0ZW1wdCBhZnRlciByMTI3NjYwCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnQuaAppbmRleCA5MDI1ZmI3MTg1OWU0ZmZjMTEwODkyMzE5MTlmZDhmNmFhN2IzNGUxLi5jZTUw NTQ2M2NkMTc4ODM1ODllZDVjZDE5YmFjZjRjYjZmYTAwMTZiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgK QEAgLTI3NSw2ICsyNzUsNyBAQCBwdWJsaWM6CiAgICAgRWxlbWVudFNoYWRvdyogc2hhZG93KCkg Y29uc3Q7CiAgICAgRWxlbWVudFNoYWRvdyogZW5zdXJlU2hhZG93KCk7CiAgICAgdmlydHVhbCB2 b2lkIHdpbGxBZGRBdXRob3JTaGFkb3dSb290KCkgeyB9CisgICAgdmlydHVhbCBib29sIGFyZUF1 dGhvclNoYWRvd3NBbGxvd2VkKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogCiAgICAgU2hhZG93 Um9vdCogdXNlckFnZW50U2hhZG93Um9vdCgpIGNvbnN0OwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9v dC5jcHAKaW5kZXggNmI3MzA2OGM3MWNjNTI2NjMwNzdlMTBiNWQ1Yjc1OTg5ZmEyZDUwYy4uOWU5 YWJjNDM4Mzk4MjVmZGU3OWE5ODhjNDE1OTIwMTRkM2NhNmY1YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFk b3dSb290LmNwcApAQCAtODIsMjMgKzgyLDcgQEAgc3RhdGljIGJvb2wgYWxsb3dzQXV0aG9yU2hh ZG93Um9vdChFbGVtZW50KiBlbGVtZW50KQogICAgIGlmIChSdW50aW1lRW5hYmxlZEZlYXR1cmVz OjphdXRob3JTaGFkb3dET01Gb3JBbnlFbGVtZW50RW5hYmxlZCgpKQogICAgICAgICByZXR1cm4g dHJ1ZTsKICNlbmRpZgotCi0gICAgLy8gRklYTUU6IFRoZSBlbGVtZW50cyBpbiBTaGFkb3cgRE9N IG9mIGFuIGlucHV0IGVsZW1lbnQgYXNzdW1lcyB0aGF0IHRoZXkgaGF2ZSByZW5kZXJlciBpZiB0 aGUgaW5wdXQKLSAgICAvLyBlbGVtZW50IGhhcyBhIHJlbmRlcmVyLiBIb3dldmVyLCB0aGlzIGRv ZXMgbm90IGhvbGQgdW50aWwgaW5wdXQgZWxlbW5ldCBpcyBBdXRob3JTaGFkb3dET00tcmVhZHku Ci0gICAgLy8gU28gd2Ugd291bGQgbGlrZSB0byBwcm9oaWJpdCBoYXZpbmcgYSBBdXRob3JTaGFk b3dET00gZm9yIGEgd2hpbGUuIFRoZSBzYW1lIHRoaW5nIGhhcHBlbnMgdG8KLSAgICAvLyB0ZXh0 YXJlYSBlbGVtZW50IGFsc28uCi0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkyNjA4Ci0gICAgaWYgKGlzSFRNTElucHV0RWxlbWVudChlbGVtZW50KSkKLSAg ICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgLy8gRklYTUU6IFdlIGRpc2FibGUgbXVsdGlwbGUg c2hhZG93IHN1YnRyZWVzIGZvciBTVkcgZm9yIHdoaWxlLCBiZWNhdXNlIHRoZXJlIHdpbGwgYmUg cHJvYmxlbXMgdG8gc3VwcG9ydCBpdC4KLSAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzgyMDUKLSAgICAvLyBFc3BlY2lhbGx5IFNWRyBUUkVGIHJlY3JlYXRl cyBzaGFkb3cgcm9vdCBkeW5hbWljYWxseS4KLSAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Nzc5MzgKLSAgICBpZiAoZWxlbWVudC0+aXNTVkdFbGVtZW50KCkp Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIHJldHVybiB0cnVlOworICAgIHJldHVybiBl bGVtZW50LT5hcmVBdXRob3JTaGFkb3dzQWxsb3dlZCgpOwogfQogCiBQYXNzUmVmUHRyPFNoYWRv d1Jvb3Q+IFNoYWRvd1Jvb3Q6OmNyZWF0ZShFbGVtZW50KiBlbGVtZW50LCBFeGNlcHRpb25Db2Rl JiBlYykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5o IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKaW5kZXggMGY5YzQ1YTQ0 Y2NkMmMyMjIxNzU3ZTUxNmYxMTFkZTg5YjA1Mzk5Ni4uNjc4ZjU5YWZmOTUwMDJiNWQwMWJlNDYx ODIxZTkxMDA3MjlkODI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5w dXRFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgK QEAgLTI5MCw2ICsyOTAsOSBAQCBwcm90ZWN0ZWQ6CiAgICAgSFRNTElucHV0RWxlbWVudChjb25z dCBRdWFsaWZpZWROYW1lJiwgRG9jdW1lbnQqLCBIVE1MRm9ybUVsZW1lbnQqLCBib29sIGNyZWF0 ZWRCeVBhcnNlcik7CiAgICAgdm9pZCBjcmVhdGVTaGFkb3dTdWJ0cmVlKCk7CiAgICAgdmlydHVh bCB2b2lkIGRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqKTsKKyAgICAvLyBGSVhNRTogQXV0aG9y IHNoYWRvd3Mgc2hvdWxkIGJlIGFsbG93ZWQKKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTI2MDgKKyAgICB2aXJ0dWFsIGJvb2wgYXJlQXV0aG9yU2hhZG93 c0FsbG93ZWQoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiBmYWxzZTsgfQogCiBwcml2YXRlOgog ICAgIGVudW0gQXV0b0NvbXBsZXRlU2V0dGluZyB7IFVuaW5pdGlhbGl6ZWQsIE9uLCBPZmYgfTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmggYi9Tb3VyY2UvV2Vi Q29yZS9zdmcvU1ZHRWxlbWVudC5oCmluZGV4IDkwMGI2MTQ1NDVjMDdmOTcyNmEzNTk0YmVmNTNh OThjZjVmODYwODEuLmE4YjAxMzI2MGJhOTI2ZjAzZDZmNWI0ZmUxYjk0ZTlkODE3NDI4NTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmgKKysrIGIvU291cmNlL1dl YkNvcmUvc3ZnL1NWR0VsZW1lbnQuaApAQCAtMTM2LDYgKzEzNiwxMCBAQCBwcm90ZWN0ZWQ6CiAK ICAgICB2b2lkIHJlcG9ydEF0dHJpYnV0ZVBhcnNpbmdFcnJvcihTVkdQYXJzaW5nRXJyb3IsIGNv bnN0IEF0dHJpYnV0ZSYpOwogCisgICAgLy8gRklYTUU6IEF1dGhvciBzaGFkb3dzIHNob3VsZCBi ZSBhbGxvd2VkCisgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc3OTM4CisgICAgdmlydHVhbCBib29sIGFyZUF1dGhvclNoYWRvd3NBbGxvd2VkKCkgY29uc3Qg T1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7IH0KKwogcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3Mg U1ZHRWxlbWVudEluc3RhbmNlOwogCg==