95652 2012-09-02 00:50:50 -0700 Don't create access error strings if there is no access error 2012-09-02 01:34:03 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 93407 1 fpizlo fpizlo abarth barraclough eric ggaren mhahnenberg msaboff oliver sam oldest_to_newest 710317 0 fpizlo 2012-09-02 00:50:50 -0700 Patch forthcoming. I'm just trying to undo our 50% regression in pdfjs caused by http://trac.webkit.org/changeset/126165. 710318 1 161839 fpizlo 2012-09-02 00:54:48 -0700 Created attachment 161839 the patch 710321 2 161839 abarth 2012-09-02 01:02:24 -0700 Comment on attachment 161839 the patch I would just remove the |result| temporary and just early return if shouldAllowAccessToFoo returns true. Thanks for fixing my regression. 710322 3 fpizlo 2012-09-02 01:03:11 -0700 (In reply to comment #2) > (From update of attachment 161839 [details]) > I would just remove the |result| temporary and just early return if shouldAllowAccessToFoo returns true. Thanks for fixing my regression. Good point! I will do that instead. Thanks for the quick review! 710323 4 fpizlo 2012-09-02 01:34:03 -0700 Landed in http://trac.webkit.org/changeset/127387 161839 2012-09-02 00:54:48 -0700 2012-09-02 01:02:23 -0700 the patch errorstrings_patch_1.diff text/plain 2173 fpizlo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzM4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTAyICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgY3JlYXRlIGFjY2VzcyBl cnJvciBzdHJpbmdzIGlmIHRoZXJlIGlzIG5vIGFjY2VzcyBlcnJvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU2NTIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgdW5kb2VzIHRoZSA1 MCUgcGVyZm9ybWFuY2UgcmVncmVzc2lvbiBpbiBwZGZqcyBjYXVzZWQgYnkKKyAgICAgICAgaHR0 cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTI2MTY1CisKKyAgICAgICAgTm8gbmV3IHRl c3RzIGJlY2F1c2UgYmVoYXZpb3IgaXMgdW5jaGFuZ2VkLgorCisgICAgICAgICogYmluZGluZ3Mv anMvSlNET01CaW5kaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNob3VsZEFsbG93QWNjZXNz VG9GcmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93 KToKKwogMjAxMi0wOC0zMSAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFVzZSAtd2Via2l0LWNsaXAtcGF0aCBzaGFwZXMgdG8gY2xpcCBTVkcgZWxlbWVudHMKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmNwcAkocmV2aXNp b24gMTI3MzU3KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjIzLDcgKzIyMyw4IEBAIGJvb2wgc2hvdWxkQWxsb3dBY2Nl c3NUb0ZyYW1lKEV4ZWNTdGF0ZSoKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGJvb2wgcmVz dWx0ID0gQmluZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRnJhbWUoZXhlYywgZnJh bWUsIERvTm90UmVwb3J0U2VjdXJpdHlFcnJvcik7CiAgICAgLy8gRklYTUU6IFRoZSBmb2xsb3dp bmcgbGluZSBvZiBjb2RlIHNob3VsZCBtb3ZlIHNvbWV3aGVyZSB0aGF0IGl0IGNhbiBiZSBzaGFy ZWQgd2l0aCBpbW1lZGlhdGVseVJlcG9ydFVuc2FmZUFjY2Vzc1RvLgotICAgIG1lc3NhZ2UgPSBm cmFtZS0+ZG9jdW1lbnQoKS0+ZG9tV2luZG93KCktPmNyb3NzRG9tYWluQWNjZXNzRXJyb3JNZXNz YWdlKGFjdGl2ZURPTVdpbmRvdyhleGVjKSk7CisgICAgaWYgKCFyZXN1bHQpCisgICAgICAgIG1l c3NhZ2UgPSBmcmFtZS0+ZG9jdW1lbnQoKS0+ZG9tV2luZG93KCktPmNyb3NzRG9tYWluQWNjZXNz RXJyb3JNZXNzYWdlKGFjdGl2ZURPTVdpbmRvdyhleGVjKSk7CiAgICAgcmV0dXJuIHJlc3VsdDsK IH0KIApAQCAtMjMzLDcgKzIzNCw4IEBAIGJvb2wgc2hvdWxkQWxsb3dBY2Nlc3NUb0RPTVdpbmRv dyhFeGVjU3QKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGJvb2wgcmVzdWx0ID0gQmluZGlu Z1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93KGV4ZWMsIHRhcmdldCwgRG9O b3RSZXBvcnRTZWN1cml0eUVycm9yKTsKICAgICAvLyBGSVhNRTogVGhlIGZvbGxvd2luZyBsaW5l IG9mIGNvZGUgc2hvdWxkIG1vdmUgc29tZXdoZXJlIHRoYXQgaXQgY2FuIGJlIHNoYXJlZCB3aXRo IGltbWVkaWF0ZWx5UmVwb3J0VW5zYWZlQWNjZXNzVG8uCi0gICAgbWVzc2FnZSA9IHRhcmdldC0+ Y3Jvc3NEb21haW5BY2Nlc3NFcnJvck1lc3NhZ2UoYWN0aXZlRE9NV2luZG93KGV4ZWMpKTsKKyAg ICBpZiAoIXJlc3VsdCkKKyAgICAgICAgbWVzc2FnZSA9IHRhcmdldC0+Y3Jvc3NEb21haW5BY2Nl c3NFcnJvck1lc3NhZ2UoYWN0aXZlRE9NV2luZG93KGV4ZWMpKTsKICAgICByZXR1cm4gcmVzdWx0 OwogfQogCg==