95644 2012-09-01 07:09:19 -0700 [Gtk] accessibility/canvas-description-and-role expected results needed 2012-09-06 22:08:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jdiggs webkit-unassigned apinheiro dmazzoni webkit.review.bot zan oldest_to_newest 710235 0 jdiggs 2012-09-01 07:09:19 -0700 A new CanvasRole was added to the accessibility code so we have a new layout test in need of expected results. The thing is, I don't see why the decision was made to not map CanvasRole to ATK_ROLE_CANVAS. I think the mapping is wrong, thus the expected results which will get generated will also be wrong. Filing this in Tools / Tests largely as a heads-up to gardeners. I'll attach a patch which addresses both issues and leave it to someone else to decide how to proceed with the lack of results. 710237 1 161826 jdiggs 2012-09-01 07:21:39 -0700 Created attachment 161826 Patch 710238 2 jdiggs 2012-09-01 07:23:35 -0700 Dominic, adding you to the CC here to comment in case CanvasRole really should not be mapped to ATK_ROLE_CANVAS. Thanks! 710241 3 161826 mrobinson 2012-09-01 07:32:21 -0700 Comment on attachment 161826 Patch Are the results here the same as for other platforms, thus allowing them to be shared and placed by placing them in a platform-independent results directory? 710244 4 jdiggs 2012-09-01 07:53:57 -0700 They're quite close, but not exact (pasted below for your convenience). These differences result from two things: 1. Different ports have different output "just 'cuz" (AXCanvas versus canvas). 2. Different ports have different roles. The former we should try to resolve (though that is a bug bigger than what I have filed here). The latter is a bit tougher. Especially when in certain cases what is being tested requires more of the accessible hierarchy than this particular example because those hierarchies tend to diverge pretty quickly amongst ports. Mac: PASS axContainer.childrenCount is 2 Canvas 1 description: AXDescription: Canvas label --> Canvas 1 role: AXRole: AXImage Canvas 2 description: AXDescription: --> Canvas 2 role: AXRole: AXGroup Win: FAIL axContainer.childrenCount should be 2. Was 3. Canvas 1 description: Description: Canvas label --> Canvas 1 role: graphic Canvas 2 description: --> Canvas 2 role: graphic Chromium: PASS axContainer.childrenCount is 2 Canvas 1 description: AXDescription: Canvas label --> Canvas 1 role: AXRole: AXCanvas Canvas 2 description: AXDescription: --> Canvas 2 role: AXRole: AXCanvas Gtk (Proposed): PASS axContainer.childrenCount is 2 Canvas 1 description: AXDescription: Canvas label --> Canvas 1 role: AXRole: canvas Canvas 2 description: AXDescription: --> Canvas 2 role: AXRole: canvas 710920 5 apinheiro 2012-09-04 02:44:30 -0700 (In reply to comment #0) > A new CanvasRole was added to the accessibility code so we have a new layout test in need of expected results. > > The thing is, I don't see why the decision was made to not map CanvasRole to ATK_ROLE_CANVAS. I think the mapping is wrong, thus the expected results which will get generated will also be wrong. FWIW, I also think that the current WebCore CanvasRole to ATK ATK_ROLE_IMAGE mappping is wrong. ATK_ROLE_CANVAS is the proper mapping. 711216 6 dmazzoni 2012-09-04 10:29:54 -0700 Hi - I'm sorry for not just mapping to ATK_ROLE_CANVAS right away. I didn't know how that might affect Orca, so I tried to just keep the same behavior as before with ATK, rather than make assumptions. The only potential reason to not always map to ATK_ROLE_CANVAS is if you think it'd make sense to distinguish between an interactive canvas and a static one. For example: 1. <canvas alt="User image icon" width=100 height=100></canvas> 2. <canvas width=100 height=100 id="monkey_spinner_widget"> <label> Number of flying monkeys <input type="range" min=0 max=100> </label> </canvas> In the first case, it might make more sense to use ATK_ROLE_IMAGE since the canvas is just static content, and conceptually it's just an image. In the second case, from an accessibility perspective the canvas element is just a container for an interactive widget. It's not conceptually a "graphic" anymore, the canvas element is just a container for interactive content - and the fact that it's displayed in a graphical canvas is only of secondary importance to a screen reader user. 711284 7 jdiggs 2012-09-04 11:34:46 -0700 (In reply to comment #6) > The only potential reason to not always map to ATK_ROLE_CANVAS is if you think it'd make sense to distinguish between an interactive canvas and a static one. > > For example: > > 1. <canvas alt="User image icon" width=100 height=100></canvas> > > 2. <canvas width=100 height=100 id="monkey_spinner_widget"> > <label> > Number of flying monkeys > <input type="range" min=0 max=100> > </label> > </canvas> The second case is awesome btw. :) And I do see your point. But in that case it's not really a platform thing, is it? In other words, case 1 is a static image for all users of all platforms. Thus perhaps in that instance, WebCore a11y should determine that it is ImageRole rather than CanvasRole and only declare CanvasRole for those objects which are functionally canvas. Thoughts? 711299 8 dmazzoni 2012-09-04 11:43:35 -0700 (In reply to comment #7) > And I do see your point. But in that case it's not really a platform thing, is it? In other words, case 1 is a static image for all users of all platforms. Thus perhaps in that instance, WebCore a11y should determine that it is ImageRole rather than CanvasRole and only declare CanvasRole for those objects which are functionally canvas. I don't have strong feelings either way, but you could argue that approach would "lose information" - if a platform didn't want a static canvas to be an ImageRole, it wouldn't have a way to do that. I just felt it was the most clear for WebCore to always call a canvas a canvas - but provide platforms with enough information to distinguish between static and dynamic canvases *if they want*. 711306 9 jdiggs 2012-09-04 11:48:52 -0700 (In reply to comment #8) > I just felt it was the most clear for WebCore to always call a canvas a canvas - but provide platforms with enough information to distinguish between static and dynamic canvases *if they want*. Gotcha. Sounds good to me. Martin (or anyone else with reviewer status): Please review so that Gtk maps a WebCore accessible CanvasRole to ATK_ROLE_CANVAS and that we also have expected test results. Thanks! 711881 10 zan 2012-09-05 03:03:33 -0700 *** Bug 95825 has been marked as a duplicate of this bug. *** 714102 11 161826 webkit.review.bot 2012-09-06 22:08:41 -0700 Comment on attachment 161826 Patch Clearing flags on attachment: 161826 Committed r127825: <http://trac.webkit.org/changeset/127825> 714103 12 webkit.review.bot 2012-09-06 22:08:44 -0700 All reviewed patches have been landed. Closing bug. 161826 2012-09-01 07:21:39 -0700 2012-09-06 22:08:41 -0700 Patch bug-95644-20120901102125.patch text/plain 3722 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU1YTkwMDBjZmI1Mjgw OWE0ZmUyYzJiOWMxOTJkMWRkZDU5NDI0OS4uZWYyYzE2NmI3YmMyNWE2YmRiM2QxNmQ1MTAzNjg3 NmM4OGRlNDUwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTA5LTAxICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR3RrXSBhY2Nlc3Np YmlsaXR5L2NhbnZhcy1kZXNjcmlwdGlvbi1hbmQtcm9sZSBleHBlY3RlZCByZXN1bHRzIG5lZWRl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU2NDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbmV3 IGFjY2Vzc2liaWxpdHkgQ2FudmFzUm9sZSBzaG91bGQgYmUgbWFwcGVkIHRvIEFUS19ST0xFX0NB TlZBUworICAgICAgICByYXRoZXIgdGhhbiBBVEtfUk9MRV9JTUFHRS4KKworICAgICAgICBObyBu ZXcgdGVzdCBiZWNhdXNlIHRoZSBDYW52YXNSb2xlIGNhbWUgd2l0aCBhIG5ldyBsYXlvdXQgdGVz dCBsYWNraW5nCisgICAgICAgIGV4cGVjdGVkIHJlc3VsdHMgZm9yIEd0ay4gVGhlIGdlbmVyYXRl ZCBleHBlY3RlZCByZXN1bHRzIGZvciB0aGF0IHRlc3QKKyAgICAgICAgcmVmbGVjdCB0aGUgcmV2 aXNlZCBtYXBwaW5nIHRvIEFUS19ST0xFX0NBTlZBUy4KKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvZ3RrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKGF0a1JvbGUp OgorCisyMDEyLTA5LTAxICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKwog ICAgICAgICBbR3RrXSBObyBhY2Nlc3NpYmxlIGNhcmV0LW1vdmVkIGV2ZW50cyBmb3VuZCBpbiBj ZXJ0YWluIGNvbnRlbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTcyODExCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv Z3RrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvZ3RrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAppbmRleCAxZjdjMzIx NzNhNzMyZWY1Mjg1OTMzN2Q3M2I5MzRiMTc1MmY1NDJmLi43YmNjYWQ4ODQ3MGNiMGRlZTE3N2Ix OGMxNDc5ZTU1NzkxMjlmODg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2d0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9ndGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCkBAIC01 MDEsNyArNTAxLDYgQEAgc3RhdGljIEF0a1JvbGUgYXRrUm9sZShBY2Nlc3NpYmlsaXR5Um9sZSBy b2xlKQogICAgIGNhc2UgV2ViQ29yZUxpbmtSb2xlOgogICAgIGNhc2UgSW1hZ2VNYXBMaW5rUm9s ZToKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX0xJTks7Ci0gICAgY2FzZSBDYW52YXNSb2xlOgog ICAgIGNhc2UgSW1hZ2VNYXBSb2xlOgogICAgIGNhc2UgSW1hZ2VSb2xlOgogICAgICAgICByZXR1 cm4gQVRLX1JPTEVfSU1BR0U7CkBAIC01MjUsNiArNTI0LDggQEAgc3RhdGljIEF0a1JvbGUgYXRr Um9sZShBY2Nlc3NpYmlsaXR5Um9sZSByb2xlKQogICAgICAgICByZXR1cm4gQVRLX1JPTEVfU0VD VElPTjsKICAgICBjYXNlIEZvcm1Sb2xlOgogICAgICAgICByZXR1cm4gQVRLX1JPTEVfRk9STTsK KyAgICBjYXNlIENhbnZhc1JvbGU6CisgICAgICAgIHJldHVybiBBVEtfUk9MRV9DQU5WQVM7CiAg ICAgZGVmYXVsdDoKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX1VOS05PV047CiAgICAgfQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDQ2NzA4YjczNWQwNzBhZjFiYTUyMTk0OTBhNTFmOTdhMDQ4NjRjZTkuLjdiNjYxZGU4MWY4 Yjc4MjU4ZGRkYmQ2Mjg1OGMxMTlhMTZhMTc0NDIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAx Mi0wOS0wMSAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CiAKKyAgICAgICAg W0d0a10gYWNjZXNzaWJpbGl0eS9jYW52YXMtZGVzY3JpcHRpb24tYW5kLXJvbGUgZXhwZWN0ZWQg cmVzdWx0cyBuZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk1NjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgR2VuZXJhdGVkIGV4cGVjdGVkIHJlc3VsdHMgZm9yIEd0ay4gVGhlc2UgcmVzdWx0cyBy ZWZsZWN0IHRoZSByZXZpc2VkCisgICAgICAgIG1hcHBpbmcgb2YgQ2FudmFzUm9sZSB0byBBVEtf Uk9MRV9DQU5WQVMgcmF0aGVyIHRoYW4gQVRLX1JPTEVfSU1BR0UuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9jYW52YXMtZGVzY3JpcHRpb24tYW5kLXJvbGUtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKworMjAxMi0wOS0wMSAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGln YWxpYS5jb20+CisKICAgICAgICAgW0d0a10gTm8gYWNjZXNzaWJsZSBjYXJldC1tb3ZlZCBldmVu dHMgZm91bmQgaW4gY2VydGFpbiBjb250ZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MjgxMQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9jYW52YXMtZGVzY3JpcHRpb24tYW5kLXJvbGUtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvY2FudmFzLWRl c2NyaXB0aW9uLWFuZC1yb2xlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yZWMyZjRkZmNmZWJh OTdjZjdjODA5MzJiZmYyM2JiZTQ5ZWQyMmRjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvY2FudmFzLWRlc2NyaXB0aW9uLWFuZC1yb2xl LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE0IEBACitUaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0 IGEgY2FudmFzIHdpdGggYW5kIHdpdGhvdXQgZmFsbGJhY2sgY29udGVudCBlYWNoIGhhcyB0aGUg cmlnaHQgcm9sZSBhbmQgZGVzY3JpcHRpb24uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBh IHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4K KworCitQQVNTIGF4Q29udGFpbmVyLmNoaWxkcmVuQ291bnQgaXMgMgorQ2FudmFzIDEgZGVzY3Jp cHRpb246IEFYRGVzY3JpcHRpb246IENhbnZhcyBsYWJlbAorQ2FudmFzIDEgcm9sZTogQVhSb2xl OiBjYW52YXMKK0NhbnZhcyAyIGRlc2NyaXB0aW9uOiBBWERlc2NyaXB0aW9uOiAKK0NhbnZhcyAy IHJvbGU6IEFYUm9sZTogY2FudmFzCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisK K1RFU1QgQ09NUExFVEUKKwo=