95553 2012-08-31 04:12:22 -0700 [Qt] QNX does not support SOCK_SEQPACKET socket type for socketpair in ProcessLauncherQt 2012-08-31 06:33:39 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95466 1 milian.wolff milian.wolff abecsi cmarcelo menard webkit.review.bot zoltan oldest_to_newest 709476 0 milian.wolff 2012-08-31 04:12:22 -0700 Running a WebKit2/QML app on QNX shows this debug output: Creation of socket failed with errno: 241 This is from ProcessLauncherQt.cpp, where we currently have: #if defined(SOCK_SEQPACKET) && !defined(Q_OS_MACX) #define SOCKET_TYPE SOCK_SEQPACKET #else #define SOCKET_TYPE SOCK_DGRAM #endif Thus on QNX the SOCK_SEQPACKET socket type is passed to socketpair futher below. On QNX this is apparently not supported, as can be reproduced with this minimal test case: #include <sys/socket.h> #include <stdio.h> int main(int argc, char** argv) { int fds[2]; char c; if (socketpair(AF_UNIX, SOCK_SEQPACKET, 0, fds) == -1) { perror("socketpair"); return 1; } if (send(fds[0], "a", 1, 0) == -1) { perror("send"); return 1; } if (recv(fds[1], &c, 1, 0) == -1) { perror("recv"); return 1; } printf("%c\n", c); return 0; } The output on a Playbook (bbndk 2.0.1) is: socketpair: Protocol wrong type for socket Changing SOCK_SEQPACKET to SOCK_DGRAM in the example makes it work, i.e. the output will be "a". Thus I propose to use SOCK_DGRAM in ProcessLauncherQt.cpp as well, I'll publish a patch. 709478 1 161661 milian.wolff 2012-08-31 04:20:14 -0700 Created attachment 161661 Patch 709572 2 161661 webkit.review.bot 2012-08-31 06:33:36 -0700 Comment on attachment 161661 Patch Clearing flags on attachment: 161661 Committed r127253: <http://trac.webkit.org/changeset/127253> 709573 3 webkit.review.bot 2012-08-31 06:33:39 -0700 All reviewed patches have been landed. Closing bug. 161661 2012-08-31 04:20:14 -0700 2012-08-31 06:33:36 -0700 Patch bug-95553-20120831132001.patch text/plain 1770 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmUyMzY1NDQyNjIwMTNi MWJjYWQ1MTRjYjQxM2EzMzYzOTg3Njg2MC4uNzQwYWFmYjVhNzdlN2IzMTBlY2RkOWQ2NzdlY2Vm OTAyN2RiYjAwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTMxICBNaWxp YW4gV29sZmYgIDxtaWxpYW4ud29sZmZAa2RhYi5jb20+CisKKyAgICAgICAgW1F0XSBRTlggZG9l cyBub3Qgc3VwcG9ydCBTT0NLX1NFUVBBQ0tFVCBzb2NrZXQgdHlwZSBmb3Igc29ja2V0cGFpciBp biBQcm9jZXNzTGF1bmNoZXJRdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTU1NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDYWxsaW5nIHNvY2tldHBhaXIgd2l0aCBTT0NLX1NFUVBBQ0tFVCBzb2NrZXQg dHlwZSBmYWlscyBvbiBRTlggd2l0aCBhbiBlcnJvciAyNDEgKEVQUk9UT1RZUEUpLAorICAgICAg ICBhcyBjYW4gYmUgc2VlbiBieSB0aGUgZm9sbG93aW5nIGRlYnVnIG91dHB1dDogIkNyZWF0aW9u IG9mIHNvY2tldCBmYWlsZWQgd2l0aCBlcnJubzogMjQxIi4KKyAgICAgICAgQSB0ZXN0IGFwcCBz aG93cyB0aGF0IFNPQ0tfREdSQU0gd29ya3MgcHJvcGVybHkgb24gUU5YLCB0aHVzIHVzZSBpdCBp bnN0ZWFkIG9mIFNPQ0tfU0VRUEFDS0VULgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVy L3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNwcDoKKwogMjAxMi0wOC0zMCAgTWFyayBIYWhuZW5iZXJn ICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIH5KU05QT2JqZWN0IHNob3VsZCBj YWxsIGludmFsaWRhdGUoKSBpZiBpdCBoYXNuJ3QgYmVlbiBjYWxsZWQgYWxyZWFkeQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hl clF0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9xdC9Qcm9jZXNzTGF1 bmNoZXJRdC5jcHAKaW5kZXggZjA5OWQ2MjgzN2JkNzU0NmI5MDZjNWVmOTIyZDA4YTMzMTQxM2Ux Yy4uZDNhODY0YTI1ZjVjMzEzOGMyNzU1YTQ2ZTgzMWYxYTQzMTUwYTU4MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5j aGVyUXQuY3BwCkBAIC02Miw3ICs2Miw4IEBACiBleHRlcm4gIkMiIGtlcm5fcmV0dXJuX3QgYm9v dHN0cmFwX3JlZ2lzdGVyMihtYWNoX3BvcnRfdCwgbmFtZV90LCBtYWNoX3BvcnRfdCwgdWludDY0 X3QpOwogI2VuZGlmCiAKLSNpZiBkZWZpbmVkKFNPQ0tfU0VRUEFDS0VUKSAmJiAhZGVmaW5lZChR X09TX01BQ1gpCisvLyBmb3IgUU5YIHdlIG5lZWQgU09DS19ER1JBTSwgc2VlIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTU1MworI2lmIGRlZmluZWQoU09DS19TRVFQ QUNLRVQpICYmICFkZWZpbmVkKFFfT1NfTUFDWCkgJiYgIU9TKFFOWCkKICNkZWZpbmUgU09DS0VU X1RZUEUgU09DS19TRVFQQUNLRVQKICNlbHNlCiAjZGVmaW5lIFNPQ0tFVF9UWVBFIFNPQ0tfREdS QU0K