94985 2012-08-24 17:15:07 -0700 Compositing and transforms break caret rendering 2013-01-22 15:46:46 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 15671 InRadar P2 Major --- 1 gregg anilsson anilsson eric Gnanasekar.somanathan gregg jamesr mifenton rniwa rwlbuis simon.fraser webkit-bug-importer oldest_to_newest 704543 0 gregg 2012-08-24 17:15:07 -0700 I am seeing repaint issues with transforming elements that have carets. This includes textareas, inputs, and divs (possibly more, but that's all I've tested). Adding the scale3d css property to an element the caret no longer blinks and no longer moves when using the arrow keys. When the arrow keys are moved, the caret DOES actually move, just not visually, since when you type the text appears in the correct spot. I've attached an HTML file that shows the issue. Also, here is a jsfiddle showing the same: http://jsfiddle.net/galtschul/StbKg/ One thing to point out is that when I scale using scale3d(1.01,1.01,1) the issue does not seem to occur. 704544 1 160527 gregg 2012-08-24 17:15:51 -0700 Created attachment 160527 html file with the scale3d issue 704545 2 eric 2012-08-24 17:18:46 -0700 Wow. Not only do we not repaint the caret correctly, but we also repaint the whole screen each blink. :( Thanks for the bug! 704547 3 gregg 2012-08-24 17:19:56 -0700 No problem. Glad I could help! 704563 4 gregg 2012-08-24 17:39:01 -0700 I just found that the same problem happens with the translate3d function. See attached file. 704564 5 160530 gregg 2012-08-24 17:40:17 -0700 Created attachment 160530 html file with the translate3d issue 705537 6 simon.fraser 2012-08-27 12:44:13 -0700 *** This bug has been marked as a duplicate of bug 15671 *** 705544 7 eric 2012-08-27 12:48:43 -0700 Does that mean this is fixed? The issue reproduces for me on Chromium-dev channel (as noted in comment #2). 705545 8 gregg 2012-08-27 12:49:27 -0700 How is this a duplicate? The original one is marked as resolved, but based on my examples it is very clearly not resolved. 705546 9 simon.fraser 2012-08-27 12:49:59 -0700 Oh, sorry, no. I meant to dup to 18751, but there could be two different issues here: a) caret under software transform b) caret in compositing layers 705547 10 gregg 2012-08-27 12:54:40 -0700 But, with respect to the caret issues, it looks like 18751 ultimately links back to 15671 in the end anyway. 705552 11 160786 simon.fraser 2012-08-27 13:04:32 -0700 Created attachment 160786 Another testcase Issue appears to be when a composited layer has a non-identity transform. Note the half-caret in the lower pair of form controls. 705553 12 webkit-bug-importer 2012-08-27 13:05:28 -0700 <rdar://problem/12181912> 705557 13 simon.fraser 2012-08-27 13:09:56 -0700 void RenderLayerCompositor::recursiveRepaintLayerRect(RenderLayer* layer, const IntRect& rect) { // FIXME: This method does not work correctly with transforms. 705559 14 simon.fraser 2012-08-27 13:11:34 -0700 Caret repainting is pretty sucking; it invalidates the window and all compositing layers that intersect the caret rectangle. We should try harder. 745733 15 169506 anilsson 2012-10-18 16:42:51 -0700 Created attachment 169506 Patch 745736 16 169506 anilsson 2012-10-18 16:45:25 -0700 Comment on attachment 169506 Patch This patch doesn't have test cases, proper commit msg etc, so the r? isn't really appropriate. I'm happy to hear your feedback though. 745749 17 169506 simon.fraser 2012-10-18 16:54:04 -0700 Comment on attachment 169506 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169506&action=review Approach seems OK. Would be nice to eliminate repaintRectangleInViewAndCompositedLayers() if we can. > Source/WebCore/editing/FrameSelection.cpp:1331 > + container = caretPainter->enclosingLayer()->enclosingCompositingLayer(); You should use RenderObject::containerForRepaint(). > Source/WebCore/editing/FrameSelection.cpp:1350 > + container->setBackingNeedsRepaintInRect(oldContainerCaretRepaintBounds); This should call container->repaintUsingContainer(container, oldContainerCaretRepaintBounds). > Source/WebCore/editing/FrameSelection.cpp:1354 > + container->setBackingNeedsRepaintInRect(m_containerCaretRepaintBounds); Ditto. 745759 18 anilsson 2012-10-18 17:05:00 -0700 Thanks for your feedback! Getting rid of repaintRectangleInViewAndCompositedLayers should be possible, thanks to containerForRepaint/repaintUsingContainer which I just learned about, it generalizes to the non-composited case. I'll be back another day with a better patch and some layouttest. 763848 19 anilsson 2012-11-11 09:09:38 -0800 (In reply to comment #14) > Caret repainting is pretty sucking; it invalidates the window and all compositing layers that intersect the caret rectangle. We should try harder. Hi there! I've been thinking about this for some time now, and I would like to ask for your feedback on the idea to make the caret a separate AC layer on ports that support AC (which are the only ones that are going to run into this bug) Benefits: 1. Faster painting (well, because there is no painting, only compositing) - not even the containing layer needs to be repainted. This can be used to add the blinking effect (in BlackBerry's case, even with fading) without having to pay a penalty in continuous repaints. 2. When the caret moves, no need to repaint the container where the caret was, just move the caret AC layer to the new container. Drawbacks: 1. The caret could be painted in front of content it was really supposed to be behind. I don't have enough insight into when layers are created to say if this is a big problem - hopefully the thing in front of it will be a separate layer. I didn't intend for the caret to force the creation of layers by itself - it would only be added to the container's containing AC layer (which might be the root layer actually). This could augment the effect of Drawback 2 because content in front of the caret would not be forced to have a layer. This could be done similar to the scrollbar layers (every RenderLayerCompositor has one), or it could be a layer that the FrameSelection class owns, and that it moves from layer to layer. 813491 20 simon.fraser 2013-01-22 15:45:00 -0800 *** This bug has been marked as a duplicate of bug 15671 *** 813496 21 simon.fraser 2013-01-22 15:46:46 -0800 Bug 103955 also fixed some caret issues. 160527 2012-08-24 17:15:51 -0700 2012-08-24 17:16:10 -0700 html file with the scale3d issue scaleIssue.html text/html 469 gregg PCFET0NUWVBFIGh0bWw+CjxodG1sPgoKPGhlYWQ+CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CnRl eHRhcmVhIHsgd2lkdGg6IDEwMCU7IGhlaWdodDogMTAwJTsgfQpkaXYgewogICAgd2lkdGg6IDEw MHB4OwogICAgaGVpZ2h0OiAyMDBweDsKICAgIG1hcmdpbi1sZWZ0OiA1MHB4OwogICAgbWFyZ2lu LXRvcDogMTAwcHg7CiAgICBib3JkZXI6IHNvbGlkIGJsYWNrOwogICAgLXdlYmtpdC10cmFuc2Zv cm06c2NhbGUzZCgwLjUsMC41LDEpOwp9Cjwvc3R5bGU+CjwvaGVhZD4KCjxib2R5PgoKPGRpdiBp ZD0idGVzdCI+CiAgICA8dGV4dGFyZWE+PC90ZXh0YXJlYT4KICAgIDxpbnB1dCB0eXBlPSJ0ZXh0 IiAvPgo8L2Rpdj4KPGJyIC8+PGJyIC8+PGJyIC8+PGJyIC8+PGJyIC8+PGJyIC8+PGJyIC8+PGJy IC8+PGJyLz48YnIvPgo8ZGl2IGlkPSJjZSIgY29udGVudGVkaXRhYmxlPSJ0cnVlIiAvPgoKPC9i b2R5Pgo8L2h0bWw+Cg== 160530 2012-08-24 17:40:17 -0700 2012-08-27 12:56:15 -0700 html file with the translate3d issue translateIssue.html text/html 479 gregg PCFET0NUWVBFIGh0bWw+CjxodG1sPgoKPGhlYWQ+CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CnRl eHRhcmVhIHsgd2lkdGg6IDEwMCU7IGhlaWdodDogMTAwJTsgfQpkaXYgewogICAgd2lkdGg6IDEw MHB4OwogICAgaGVpZ2h0OiAyMDBweDsKICAgIG1hcmdpbi1sZWZ0OiA1MHB4OwogICAgbWFyZ2lu LXRvcDogMTAwcHg7CiAgICBib3JkZXI6IHNvbGlkIGJsYWNrOwogICAgLXdlYmtpdC10cmFuc2Zv cm06dHJhbnNsYXRlM2QoMTAwcHgsMTAwcHgsMHB4KTsKfQo8L3N0eWxlPgo8L2hlYWQ+Cgo8Ym9k eT4KCjxkaXYgaWQ9InRlc3QiPgogICAgPHRleHRhcmVhPjwvdGV4dGFyZWE+CiAgICA8aW5wdXQg dHlwZT0idGV4dCIgLz4KPC9kaXY+CjxiciAvPjxiciAvPjxiciAvPjxiciAvPjxiciAvPjxiciAv PjxiciAvPjxiciAvPjxici8+PGJyLz4KPGRpdiBpZD0iY2UiIGNvbnRlbnRlZGl0YWJsZT0idHJ1 ZSIgLz4KCjwvYm9keT4KPC9odG1sPgo= 160786 2012-08-27 13:04:32 -0700 2012-08-27 13:04:32 -0700 Another testcase caret-transforms.html text/html 686 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3Mi IG1lZGlhPSJzY3JlZW4iPgogICAgICAgIC5ib3ggewogICAgICAgICAgICB3aWR0aDogMzAwcHg7 CiAgICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOwogICAgICAgICAgICBtYXJnaW46 IDEwcHg7CiAgICAgICAgICAgIHBhZGRpbmc6IDEwcHg7CiAgICAgICAgfQogICAgICAgIAogICAg ICAgIC50cmFuc2Zvcm1lZCB7CiAgICAgICAgICAgIC13ZWJraXQtdHJhbnNmb3JtOiByb3RhdGUo MTBkZWcpOwogICAgICAgIH0KCiAgICAgICAgLmNvbXBvc2l0ZWQgewogICAgICAgICAgICAtd2Vi a2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlM2QoMCwgN3B4LCAwKTsKICAgICAgICB9CiAgICA8L3N0 eWxlPgo8L2hlYWQ+Cjxib2R5PgogICAgPGRpdiBjbGFzcz0idHJhbnNmb3JtZWQgYm94Ij4KICAg ICAgICA8cD5UcmFuc2Zvcm1lZDwvcD4KICAgICAgICA8dGV4dGFyZWE+PC90ZXh0YXJlYT48YnI+ PGlucHV0IHR5cGU9InRleHQiPgogICAgPC9kaXY+CgogICAgPGRpdiBjbGFzcz0iY29tcG9zaXRl ZCBib3giPgogICAgICAgIDxwPlRyYW5zZm9ybWVkPC9wPgogICAgICAgIDx0ZXh0YXJlYT48L3Rl eHRhcmVhPjxicj48aW5wdXQgdHlwZT0idGV4dCI+CiAgICA8L2Rpdj4KCjwvYm9keT4KPC9odG1s Pgo= 169506 2012-10-18 16:42:51 -0700 2012-10-18 16:54:04 -0700 Patch bug-94985-20121019014134.patch text/plain 4228 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODEzY2Y0MjczYjZlMmYy MzcyODNhMTcyNzI1MTE0YzAwMjM4MzFiOC4uNjk0ZjkxOWE0MGJmZTQ1YTE1NGE4YWY0ZGUyM2Rm NDE4MTMwNjVhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTE4ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBDb21wb3NpdGluZyBhbmQg dHJhbnNmb3JtcyBicmVhayBjYXJldCByZW5kZXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0OTg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQSBmaXJzdCBzdGFiIGF0IHRoaXMsIHRvIHNlZSBpZiBh bnlvbmUgaGFzIGNvbW1lbnRzIG9uIHRoaXMgYXBwcm9hY2guCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjpyZWNvbXB1dGVDYXJldFJlY3QpOgorICAg ICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uaDoKKwogMjAxMi0xMC0xNSAgSm9uYXRoYW4g RG9uZyAgPGpvbmF0aGFuLmRvbmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFj a0JlcnJ5XSByZXBsYWNlIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpsb2coKSB3aXRoIEJCTE9HKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKaW5kZXggNDBjYTIwN2U5 NDdmNDM3ZTliYmNmMjBiNGJjNDJjMzQ3MjI0MTRlYS4uYjRiMDYxMTYxZTg5MjM3MDJjMDY2MDcw MmIxMTNiYmJiNTc4YWQwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFt ZVNlbGVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlv bi5jcHAKQEAgLTUwLDYgKzUwLDcgQEAKICNpbmNsdWRlICJJbmxpbmVUZXh0Qm94LmgiCiAjaW5j bHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlJhbmdlLmgiCisjaW5jbHVkZSAiUmVuZGVyTGF5ZXIu aCIKICNpbmNsdWRlICJSZW5kZXJUZXh0LmgiCiAjaW5jbHVkZSAiUmVuZGVyVGV4dENvbnRyb2wu aCIKICNpbmNsdWRlICJSZW5kZXJUaGVtZS5oIgpAQCAtMTMyMCwxMiArMTMyMSwzOCBAQCBib29s IEZyYW1lU2VsZWN0aW9uOjpyZWNvbXB1dGVDYXJldFJlY3QoKQogICAgIC8vIFdlIGJlbGlldmUg dGhhdCB3ZSBuZWVkIHRvIGluZmxhdGUgdGhlIGxvY2FsIHJlY3QgYmVmb3JlIHRyYW5zZm9ybWlu ZyBpdCB0byBvYnRhaW4gdGhlIHJlcGFpbnQgYm91bmRzLgogICAgIG1fYWJzb2x1dGVDYXJldFJl cGFpbnRCb3VuZHMgPSBjYXJldFJlcGFpbnRSZWN0KG1fc2VsZWN0aW9uLnN0YXJ0KCkuZGVwcmVj YXRlZE5vZGUoKSk7CiAKKyAgICAvLyBJZiBpdCB3YXMgYSBkaWZmZXJlbnQgY29udGFpbmVyLCB0 aGF0IGRvZXNuJ3QgbWF0dGVyIG11Y2ggLSB0aGUgb2xkIGNvbnRhaW5lciBob3BlZnVsbHkgaGFz CisgICAgLy8gYWxyZWFkeSBiZWVuIGludmFsaWRhdGVkIGR1ZSB0byB3aGF0ZXZlciB0cmFuc2Zl cnJlZCB0aGUgY2FyZXQgdG8gdGhlIG5ldyBjb250YWluZXIsCisgICAgLy8gZS5nIGxvc2luZyBm b2N1cywgYW5kIHdlJ2xsIGp1c3QgaW52YWxpZGF0ZSBzb21lIGJvZ3VzIHJlY3QuCisgICAgSW50 UmVjdCBvbGRDb250YWluZXJDYXJldFJlcGFpbnRCb3VuZHMgPSBtX2NvbnRhaW5lckNhcmV0UmVw YWludEJvdW5kczsKKyAgICBSZW5kZXJMYXllciogY29udGFpbmVyID0gMDsKKyAgICBtX2NvbnRh aW5lckNhcmV0UmVwYWludEJvdW5kcyA9IEludFJlY3QoKTsKKyAgICBpZiAoUmVuZGVyT2JqZWN0 KiBjYXJldFBhaW50ZXIgPSBjYXJldFJlbmRlcmVyKCkpIHsKKyAgICAgICAgY29udGFpbmVyID0g Y2FyZXRQYWludGVyLT5lbmNsb3NpbmdMYXllcigpLT5lbmNsb3NpbmdDb21wb3NpdGluZ0xheWVy KCk7CisgICAgICAgIGlmIChjb250YWluZXIpIHsKKyAgICAgICAgICAgIExheW91dFJlY3QgbG9j YWxSZWN0KGxvY2FsQ2FyZXRSZWN0V2l0aG91dFVwZGF0ZSgpKTsKKyAgICAgICAgICAgIGlmIChj YXJldFBhaW50ZXItPmlzQm94KCkpCisgICAgICAgICAgICAgICAgdG9SZW5kZXJCb3goY2FyZXRQ YWludGVyKS0+ZmxpcEZvcldyaXRpbmdNb2RlKGxvY2FsUmVjdCk7CisKKyAgICAgICAgICAgIEZs b2F0UXVhZCBxdWFkID0gY2FyZXRQYWludGVyLT5sb2NhbFRvQ29udGFpbmVyUXVhZChGbG9hdFJl Y3QobG9jYWxSZWN0KSwgY29udGFpbmVyLT5yZW5kZXJlcigpLCBmYWxzZSk7CisgICAgICAgICAg ICBtX2NvbnRhaW5lckNhcmV0UmVwYWludEJvdW5kcyA9IHF1YWQuZW5jbG9zaW5nQm91bmRpbmdC b3goKTsKKworICAgICAgICAgICAgLy8gQ2xlYXIgdGhpcyB0byBtYWtlIHN1cmUgd2UgdXNlIHRo ZSBjb250YWluZXIgY29kZSBwYXRoIGZvciB0aGUgbmV4dCBzdGVwCisgICAgICAgICAgICBtX2Fi c29sdXRlQ2FyZXRSZXBhaW50Qm91bmRzID0gSW50UmVjdCgpOworICAgICAgICB9CisgICAgfQor CiAjaWYgRU5BQkxFKFRFWFRfQ0FSRVQpCiAgICAgaWYgKFJlbmRlclZpZXcqIHZpZXcgPSB0b1Jl bmRlclZpZXcobV9mcmFtZS0+ZG9jdW1lbnQoKS0+cmVuZGVyZXIoKSkpIHsKLSAgICAgICAgLy8g RklYTUU6IG1ha2UgY2FyZXQgcmVwYWludGluZyBjb250YWluZXItYXdhcmUuCisKICAgICAgICAg dmlldy0+cmVwYWludFJlY3RhbmdsZUluVmlld0FuZENvbXBvc2l0ZWRMYXllcnMob2xkQWJzb2x1 dGVDYXJldFJlcGFpbnRCb3VuZHMsIGZhbHNlKTsKLSAgICAgICAgaWYgKHNob3VsZFJlcGFpbnRD YXJldCh2aWV3LCBpc0NvbnRlbnRFZGl0YWJsZSgpKSkKKyAgICAgICAgaWYgKGNvbnRhaW5lciAm JiAhb2xkQ29udGFpbmVyQ2FyZXRSZXBhaW50Qm91bmRzLmlzRW1wdHkoKSkKKyAgICAgICAgICAg IGNvbnRhaW5lci0+c2V0QmFja2luZ05lZWRzUmVwYWludEluUmVjdChvbGRDb250YWluZXJDYXJl dFJlcGFpbnRCb3VuZHMpOworICAgICAgICBpZiAoc2hvdWxkUmVwYWludENhcmV0KHZpZXcsIGlz Q29udGVudEVkaXRhYmxlKCkpKSB7CiAgICAgICAgICAgICB2aWV3LT5yZXBhaW50UmVjdGFuZ2xl SW5WaWV3QW5kQ29tcG9zaXRlZExheWVycyhtX2Fic29sdXRlQ2FyZXRSZXBhaW50Qm91bmRzLCBm YWxzZSk7CisgICAgICAgICAgICBpZiAoY29udGFpbmVyICYmICFtX2NvbnRhaW5lckNhcmV0UmVw YWludEJvdW5kcy5pc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgY29udGFpbmVyLT5zZXRCYWNr aW5nTmVlZHNSZXBhaW50SW5SZWN0KG1fY29udGFpbmVyQ2FyZXRSZXBhaW50Qm91bmRzKTsKKyAg ICAgICAgfQogICAgIH0KICNlbmRpZgogICAgIHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvZWRp dGluZy9GcmFtZVNlbGVjdGlvbi5oCmluZGV4IGEwY2UwNTk5MTU2YmQ3Mjk5NjkwNzFhODNlZTRm OTk5NDc5ZGViMTMuLjcxMDYwMDg2YWI4OGJhMWUzOTEzNzM2M2Y3MzIyY2Q5OGUzNTc5YjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uaAorKysgYi9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmgKQEAgLTMwOCw2ICszMDgsNyBA QCBwcml2YXRlOgogICAgIEludFJlY3QgbV9hYnNDYXJldEJvdW5kczsKICAgICAvLyBTaW1pbGFy IHRvIGFib3ZlLCBidXQgaW5mbGF0ZWQgdG8gZW5zdXJlIHByb3BlciByZXBhaW50IChzZWUgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDg2KQogICAgIEludFJlY3Qg bV9hYnNvbHV0ZUNhcmV0UmVwYWludEJvdW5kczsKKyAgICBJbnRSZWN0IG1fY29udGFpbmVyQ2Fy ZXRSZXBhaW50Qm91bmRzOwogICAgIGJvb2wgbV9hYnNDYXJldEJvdW5kc0RpcnR5IDogMTsKICAg ICBib29sIG1fY2FyZXRQYWludCA6IDE7CiAgICAgYm9vbCBtX2lzQ2FyZXRCbGlua2luZ1N1c3Bl bmRlZCA6IDE7Cg==