94874 2012-08-23 16:56:19 -0700 [mac] REGRESSION (r122215): Animated GIF outside the viewport doesn't play when scrolled into view 2012-10-05 18:28:01 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 thorton webkit-unassigned adele andersca bdakin dongseong.hwang eric japhet kling koivisto simon.fraser skyul webkit.review.bot oldest_to_newest 703547 0 thorton 2012-08-23 16:56:19 -0700 Steps to Reproduce: 1. On Mountain Lion, with the Mac port (where tiled scrolling is enabled): 2. With a relatively small window: 3. Load http://whenapthuntinginsf.tumblr.com. 4. Scroll down. Expected: All of the GIFs animate. Actual: The GIFs which are scrolled into view do not animate. This is probably due to the fact that they are offscreen (on offscreen tiles) when they are first painted, so they don't animate. Then, when they are scrolled into view, they don't need to repaint, so they don't realize they should start animating. This will probably require some special logic in the tiled scrolling case. <rdar://problem/12067641> 703557 1 thorton 2012-08-23 17:04:49 -0700 This regressed in http://trac.webkit.org/changeset/122215. The ChangeLog entry for that patch includes the comment: "This patch makes GIF animation outside the viewport be paused." 703651 2 dongseong.hwang 2012-08-23 18:57:41 -0700 (In reply to comment #1) > This regressed in http://trac.webkit.org/changeset/122215. The ChangeLog entry for that patch includes the comment: "This patch makes GIF animation outside the viewport be paused." I'm sorry for this regression. I think the tiled scrolling disables RenderObject::willRenderImage from checking if the renderer is outside the viewport. "viewRect().intersects(absoluteClippedOverflowRect())" is often used in WebKit, such as spatial navigation. I think the tiled scrolling should return the proper value. bool RenderObject::willRenderImage(CachedImage*) { .... // If a renderer is outside the viewport, we won't render. return viewRect().intersects(absoluteClippedOverflowRect()); } 736127 3 167425 dongseong.hwang 2012-10-05 17:46:10 -0700 Created attachment 167425 Patch 736131 4 dongseong.hwang 2012-10-05 17:48:55 -0700 (In reply to comment #3) > Created an attachment (id=167425) [details] > Patch Rollback previous patch because this patch caused two problems. 1. GIF animation is occasionally paused when tiled scrolling is enabled. 2. This change regressed Apple's Membuster benchmark by ~20% (80MB.) 736149 5 167425 webkit.review.bot 2012-10-05 18:27:57 -0700 Comment on attachment 167425 Patch Clearing flags on attachment: 167425 Committed r130573: <http://trac.webkit.org/changeset/130573> 736150 6 webkit.review.bot 2012-10-05 18:28:01 -0700 All reviewed patches have been landed. Closing bug. 167425 2012-10-05 17:46:10 -0700 2012-10-05 18:27:57 -0700 Patch bug-94874-20121006094511.patch text/plain 6019 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjI0NTczODQ5ODFjNDhl MDZlNTY1MWMzYTRkNGIzYmYxYzUwYTg0Yi4uMTlmNWUzMDI2YzQ5MGM3ODk0ZTIyN2ExNzk1ZDgx NjFmMGNhOWY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTEwLTA1ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIFttYWNdIFJF R1JFU1NJT04gKHIxMjIyMTUpOiBBbmltYXRlZCBHSUYgb3V0c2lkZSB0aGUgdmlld3BvcnQgZG9l c24ndCBwbGF5IHdoZW4gc2Nyb2xsZWQgaW50byB2aWV3LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ4NzQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSb2xsYmFjayBwcmV2aW91cyBwYXRjaCBiZWNhdXNl IHRoaXMgcGF0Y2ggY2F1c2VkIHR3byBwcm9ibGVtcy4KKyAgICAgICAgMS4gR0lGIGFuaW1hdGlv biBpcyBvY2Nhc2lvbmFsbHkgcGF1c2VkIHdoZW4gdGlsZWQgc2Nyb2xsaW5nIGlzIGVuYWJsZWQu CisgICAgICAgIDIuIFRoaXMgY2hhbmdlIHJlZ3Jlc3NlZCBBcHBsZSdzIE1lbWJ1c3RlciBiZW5j aG1hcmsgYnkgfjIwJSAoODBNQi4pCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkSW1h Z2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkSW1hZ2U6OnNob3VsZFBhdXNlQW5pbWF0 aW9uKToKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuaDoKKyAgICAgICAgKENh Y2hlZEltYWdlKToKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuaDoKKyAg ICAgICAgKiBsb2FkZXIvY2FjaGUvTWVtb3J5Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TWVtb3J5Q2FjaGU6OnBydW5lTGl2ZVJlc291cmNlc1RvU2l6ZSk6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6Ondp bGxSZW5kZXJJbWFnZSk6CisKKzIwMTItMTAtMDUgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFA Y29tcGFueTEwMC5uZXQ+CisKICAgICAgICAgW0NTUyBTaGFkZXJzXSBJbXBsZW1lbnQgb3Zlcmxh eSwgY29sb3ItZG9kZ2UsIGNvbG9yLWJ1cm4sIGhhcmQtbGlnaHQsIHNvZnQtbGlnaHQgYmxlbmQg bW9kZXMuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODUwNAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkSW1h Z2UuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmNwcAppbmRl eCBiZWU5Njk1YWJmZWVlYjliNzJjNDhmMDdhYzEzZmM2YzE2NTZhMzA2Li43NGIyNmQzZjFjYTY0 MGRiNWQyNGNhNmRlYWQyNGIwMDM5YWUzOTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRJbWFnZS5jcHAKQEAgLTQyMiwxNyArNDIyLDYgQEAgdm9pZCBDYWNoZWRJbWFn ZTo6ZGVjb2RlZFNpemVDaGFuZ2VkKGNvbnN0IEltYWdlKiBpbWFnZSwgaW50IGRlbHRhKQogICAg IHNldERlY29kZWRTaXplKGRlY29kZWRTaXplKCkgKyBkZWx0YSk7CiB9CiAKLWJvb2wgQ2FjaGVk SW1hZ2U6Omxpa2VseVRvQmVVc2VkU29vbigpCi17Ci0gICAgQ2FjaGVkUmVzb3VyY2VDbGllbnRX YWxrZXI8Q2FjaGVkSW1hZ2VDbGllbnQ+IHdhbGtlcihtX2NsaWVudHMpOwotICAgIHdoaWxlIChD YWNoZWRJbWFnZUNsaWVudCogY2xpZW50ID0gd2Fsa2VyLm5leHQoKSkgewotICAgICAgICBpZiAo Y2xpZW50LT53aWxsUmVuZGVySW1hZ2UodGhpcykpCi0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsK LSAgICB9Ci0KLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KIHZvaWQgQ2FjaGVkSW1hZ2U6OmRpZERy YXcoY29uc3QgSW1hZ2UqIGltYWdlKQogewogICAgIGlmICghaW1hZ2UgfHwgaW1hZ2UgIT0gbV9p bWFnZSkKQEAgLTQ1MCw3ICs0MzksMTMgQEAgYm9vbCBDYWNoZWRJbWFnZTo6c2hvdWxkUGF1c2VB bmltYXRpb24oY29uc3QgSW1hZ2UqIGltYWdlKQogICAgIGlmICghaW1hZ2UgfHwgaW1hZ2UgIT0g bV9pbWFnZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAotICAgIHJldHVybiAhbGlrZWx5 VG9CZVVzZWRTb29uKCk7CisgICAgQ2FjaGVkUmVzb3VyY2VDbGllbnRXYWxrZXI8Q2FjaGVkSW1h Z2VDbGllbnQ+IHcobV9jbGllbnRzKTsKKyAgICB3aGlsZSAoQ2FjaGVkSW1hZ2VDbGllbnQqIGMg PSB3Lm5leHQoKSkgeworICAgICAgICBpZiAoYy0+d2lsbFJlbmRlckltYWdlKHRoaXMpKQorICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKworICAgIHJldHVybiB0cnVlOwogfQogCiB2 b2lkIENhY2hlZEltYWdlOjphbmltYXRpb25BZHZhbmNlZChjb25zdCBJbWFnZSogaW1hZ2UpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuaCBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFnZS5oCmluZGV4IDA3OGY3YWIxYzYy ZmY4NmI4MTViOWYwNjU0NjMwZDM2MDE5MjkzY2EuLjY3ZTAwNjA3YjI0Mzc3Y2E4MDQ3ZWIxNGY0 MmY3NmM0ZDE1OGY1ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9D YWNoZWRJbWFnZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFn ZS5oCkBAIC03Miw4ICs3Miw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgYWxsQ2xpZW50 c1JlbW92ZWQoKTsKICAgICB2aXJ0dWFsIHZvaWQgZGVzdHJveURlY29kZWREYXRhKCk7CiAKLSAg ICB2aXJ0dWFsIGJvb2wgbGlrZWx5VG9CZVVzZWRTb29uKCk7Ci0KICAgICB2aXJ0dWFsIHZvaWQg ZGF0YShQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gZGF0YSwgYm9vbCBhbGxEYXRhUmVjZWl2ZWQp OwogICAgIHZpcnR1YWwgdm9pZCBlcnJvcihDYWNoZWRSZXNvdXJjZTo6U3RhdHVzKTsKICAgICB2 aXJ0dWFsIHZvaWQgc2V0UmVzcG9uc2UoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuaAppbmRleCBiNzM5ZDY4YWY4 MWYyZGI3YjQ4NjJkZjE1OWFhY2YxNThlMGI1NzMzLi42MWU2MWFmMjUwMjg3ZmIyMmMzNWYxYmZj Y2QzYWY2ZTU5MDk0M2JhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUv Q2FjaGVkUmVzb3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVk UmVzb3VyY2UuaApAQCAtMjE1LDkgKzIxNSw2IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2V0T3du aW5nQ2FjaGVkUmVzb3VyY2VMb2FkZXIoQ2FjaGVkUmVzb3VyY2VMb2FkZXIqIGNhY2hlZFJlc291 cmNlTG9hZGVyKSB7IG1fb3duaW5nQ2FjaGVkUmVzb3VyY2VMb2FkZXIgPSBjYWNoZWRSZXNvdXJj ZUxvYWRlcjsgfQogICAgIAotICAgIC8vIE1lbW9yeUNhY2hlIGRvZXMgbm90IGRlc3Ryb3kgdGhl IGRlY29kZWQgZGF0YSBvZiBhIENhY2hlZFJlc291cmNlIGlmIHRoZSBkZWNvZGVkIGRhdGEgd2ls bCBiZSBsaWtlbHkgdXNlZC4KLSAgICB2aXJ0dWFsIGJvb2wgbGlrZWx5VG9CZVVzZWRTb29uKCkg eyByZXR1cm4gZmFsc2U7IH0KLQogICAgIGJvb2wgaXNQcmVsb2FkZWQoKSBjb25zdCB7IHJldHVy biBtX3ByZWxvYWRDb3VudDsgfQogICAgIHZvaWQgaW5jcmVhc2VQcmVsb2FkQ291bnQoKSB7ICsr bV9wcmVsb2FkQ291bnQ7IH0KICAgICB2b2lkIGRlY3JlYXNlUHJlbG9hZENvdW50KCkgeyBBU1NF UlQobV9wcmVsb2FkQ291bnQpOyAtLW1fcHJlbG9hZENvdW50OyB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvTWVtb3J5Q2FjaGUuY3BwIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL01lbW9yeUNhY2hlLmNwcAppbmRleCAxMGM5ZTZiYjE4MzcyNGIwYjRlYzAz OTBjMjc5YTgxNmY5YzBhMmJhLi4yYmQ4ZGY5NzhhMGFkY2IxZmI5MWY0ZGNjMDY1NDc1ZGE5Yjc4 MGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvTWVtb3J5Q2FjaGUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9NZW1vcnlDYWNoZS5jcHAKQEAg LTIzOCwxMiArMjM4LDYgQEAgdm9pZCBNZW1vcnlDYWNoZTo6cHJ1bmVMaXZlUmVzb3VyY2VzVG9T aXplKHVuc2lnbmVkIHRhcmdldFNpemUpCiAgICAgICAgICAgICBpZiAoZWxhcHNlZFRpbWUgPCBj TWluRGVsYXlCZWZvcmVMaXZlRGVjb2RlZFBydW5lKQogICAgICAgICAgICAgICAgIHJldHVybjsK IAotICAgICAgICAgICAgLy8gQ2hlY2sgdG8gc2VlIGlmIHRoZSBjdXJyZW50IHJlc291cmNlIGFy ZSBsaWtlbHkgdG8gYmUgdXNlZCBhZ2FpbiBzb29uLgotICAgICAgICAgICAgaWYgKGN1cnJlbnQt Pmxpa2VseVRvQmVVc2VkU29vbigpKSB7Ci0gICAgICAgICAgICAgICAgY3VycmVudCA9IHByZXY7 Ci0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICB9Ci0KICAgICAgICAgICAg IC8vIERlc3Ryb3kgb3VyIGRlY29kZWQgZGF0YS4gVGhpcyB3aWxsIHJlbW92ZSB1cyBmcm9tIAog ICAgICAgICAgICAgLy8gbV9saXZlRGVjb2RlZFJlc291cmNlcywgYW5kIHBvc3NpYmx5IG1vdmUg dXMgdG8gYSBkaWZmZXJlbnQgTFJVIAogICAgICAgICAgICAgLy8gbGlzdCBpbiBtX2FsbFJlc291 cmNlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKaW5kZXggODk1 ZjhlZmVkMjdkYTIzZDY4ZjBmNGEwNzcwMWU1Zjk2YjlhZWVjZi4uZDQ1Y2UzN2JhOWZkMTY3ZDY3 MmVlZTYxNDQ5MmExYTUxNWY4MzQ2MCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHAKQEAgLTI4MDYsMTYgKzI4MDYsNyBAQCBib29sIFJlbmRlck9iamVjdDo6d2ls bFJlbmRlckltYWdlKENhY2hlZEltYWdlKikKIAogICAgIC8vIElmIHdlJ3JlIG5vdCBpbiBhIHdp bmRvdyAoaS5lLiwgd2UncmUgZG9ybWFudCBmcm9tIGJlaW5nIHB1dCBpbiB0aGUgYi9mIGNhY2hl IG9yIGluIGEgYmFja2dyb3VuZCB0YWIpCiAgICAgLy8gdGhlbiB3ZSBkb24ndCB3YW50IHRvIHJl bmRlciBlaXRoZXIuCi0gICAgaWYgKGRvY3VtZW50KCktPmluUGFnZUNhY2hlKCkgfHwgZG9jdW1l bnQoKS0+dmlldygpLT5pc09mZnNjcmVlbigpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAg ICAvLyBJZiB0aGUgZG9jdW1lbnQgaXMgYmVpbmcgZGVzdHJveWVkIG9yIGhhcyBub3QgYmVlbiBh dHRhY2hlZCwgdGhlbiB0aGlzCi0gICAgLy8gUmVuZGVyT2JqZWN0IHdpbGwgbm90IGJlIHJlbmRl cmVkLgotICAgIGlmICghdmlldygpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICAvLyBJ ZiBhIHJlbmRlcmVyIGlzIG91dHNpZGUgdGhlIHZpZXdwb3J0LCB3ZSB3b24ndCByZW5kZXIuCi0g ICAgcmV0dXJuIHZpZXdSZWN0KCkuaW50ZXJzZWN0cyhhYnNvbHV0ZUNsaXBwZWRPdmVyZmxvd1Jl Y3QoKSk7CisgICAgcmV0dXJuICFkb2N1bWVudCgpLT5pblBhZ2VDYWNoZSgpICYmICFkb2N1bWVu dCgpLT52aWV3KCktPmlzT2Zmc2NyZWVuKCk7CiB9CiAKIGludCBSZW5kZXJPYmplY3Q6Om1heGlt YWxPdXRsaW5lU2l6ZShQYWludFBoYXNlIHApIGNvbnN0Cg==