94792 2012-08-23 01:53:51 -0700 Enable sub-pixel layout for the GTK port 2013-04-27 05:39:16 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 89572 115304 85532 1 zan zan d-r eae leviw mrobinson pnormand oldest_to_newest 702814 0 zan 2012-08-23 01:53:51 -0700 This bug will cover enabling the sub-pixel layout on the GTK port. I believe the branch for the next stable release series will be created soon - I'd recommend proceeding with enabling this feature only after that. 739936 1 d-r 2012-10-11 07:10:24 -0700 So you consider bug 89572 required for enabling sub pixel layout on GTK as well? Do you see the same issue that I observed initially that there's too much rebaselining required on GTK without that patch? Maybe together we can make another attempt and working with the Chromium gardeners to get it landed. Last time I tried I couldn't quite get them to rebase these 6000+ cases - but if we're two (ports), we might have more luck. 739938 2 zan 2012-10-11 07:14:12 -0700 (In reply to comment #1) > So you consider bug 89572 required for enabling sub pixel layout on GTK as well? Do you see the same issue that I observed initially that there's too much rebaselining required on GTK without that patch? > Maybe together we can make another attempt and working with the Chromium gardeners to get it landed. Last time I tried I couldn't quite get them to rebase these 6000+ cases - but if we're two (ports), we might have more luck. I haven't really checked out how this patch affects the number of tests that would need rebaselining, but it wouldn't come around as smart to enable the subpixel layout, rebaseline gazillion of tests, get that patch landed and rebaseline gazillion of tests again. I'd rather help out the Chromium gardeners do their rebaselining when this patch lands. 814152 3 d-r 2013-01-23 06:19:57 -0800 As you've probably seen on some other bugs, we've enabled it on EFL, and bug 89572 wasn't actually the core of the issue. Updating FreeType was. And no rebaselines required on the Chromium side. However, after my discussions with Werner Lemberg, there will be another change in FreeType that might affect baselines - so, if you plan to enable sub-pixel layout on GTK, I would wait for FreeType 2.4.12 - or in other words any release that includes http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=e0469372be3870a5ad60b2c4586e9c281357bd28 876062 4 198186 zan 2013-04-15 14:20:14 -0700 Created attachment 198186 Patch 878784 5 198186 zan 2013-04-20 12:20:34 -0700 Comment on attachment 198186 Patch Clearing flags on attachment: 198186 Committed r148793: <http://trac.webkit.org/changeset/148793> 878785 6 zan 2013-04-20 12:20:40 -0700 All reviewed patches have been landed. Closing bug. 198186 2013-04-15 14:20:14 -0700 2013-04-20 12:20:34 -0700 Patch bug-94792-20130415231949.patch text/plain 1062 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODQ2 NykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA0 LTE1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBFbmFi bGUgc3ViLXBpeGVsIGxheW91dCBmb3IgdGhlIEdUSyBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDc5MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2F1dG90b29scy9TZXR1cFdlYktp dEZlYXR1cmVzLm00OiBFbmFibGUgdGhlIHN1YnBpeGVsIGxheW91dC4KKwogMjAxMy0wNC0xNSAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBbQ01ha2Vd IEFkZCBXVEZfVVNFXypfVU5JQ09ERSB2YXJpYWJsZXMKSW5kZXg6IFNvdXJjZS9hdXRvdG9vbHMv U2V0dXBXZWJLaXRGZWF0dXJlcy5tNAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYXV0b3Rvb2xzL1Nl dHVwV2ViS2l0RmVhdHVyZXMubTQJKHJldmlzaW9uIDE0ODQ2NikKKysrIFNvdXJjZS9hdXRvdG9v bHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNAkod29ya2luZyBjb3B5KQpAQCAtMTY4LDYgKzE2OCw3 IEBAICRzcmNkaXIvVG9vbHMvZ3RrL2dlbmVyYXRlLWZlYXR1cmUtZGVmaW4KICAgICBFTkFCTEVf U0hBUkVEX1dPUktFUlM9MSBcCiAgICAgRU5BQkxFX1NNT09USF9TQ1JPTExJTkc9MSBcCiAgICAg RU5BQkxFX1NRTF9EQVRBQkFTRT0xIFwKKyAgICBFTkFCTEVfU1VCUElYRUxfTEFZT1VUPTEgXAog ICAgIEVOQUJMRV9TVFlMRV9TQ09QRUQ9MCBcCiAgICAgRU5BQkxFX1RFTVBMQVRFX0VMRU1FTlQ9 MCBcCiAgICAgRU5BQkxFX1RFWFRfQVVUT1NJWklORz0wIFwK