94701 2012-08-22 06:30:16 -0700 [V8] Move precompileScript() from V8Proxy to ScriptSourceCode 2012-08-22 15:27:25 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 701843 0 haraken 2012-08-22 06:30:16 -0700 To kill V8Proxy, we can move precompileScript() from V8Proxy to ScriptSourceCode. 701852 1 159924 haraken 2012-08-22 06:37:37 -0700 Created attachment 159924 Patch 702422 2 159924 webkit.review.bot 2012-08-22 15:27:22 -0700 Comment on attachment 159924 Patch Clearing flags on attachment: 159924 Committed r126360: <http://trac.webkit.org/changeset/126360> 702423 3 webkit.review.bot 2012-08-22 15:27:25 -0700 All reviewed patches have been landed. Closing bug. 159924 2012-08-22 06:37:37 -0700 2012-08-22 15:27:22 -0700 Patch bug-94701-20120822223734.patch text/plain 6245 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Mjk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDk5MmU0N2FlZjJlNTQ3 NmM2YTRlMTY3OWZkMGMzZGYwYTE0ODE1Zi4uMmNhZGIxN2Y0NDQzOTJiZTM3ZGIxMWM2YmQ0Y2Fl OTQyMWRmNDgxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA4LTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgcHJl Y29tcGlsZVNjcmlwdCgpIGZyb20gVjhQcm94eSB0byBTY3JpcHRTb3VyY2VDb2RlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDcwMQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGtpbGwgVjhQcm94eSwg d2UgY2FuIG1vdmUgcHJlY29tcGlsZVNjcmlwdCgpIGZyb20gVjhQcm94eQorICAgICAgICB0byBT Y3JpcHRTb3VyY2VDb2RlLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZp b3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRTb3VyY2VDb2RlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNjcmlwdFNvdXJjZUNvZGU6OnByZWNvbXBpbGVTY3JpcHQpOgorICAgICAg ICAoV2ViQ29yZSk6CisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0U291cmNlQ29kZS5oOgor ICAgICAgICAoU2NyaXB0U291cmNlQ29kZSk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94 eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5OjpldmFsdWF0ZSk6CisgICAgICAgICog YmluZGluZ3MvdjgvVjhQcm94eS5oOgorICAgICAgICAoVjhQcm94eSk6CisKIDIwMTItMDgtMjIg IEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0g U3VwcG9ydCBzbGlkZXIgdGljayBtYXJrIHNuYXBwaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRTb3VyY2VDb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NjcmlwdFNvdXJjZUNvZGUuY3BwCmluZGV4IGE0NzhlNjgxN2Q0ZTZmZDBmNjUx ZmNlY2YyMWE0NDk5NGRmZmMyN2UuLmVmZmY2M2UxN2RhMTVmYTFhMGU5ZWNiNDc3NmJhZDE1ZWQ4 YmRjMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFNvdXJj ZUNvZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFNvdXJjZUNv ZGUuY3BwCkBAIC0yNiwxMCArMjYsMzQgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRl ICJTY3JpcHRTb3VyY2VDb2RlLmgiCiAKKyNpbmNsdWRlICJDYWNoZWRNZXRhZGF0YS5oIgorI2lu Y2x1ZGUgIkNhY2hlZFNjcmlwdC5oIgogI2luY2x1ZGUgIlY4QmluZGluZy5oIgogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKK1Bhc3NPd25QdHI8djg6OlNjcmlwdERhdGE+IFNjcmlwdFNvdXJjZUNv ZGU6OnByZWNvbXBpbGVTY3JpcHQodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBjb2RlLCBDYWNoZWRT Y3JpcHQqIGNhY2hlZFNjcmlwdCkKK3sKKyAgICAvLyBBIHBzZXVkby1yYW5kb21seSBjaG9zZW4g SUQgdXNlZCB0byBzdG9yZSBhbmQgcmV0cmlldmUgVjggU2NyaXB0RGF0YSBmcm9tCisgICAgLy8g dGhlIENhY2hlZFNjcmlwdC4gSWYgdGhlIGZvcm1hdCBjaGFuZ2VzLCB0aGlzIElEIHNob3VsZCBi ZSBjaGFuZ2VkIHRvby4KKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgZGF0YVR5cGVJRCA9IDB4 RUNDMTNCRDc7CisKKyAgICAvLyBWZXJ5IHNtYWxsIHNjcmlwdHMgYXJlIG5vdCB3b3J0aCB0aGUg ZWZmb3J0IHRvIHByZXBhcnNlLgorICAgIHN0YXRpYyBjb25zdCBpbnQgbWluUHJlcGFyc2VMZW5n dGggPSAxMDI0OworCisgICAgaWYgKCFjYWNoZWRTY3JpcHQgfHwgY29kZS0+TGVuZ3RoKCkgPCBt aW5QcmVwYXJzZUxlbmd0aCkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICBDYWNoZWRN ZXRhZGF0YSogY2FjaGVkTWV0YWRhdGEgPSBjYWNoZWRTY3JpcHQtPmNhY2hlZE1ldGFkYXRhKGRh dGFUeXBlSUQpOworICAgIGlmIChjYWNoZWRNZXRhZGF0YSkKKyAgICAgICAgcmV0dXJuIGFkb3B0 UHRyKHY4OjpTY3JpcHREYXRhOjpOZXcoY2FjaGVkTWV0YWRhdGEtPmRhdGEoKSwgY2FjaGVkTWV0 YWRhdGEtPnNpemUoKSkpOworCisgICAgT3duUHRyPHY4OjpTY3JpcHREYXRhPiBzY3JpcHREYXRh ID0gYWRvcHRQdHIodjg6OlNjcmlwdERhdGE6OlByZUNvbXBpbGUoY29kZSkpOworICAgIGNhY2hl ZFNjcmlwdC0+c2V0Q2FjaGVkTWV0YWRhdGEoZGF0YVR5cGVJRCwgc2NyaXB0RGF0YS0+RGF0YSgp LCBzY3JpcHREYXRhLT5MZW5ndGgoKSk7CisKKyAgICByZXR1cm4gc2NyaXB0RGF0YS5yZWxlYXNl KCk7Cit9CisKIHY4OjpIYW5kbGU8djg6OlNjcmlwdD4gU2NyaXB0U291cmNlQ29kZTo6Y29tcGls ZVNjcmlwdCh2ODo6SGFuZGxlPHY4OjpTdHJpbmc+IGNvZGUsIGNvbnN0IFN0cmluZyYgZmlsZU5h bWUsIGNvbnN0IFRleHRQb3NpdGlvbiYgc2NyaXB0U3RhcnRQb3NpdGlvbiwgdjg6OlNjcmlwdERh dGEqIHNjcmlwdERhdGEpCiB7CiAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBuYW1lID0gdjhT dHJpbmcoZmlsZU5hbWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv U2NyaXB0U291cmNlQ29kZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0U291 cmNlQ29kZS5oCmluZGV4IGE2NTQzY2E4MTM2MDBmMWQ4YTQ1NGVjMTU3YWY5MDJmYzRkNzNiMDIu LjMyZjg1NWRhNzU1Y2Y2Zjk2ZTA4MWZiZmY3YWI0OTI3ODFkODJlMTAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFNvdXJjZUNvZGUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRTb3VyY2VDb2RlLmgKQEAgLTM2LDYgKzM2LDcgQEAK ICNpbmNsdWRlICJLVVJMLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKICNpbmNsdWRl IDx2OC5oPgorI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQv VGV4dFBvc2l0aW9uLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTczLDYgKzc0LDcgQEAg cHVibGljOgogICAgIGludCBzdGFydExpbmUoKSBjb25zdCB7IHJldHVybiBtX3N0YXJ0UG9zaXRp b24ubV9saW5lLm9uZUJhc2VkSW50KCk7IH0KICAgICBjb25zdCBUZXh0UG9zaXRpb24mIHN0YXJ0 UG9zaXRpb24oKSBjb25zdCB7IHJldHVybiBtX3N0YXJ0UG9zaXRpb247IH0KIAorICAgIHN0YXRp YyBQYXNzT3duUHRyPHY4OjpTY3JpcHREYXRhPiBwcmVjb21waWxlU2NyaXB0KHY4OjpIYW5kbGU8 djg6OlN0cmluZz4sIENhY2hlZFNjcmlwdCopOwogICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpT Y3JpcHQ+IGNvbXBpbGVTY3JpcHQodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiwgY29uc3QgU3RyaW5n JiwgY29uc3QgVGV4dFBvc2l0aW9uJiwgdjg6OlNjcmlwdERhdGEqID0gMCk7CiAKIHByaXZhdGU6 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCmluZGV4IDBjMDI1YzE3NmU3NzA4 YjYyYTY5MDljZWJjOTY0ZWYwYTUyOTVkNjkuLjYzN2YyNDk1Yjk4ODNkOWQ5ZWQ2MzE4YWY0YWQx NGZlMGU4MDE2YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJv eHkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCkBAIC05 NCwyOCArOTQsNiBAQCBWOFByb3h5Ojp+VjhQcm94eSgpCiAgICAgd2luZG93U2hlbGwoKS0+ZGVz dHJveUdsb2JhbCgpOwogfQogCi1QYXNzT3duUHRyPHY4OjpTY3JpcHREYXRhPiBWOFByb3h5Ojpw cmVjb21waWxlU2NyaXB0KHY4OjpIYW5kbGU8djg6OlN0cmluZz4gY29kZSwgQ2FjaGVkU2NyaXB0 KiBjYWNoZWRTY3JpcHQpCi17Ci0gICAgLy8gQSBwc2V1ZG8tcmFuZG9tbHkgY2hvc2VuIElEIHVz ZWQgdG8gc3RvcmUgYW5kIHJldHJpZXZlIFY4IFNjcmlwdERhdGEgZnJvbQotICAgIC8vIHRoZSBD YWNoZWRTY3JpcHQuIElmIHRoZSBmb3JtYXQgY2hhbmdlcywgdGhpcyBJRCBzaG91bGQgYmUgY2hh bmdlZCB0b28uCi0gICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGRhdGFUeXBlSUQgPSAweEVDQzEz QkQ3OwotCi0gICAgLy8gVmVyeSBzbWFsbCBzY3JpcHRzIGFyZSBub3Qgd29ydGggdGhlIGVmZm9y dCB0byBwcmVwYXJzZS4KLSAgICBzdGF0aWMgY29uc3QgaW50IG1pblByZXBhcnNlTGVuZ3RoID0g MTAyNDsKLQotICAgIGlmICghY2FjaGVkU2NyaXB0IHx8IGNvZGUtPkxlbmd0aCgpIDwgbWluUHJl cGFyc2VMZW5ndGgpCi0gICAgICAgIHJldHVybiBudWxscHRyOwotCi0gICAgQ2FjaGVkTWV0YWRh dGEqIGNhY2hlZE1ldGFkYXRhID0gY2FjaGVkU2NyaXB0LT5jYWNoZWRNZXRhZGF0YShkYXRhVHlw ZUlEKTsKLSAgICBpZiAoY2FjaGVkTWV0YWRhdGEpCi0gICAgICAgIHJldHVybiBhZG9wdFB0cih2 ODo6U2NyaXB0RGF0YTo6TmV3KGNhY2hlZE1ldGFkYXRhLT5kYXRhKCksIGNhY2hlZE1ldGFkYXRh LT5zaXplKCkpKTsKLQotICAgIE93blB0cjx2ODo6U2NyaXB0RGF0YT4gc2NyaXB0RGF0YSA9IGFk b3B0UHRyKHY4OjpTY3JpcHREYXRhOjpQcmVDb21waWxlKGNvZGUpKTsKLSAgICBjYWNoZWRTY3Jp cHQtPnNldENhY2hlZE1ldGFkYXRhKGRhdGFUeXBlSUQsIHNjcmlwdERhdGEtPkRhdGEoKSwgc2Ny aXB0RGF0YS0+TGVuZ3RoKCkpOwotCi0gICAgcmV0dXJuIHNjcmlwdERhdGEucmVsZWFzZSgpOwot fQotCiB2ODo6TG9jYWw8djg6OlZhbHVlPiBWOFByb3h5OjpldmFsdWF0ZShjb25zdCBTY3JpcHRT b3VyY2VDb2RlJiBzb3VyY2UsIE5vZGUqIG5vZGUpCiB7CiAgICAgQVNTRVJUKHY4OjpDb250ZXh0 OjpJbkNvbnRleHQoKSk7CkBAIC0xMzgsNyArMTE2LDcgQEAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4g VjhQcm94eTo6ZXZhbHVhdGUoY29uc3QgU2NyaXB0U291cmNlQ29kZSYgc291cmNlLCBOb2RlKiBu b2QKICNpZiBQTEFURk9STShDSFJPTUlVTSkKICAgICAgICAgVFJBQ0VfRVZFTlRfQkVHSU4wKCJ2 OCIsICJ2OC5jb21waWxlIik7CiAjZW5kaWYKLSAgICAgICAgT3duUHRyPHY4OjpTY3JpcHREYXRh PiBzY3JpcHREYXRhID0gcHJlY29tcGlsZVNjcmlwdChjb2RlLCBzb3VyY2UuY2FjaGVkU2NyaXB0 KCkpOworICAgICAgICBPd25QdHI8djg6OlNjcmlwdERhdGE+IHNjcmlwdERhdGEgPSBTY3JpcHRT b3VyY2VDb2RlOjpwcmVjb21waWxlU2NyaXB0KGNvZGUsIHNvdXJjZS5jYWNoZWRTY3JpcHQoKSk7 CiAKICAgICAgICAgLy8gTk9URTogRm9yIGNvbXBhdGliaWxpdHkgd2l0aCBXZWJDb3JlLCBTY3Jp cHRTb3VyY2VDb2RlJ3MgbGluZSBzdGFydHMgYXQKICAgICAgICAgLy8gMSwgd2hlcmVhcyB2OCBz dGFydHMgYXQgMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJv eHkuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAppbmRleCBhNjJhNjA4 NjIxM2FkYTJiYjM0YWI2MGZmMTRlNGUzZmRmYWU0N2MzLi5iMDlkM2M2ZWYyNGI5MDdiMThhZjlk ZGM0ZDhmYjFmYmY1OTFmYWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOFByb3h5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCkBA IC0xMTcsOCArMTE3LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBJc29sYXRlZFdv cmxkU2VjdXJpdHlPcmlnaW5NYXAmIGlzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbnMoKSB7IHJl dHVybiBtX2lzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbnM7IH0KIAogICAgIHByaXZhdGU6Ci0g ICAgICAgIFBhc3NPd25QdHI8djg6OlNjcmlwdERhdGE+IHByZWNvbXBpbGVTY3JpcHQodjg6Okhh bmRsZTx2ODo6U3RyaW5nPiwgQ2FjaGVkU2NyaXB0Kik7Ci0KICAgICAgICAgRnJhbWUqIG1fZnJh bWU7CiAKICAgICAgICAgLy8gVGhlIGlzb2xhdGVkIHdvcmxkcyB3ZSBhcmUgdHJhY2tpbmcgZm9y IHRoaXMgZnJhbWUuIFdlIGhvbGQgdGhlbSBhbGl2ZQo=